GitLab

Multiple instances of the same WebUI URL can legitimately share a pairing delegate.

BUG=568426

Review URL: https://codereview.chromium.org/1540323002

Cr-Commit-Position: refs/heads/master@{#367007}

BUG=451577
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1550823002

Cr-Commit-Position: refs/heads/master@{#367006}

BUG=chromedriver:1302

Review URL: https://codereview.chromium.org/1553453002

Cr-Commit-Position: refs/heads/master@{#367005}

BUG=572714
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1550813002

Cr-Commit-Position: refs/heads/master@{#367004}

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158

Review URL: https://codereview.chromium.org/1545743002

Cr-Commit-Position: refs/heads/master@{#367003}

BUG=451577
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1550143003

Cr-Commit-Position: refs/heads/master@{#367002}

BUG=

Review URL: https://codereview.chromium.org/1551513002

Cr-Commit-Position: refs/heads/master@{#367001}

Cr-Commit-Position: refs/heads/master@{#367000}

BUG=451577
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1544413002

Cr-Commit-Position: refs/heads/master@{#366999}

BUG=571104

Review URL: https://codereview.chromium.org/1536083003

Cr-Commit-Position: refs/heads/master@{#366998}

BUG=
TEST=nothing breaks
R=kbr@chromium.org,piman@chromium.org,jmadill@chromium.org,bbudge@chromium.org,rmaymes@chromium.org

Review URL: https://codereview.chromium.org/1541283002

Cr-Commit-Position: refs/heads/master@{#366997}

On WebKit Linux Oilpan (dbg), WebKit Mac10.7 (dbg)

BUG=571710
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1553443002

Cr-Commit-Position: refs/heads/master@{#366996}

inspector/elements/user-properties.html
inspector/extensions/extensions-reload.html
inspector/extensions/extensions-resources.html
inspector/extensions/extensions-sidebar.html

BUG=451577
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1549423002

Cr-Commit-Position: refs/heads/master@{#366995}

https://chromium.googlesource.com/skia.git/+log/e76b4bb3ae03..93eb4b97d4b8

$ git log e76b4bb3a..93eb4b97d --date=short --no-merges --format='%ad %ae %s'
2015-12-28 joshualitt Disable ES2 on Linux SDL

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1546353002

Cr-Commit-Position: refs/heads/master@{#366994}

This patch makes Character::isCJKIdeographOrSymbol() faster for:

1. Check cjkSymbolRanges earlier than cjkIsolatedSymbols. Because the
   former is much more commonly used, it improves common cases.
2. Add the first/last optimization for cjkSymbolRanges check. This
   improves characters outside the cjkSymbolRanges.
3. Check U+02C7, U+02CA, U+02CB, U+02D9 separately. Since these are the
   only CJK below U+2020, this improves the performance below U+2020.

As the result of these changes, following improvements are seen in
local debug builds.

Average of all code points: 5673 -> 2760 (50% improve)
Han Ideograph Basic block: 5044 -> 3223 (36% improve)
Hiragana: 342 -> 269 (21% improve)
Arabic: 748 -> 51 (93% improve)

No code path changes for code points below U+02C7.

No behavior changes.

BUG=571943, 571654

Review URL: https://codereview.chromium.org/1545073002

Cr-Commit-Position: refs/heads/master@{#366993}

BUG=451577
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1548353002

Cr-Commit-Position: refs/heads/master@{#366992}

Don't write to stdout. Only write to stderr when there's an error.

BUG=572396

Review URL: https://codereview.chromium.org/1550793002

Cr-Commit-Position: refs/heads/master@{#366991}

iOS 8 and 9 deprecated many APIs. Add -Wno-deprecated-declarations to
iOS targets until the corresponding deprecated API usages are removed.

BUG=569158,571217

Review URL: https://codereview.chromium.org/1548323002

Cr-Commit-Position: refs/heads/master@{#366990}

BUG=567991

Review URL: https://codereview.chromium.org/1552533003

Cr-Commit-Position: refs/heads/master@{#366989}

Switch a test from fail to skip, because it nuked the harness.

BUG=483282
TEST=gpu fyi win debug bots
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1545363002

Cr-Commit-Position: refs/heads/master@{#366988}

Adds max sync event duration as a parameter to
BackgroundSyncParameters and allows it to be overwritten via field
trials.

BUG=569001

Review URL: https://codereview.chromium.org/1536023002

Cr-Commit-Position: refs/heads/master@{#366987}

relnote: Replace last remaining NULLs in gfe/quic with nullptr. No behavior change.

Merge internal change: 110570650
https://codereview.chromium.org/1542753004/

relnote: Add PushResponse() in QuicSimpleServerStream.

Merge internal change: 110554875
https://codereview.chromium.org/1545793002/

relnote: Adding details to most quic connection close calls.

This is a precursor to removing CloseConnection[without details] entirely.
This is so we can to be able disambiguate various causes of specific error codes when logging them server side.  We can always add more details where useful at a later point.

Merge internal change: 110546286
https://codereview.chromium.org/1548783002/

relnote: Add path_id to QuicSentPacketManager and QuicSentPacketManager::PendingRetransmission. No functional change.

Merge internal change: 110540464
https://codereview.chromium.org/1542773004/

relnote: Add class QuicMultipathReceivedPacketManager (not in use currently).

Merge internal change: 110454683
https://codereview.chromium.org/1548703002/

relnote: If the user supplied a request body in hex, print response body in hex as well. In addition, convert hex in both cases to printable ASCII characters where possible.

Example output:

Request:
headers:
{
  :authority:test.example.com
  :path:/net.grpc.examples.QuicGreeter/SayHello
  :scheme:http
  :method:POST
  te:trailers
  grpc-encoding:identity
  grpc-accept-encoding:identity,deflate,gzip
  content-type:application/grpc
  user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux)
}
body hex:   00000000070a05776f726c64
body ascii:  . . . . . . . w o r l d

Response:
headers:
 HTTP/1.1 200 OK
 grpc-encoding: identity
 grpc-accept-encoding: identity,deflate,gzip
 content-type: application/grpc

body hex:   0a0b48656c6c6f20776f726c64
body ascii:  . . H e l l o   w o r l d
trailers:
{
  grpc-status:0
}

Request succeeded (200).

Merge internal change: 110446931
https://codereview.chromium.org/1545703002/

relnote: Drop not awaited packets before decrypt them.

Merge internal change: 110403572
https://codereview.chromium.org/1546633002/

relnote: Add path_id to SerializedPacket. No functional change.

Merge internal change: 110393215
https://codereview.chromium.org/1542123002/

relnote: Drop packets which are larger than kMaxPacketSize, instead of closing the connection with QUIC_PACKET_TOO_LARGE. Not flag protected.

Merge internal change: 110290154
https://codereview.chromium.org/1543703002/

relnote: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not empty. An empty host works fine in google3, but breaks tests in Chromium for $reasons.

Merge internal change: 110286048
https://codereview.chromium.org/1544563002/

relnote: Delete unused methods in QuicServerSession

Merge internal change: 110254138
https://codereview.chromium.org/1539333003/

relnote: If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865
https://codereview.chromium.org/1538373002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1541263002

Cr-Commit-Position: refs/heads/master@{#366986}

https://chromium.googlesource.com/skia.git/+log/9a878a00ef2c..e76b4bb3ae03

$ git log 9a878a00e..e76b4bb3a --date=short --no-merges --format='%ad %ae %s'
2015-12-28 joshualitt Reland of Make draw* lines responsible for cache management (patchset #1 id:1 of https://codereview.chromium.org/1552513003/ )
2015-12-28 joshualitt Revert of Make draw* lines responsible for cache management (patchset #1 id:1 of https://codereview.chromium.org/1521613002/ )

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1546333002

Cr-Commit-Position: refs/heads/master@{#366985}

BUG=

Review URL: https://codereview.chromium.org/1549313002

Cr-Commit-Position: refs/heads/master@{#366984}

R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, krasin@chromium.org
BUG=569578

Review URL: https://codereview.chromium.org/1549793002

Cr-Commit-Position: refs/heads/master@{#366983}

InputType test has duplicate data, "host#ref", on line 86 and 88.

	modified:   components/omnibox/browser/autocomplete_input_unittest.cc

BUG=571771

Review URL: https://codereview.chromium.org/1548893002

Cr-Commit-Position: refs/heads/master@{#366982}

BUG=

Review URL: https://codereview.chromium.org/1548943002

Cr-Commit-Position: refs/heads/master@{#366981}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=yzshen@chromium.org

Review URL: https://codereview.chromium.org/1550733002

Cr-Commit-Position: refs/heads/master@{#366980}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1549363002

Cr-Commit-Position: refs/heads/master@{#366979}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1549353002

Cr-Commit-Position: refs/heads/master@{#366978}

This CL is an attempt to ensure that input audio recording always works on Mac OS X.
It is a trivial change and I don't know if it has any real effect, hence it is speculative.
I am making this change since I have seen in examples that it is recommended to initialize
the AUHAL before using it. We can only hope that it has a positive effect.
More small changes are in the pipeline but my plan was to land them one by one to keep
the changes as simple as possible and easy to revert if needed.

Adding tommi@ as TBR since he is OOO and the change can be considered trivial. If we are lucky
it has a positive effect. If we are not, I don't expect any effect at all.

TBR=tommi
BUG=549021

Review URL: https://codereview.chromium.org/1551613002

Cr-Commit-Position: refs/heads/master@{#366977}

TBR=jam@chromium.org
BUG=561803
NOTRY=true

Review URL: https://codereview.chromium.org/1551553003

Cr-Commit-Position: refs/heads/master@{#366976}

InternalSettingsGenerated.h is included by V8InternalSettingsGenerated.h as
"../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h".
And it was emitted to the depfile as
"gen/../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h".
That confuses dependency analysis of Ninja and causes unneeded rebuild.

This CL converts it to the relative path to out/Release/gen/blink, so that
the include path is simplified to "core/testing/InternalSettingsGenerated.h".

BUG=531579

Review URL: https://codereview.chromium.org/1544373002

Cr-Commit-Position: refs/heads/master@{#366975}

BUG=

Review URL: https://codereview.chromium.org/1549303002

Cr-Commit-Position: refs/heads/master@{#366974}

Review URL: https://codereview.chromium.org/1539913002

Cr-Commit-Position: refs/heads/master@{#366973}

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1538613002

Cr-Commit-Position: refs/heads/master@{#366972}

Mostly this involves parameterizing the tab and new tab button drawing so they
can handle different desired sizes.  There should be no change in material
(non-hybrid) mode.

This also positions the new tab button vertically based on the distance below
the button instead of the distance above, since we want the gap between the
button and the toolbar to remain constant even as the tab and button heights
change, rather than having the button starting a fixed distance below the top of
the tabs.

BUG=519020
TEST=Run with --top-chrome-md=material-hybrid and check that the tabs and new tab button are larger than in material mode but still shaped correctly

Review URL: https://codereview.chromium.org/1541313002

Cr-Commit-Position: refs/heads/master@{#366971}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/951fd121..56ce1b39

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1549373002

Cr-Commit-Position: refs/heads/master@{#366970}

Search provider specified by preferences and by extensions have wrong
comments. This CL fixes it.

BUG=NONE

Review URL: https://codereview.chromium.org/1551543002

Cr-Commit-Position: refs/heads/master@{#366969}

* Uses layout constants for the tab height in all cases, not just material.
* Removes TAB_MAXIMUM_TITLE_WIDTH layout constant.  We really just want the total maximum tab width to be the same across all modes, so compute it that way directly in tab.cc.
* Adds a new GetLayoutSize() function, which currently is only used for the new tab button size.
* A few other tiny cleanups.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1543963002

Cr-Commit-Position: refs/heads/master@{#366968}