GitLab

clear HSTS data and HttpServerProperties.

Also move that logic from chrome/ to content/, since the data isn't
specific to Chrome. The new tests are written to work when the network
service is run out of process, rather than rely on direct access to
net objects.

It had been going through ProfileIOData unnecessarily, since it has
direct access to all the relevant classes. The goal is to eventually
remove ProfileIOData, and make consumers use the network service
directly, rather than go through chrome/ classes. The new code will
work both when running with an in-process network stack and when
running with the network service.

TBR=phajdan.jr@chromium.org, khmel@chromium.org

Bug: 715695
Change-Id: I2e0c8b4ea0ffd7f718412699e773c900f786c62d
Reviewed-on: https://chromium-review.googlesource.com/719736
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509244}

When there is a preferred app (because the user set it previously) we
need to honor that decision and use that preference for the next similar
urls. This means that the intent picker won't be auto-displayed, however
the icon needs to be shown, so the user can still decide to continue in
other app instead of their previously recorded preferred app.

Also removing ShowIntentPickerCallback since the throttle no longer
communicates directly with the UI.

Bug: 678141
Test: Try.
Change-Id: Id550d4763a05d7db1734ce4b11dd1077e38bee9d
Reviewed-on: https://chromium-review.googlesource.com/722071
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509243}

Download should always be treated as main frame request

BUG=715630

Change-Id: If1403ba99b30d98387de850d191876ad6bfabdbe
Reviewed-on: https://chromium-review.googlesource.com/721922Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509242}

Use a fake Button class for the TextViews on Reader Mode Infobar, so
that it can be announced as a button with TalkBack.

Bug: 773763
Change-Id: I0a3f62a0752604e7fe94d9bc61d8b69edb4be8d0
Reviewed-on: https://chromium-review.googlesource.com/713755
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509241}

The '--modules' flag to gen.py was renamed '--packages'.

Bug: 707031
Change-Id: I04cbae76eacf0a9c593fdf1d375c84c25fbee088
Reviewed-on: https://chromium-review.googlesource.com/721887Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509240}

This picks up the EGL_ANDROID_get_native_client_buffer extension for
eglGetNativeClientBufferANDROID, and declares struct AHardwareBuffer.

Preserve Chromium-specific support for EGL_EXT_image_flush_external
extension, and remove "Chromium-specific" comment for Ozone types such
as EGLNativeDisplayType since that section is now upstreamed.

Also ran "git cl format ." but reverted the changes to the
autogenerated date header.

BUG=761432

Change-Id: If911142151ecfc14b1eba6cf9bc8fc72e8ccf672
Reviewed-on: https://chromium-review.googlesource.com/721600Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509239}

Bug: 769529
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b55fe9185c40e93301cae975bad4d56e961667c
Reviewed-on: https://chromium-review.googlesource.com/713952Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509238}

Bug: 755727
Change-Id: Ie1ced7f1979392dde03eb81eaf0e9aa5aa0e0916
Reviewed-on: https://chromium-review.googlesource.com/721873Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509237}

This is a mostly automated refactor.

BUG=638327
TBR=dcheng@chromium.org

Change-Id: I211c1627b5aa7ee7be9fc68e057243c64d8748dc
Reviewed-on: https://chromium-review.googlesource.com/722103Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509236}

Should have been added in 579429.

Bug: 545324
Change-Id: I422673ee1cb8f8970ece70bbcb39d4ba4f5e9732
Reviewed-on: https://chromium-review.googlesource.com/720638Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509235}

Bug: 695632
Change-Id: Ie6c22f2d636d4437963039836011453815b964d9
Reviewed-on: https://chromium-review.googlesource.com/721976Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509234}

Convert client code to directly access GetLastCommittedURL
method from WebState instead of the re-implementation in
Tab.

Remove some useless creation of GURL and std::string by
using the API that take base::StringPiece.

Bug: none
Change-Id: I78e0ea18110b83cdaa6bcc5f45b02e61544cc095
Reviewed-on: https://chromium-review.googlesource.com/720438
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509233}

IdentityProvider is now a construction argument instead of in the Delegate.

Bug: None
Test: Existing
Change-Id: I9bb7e590e7fec84a54b2a5fd531231ddf05dce0e
Reviewed-on: https://chromium-review.googlesource.com/719977
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509232}

This moves the contents of content/common/devtools to content/network/throttling,
removing DevTools from the class names.

Bug: 721408
Change-Id: I0dc5b70eceb9976af623662a21d730260e6bbba8
Reviewed-on: https://chromium-review.googlesource.com/703674
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509231}

This is temporary, we'll follow up with some additional
crash logging to identify the true root cause.

Note that the crashes are happening on Android when trying
to get an accessibility tree "snapshot", i.e. now-on-tap,
so when it fails it will just fail to retrieve content
rather than crashing.

Bug: 765490
Change-Id: I48a37bcc9cd74b6887a3408a48e082325983d98e
Reviewed-on: https://chromium-review.googlesource.com/719468
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509230}

This CL adds MediaPlayerRendererWebContentsObserver to send WebContents
muting updates to all MediaPlayerRenderers. The MediaPlayerRenderer then
manually mutes itself, since it's not properly muted by WebContent's
audio muter.

Bug: 765337
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I59714240d507d80258ce200183eb4227718fa460
Reviewed-on: https://chromium-review.googlesource.com/713406
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509229}

Before this CL, there was a NPE crash in DownloadBroadcastManager. This
CL fixes this crash.

Bug: 774705
Change-Id: I43c0aaa6acc58f6fd68203ffe785cbc997a81b9b
Reviewed-on: https://chromium-review.googlesource.com/719354Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509228}

The return value and has_property argument is confusing, and there is
only one user, so this change removes it.

Bug: None
Change-Id: I6958fd0a441299f1e244a977d68e0e17590b42bb
Reviewed-on: https://chromium-review.googlesource.com/720698
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509227}

Return a -1 if one or more tests fails/errors (errors are usually a failure that fail for an unexpected reasons).

Bug: 762747
Change-Id: Ie4f50363d58cabda5c7497fb1a4b4ad5dce71d4e
Reviewed-on: https://chromium-review.googlesource.com/653727Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Richard Bustamante <bustamante@google.com>
Cr-Commit-Position: refs/heads/master@{#509226}

Bug: 770851
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iead1096721a70f1890b03106ab296b08070f6094
Reviewed-on: https://chromium-review.googlesource.com/717562
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509225}

Bug: 762380, 649017
Change-Id: Ice9f4c558974d39a44cb67e02f2da82ff4af7fa5
Reviewed-on: https://chromium-review.googlesource.com/721266Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509224}

Bug: 773698
Test: unit_tests --gtest_filter=NoteTakingHelperTest.*
Change-Id: I66ec6b95b24597df199df780efbd33f5076c90d7
Reviewed-on: https://chromium-review.googlesource.com/721693
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509223}

TBR=fdoray@chromium.org,atimoxin@yandex-team.ru

Bug: 772839
Change-Id: I50e1c997865d45c313e55ef613952494c7df5d10
Reviewed-on: https://chromium-review.googlesource.com/721856Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509222}

BUG=774979, 774641

Change-Id: I810121de4fb572b0f6919a25afaf7aac88c2f629
Reviewed-on: https://chromium-review.googlesource.com/721260Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509221}

This is a reland of 3d541cac
Original change's description:
> Credit card autofill ablation experiment setup
>
> This CL is patched from  https://chromium-review.googlesource.com/c/chromium/src/+/615603
> Handling this since Kumar doesn't have enough time to finish this in this week.
>
> Bug:755337
>
> Abalation doc - https://docs.google.com/document/d/1vMGO7sfzYDXpev_5ftyLH-WoKpCHA4I9lVLYuesVT9c/edit?ts=59826c12#heading=h.k6sbad93o9zk
>
> Conditional Metrics to log in control & ablation arm
> >>
> Submitted with suggestion shown (once)
> >>
>
> Change-Id: Ie1be217bc9dfcca36419e6635f9f8459be1ec0b5
> Reviewed-on: https://chromium-review.googlesource.com/711021
> Commit-Queue: Shanfeng Zhang <szhangcs@google.com>
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508441}

Bug: 755337
Change-Id: Ife233986e1f3877cea7cdcc128398c64bb1a8818
Reviewed-on: https://chromium-review.googlesource.com/719411Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Shanfeng Zhang <szhangcs@google.com>
Cr-Commit-Position: refs/heads/master@{#509220}

This test fails occasionally in test automation run for Android build.
Test is disabled.

Bug: chromedriver:2081
Change-Id: I47fa1225efeb3bedb821d505dc3f956057f816a6
Reviewed-on: https://chromium-review.googlesource.com/722019
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509219}

Currently, the separator in an omnibox bubble view
disappears when the ink drop animates in and then
reappears when it animates out. However, it's
possible for the ink drop to be removed without
animation. This causes the separator to go missing
since its opacity has not be updated.

This CL fix this issue by updating the separator's
opacity when the ink drop layer is removed.

Bug: 772832
Change-Id: I812d8dcacd79851bf23b0dce2d7fd00330887278
Reviewed-on: https://chromium-review.googlesource.com/713398Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509218}

This allows us to forward declare it from platform code.
We could forward declare it as an enum but that would be more verbose.
It looks better to use enum class name to replace the common prefixes.

This is a preparation of https://chromium-review.googlesource.com/c/chromium/src/+/721602
(Remove LayoutObjectDrawingRecorder).

Bug: 657186
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie65ff7014c0a7e2e6e3ce5bdb94c60e6d5f6ddfc
Reviewed-on: https://chromium-review.googlesource.com/721920Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509217}

AutomationApiHelper is responsible for handling extension messages sent
on behalf of the automationInternal API (specifically, the
QuerySelector message). Instead of observing the RenderView, observe the
RenderFrame. This removes all hooks for RenderViewCreated in extensions
renderer code, as well as the last RenderViewObserver.

Additionally, the AutomationApiHelper only cares about the main frame,
so we can clean up the code by
a) only instantiating the AutomationApiHelper for main frames and
b) only sending messages to the main frame.
This allows us to remove one of the error cases specified for the
message.

Bug: 304341

Change-Id: I0652f85df47a42faa4320e9b0549fcffe4a754a5
Reviewed-on: https://chromium-review.googlesource.com/709996
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509216}

This upgrades the driver version used in the tester bots from 372.54
to 387.92. This CL should land as the bots are being switched over to
the new driver version, and the upgrade should be finished after it
lands.

BUG=771654

NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9ed27aeeab48604e3c3ec862f58d474934f06a7f
Reviewed-on: https://chromium-review.googlesource.com/716658
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509215}

Use catapult package versions for OpenCV and NumPy. These versions are
explicitly asserted by the "catapult" test framework, and versions
outside of this range will not successfully load.

Note the catapult version dependency in the definition.

BUG=chromium:762005
TEST=None

Change-Id: I4659e0b6c28c8fd043a8f42c6993a11f2473cdeb
Reviewed-on: https://chromium-review.googlesource.com/721423Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509214}

Running tools\win\static_initializers showed several atexit destructors
that were triggered for static local std::string variables. These aren't
as bad as globals with constructors but they still have unnecessary cost
because they are thread-safe initialized, may allocate memory, and are
registered for atexit destruction. Since char[] easily replaces them we
might as well use it.

Bug: 341941
Change-Id: I03e36ce56852c77947b41fa5efdd0c14e27485f7
Reviewed-on: https://chromium-review.googlesource.com/708047Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509213}

Follow ups to post-commit review of
https://chromium-review.googlesource.com/600541, this renames the two
blink specific .typemap files to match the name of the native type
rather than the name of the mojom struct, and updates the struct traits
to not use std::vector at all.

Bug: 740744, 351753
Change-Id: I19b9a45d1bc1352e9b2ea89dcc0237aa5f938a0b
Reviewed-on: https://chromium-review.googlesource.com/721774Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509212}

This patch ensures that the legacy touch calibration data is stored in
the legacy format. This is to ensure that if anything breaks with the new
changes, we have something to fallback on.

Component: display preferences, touch
Bug: 599985
Change-Id: I77c6fd22634ae447c5829565b912a5142b0eb16d
Reviewed-on: https://chromium-review.googlesource.com/720161
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509211}

BUG=773350
R=dpranke@chromium.org

Change-Id: Ic95199a275e33808b3e3f895f884561955bc6746
Reviewed-on: https://chromium-review.googlesource.com/720198
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509210}

This change fixes a crash that occurred as a result of native not
being ready when trying to record metrics. The metrics recording
has been moved to the same method that the Chrome Home state is
cached in (which runs after native is ready).

BUG=775126

Change-Id: I11756265020ceb2bb0fbb59702cba3c9d9f8038a
Reviewed-on: https://chromium-review.googlesource.com/721959Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509209}

If the service thread is stopped after workers are joined, the service
thread can post a task after join_called_for_testing_ is set which
causes a CHECK. Instead stop the service thread before joining the pool
workers in TaskSchedulerImpl::JoinForTesting().

This bug showed up on Fuchsia, but is cross-platform.

Bug: 771701, 698140
Change-Id: I4a25ede2bceb700eeea17ae47f7402211856bef6
Reviewed-on: https://chromium-review.googlesource.com/721570Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509208}

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique ui/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifaaa249f83d84154f5a0f03c5c96d6dacaf70c84
Reviewed-on: https://chromium-review.googlesource.com/646226Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509207}

The TextSuggestionControllerTest.ApplyingMisspellingTextSuggestionClearsMarker
test case is currently failing on the first run when run with other tests in
TextSuggestionControllerTest. This is because DocumentMarkerController keeps
track of a counter for how many suggestion markers have been added so far, and
I was assuming this counter was reset at the beginning of each test case and so
would always be 1, but it's not.

The fix is to check the counter value for the marker that was just added instead
of assuming it's going to be 1.

Bug: 774362
Change-Id: Ib34bd5d0f57f08557432a6686d00c5481cd1a9b3
Reviewed-on: https://chromium-review.googlesource.com/721074Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509206}

VideoCaptureTest uses fake RFH IDs which require the
FakeMediaStreamUIProxy to be configured correctly.

Bug: 689802
Change-Id: I1568a326f32acde5a375a99b108edb4f626c44aa
Reviewed-on: https://chromium-review.googlesource.com/720589Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509205}