GitLab

Revert of [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (patchset #5 id:80001 of https://codereview.chromium.org/737653003/)

Reason for revert:
Broke compile on Google Chrome ChromeOS bot.

[8069/19495] CXX obj/components/policy/core/common/cloud/policy_component_common.external_policy_data_updater.o
FAILED: cd ../../third_party/liblouis; python ../../native_client_sdk/src/tools/create_nmf.py ../../out/Release/chromevox_test_data/braille/liblouis_nacl_x86_64.nexe "--output=../../out/Release/chromevox_test_data/braille/liblouis_nacl.nmf"
Traceback (most recent call last):
  File "../../native_client_sdk/src/tools/create_nmf.py", line 680, in <module>
    rtn = main(sys.argv[1:])
  File "../../native_client_sdk/src/tools/create_nmf.py", line 633, in main
    options.lib_path += GetDefaultLibPath(config)
  File "../../native_client_sdk/src/tools/create_nmf.py", line 507, in GetDefaultLibPath
    sdk_root = GetSDKRoot()
  File "../../native_client_sdk/src/tools/create_nmf.py", line 478, in GetSDKRoot
    assert(os.path.exists(os.path.join(sdk_root, 'toolchain')))
AssertionError
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/76569

Original issue's description:
> [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var
>
> create_nmf should determine the root of the SDK relative
> to its own location.
>
> The exception to this is when its run as part of the
> chrome build, when it is not yet installed.  In this
> case we pass --no-default-libpath and --objdump to
> create_nmf to remove any use of the SDK root.
>
> Committed: https://crrev.com/088561ac99314a79866a39f79bb32bd5e1196217
> Cr-Commit-Position: refs/heads/master@{#313957}

TBR=binji@chromium.org,dmichael@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/890033003

Cr-Commit-Position: refs/heads/master@{#313963}

Now Chrome start using ChannelMojo. The ipc_fuzzer has to
follow the move.

R=tsepez@chromium.org, inferno@chromium.org
BUG=453571

Review URL: https://codereview.chromium.org/875513007

Cr-Commit-Position: refs/heads/master@{#313962}

BUG=453875
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/868203004

Cr-Commit-Position: refs/heads/master@{#313961}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2d45b1e..f76ca40

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/892683002

Cr-Commit-Position: refs/heads/master@{#313960}

Cr-Commit-Position: refs/heads/master@{#313959}

WebRTC 8214:8220
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/29882bb..cfe4b49

Libjingle 8213:8221
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d0c206c..18f533d

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/893583004

Cr-Commit-Position: refs/heads/master@{#313958}

create_nmf should determine the root of the SDK relative
to its own location.

The exception to this is when its run as part of the
chrome build, when it is not yet installed.  In this
case we pass --no-default-libpath and --objdump to
create_nmf to remove any use of the SDK root.

Review URL: https://codereview.chromium.org/737653003

Cr-Commit-Position: refs/heads/master@{#313957}

Adding a UMA to keep track of the number of times RequestMediaKeyAccess
is called with a particular key system, and the number of times the
request succeeds. The counts are only incremented once per renderer
frame.

BUG=351501
TEST=existing EME tests pass, verified UMA locally

Review URL: https://codereview.chromium.org/881853002

Cr-Commit-Position: refs/heads/master@{#313956}

Was causing a bug where identities were slightly different.

BUG=453792

Review URL: https://codereview.chromium.org/864223006

Cr-Commit-Position: refs/heads/master@{#313955}

BUG=453126
R=rch@chromium.org

Review URL: https://codereview.chromium.org/885233002

Cr-Commit-Position: refs/heads/master@{#313954}

Revert of IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is givne (patchset #1 id:1 of https://codereview.chromium.org/885143002/)

Reason for revert:
The flag was wrong. It needs finer configuration.

Original issue's description:
> IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is given
>
> This adds an option to enable ChannelMojo on ipc_fuzzer.
>
> R=inferno@chormium.org, mbarbella@chromium.org
> BUG=453571
>
> Committed: https://crrev.com/9b1b6da70aab6c78bbecb5f86081ec5abc101f86
> Cr-Commit-Position: refs/heads/master@{#313840}

TBR=inferno@chormium.org,tsepez@chromium.org,mbarbella@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453571

Review URL: https://codereview.chromium.org/893603004

Cr-Commit-Position: refs/heads/master@{#313953}

Following up on https://codereview.chromium.org/825773003/#msg26, this CL adds weak_erase() calls at some places, to speed-up deletion of ScopedVectors, which are arguably only containing null or dangling pointers.

The benchmark from https://codereview.chromium.org/825773003/#msg24 showed on Mac, unlike on Linux, that weak_erase() + destruction takes (not surprisingly) constant time, whereas ommitting the weak_erase() is linear in the size of the vector.

The CL adds the weak_erase in a slightly complicated way. Instead of just adding the weak_erase() calls, it creates a dedicated method for doing the operation of passing all owned objects out of a scoped vector, to ensure that future changes in the code don't easily add leaks through the weak_ptr.

BUG=451018

Review URL: https://codereview.chromium.org/885033002

Cr-Commit-Position: refs/heads/master@{#313952}

This changes adds four histograms to UMA. Profile.NumberofSwitches
collects the number of profile switches happening over a session.

The others are:

- Profile.ProfileSwitch.ToOpenedProfile counts the number of switches to
  opened profiles and buckets depending on the UI flow used to switch.
- Profile.ProfileSwitch.ToUnopenedProfile does the same but for switches
  to unopened profiles
- Profile.ProfileSwitch aggregates the data from the previous two

BUG=448982

Review URL: https://codereview.chromium.org/844193005

Cr-Commit-Position: refs/heads/master@{#313951}

Revert of Flip flag to turn CrOS Browser Compositor Single Threaded (patchset #5 id:80001 of https://codereview.chromium.org/781163003/)

Reason for revert:
Possible cause for veyron: Chrome crash in SW Mirror mode (at login screen)

https://code.google.com/p/chromium/issues/detail?id=453732

Original issue's description:
> Flip flag to turn CrOS Browser Compositor Single Threaded
>
> Simply stop using threaded browser compositor for CrOS. Clean up would
> be in follow up patch.
>
> R=danakj@chromium.org, piman@chromium.org
> BUG=329552
>
> Committed: https://crrev.com/e111a7d64d9ba12833900ab743beaf4ee6d267ed
> Cr-Commit-Position: refs/heads/master@{#313842}

TBR=danakj@chromium.org,piman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=329552

Review URL: https://codereview.chromium.org/893623002

Cr-Commit-Position: refs/heads/master@{#313950}

 ultrasound32 and audible32
BUG=449864

Review URL: https://codereview.chromium.org/874163002

Cr-Commit-Position: refs/heads/master@{#313949}

Revert of Move AW renderer compositor context to gpu thread (patchset #6 id:100001 of https://codereview.chromium.org/769703005/)

Reason for revert:
Suspect causing AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen to time out

Original issue's description:
> Move AW renderer compositor context to gpu thread
>
> Use TexSubImage2D instead of TexImage2D to avoid orphaning
> EGLImage
> Create the renderer compositor context on the gpu thread.
>
> BUG=448168, 259924
>
> Committed: https://crrev.com/a4baed454be2bb165cb12eb7df432e9138e746e6
> Cr-Commit-Position: refs/heads/master@{#313846}

TBR=epenner@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448168, 259924

Review URL: https://codereview.chromium.org/888903002

Cr-Commit-Position: refs/heads/master@{#313948}

Review URL: https://codereview.chromium.org/879783004

Cr-Commit-Position: refs/heads/master@{#313947}

TBR=torne
NOTRY=true
BUG=453857

Review URL: https://codereview.chromium.org/893533006

Cr-Commit-Position: refs/heads/master@{#313946}

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032

Review URL: https://codereview.chromium.org/831813004

Cr-Commit-Position: refs/heads/master@{#313945}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d2fd44..1872ad0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/882723005

Cr-Commit-Position: refs/heads/master@{#313944}

This CL implements automatic timezone refresh on location update.

BUG=416494
TEST=manually tested

Review URL: https://codereview.chromium.org/834073002

Cr-Commit-Position: refs/heads/master@{#313943}

This CL makes CronetHttpURLStreamHandler.openConnection() public, so it is
easier to construct CronetHttpURLConnection.

BUG=398997

Review URL: https://codereview.chromium.org/876123002

Cr-Commit-Position: refs/heads/master@{#313942}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=cpu@chromium.org,dtu@chromium.org

Review URL: https://codereview.chromium.org/888883002

Cr-Commit-Position: refs/heads/master@{#313941}

Revert of Disable LayerTreeHostTestDeferCommits since it is flaky on Win. (patchset #2 id:20001 of https://codereview.chromium.org/864313004/)

Reason for revert:
found culprit and reverting

Original issue's description:
> Disable LayerTreeHostTestDeferCommits since it is flaky on Win.
>
> Sorry if I disabled too many tests...
>
> BUG=453787
> TBR=danakj@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8bf8e0bde343027f98f9496e2ccc224ea418b835

TBR=perkj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453787

Review URL: https://codereview.chromium.org/888063002

Cr-Commit-Position: refs/heads/master@{#313940}

Revert of cc: Control defer_commits logic by Scheduler (patchset #12 id:250001 of https://codereview.chromium.org/337693005/)

Reason for revert:
seems to flakily not stop commits https://code.google.com/p/chromium/issues/detail?id=453787

Original issue's description:
> cc: Control defer_commits logic by Scheduler
>
> So far, EarlyOut_DeferCommits is controlled by Proxy.
> Because Scheduler doesn't know about this deferring, it triggers next
> BeginMainFrame when main thread want to defer a commit.
> This CL moves the EarlyOut_DeferCommits logic from Proxy to
> Scheduler so Scheduler can stop next BeginMainFrame until defer commit is off.
>
> R=brianderson@chromium.org, danakj@chromium.org, skyostil@chromium.org
> BUG=382572
> TEST=cc_unittests
>
> Committed: https://crrev.com/1625b74468e4dd55f54ba209f8e91d05493875b9
> Cr-Commit-Position: refs/heads/master@{#313816}

TBR=brianderson@chromium.org,skyostil@chromium.org,enne@chromium.org,mithro@mithis.com,simonhong@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=382572

Review URL: https://codereview.chromium.org/870183004

Cr-Commit-Position: refs/heads/master@{#313939}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

Make a new class InputDeviceFactoryProxyEvdev that wraps
InputDeviceFactoryEvdev and can be safely passed to another thread. When
the other thread calls to manipulate devices, we'll post to
InputDeviceFactoryEvdev on the device thread with the command.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/875513005

Cr-Commit-Position: refs/heads/master@{#313938}

BUG=453795

Review URL: https://codereview.chromium.org/890873004

Cr-Commit-Position: refs/heads/master@{#313937}

BUG=453635

Review URL: https://codereview.chromium.org/890753002

Cr-Commit-Position: refs/heads/master@{#313936}

Revert of cc: Stop pushing properties every activation for picture layers. (patchset #3 id:40001 of https://codereview.chromium.org/874613003/)

Reason for revert:
flaky tests https://code.google.com/p/chromium/issues/detail?id=452965

Original issue's description:
> cc: Stop pushing properties every activation for picture layers.
>
> Since we don't swap tilings anymore, we only need to push properties
> when a property, or a tiling, or the raster source (invalidation) has
> changed.
>
> R=vmpstr
> BUG=303943
>
> Committed: https://crrev.com/dcaa923e704847eb6ba7003602ff70579aaaf47e
> Cr-Commit-Position: refs/heads/master@{#313329}

TBR=vmpstr@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=303943

Review URL: https://codereview.chromium.org/890963002

Cr-Commit-Position: refs/heads/master@{#313935}

BUG=441960

Review URL: https://codereview.chromium.org/888693003

Cr-Commit-Position: refs/heads/master@{#313934}

BUG=417589
TEST=none

Review URL: https://codereview.chromium.org/884723002

Cr-Commit-Position: refs/heads/master@{#313933}

The extension keybinding api tests currently include a lot of back-and-forth
by having an extension inject a script into a page, which changes the color, and
then injecting another script to see if the color did, in fact, change. Change
this to not rely on script injection.

Review URL: https://codereview.chromium.org/880523005

Cr-Commit-Position: refs/heads/master@{#313932}

Where he used to be in individual android/ and mac/ OWNERS

Review URL: https://codereview.chromium.org/888033002

Cr-Commit-Position: refs/heads/master@{#313931}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/864223007

Cr-Commit-Position: refs/heads/master@{#313930}

BUG=453088

Review URL: https://codereview.chromium.org/879383004

Cr-Commit-Position: refs/heads/master@{#313929}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=dmichael@chromium.org

Review URL: https://codereview.chromium.org/885283004

Cr-Commit-Position: refs/heads/master@{#313928}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f4ee92e..5d2fd44

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/892633002

Cr-Commit-Position: refs/heads/master@{#313927}

Instead of using the factories to retrieve the dependended upon keyed service,
pass them explicitly to WebHistoryService from the WebHistoryServiceFactory.

Fix the dependency of WebHistoryService to add the service used and to remove
the service unused.

Move file into //components/history/core/browser, remove unnecessary #include
and fix files that did not #include all the files they used.

BUG=371835

Review URL: https://codereview.chromium.org/882753002

Cr-Commit-Position: refs/heads/master@{#313926}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/868253010

Cr-Commit-Position: refs/heads/master@{#313925}

BUG=

Review URL: https://codereview.chromium.org/880003002

Cr-Commit-Position: refs/heads/master@{#313924}