GitLab

This CL reorganizes code before adding the read directory implementation.

First of all, operations are now extracted to separate classes, to avoid huge
file_system_provider.cc. Such operation classes are now arguments for the
RequestManager which replaces the former pair of [success, error] callbacks.

Such operation classes are now easy to test, because of ability to cut out
the EventRouter by using Operation::SetDispatchEventImplForTests.

Finally, a RequestValue class has been introduced, which replaces former
base::DictionaryValue. The former solution was not good, since we already
parse the base::Value in api function implementations (using generated from
IDL parsers). So, passing a raw base::Value and later parsing is again is an
overkill.

The RequestValue class is a trivial wrapper for all kinds of IDL values, which
can be passed through the RequestManager to Operation classes.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/257493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363540
TEST=manually tested.

Review URL: https://codereview.chromium.org/255823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266515 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/238123003 an import
of base.gyp is introduced in build/common.gypi. This
makes GYP fail for some client projects using the Chromium
build toolchain. By adding a condition variable for this
part, it is possible to avoid this include by setting
use_sanitizer_options=0.

NOTRY=True
BUG=302040
TEST=passing runhooks on a variety of trybots.

Review URL: https://codereview.chromium.org/250883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266514 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes the process that sends pending frames when a WebSocketChannel
receives quota from the renderer process. The IOBuffer data of a frame can
be null, but the implementation didn't take account of that.

BUG=364788
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/258833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266513 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Telemetry] Enable the measurement smoke test on android. (https://codereview.chromium.org/250593003/)

Reason for revert:
[Sheriff] This is failing on android now (slightly after its activation, but I can't figure out the actual culprit):
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20079

Original issue's description:
> [Telemetry] Enable the measurement smoke test on android.
> 
> This required disabling the benchmarks that were causing it to fail. It looks
> like those failures were due to lack of tab support in ChromeShell.
> 
> BUG=337829
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266457

TBR=bulach@chromium.org,tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=337829

Review URL: https://codereview.chromium.org/256123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367695
TBR=piman@chromium.org, mihaip@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/254743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266510 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/251663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266509 0039d316-1c4b-4281-b951-d872f2087c98

Some systems might like to use Mojo IPC to talk to services that are
running outside the auspices of the Mojo shell. DBus is one potential
channel to use for bootstrapping such a connection.

In order to allow the externally-running service to accept connections
from a Mojo shell, we need to get it a ShellHandle. This change
defines a DBusServiceLoader that implements the ServiceLoader
interface.  DBusServiceLoader creates a dedicated MessagePipe, passes
a handle to one end to the desired service over DBus, and then passes
the ShellHandle over that pipe.

This class assumes the following:
1) Your service is already running,
2) Your service implements the Mojo ExternalService API
   (from external_service.mojom).
3) Your service exports an object that implements the org.chromium.Mojo
   DBus interface:
   <interface name="org.chromium.Mojo">
     <method name="ConnectChannel">
       <arg type="h" name="file_descriptor" direction="in" />
     </method>
   </interface>

This change also includes a trivial DBusEchoService that can be
"loaded" using the DBusServiceLoader, as well as a mojo example app
that connects to this service.

BUG=364903
TEST=run mojo_dbus_echo_service in one shell, and then load mojo_dbus_echo in the mojo shell. "who" should successfully echo between the two.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265927

Review URL: https://codereview.chromium.org/242763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266508 0039d316-1c4b-4281-b951-d872f2087c98

NavigationList's activeModelItem_() is called even when the actual active model is not changed.
It occurs when the list items on navigation list are permutated by mounting/unmounting devices.
This patch checks if the actual active model is changed.
Code for clearing selection on clicking root items is moved to click event handler. 

BUG=361047
TEST=manually tested
ran browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/251483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266507 0039d316-1c4b-4281-b951-d872f2087c98

If the ancestorEntry is root directory, the URL for it ends with slash.
Appending one more slash cause failure to comparison.
I think appending slash is not necessary because we have already checked
that the ascestorEntry is directory.

BUG=361047
TEST=ran browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/253343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331299
TEST=None, no functional changes. Just build content_shell,
content_unittests, content_browsertests to make it still link.
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/259773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266505 0039d316-1c4b-4281-b951-d872f2087c98

Missed a case when enabling the flag on CrOS in r266119.

BUG=367099

Review URL: https://codereview.chromium.org/257903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266504 0039d316-1c4b-4281-b951-d872f2087c98

This makes the "Rasterization" field work properly again and adds
some constants to prevent this from breaking again.

BUG=367124

Review URL: https://codereview.chromium.org/250773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326577
TEST=Each detail how has both the time and status on one
row rather than split over two rows.

Review URL: https://codereview.chromium.org/249523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266502 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266501 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative revert of a libvpx roll to unblock dev release.

BUG=366025

> Roll libvpx 263116:264320
> 
> Enable AVX2 code:
> https://codereview.chromium.org/236183003
> 
> Fix Win build issues:
> https://codereview.chromium.org/239003004
> 
> Leave AVX2 ready but off:
> https://codereview.chromium.org/240153006
> 
> Remove all the AVX2 references:
> https://codereview.chromium.org/240113008
> 
> Review URL: https://codereview.chromium.org/236263002

TBR=johannkoenig@google.com

Review URL: https://codereview.chromium.org/252003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266500 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Enable impl-side painting by default on all platforms where threaded compositing is used. (https://codereview.chromium.org/242803007/)

Reason for revert:
This makes DevTools unusable on Linux Aura, see crbug.com/367673.

Original issue's description:
> cc: Enable impl-side painting by default on all platforms where threaded compositing is used.
> 
> BUG=169282
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266471

TBR=piman@chromium.org,vangelis@chromium.org,enne@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=169282

Review URL: https://codereview.chromium.org/259843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266499 0039d316-1c4b-4281-b951-d872f2087c98

> Reland of 260688: [Files.app] Use getDriveEntryProperties() to retrieve metadata
> 
> This is a reland of 260688, which is reverted due to false charge of build failure.
> 
> Previously, we used FileEntry.getMetadata() to retrieve filesystem metadata and getDriveEntryProperties() to get Drive metadata, so we need 2 calls for 1 file on Drive.
> 
> With this patch, getDriveEntryProperties() returns not only Drive metadata but also filesystem metadata. It's enough to call only getDriveEntryProperties() and we can reduce a number of calls by half.
> 
> BUG=345196
> TEST=browser_test passes.
> R=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org
> TBR=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org
> 
> Review URL: https://codereview.chromium.org/195763004

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/250803018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367665
TBR=nick@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/255903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266497 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add perf tests for simd yuv->rgb conversion functions. (https://codereview.chromium.org/238353008/)

Reason for revert:
Breaks win64 compile.

Original issue's description:
> Add perf tests for simd yuv->rgb conversion functions.
> 
> BUG=172898
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266490

TBR=scherkus@chromium.org,rileya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=172898

Review URL: https://codereview.chromium.org/251953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266496 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266494 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172575:172711&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/258003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266493 0039d316-1c4b-4281-b951-d872f2087c98

This is a large refactoring to cleanup the code that handles video
capturing in the render process. The goal of this change is to:
* Simplify threading model for objects involved.
* Clarify ownership model.
* Remove extra complexity caused by media::VideoCapture.

Summary of this change:
* Interface media::VideoCapture is removed completely.
  This interface doesn't add much value. It fails to define threading
  model and ownership. Some of the methods are obsolete. 
* Pepper code that performs video capturing now do not inherit from
  media::VideoCapture.
  The inheritance is not necessary
* VideoCaptureImpl is now a purely IO thread object.
  VideoCaptureImpl can only be accessed on the IO thread. It now becomes
  and inner object of VideoCaptureImplManager. Client is not allowed to
  access this object directly. This helps remove code that accepts
  call from the render thread and hopping to the IO thread. This also
  makes cleanup much simpler.
* VideoCaptureHandle is removed.
  The function of VideoCaptureHandle, i.e. handle cleanup of video
  capture resource is now folded into VideoCaptureImplManager. It's
  function is now replaced by a closure.
* VideoCaptureImplManager becomes the public interface for accessing
  video capture device and start/stop capture.
  It takes VideoCaptureImpl as an internal object and sheild it from
  clients. We can now perform cleanup to prevent leak. Also ensures
  VideoCaptureImpl objects are deleted on the IO thread.
* VideoFrames delivery done using callback insteasd of an interface.
  Using callback to deliver VideoFrames and state changes make thread
  hopping much simpler. Clients no longer need to provide an
  EventHandler interface.
* Net deleted 450 lines of code.

Tested with apprtc.appspot.com and example pepper plugin.
Additional test to verify there's no leakage of VideoCaptureImpl objects.

BUG=335327, 362558

Review URL: https://codereview.chromium.org/242013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266492 0039d316-1c4b-4281-b951-d872f2087c98

server configs, so that server can replace both the server config and
source address token key when communication with keystore succeeds.

Add retry logic and more graceful fallback to code that loads QUIC
insecure secrets from keystore.  Not flag protected.

Merge internal change: 63497296

  + Changed ComputeSourceAddressTokenKey to DeriveSourceAddressTokenKey
  + Fixed comments.
  + Changed Config* to a const reference in BuildRejection,
    NewSourceAddressToken and ValidateSourceAddressToken methods.

Merge internal change: 65382861

Use QuicEncrypter and QuicDecrypter with "AES128 + GCM-12" as the AEAD
algorithm to implement CryptoSecretBoxes' Box and Unbox methods. These
methods are used in unit tests only.

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/213473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172898

Review URL: https://codereview.chromium.org/238353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266490 0039d316-1c4b-4281-b951-d872f2087c98

Use a map sorted by <timestamp, ssrc, packet_id> to keep track of duplicate
packets. This map conveniently sorts such that map.begin() is the oldest packet
and should be sent first.

Also make sure that we never buffer more than one RTSP packet per ssrc.

Review URL: https://codereview.chromium.org/248493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266488 0039d316-1c4b-4281-b951-d872f2087c98

It's need to be used by utility and browser processes.

BUG=349645

Review URL: https://codereview.chromium.org/256923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266487 0039d316-1c4b-4281-b951-d872f2087c98

The DomDistillerService now requires callers to pass in DistillerPage.
This enables callers to more closely control how the page is distilled.

BUG=361939

Review URL: https://codereview.chromium.org/254483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266486 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/258893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266485 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements the getService and getServices functions of the
bluetoothLowEnergy API. The key changes introduced are:

* BluetoothLowEnergyEventRouter, which tracks Observer events from the
device/bluetooth API, maintains a mapping from instance IDs to the necessary
metadata to look up a GATT object from the adapter, and handles basic logic
such as conversion between device::BluetoothGatt* and
extensions::api::bluetooth_low_energy::* objects and sending of API events.

* Implementation of getService and getServices functions.

* In browser unit tests for the above functions.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*, device_unittests

Review URL: https://codereview.chromium.org/256413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357670

Review URL: https://codereview.chromium.org/259763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266483 0039d316-1c4b-4281-b951-d872f2087c98

This blacklists some specific types of HID devices from
being accessible to the chrome.hid API. Namely, any keyboard,
mice, other pointer devices, or system control inputs (such as
power and reset buttons) are blocked and cannot be enumerated
or opened by the consumers of the API.

BUG=355022
R=rpaquay

Review URL: https://codereview.chromium.org/258733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266482 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up CL of https://codereview.chromium.org/228263004/

This CL adds instances of SavePasswordProgressLogger into crucial parts of the password manager code. After this CL, the logging should already work, i.e., when the command line flag is enabled, the internals page should show debugging info about saving a password on a website.

More context in the design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing

BUG=347927

Review URL: https://codereview.chromium.org/231283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266481 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/252703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266480 0039d316-1c4b-4281-b951-d872f2087c98

Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).

This pref will be used to persist data about user-selected 
default search providers. In future CLs, support will be added for default search providers set by policy and sync.


BUG=365762

Review URL: https://codereview.chromium.org/229763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266479 0039d316-1c4b-4281-b951-d872f2087c98

Per the spec DiscardPadding is a signed integer.  Sadly the parser
only supports UInt values at the moment.  To avoid refactoring the
world, we parse DiscardPadding as binary and have a one off parser.

A re-encoded bear-opus-end-trimming.webm will be landed separately
ahead of this change.

This patch also adds a check to ensure we never parse uint64 values
which will overflow an int64 container.

BUG=366750
TEST=Existing tests pass w/ DCHECK.

Review URL: https://codereview.chromium.org/251583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266478 0039d316-1c4b-4281-b951-d872f2087c98

R=Jói

Review URL: https://codereview.chromium.org/244313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338759
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/250903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=wtc@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/253643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266475 0039d316-1c4b-4281-b951-d872f2087c98

This CL reenables the change introduced in http://crrev.com/256939. The UI is updated to reflect the one approved by UX team.

BUG=314621

Review URL: https://codereview.chromium.org/225523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266474 0039d316-1c4b-4281-b951-d872f2087c98