- 19 Jun, 2018 40 commits
-
-
Hajime Hoshi authored
This reverts commit 18a428ba. Reason for revert: We realized that EventQueueImpl (after merged with MediaElementEventQueue) : target is not 1:1. Instead of EventQueueImpl with a target, each event should have its target. Original change's description: > Add EventQueueImpl::target_ > > This CL is a continuation of > https://chromium-review.googlesource.com/c/chromium/src/+/1088356. > > This CL gives an event target to EventQueueImpl and use it instead of > event->target() so that we can have EventQueueImpl and > MediaElementEventQueue with the same structure. > > Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# > > Bug: 846618 > Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e > Reviewed-on: https://chromium-review.googlesource.com/1098736 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567220} TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846618 Change-Id: Ic2f63364ec2d76d3aef51432d9e4c1258034c867 Reviewed-on: https://chromium-review.googlesource.com/1105653Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568406}
-
Marc Treib authored
The recently-added virtual/user-activation-v2/ needs the same expectations as other suites. While we're here, also update the bug numbers. TBR=mustaq@chromium.org NOTRY=true Bug: 828506 Change-Id: Ic1e7b0e394f1eb93fc265bc17b53eed40aa1b605 Reviewed-on: https://chromium-review.googlesource.com/1105980Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568405}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/024eeff4215d..790da37b72f9 git log 024eeff4215d..790da37b72f9 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 saza@webrtc.org Fuzz AEC field trial killswitches 2018-06-19 saza@webrtc.org Remove non-API beamformer references Created with: gclient setdep -r src/third_party/webrtc@790da37b72f9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6481f93beab31e8ef1e437ac25f7dc7114df6662 Reviewed-on: https://chromium-review.googlesource.com/1105103 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568404}
-
Hajime Hoshi authored
We realized that MediaElementEventQueue : target is not 1 : 1. Then, Having MediaElementEventQueue own a target doesn't make sense. This CL enforces to set a target of an event before enqueuing and use it when dispatching. Bug: 846618 Change-Id: Iacc19e6c55040fe05e4883fa33f570b3424650e0 Reviewed-on: https://chromium-review.googlesource.com/1105803Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
David 'Digit' Turner authored
This CL adds a new GN template to specify a set of Android resource files generated by another target's action. The generated files must be stored by the action into a zip archive, with a layout similar to standard Android res/ folder (but note that the archive should not have a top-level res/ directory). + Update java_strings_grd(), java_strings_grd_prebuilt() and jinja_template_resources() to use it. BUG=846633 R=agrieve@chromium.org, estevenson@chromium.org, jbudorick@chromium.org Change-Id: Ibb0ec100d0922ac1ec3155f4577f40136f233b0b Reviewed-on: https://chromium-review.googlesource.com/1104355 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568402}
-
Sylvain Defresne authored
Some client of SigninManagerFactory uses the GetForProfileIfExists method to get the instance without creating it. Add the same method to IdentityManagerFactory. Bug: none Change-Id: I84323808e555c8558576ba614a1b4c6057b2a074 Reviewed-on: https://chromium-review.googlesource.com/1100757Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568401}
-
Ulan Degenbaev authored
This CL adds a new infobar and a new tab helper. The infobar shows a message "The web page was reloaded because it ran out of memory." when a tab running in a bloated renderer is reloaded by the resource coordinator. The resource coordinator notifies the tab helper using a new WillReloadPageWithBloatedRenderer method in WebContentsObserver. After receiving this notification the tab helper shows the infobar on the subsequent DidFinishNavigation event. Bug: 808143 Change-Id: Id32d38cd6f45b30896696026fb71549eb7a570ac Reviewed-on: https://chromium-review.googlesource.com/1072474 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#568400}
-
Ivan Sandrk authored
Bug: chromium:833188 Change-Id: Ie5b219d8af790372e8cdd78d012cd6dce4977ac6 Reviewed-on: https://chromium-review.googlesource.com/1098930 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568399}
-
Nico Weber authored
Change-Id: I96766521324749040f483e18cab94ba96d84daae Reviewed-on: https://chromium-review.googlesource.com/1105523Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The metric tracks the size of all objects allocated in V8 and it is similar to the existing Memory.Experimental.Renderer2.V8 metric. The difference between the two metrics shows fragmentation of V8's heap. The naming scheme is chosen similar to the existing BlinkGC and BlinkGC.AllocatedObjects metrics. Bug: 852415 Change-Id: Id1addec3bc0e09b3a16a16afbec0a634e5c26fe5 Reviewed-on: https://chromium-review.googlesource.com/1101020Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568397}
-
Findit authored
This reverts commit 8828e090. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 568352 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4MjhlMDkwM2U4Y2QxNzIyZDE0ZjI3Zjg3YjgxYTllZWQxOGQ1NWMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7673 Sample Failed Step: chromeos_unittests Original change's description: > [CrOS MultiDevice] Implement PendingConnectionManagerImpl. > > This class creates one ConnectionAttempt per ConnectionAttemptDetails > requested; if more than one request shares the same > ConnectionAttemptDetails, a single ConnectionAttempt attempts a > connection for all associated requests. > > If a ConnectionAttempt successfully creates a channel, this class > extracts client data from all requests to the same remote device and > alerts its delegate, deleting all associated ConnectionAttempts when it > is finished. > > Bug: 824568, 752273 > Change-Id: If9790549157919209e3e96f4a0b11d04fda2870c > Reviewed-on: https://chromium-review.googlesource.com/1103669 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568352} Change-Id: Idd35a8b968324aafbf283868ff79fa49d9f879e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824568, 752273 Reviewed-on: https://chromium-review.googlesource.com/1105897 Cr-Commit-Position: refs/heads/master@{#568396}
-
Marc Treib authored
This reverts commit c45ec0a7. Reason for revert: Seems to have broken services_unittests on Android CFI, see: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/1747 Note that the bot says it timed out, but looking at the failed shard, GeolocationProviderTest.OnPermissionGrantedWithoutObservers and .StartStop fail with: I 212.843s run_tests_on_device(00f19e674463a218) [ RUN ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers I 212.843s run_tests_on_device(00f19e674463a218) ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:177: Failure I 212.843s run_tests_on_device(00f19e674463a218) Value of: provider()->user_did_opt_into_location_services_for_testing() I 212.843s run_tests_on_device(00f19e674463a218) Actual: true I 212.843s run_tests_on_device(00f19e674463a218) Expected: false I 212.843s run_tests_on_device(00f19e674463a218) Stack trace: I 212.843s run_tests_on_device(00f19e674463a218) #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599 I 212.843s run_tests_on_device(00f19e674463a218) #01 0xde0321af /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014311af I 212.843s run_tests_on_device(00f19e674463a218) #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3 I 212.843s run_tests_on_device(00f19e674463a218) I 212.844s run_tests_on_device(00f19e674463a218) [ FAILED ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers (32 ms) I 212.844s run_tests_on_device(00f19e674463a218) [ RUN ] GeolocationProviderTest.StartStop I 212.844s run_tests_on_device(00f19e674463a218) ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:183: Failure I 212.844s run_tests_on_device(00f19e674463a218) Value of: provider()->IsRunning() I 212.844s run_tests_on_device(00f19e674463a218) Actual: true I 212.844s run_tests_on_device(00f19e674463a218) Expected: false I 212.844s run_tests_on_device(00f19e674463a218) Stack trace: I 212.844s run_tests_on_device(00f19e674463a218) #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599 I 212.844s run_tests_on_device(00f19e674463a218) #01 0xde0323b7 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014313b7 I 212.844s run_tests_on_device(00f19e674463a218) #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3 I 212.844s run_tests_on_device(00f19e674463a218) I 212.844s run_tests_on_device(00f19e674463a218) [ FAILED ] GeolocationProviderTest.StartStop (29 ms) Original change's description: > Move geolocation unittests from //device to //services > > This is one step of "moving //device/geolocation into //services". > > BUG=800659 > > Change-Id: I041329923b2cbedab1afd51cc865b278a6a1523a > Reviewed-on: https://chromium-review.googlesource.com/1100694 > Reviewed-by: Ben Chan <benchan@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Ke He <ke.he@intel.com> > Cr-Commit-Position: refs/heads/master@{#568322} TBR=stevenjb@chromium.org,benchan@chromium.org,rockot@chromium.org,ke.he@intel.com Change-Id: I6527e0a42788d033ff8047b9d38ff16102050a55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800659 Reviewed-on: https://chromium-review.googlesource.com/1105877Reviewed-by:
-
Rune Lillesveen authored
::before, ::after, and ::backdrop should be created during style recalc, or they will be created from AttachLayoutTree() if parent needs to create its layout box. ::first-letter is still special because its creation depends on the layout tree and it needs to be constructed in RebuildPseudoElementLayoutTree for the case below when #outer has a ::first-letter, #inner is initially display:none and changes to block: <div id=outer><div id=inner>Text</div></div> This fixes crashers after: https://crrev.com/2d21d004fa5157a1c4409b19e2f808001d026304 Bug: 852396, 853551 Change-Id: Ib58e211defe44a5d2ca04222be5eeb6aecfa59af Reviewed-on: https://chromium-review.googlesource.com/1105055Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568394}
-
Vaclav Brozek authored
Username predictions list text field from a form in a descending likelihood that they are usernames. The predictions are obtained by running a classifier (locally) on the DOM tree containing the form. They are represented as a vector of unique renderer ids of the identified fields. This CL makes the username predictions part of FormData and teaches the new FormData -> PasswordForm parser to use them. FormData serves both address autofill and password autofill, yet username predictions are only relevant to the latter. In this sense, password autofill is polluting the struct for address autofill. However, given the close relationship between the predictions and the actual FormFieldData they refer to, and given the not-so-high overhead of passing around an empty vector (compared to the overall size of FormData), encapsulating the predictions with FormData was chosen as the approach to go with. Bug: 845426 Change-Id: I92ca2eb8d2a24d08541e4878a0732092a473c74f Reviewed-on: https://chromium-review.googlesource.com/1101027 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#568393}
-
Marc Treib authored
TBR=thakis@chromium.org NOTRY=true Bug: 807465 Change-Id: I217899e452758bd531eb800b3ed8ae761f8af4d7 Reviewed-on: https://chromium-review.googlesource.com/1105826Reviewed-by:
-
Sylvain Defresne authored
IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert NTPResourceCache to the new API. Bug: 798408 Change-Id: Ia94e15dd8b50f546a9d6b02957dfefe9d40105e0 Reviewed-on: https://chromium-review.googlesource.com/1097332Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568391}
-
Kinuko Yasuda authored
ResourceLoadScheduler (as a code infra) is already in use for the renderer-side resource scheduler, and is also a basis for stopping loading feature that is gated by other feature flags. This change isolates the ResourceLoadScheduler flag (as a flag) to make it affect only for background throttling, so that separate features built on top of ResourceLoadScheduler can be enabled independently. R=ksakamoto@chromium.org, toyoshim@chromium.org Bug: 837771 Change-Id: I346faf192ff93f2441fe5ed6a82212e76bd34b78 Reviewed-on: https://chromium-review.googlesource.com/1105202Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568390}
-
Olga Sharonova authored
Audio process experiment is observing performance regressions caused by on-the-flight audio process launch. Introducing a feature flag to pre-launch it on the browser startup. This will be rolled out as another AudioService experiment group, to evaluate memory and performance impact. TEST=manual Bug: 851611,853781 Change-Id: I30c1798dae07c5ce8a71243ab482ceb89d008e43 Reviewed-on: https://chromium-review.googlesource.com/1104681 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This CL copies the throttling_profile_id of the original signed exchange request to the certificate request, so that we can throttles the certificate requests using DevTools. The throttling_profile_id is copied in this flow. Navigation case: NavigationURLLoaderImpl::URLLoaderRequestController => SignedExchangeRequestHandler => SignedExchangeLoader => SignedExchangeCertFetcherFactory::Create() => SignedExchangeCertFetcherFactoryImpl => SignedExchangeCertFetcher::CreateAndStart() => SignedExchangeCertFetcher => network::ResourceRequest Prefetch case: PrefetchURLLoader::PrefetchURLLoader() => SignedExchangePrefetchHandler => SignedExchangeLoader => ... same as navigation case... Bug: 849966 Change-Id: I443af86ca6a465a68e9f4c804d4cd9a9bac12227 Reviewed-on: https://chromium-review.googlesource.com/1088343Reviewed-by: -
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd5dd45d..72566aa8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0e6d34f28a4c3cb7b025fabb5a72769659b20557 Reviewed-on: https://chromium-review.googlesource.com/1105629Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568387}
-
Christian Dullweber authored
Test that the CookieTreeModel behaves the same as the site data counter. Bug: 843995 Change-Id: Ib226c829dec5a242fca22222961b99c398703d1d Reviewed-on: https://chromium-review.googlesource.com/1100827 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568386}
-
Gauthier Ambard authored
This CL avoid presenting a popup menu is there is already one shown. This can be done by pressing simultaneously on two buttons. Bug: 850057 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e501235c3527217e9f354277e09bc353430b95b Reviewed-on: https://chromium-review.googlesource.com/1104694Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568385}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00c71836144b..024eeff4215d git log 00c71836144b..024eeff4215d --date=short --no-merges --format='%ad %ae %s' 2018-06-19 buildbot@webrtc.org Roll chromium_revision 9df92afb..9d565db4 (566630:568343) 2018-06-18 braveyao@webrtc.org [desktopCapture Mac]reorder execution order in start/release processing 2018-06-18 deadbeef@webrtc.org Removing unused cricket::Port constructor. 2018-06-18 titovartem@webrtc.org Extract rtc_base/base64.h and rtc_base/base64.cc into separate target. 2018-06-18 nisse@webrtc.org Delete FakeWebRtcVcmFactory::OnDestroyed method. 2018-06-18 saza@webrtc.org Stop using the beamformer inside APM 2018-06-18 danilchap@webrtc.org Replace rtc::Optional with absl::optional in test and rtc_tools 2018-06-18 danilchap@webrtc.org Pass buffer with size when writing rtp header extension 2018-06-18 danilchap@webrtc.org Replace rtc::Optional with absl::optional 2018-06-18 jonasolsson@webrtc.org Disable new RTC_CHECK unittest Created with: gclient setdep -r src/third_party/webrtc@024eeff4215d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:851883,chromium:None,chromium:826911 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I40c83252469c6851a87290ae594082cb5a53c2cf Reviewed-on: https://chromium-review.googlesource.com/1105221 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Chris Nardi authored
Per the CSS Fonts 4 spec [1], only keyword values for font-stretch are valid in the font shorthand. Our current serialization code ignores this, and outputs percentage values as well in the shorthand, meaning that the generated rule cannot be reparsed. We now check if the percentage can be converted to a keyword, and if so, output it as that keyword. Otherwise, we do not output a serialization for the font shorthand, as per the CSSOM spec [2]. [1]: https://drafts.csswg.org/css-fonts-4/#font-prop [2]: https://drafts.csswg.org/cssom/#serializing-css-values Bug: 850092 Change-Id: I7e3eec64723966b15abfa819213b95cba6cbc3d5 Reviewed-on: https://chromium-review.googlesource.com/1103856 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#568383}
-
Jérôme Lebel authored
Moving code to implement collapsable model from TableViewModel to ListModel. The benefit is to have collapsable collection view too. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iff0d0bd9c15358ba21b82fdda9e373e8b1079656 Reviewed-on: https://chromium-review.googlesource.com/1101518 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568382}
-
Gauthier Ambard authored
This CL uses frames and autoresizing masks for positioning the popup menu shadow instead of auto layout as auto layout is introducing a bug on iPhone X where the shadow is 1px off. Bug: 850519 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia01d6abe924b5229b69676fe37ef251e11b60d31 Reviewed-on: https://chromium-review.googlesource.com/1104686Reviewed-by:
-
Daniel Vogelheim authored
Update the experiment to our current launch candidate. Bug: 761977 Change-Id: I3fda7188b9fa963e95dfeaa5512dcdf4f594a2f5 Reviewed-on: https://chromium-review.googlesource.com/1104350Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#568380}
-
Marc Treib authored
GetUploadToGoogleState supposedly tells you whether a given ModelType is actively being uploaded to Google. However, before this CL, it only checked that the ModelType is "preferred" (i.e. not disabled by the user) and that the SyncService itself is in an active state. That missed some cases, e.g. when a ModelType is disabled via browser policy. This CL fixes this by also checking that the ModelType in question is in an active state. Bug: 852385 Change-Id: Ifb3f4e912844ece21c691199091b3cf65ad02ad1 Reviewed-on: https://chromium-review.googlesource.com/1099239 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568379}
-
Noel Gordon authored
The QuickView tests are slower than most, and the bug addresses making them faster. setupAndWaitUntilReady loads, and pre-populates Downloads and Drive volumes with many file entries. Can we do better? A modest test speed improvement is to make setupAndWaitUntilReady only populate the volumes needed in the tests (Downloads, Drive, etc), with only those files needed to perform each test. Bug: 851888 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0cb4d08fa38d9df76999595f41dfb8a0df378a9f Reviewed-on: https://chromium-review.googlesource.com/1104619Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568378}
-
Marc Treib authored
TBR=cduvall@chromium.org Bug: 854032 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0af88589cf1bce8715660d4b7e71c95a697085f8 Reviewed-on: https://chromium-review.googlesource.com/1105766 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
Update the blink layout test: http/tests/inspector-protocol/frameScheduledNavigation.js This CL is similar to: * https://chromium-review.googlesource.com/c/chromium/src/+/1071630 * https://chromium-review.googlesource.com/c/chromium/src/+/1071791 Depending on timing and the size of the main resource, new navigations initiated in <script> may starts before the document is fully loaded. In this case, frameStartedLoading is not fired because the load didn't stop in between. Bug: 831155 Change-Id: I872b7ff9b332893c0b57f921f992e348276e9d42 Reviewed-on: https://chromium-review.googlesource.com/1102681Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568376}
-
Mikel Astiz authored
We currently only stop sync (without disabling) in tests only, but we expect this to be more common in the future (DICe, payments, Butter). Instead of letting bridges do ugly workarounds, let propagate the transition to the processor, and allow bridges to (if interested) do something about it. Bug: 681921 Change-Id: I9689346e71d7eeb0c7b13eb601d88722e51f5ae4 Reviewed-on: https://chromium-review.googlesource.com/1098915 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568375}
-
Boris Sazonov authored
This CL adds StateListDrawableBuilder, a helper class that simplifies StateListDrawable and AnimatedListDrawable creation. Bug: 814728 Change-Id: If2f07e1dab0cd7f5a6d46c81e37f4153b6259caa Reviewed-on: https://chromium-review.googlesource.com/1101325 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568374}
-
Ned Nguyen authored
Change-Id: Ia2524a47c97a55f17686e8a8153d3548b1eee161 Reviewed-on: https://chromium-review.googlesource.com/1105280 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Gauthier Ambard authored
The spotlighted view wasn't created for the tools menu button. This bug was introduced in the CL moving the creation of the spotlight view from a lazy accessor to a protected method. Bug: 850513 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bdf63ab0ed7095203a0dad2ce34642912814710 Reviewed-on: https://chromium-review.googlesource.com/1104690Reviewed-by:
-
tzik authored
MockOneShotTimer and MockRepeatingTimer are subclasses of OneShotTimer and RepeatingTimer respectively, that are intended to replace most of MockTimer. As MockTimer is not a OneShotTimer nor RepeatingTimer, when we want to use MockTimer for other timers, we had to use the generic Timer to hold a timer instance, that loses the timer traits from its type. Change-Id: Iea4a469708be2b89d4feb228460d78ab2a2f96d1 Reviewed-on: https://chromium-review.googlesource.com/1095195 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This reverts commit 60d31377. Reason for revert: We realized that MediaElementEventQueue : target is not 1:1. Instead of MediaElementEventQueue with a target, each event should have its target. Original change's description: > Remove some Event::SetTarget for MediaElementEventQueue > > Before merging MediaElementEventQueue into EventQueueImpl, we need to > eliminate code to set the target for an event. This is part of this work. > > Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# > > Bug: 846618 > Change-Id: Ic3b19ff2af19d931356ff72800797b36506f5ff0 > Reviewed-on: https://chromium-review.googlesource.com/1102233 > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567587} TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846618 Change-Id: I28cf7c58e123b66e2472f64b233684cbf1006dd4 Reviewed-on: https://chromium-review.googlesource.com/1105540Reviewed-by:
-
chrome://flagsDarren Shen authored
This is the expected behaviour (there was a typo in flags page template) Change-Id: I94a318b03df8bd133d49e2d8d4b345770cd6e864 Reviewed-on: https://chromium-review.googlesource.com/1105654Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#568369}
-
Anders Hartvoll Ruud authored
When a node is inserted into a container, it is notified via ::InsertedInto. However, a node may request a second notification via DidNotifySubtreeInsertionsToDocument, which occurs after all the children have been notified as well. *StyleElement is currently using this second notification. This causes a problem, because *ScriptElement is using the same mechanism, which in turn means that scripts can execute before the state of *StyleElements are properly updated. This patch avoids ::DidNotifySubtreeInsertionsToDocument, and instead processes the stylesheet in ::InsertedInto. The original reason for using ::DidNotifySubtreeInsertionsToDocument in the first place appears to be invalid now, as the test case is still passing. R=futhark@chromium.org, hayato@chromium.org Bug: 853709, 847570 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0b5fa611044c78c5745cf26870a747f88920a14 Reviewed-on: https://chromium-review.googlesource.com/1104347 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568368}
-
Kush Sinha authored
Fix memory leak in tests by removing the dangling pointers to |GaiaTokenRevocationHelper| and instead make |AccountManager| own those pending requests (via a |std::vector<std::unique_ptr<GaiaTokenRevocationRequest>>|). In tests, when |AccountManager| is deleted, these pending requests will be deleted too. Original change's description: > Add server token revocation in AccountManager > > Bug: 820046 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" > Reviewed-on: https://chromium-review.googlesource.com/1087455 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566961} Bug: 820046 Test: chromeos_unittests --gtest_filter="*AccountManager*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I8e186de574ab78a2e4c03d43a9147d1371473dd3 Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_asan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1101202 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#568367}
-
