- 11 Jan, 2019 40 commits
-
-
Ethan Nicholas authored
Change-Id: I94fbe4917ea5b5d4ce442a69219551a77313836d Reviewed-on: https://chromium-review.googlesource.com/c/1407036Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622039}
-
Martin Robinson authored
Previously a null was returned when querying the parent accessible of a document on AuraLinux. This change implements sets this accessible as a property on the view that contains the WebContents, allowing native accessibility APIs to traverse all the way up the accessibility tree by querying this value. Bug: 905013 Change-Id: I960becdcbc99a035aae00ff9f550206b042b5af3 Reviewed-on: https://chromium-review.googlesource.com/c/1356596 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#622038}
-
Navid Zolghadr authored
Bug: 612456 Change-Id: Idefb93e48c6d99ea3927702d17280a2c82850fdb Reviewed-on: https://chromium-review.googlesource.com/c/1405435Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622037}
-
Dave Tapuska authored
This is a reland of b7181485 Original change's description: > Enable 64 bit truncation warnings in blink > > BUG=879657 > > Change-Id: I80f12446a4a7507436fa85db4b454705b841a91b > Reviewed-on: https://chromium-review.googlesource.com/c/1362207 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621694} Bug: 879657 Change-Id: I2635dc3f93f93dbe05f059a91740d0d4305e39ae Reviewed-on: https://chromium-review.googlesource.com/c/1406130 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#622036}
-
Dave Tapuska authored
IntersectionObserver is using kInternalIntersectionObserver which is a pausable task queue. BUG=907125 Change-Id: I63fd26c407f32e64996f8e8a9af4ee860fc4daf6 Reviewed-on: https://chromium-review.googlesource.com/c/1388297 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a663e359..2bc360ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If5d1b71cd1f541b5fa80dff7b496f4ab21e99e47 Reviewed-on: https://chromium-review.googlesource.com/c/1406935Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622034}
-
Adithya Srinivasan authored
Tbr: sebsg@chromium.org No-Try: true Bug: 921062 Change-Id: Ic9699d7c3a2350e4969730288ae1ffae47917f4b Reviewed-on: https://chromium-review.googlesource.com/c/1407091Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#622033}
-
Robert Ma authored
This flaky test is seen to have three different failure modes on Android. This CL unblocks the wpt-importer. TBR=foolip No-Try: True Change-Id: Id2ae37beb200e05baff59c276a4735ceda616c49 Reviewed-on: https://chromium-review.googlesource.com/c/1407092Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#622032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d0af9555211..9af71a58413e Created with: gclient setdep -r src-internal@9af71a58413e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3462073d32926f0bb55fd5a1b3999bd7251441a6 Reviewed-on: https://chromium-review.googlesource.com/c/1406954Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622031}
-
Tibor Goldschwendt authored
Bug: 908819 Change-Id: I23a9f9f3f7439e6d34223321e93da2dee5bb6cbf Reviewed-on: https://chromium-review.googlesource.com/c/1406938 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#622030}
-
Roman Sorokin authored
Disabled on Mac due to flakiness TBR=aaronhk@chromium.org Bug: 920907 Change-Id: Ib3b4df696dbb7b7a1a2a4f214b2c9bd67d12d5b0 Reviewed-on: https://chromium-review.googlesource.com/c/1407070Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#622029}
-
Roman Sorokin authored
Due to flakiness (see bug) It runs on mac only TBR=rsesek@chromium.org Bug: 920582 Change-Id: I5006cdb12017f7bfb4455f2bbfaaa738f6ffab12 Reviewed-on: https://chromium-review.googlesource.com/c/1407006Reviewed-by:
-
Fredrik Söderquist authored
Remove the (unneeded) includes of console_message.h from core/dom/document.h and core/execution_context/security_context.h. This should for instance avoids indirectly including dom_node_ids.h more than needed. This will hopefully improve compilation speed a little bit, for some people. Bug: 242216 Change-Id: I775478624933833981c0f9ccd28e82e1bf815e00 Reviewed-on: https://chromium-review.googlesource.com/c/1406974 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622027}
-
Daniel Bratell authored
R=thakis@chromium.org Change-Id: I60faf240e3335bba2a4258c1677b07fb892e9b69 Reviewed-on: https://chromium-review.googlesource.com/c/1407075Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/2cf86e5ab6dc..68752454406a $ git log 2cf86e5ab..687524544 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 junyer Avoid null PODArray<> issues in SparseSet and SparseArray<>. 2019-01-11 junyer Use PODArray<> in SparseArray<>. 2019-01-10 junyer Simplify SparseArray<> significantly. 2019-01-10 junyer Ensure we succeed at constructing new sparse and dense arrays. 2019-01-09 ckennelly Ensure we succeed at constructing new sparse and dense arrays. 2019-01-09 ckennelly Use PODArray<> in SparseSet. 2019-01-08 stevenperron Make Frame use an index, not an iterator. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: I83055ef76fff8b493e2b75a877c8baf145f0bfea Reviewed-on: https://chromium-review.googlesource.com/c/1406572Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622025}
-
Etienne Bergeron authored
This CL is fixing the cause of the flakiness of this unittest: BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped We believe the flakiness was caused by the possibility of start/stop tracing twice. We added a dump of stackframe when the tracing observer call |OnTraceLogEnabled| and we realized that on linux it's called twice. The stackframes are below. Calling sites are: 1) content::BackgroundTracingManagerImpl::SetActiveScenario() 2) content::BackgroundTracingManagerImpl::OnFinalizeComplete() The call 1) is the expected one in the unittest since it's the one starting tracing. The call 2) is caused by the config not being correctly disable with the call to |DisableScenarioWhenIdle|. BackgroundTracingManager::GetInstance()->WhenIdle( base::Bind(&DisableScenarioWhenIdle)); A snippet of code can be found below that shows why |config_| needs to be resetted to avoid multiple start/stop tracing. #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250574752 content::BackgroundTracingManagerImpl::SetActiveScenario() #7 0x561c347f221a content::BackgroundTracingManagerBrowserTest_NoWhitelistedArgsStripped_Test::RunTestOnMainThread() #8 0x561c35d391dd content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #9 0x561c33f88f0d _ZN4base8internal13FunctorTraitsIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #10 0x561c33f88e84 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJPS5_EEEvOT_DpOT0_ #11 0x561c33f88e35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #12 0x561c34164f9c _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE #13 0x561c33e2827d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #14 0x561c35fb418d content::ShellBrowserMainParts::PreMainMessageLoopRun() #15 0x7f924f65fb32 content::BrowserMainLoop::PreMainMessageLoopRun() #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250579062 content::BackgroundTracingManagerImpl::OnFinalizeComplete() #7 0x7f924f17f715 _ZN4base8internal13FunctorTraitsIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEvE6InvokeIS8_PS6_JbEEEvT_OT0_DpOT1_ #8 0x7f924f17f66f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEJPS8_bEEEvOT_DpOT0_ void BackgroundTracingManagerImpl::OnFinalizeComplete(bool success) { [...] if (!idle_callback_.is_null()) idle_callback_.Run(); bool is_allowed_begin = !delegate_ || (config_ && delegate_->IsAllowedToBeginBackgroundScenario( *config_.get(), requires_anonymized_data_)) [...] // NOTE: config_ must be empty to avoid starting tracing if (is_allowed_begin) { StartTracingIfConfigNeedsIt(); } else { AbortScenario(); } B=639706,795803 R=oysteine@chromium.org Change-Id: I5495b542615633c62a3451a75a668866b18592b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341134 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622024}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/87da937789ae..b8b3c9918f14 git log 87da937789ae..b8b3c9918f14 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 terelius@webrtc.org Clean up visibility and dependencies of RTC event log build targets. 2019-01-11 titovartem@webrtc.org Introduce stats calculator. 2019-01-11 nisse@webrtc.org Reland "Refactor and remove media_optimization::MediaOptimization." 2019-01-11 nisse@webrtc.org Delete VCMEncodedFrame methods Buffer and MutableBuffer Created with: gclient setdep -r src/third_party/webrtc@b8b3c9918f14 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If89d496accc140f066266748261d8b0f99e45eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1406948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622023}
-
Emily Stark authored
TBR=meacer@chromium.org Change-Id: I3dd17ffa9f60e4efc07bee69d92ef7f5783097e7 Reviewed-on: https://chromium-review.googlesource.com/c/1407109 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#622022}
-
Dave Tapuska authored
SafeCast a 64 bit integer down to a wtf_size_t BUG=879657 Change-Id: I6d8b62a5d18f9ac11ee631f52cdbaf911c2cf597 Reviewed-on: https://chromium-review.googlesource.com/c/1406934Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622021}
-
Veranika Liaukevich authored
Screenshot: http://screen/jx76uJdNQTc.png Bug: 911366 Change-Id: I7c0859ab21458389b486e16d5bb81a1ba1b83bad Reviewed-on: https://chromium-review.googlesource.com/c/1393459Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#622020}
-
Steven Bennetts authored
This also requires making components of source sets that depend on //chromeos/network: * //chromeos/geolocation * //chromeos/timezone For trivial include file renames: TBR=sky@chromium.org Bug: 862420 Change-Id: I5ce6004f4c5f1605e7ee3b2f8418e6c14de085de Reviewed-on: https://chromium-review.googlesource.com/c/1405872 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622019}
-
Adithya Srinivasan authored
Tbr: mlippautz@chromium.org No-Try: true Bug: 921038 Change-Id: I88d6ea58f70d17c0a7e2b5b10091211b7980a267 Reviewed-on: https://chromium-review.googlesource.com/c/1407108Reviewed-by:
-
Daniel Nicoara authored
VIZ doesn't support overlays yet, so need to disable it. is active. Bug: b/122666861 Test: Ran on Chromecast device and played video to verify overlay path Change-Id: I4aaaf0f391488b0afb9576a68c7efc39b65df00d Reviewed-on: https://chromium-review.googlesource.com/c/1405695Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#622017}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I88d19eba63cbd10c6881ef620b4bb6347019e156 Reviewed-on: https://chromium-review.googlesource.com/c/1406951Reviewed-by:
-
Abhijeet Kandalkar authored
This CL fixes signin_util_win away from talking to IdentityManagerFactory in favor of talking to IdentityManagerFactory. Bug: 920229 Change-Id: I99eb707ed5ce9ad624d10ff05fd1be2f758caba2 Reviewed-on: https://chromium-review.googlesource.com/c/1406788Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#622015}
-
Vincent Boisselle authored
Bug: 920745 Change-Id: I84f55f70e5de729810f293289ddc74cbf6515e86 Reviewed-on: https://chromium-review.googlesource.com/c/1405696 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#622014}
-
Josh Karlin authored
What: Replace kAdsFeature with kAdTagging Why: kAdsFeature was used to enable/disable ads metrics recording. Since Ads Metrics now rely upon AdTagging to function and there isn't a compelling need to enable/disable metrics independently of that, we can remove it and just check for AdTagging. Bug: 920594 Change-Id: Ic36b4f2317e8a46d1187c38103314835dff141d4 Reviewed-on: https://chromium-review.googlesource.com/c/1404747 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#622013}
-
Alex Clarke authored
This time with the right patchset... Previous patch https://chromium-review.googlesource.com/c/chromium/src/+/1403130/ Change-Id: I96e557b6a1c2080abdaa825fb4f6a2bf96c0fbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1406246 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#622012}
-
Pavel Shmakov authored
The changes in https://crrev.com/c/1349653 included adding SINGLE_TOP and CLEAR_TOP flags to intents launching CCTs, and so activities above a CCT, should it be present in current task, were always getting destroyed. That shouldn't happen in cases when a client wants to launch a new CCT and to that end provides a different session token. An ideal solution would be to replace FLAG_ACTIVITY_CLEAR_TOP with FLAG_ACTIVITY_PREVIOUS_IS_TOP (which would prevent ChromeLauncherActivity getting in the way), and leave adding FLAG_ACTIVITY_CLEAR_TOP to the client. Unfortunately, FLAG_ACTIVITY_PREVIOUS_IS_TOP seems to be broken (https://b.corp.google.com/issues/122582732). The solution I propose is to keep a static map taskId -> session and use it to check if there is a CCT with matching session in the task prior to adding SINGLE_TOP and CLEAR_TOP flags. The mappings are not cleared in CCT's onStop or onDestroy to account for cases when the task is brought back to foreground by a new intent. They are only cleared on service connection termination. This should take care of this bug, however there could be potentially other side effects from the new behavior for existing clients (although, most likely they would be due to misuse of APIs). For that reason, this CL also restricts the new behavior to TWAs. For M73 we plan to remove this restriction. Bug: 918857 Change-Id: I5af4f2d9d3f9ae1bc57a9b21e5760b96575aa548 Reviewed-on: https://chromium-review.googlesource.com/c/1403119 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#622011}
-
Sebastien Lalancette authored
This change updates Autocomplete code to log the number of days since an Autocomplete entry was last used when a user selects it. To do so, the data model retrieved from autofill_table had to change from a vector of strings (values) to a vector of AutofillEntry. Since we want to send only what the UI needs to the UI, then we needed to cache the last batch of AutofillEntries sent so that we can map back the user's selection and log our metric. The cache lives in AutocompleteHistoryManager and is keyed by value. Updated and added unit tests, tested manually and verified the logs at chrome://histograms Bug: 907902 Change-Id: Iab7841c3e20193891c79f3ead5819959d6632399 Reviewed-on: https://chromium-review.googlesource.com/c/1388712 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622010}
-
Adithya Srinivasan authored
Tbr: erikchen@chromium.org, ajwong@chromium.org No-Try: true Bug: 921036 Change-Id: Icdad4b7b19e1cec4cdb7c3565092e2fbea99d7a0 Reviewed-on: https://chromium-review.googlesource.com/c/1406937Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit 9d7f9214. Reason for revert: Missing test expectations added Original change's description: > Revert "Implement basic Left/Right visual caret movement with bidi caret affinity" > > This reverts commit d7d46e61. > > Reason for revert: This patch may be the cause of failing tests: > * virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_04_rtl_multi_line.html > * virtual/bidi-caret-affinity/editing/selection/modify_move/move_right_word_02_ltr_multi_line.html > * virtual/bidi-caret-affinity/editing/selection/move-bidi-isolate.html > on Mac 10.11. See bug for more details. > > Bug: 920878 > > Original change's description: > > Implement basic Left/Right visual caret movement with bidi caret affinity > > > > Design doc: http://bit.ly/2QVAwGq > > > > This patch: > > > > 1. Introduces a new structure NGCaretNavigator to index the bidi > > information of the text_content of a block. The structure is > > built together with NGOffsetMapping. > > > > 2. With NGCaretNavigator, we can test bidi boundary in VisiblePosition > > canonicalization more directly. > > > > 3. With NGCaretNavigator, left/right visual movements on text_content > > are implemented in a straightforward manner. This patch implements > > only the basics: one line of plain text. However, the most complicated > > part of the legacy implementation, namely *bidi and whitespace > > collapsing*, have already been naturally handled. > > > > 4. SelectionModifierCharacter adds a new branch where bidi caret > > affinity is enabled, and uses NGOffsetMapping to convert input/output > > between DOM and NGCaretNavigator. > > > > Note that the implementation works on both legacy and NG layout. > > > > Bug: 894651 > > Change-Id: I806ce23a97b2dfd977d6eecfd224c812319e6a7e > > Reviewed-on: https://chromium-review.googlesource.com/c/1377618 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#621807} > > TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > Change-Id: I7146445c16b13d3cdaf12e2f88b78353b7f0d10a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 894651 > Reviewed-on: https://chromium-review.googlesource.com/c/1405116 > Reviewed-by: Patti <patricialor@chromium.org> > Commit-Queue: Patti <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621881} TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,patricialor@chromium.org Change-Id: I1cd674cf836d057bf8188b3a7c051e2c51a78bb8 Bug: 920878, 894651 Reviewed-on: https://chromium-review.googlesource.com/c/1406930 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#622008}
-
Roman Sorokin [CET] authored
This reverts commit 377dadb7. Reason for revert: breaks tests on windows (see https://bugs.chromium.org/p/chromium/issues/detail?id=920997) Original change's description: > Reland "[DevTools] Prevent JSONReader::Read errors from invalid unicode points" > > Relanding http://crrev.com/c/1399538 > Reverted by http://crrev.com/c/1404161 > > The original test didn't wait for Network.enable to finish before making > a request and expected to see network events, which did work... when > network service wasn't turned on. With network service enabled, > Network.enable takes longer and needs to be awaited for. > > browser_tests now passes with --enable-features=NetworkService > > Bug: 824174, 920539, 920544 > Change-Id: I3458b08ccce34ec6df6d7c0c65b5b5225ab3debc > Reviewed-on: https://chromium-review.googlesource.com/c/1405848 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621741} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,jarhar@chromium.org Change-Id: I2bea5199e19b0eb93394a241a9ec7833848b6c00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824174, 920539, 920544 Reviewed-on: https://chromium-review.googlesource.com/c/1406685Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/18af9a5a50c6..92ee1f9f3032 git log 18af9a5a50c6..92ee1f9f3032 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 jmadill@chromium.org Suppress InterleavedAttributeDataBenchmark on GL. Created with: gclient setdep -r src/third_party/angle@92ee1f9f3032 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921004 TBR=ynovikov@chromium.org Change-Id: I8f6bf67d11be0715c4c4a45e9a9c1c71a3baee2f Reviewed-on: https://chromium-review.googlesource.com/c/1406949Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1dbc85c8..a663e359 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65b76bd60a581f9f7752b1b41f376eac016bd7bc Reviewed-on: https://chromium-review.googlesource.com/c/1406577Reviewed-by:
-
Roman Sorokin authored
Disabled on windows due to flakiness (see bug) TBR=mamir@chromium.org Bug: 919877 Change-Id: I05bd42b71432ae3bd79b2bab8e74d879703aaade Reviewed-on: https://chromium-review.googlesource.com/c/1406676Reviewed-by:
-
Georg Neis authored
The use of a global variable as loop counter in these tests is unnecessary (perhaps accidental), and a pending change in how V8 optimizes global loads and stores causes one of the tests (fast/js/try-catch-crash.html) to time out in an msan build. Bug: chromium:917714 Change-Id: Iadd53929873f4a7b6b1d4683aa3081ee2d0f1d86 Reviewed-on: https://chromium-review.googlesource.com/c/1406727Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#622003}
-
François Beaufort authored
This CL makes sure page visibility events are fired even if a video is playing in Picture-in-Picture. This doesn't affect "disable rendering" optimizations as those are turned off already if media player is in Picture-in-Picture. https://github.com/WICG/picture-in-picture/issues/110 Bug: 917303 Change-Id: If3788ce89f55e22af59bc69a6a52cd2a3309c518 Reviewed-on: https://chromium-review.googlesource.com/c/1400803 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#622002}
-
Eric Stevenson authored
The script will generate a regular report for the build and a diff report (using a .size file from the latest build of the previous branch). Example usage: tools/binary_size/libsupersize/generate_official_build_report.py \ --version 73.0.3666.0 \ --size-path Monochrome.apk.size \ --gs-size-url gs://some_bucket_path \ --gs-size-path arm/Monochrome.apk.size \ --arch arm \ --platform android The script takes less than a minute to run locally. Bug: 919213 Change-Id: Ie52df4dc52634488e24d48ecf306c343a45fbc7b Reviewed-on: https://chromium-review.googlesource.com/c/1405174 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: -
Tim Volodine authored
This reverts commit 0b15d057. Reason for revert: broke many bots (go/clankbot) and also official build (see e.g. crbug.com/920520) one related patch was already reverted, for reference: https://chromium-review.googlesource.com/c/chromium/src/+/1404736 Original change's description: > Track when the auto-fetch in progress notification should be shown > > Watch for navigations and request coordinator changes to determine when > the in-progress notification should be shown. > > A follow-up CL will introduce an instrumentation test to supplement the > unit tests here. > > Bug: 883486 > > Change-Id: Ib3fe1eececab45eafbeca56fe05425919ba43f04 > Reviewed-on: https://chromium-review.googlesource.com/c/1381233 > Reviewed-by: Peter Williamson <petewil@chromium.org> > Commit-Queue: Dan H <harringtond@google.com> > Cr-Commit-Position: refs/heads/master@{#621849} TBR=petewil@chromium.org,harringtond@google.com Change-Id: I7bf6944094512239bb97dc20f295bcd654792d8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883486 Reviewed-on: https://chromium-review.googlesource.com/c/1406997Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622000}
-
