GitLab

BUG=333869

Review URL: https://codereview.chromium.org/134333008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245332 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245331 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12612: (dyen) Added armv7l to list of known architectures.
r12613: (jvoung) Filter out -fasynchronous-unwind-tables in callingconv test, too.
r12614: (dyen) Modifies platform_tools.py to be compatible with python 2.6
r12616: (jfb) Update TOOL_REVISIONS for PNaCl r12601->r12611
r12617: (mcgrathr) Update tools_rev to r12615
r12619: (dschuff) Factor toolchain_build_pnacl.py for canadian cross

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/140653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245329 0039d316-1c4b-4281-b951-d872f2087c98

> Set the svn:ignore property on chrome/third_party/chromevox.
> 
> BUG=330461
> 
> 




git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245328 0039d316-1c4b-4281-b951-d872f2087c98

When run with --nacl, the script should now install everything
that is needed by NaCl bots.

R=bradnelson@google.com

Review URL: https://codereview.chromium.org/138063012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245327 0039d316-1c4b-4281-b951-d872f2087c98

This CL provides just enough functionality so that
PrototypeFakeServerTest will pass.

BUG=323265

Review URL: https://codereview.chromium.org/115243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245326 0039d316-1c4b-4281-b951-d872f2087c98

* Install URL protocol handler for chrome-extension:// and chrome-extension-resource://
* Allow extension urls to be handled.
* Register extensions with IO thread extension InfoMap.
* Bonus: app_shell no longer crashes on startup.

With this change an extension background page can print "Hello world" using console.log().

BUG=288226,332982
TEST=browser_tests. Also run app_shell --app=/path/to/extension with an extension with background.js. The JavaScript executes and console.log() works.

Review URL: https://codereview.chromium.org/136453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245325 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=171404

Review URL: https://codereview.chromium.org/140793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245322 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dstockwell

Review URL: https://codereview.chromium.org/137063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245321 0039d316-1c4b-4281-b951-d872f2087c98

Periodic use of this script will show places where the OWNERS files
have become inconsistent.  This poses a problem for CL authors when
the reviewer they have selected doesn't cover all message files, so
they would have to add another.

I've stopped short of adding code to correct the files, this would
make a nice follow-up.

R=jschuh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/138033013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245320 0039d316-1c4b-4281-b951-d872f2087c98

They have been upstreamed and rolled, so they are now redundant.

TBR=hayato@chromium.org
BUG=

Review URL: https://codereview.chromium.org/132873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326154

Review URL: https://codereview.chromium.org/100513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335280
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/132883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/68533015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332506

Review URL: https://codereview.chromium.org/140203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245314 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes a number of functions from the sync debugging framework
in order to prepare for some upcoming changes to sync debugging (due to
328606).

This CL removes the following functions:
- GetRootNodeDetails
- GetNodeSummaries
- GetNodeDetails
- GetChildNodeIds

It also adds the function 'getListOfKnownTypes' to help replace some old
functionality required by the 'data' tab and to fix issue 329013.
Rather than having that tab fetch a list of children of the root node,
it now asks for a list of all known data types.  This is a better
solution, since it does not require sync to be fully initialized in
order to properly populate the set of checkboxes.

The most significant user of the removed functionality is the node
browser.  Its javascript code has been modified in order to transition
it to relying on the getAllNodes function.  Rather than fetching node
data on demand by a series of asynchronous callbacks, the tab now
fetches a list of all known sync nodes at once.  This has the advantage
of providing a more consistent (though more stale) snapshot.  This CL
adds a refresh button to the node browser tab in order to give users
some control over its staleness.

This change had some minor side-effects.  The node browser now relies on
items' string-based IDs rather than their metahandles when determining
the nodes' hierarchy.  We've also had to add a 'positionIndex' field to
the output of getAllNodes to make it easier for the node browser to sort
its entries.  In part to make it easier to fetch this field, most of the
code associated with getAllNodes has been moved into the
syncable::Directory.

In addition to all these changes, this CL adds some webui tests to help
prevent regressions in about:sync functionality.  For now, they only
cover the node browser.  More tests will be added in future CLs.

BUG=110517,329013,328606

Review URL: https://codereview.chromium.org/134443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245313 0039d316-1c4b-4281-b951-d872f2087c98

1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197

Review URL: https://codereview.chromium.org/109483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245312 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Causes crashes on Android on loading a web page, more details in https://code.google.com/p/chromium/issues/detail?id=335258 

Original issue's description:
> Enable OrientationEvent only for android.
> 
> BUG=181136, 331337
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245210

TBR=darin@chromium.org,mahesh.kk@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=181136, 331337

Review URL: https://codereview.chromium.org/130053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245310 0039d316-1c4b-4281-b951-d872f2087c98

Changes in events can affect a number of different modules, so make sure
the unit-tests for at least ash, aura, events, keyboard, and views are
tried on the appropriate bots (linux_aura, win, win_rel, linux_chromeos,
linux_chromeos_asan).

BUG=318879
R=stip@chromium.org

Review URL: https://codereview.chromium.org/136853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245309 0039d316-1c4b-4281-b951-d872f2087c98

After this change, DevToolsWindow waits for frontend to decide
on dock side, and only then shows it either docked or undocked.

This also cleans up DevToolsWindow public API, so clients don't use
test function, and test clients are explicit with their docking expectations.

Note: follow up patch on frontend side is require to switch
from SetDockSide to SetIsDocked call.

BUG=318751

Review URL: https://codereview.chromium.org/108213012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245308 0039d316-1c4b-4281-b951-d872f2087c98

This code is not chrome_elf-specific, rather, chrome_elf
is the only current user of it. Move the manifest building
logic to a more generic location.

BUG=324863

Review URL: https://codereview.chromium.org/137373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245307 0039d316-1c4b-4281-b951-d872f2087c98

This was used by the make generator. The ninja generator uses ninja's built-in
"pools" feature for limiting ld parallelism, so this is no longer needed.

BUG=330631
R=torne@chromium.org

Review URL: https://codereview.chromium.org/139263010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245304 0039d316-1c4b-4281-b951-d872f2087c98

These things are exposed through the embedder API (and/or to be used by
the embedder).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/137063010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245303 0039d316-1c4b-4281-b951-d872f2087c98

Added PrivetJSONOperation to call /privet/storage/list.

BUG=332182

Review URL: https://codereview.chromium.org/138983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245302 0039d316-1c4b-4281-b951-d872f2087c98

This changes our unit from percentage-busy to ms-per-frame.
This should be less noisy to stalls where we are idle not
producing frames.

NOTRY=true
BUG=334063

No-try since this obviously doesn't break net-unittests.

Review URL: https://codereview.chromium.org/138923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335051
TEST=open create profile dialog, observe spacing above create button.

Review URL: https://codereview.chromium.org/140863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245300 0039d316-1c4b-4281-b951-d872f2087c98

Adding the content_gl_tests unit tests to the
gtest suite list supported by test_runner.py for Android platform.

BUG=none

R=bulach

TEST= Command to execute the content_gl_tests on Android:
path/to/build/android/test_runner.py gtest -s content_gl_tests <--gtest_filter=[TestFilter]>

Review URL: https://codereview.chromium.org/140623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245299 0039d316-1c4b-4281-b951-d872f2087c98

Avoid unneccessary copy of structures gfx::SizeF
by passing them by const ref rather than value.

Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.

Pass by value creates unneccessary overhead which should be avoided.

BUG=159273

R=danakj, enne

Review URL: https://codereview.chromium.org/139173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245297 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245296 0039d316-1c4b-4281-b951-d872f2087c98

The status code is consistent with other methods like Files.delete,
so we should better align to it. This CL fixes the return code
assumption in DriveAppRegistry that previously expected HTTP_SUCCESS.

BUG=324166

Review URL: https://codereview.chromium.org/140533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/140383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245294 0039d316-1c4b-4281-b951-d872f2087c98

Ensure there is a) a focus ring around the entirety of the account
chooser, not just the image, if Chrome is running on 10.6. And b) use
the SDK's focus ring drawing from 10.7 on instead. (Before this CL,
10.7+ systems get _two_ focus rings for ImageButtonCells.)

BUG=308192
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/140353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326250
R=mkearney@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/134533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240309
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/140513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245291 0039d316-1c4b-4281-b951-d872f2087c98

- make string translations work
- break libaddressinput standalone build

BUG=333405

Review URL: https://codereview.chromium.org/134903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245290 0039d316-1c4b-4281-b951-d872f2087c98

Relanding this as this caused layout tests failures on Win7 due to the call to ShowScrollBars being incorrectly deleted
in the HWNDMessageHandler::OnSize for a regular WM_SIZE. Added that call back. The rest of the CL is exactly the same as
the previous one. TBR'ing sky.

Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows.

This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST
codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window
which is the only window which should be receive mousewheel messages.

I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that
would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the
scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message.
For normal sizing operations we continue to do this in WM_SIZE as before.

From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well

BUG=334454, 334541
TBR=sky

Review URL: https://codereview.chromium.org/133273020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332183

Review URL: https://codereview.chromium.org/140323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245288 0039d316-1c4b-4281-b951-d872f2087c98

There's already a robust check in page_runner. The extra check is messing up record_wpr.


BUG=333609
TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/top_10_000.wpr; tools/perf/record_wpr page_sets/top_10.json; mv ~/.boto.bak ~/.boto

Review URL: https://codereview.chromium.org/140293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245287 0039d316-1c4b-4281-b951-d872f2087c98

Implement a test fixture in DeviceMotionEventPumpTest to consistently
test DeviceMotionEventPump. The new implementation also avoids calls
to PlatformThread::Sleep() since it is generally undesirable in tests.

BUG=333928

Review URL: https://codereview.chromium.org/134073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245286 0039d316-1c4b-4281-b951-d872f2087c98