- 14 Mar, 2011 40 commits
-
-
cmarrin@apple.com authored
Reviewed by Adam Roben. REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong https://bugs.webkit.org/show_bug.cgi?id=52845 The lastCommitTime() value in CACFLayerTreeHost was returning as the time the render previous to this one happened. That often made it seem like animations started more in the past than they did, breaking many animations. The startAnimations() call actually fires from a CACF callback after all the WebKit content has been rendered. So sending currentTime as the start time to the animations is close enough for proper synchronization. * platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted): git-svn-id: svn://svn.chromium.org/blink/trunk@81054 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Tony Chang. Selection uses first mousemove's localRect instead of that of mousedown https://bugs.webkit.org/show_bug.cgi?id=56213 Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent using the mouse coordinates of the mousedown event that started the drag. Test: editing/selection/drag-select-rapidly.html * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): 2011-03-11 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Tony Chang. Selection uses first mousemove's localRect instead of that of mousedown https://bugs.webkit.org/show_bug.cgi?id=56213 Added a test to ensure the selection start is computed using the mouse coordinates passed down to the corresponding mousedown event instead of that of the first mousemove event. The test is co-authored by Evan Martin. * editing/selection/anchor-focus2-expected.txt: Editing delegate changes. * editing/selection/anchor-focus3-expected.txt: Ditto. * editing/selection/drag-select-rapidly-expected.txt: Added. * editing/selection/drag-select-rapidly.html: Added. * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text. * platform/mac/editing/selection/fake-drag-expected.txt: Ditto. * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81053 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
except for the typical minor font differences. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81052 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
http://webkit.org/b/56304mrowe@apple.com authored
Reviewed by Oliver Hunt. Source/JavaScriptCore: * API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if the class definition contains duplicates. This also removes what look to be leaks of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr which retains / releases the instances at the appropriate time, so explicitly calling ref is not necessary. Tools: * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): Remove duplicate entries. git-svn-id: svn://svn.chromium.org/blink/trunk@81051 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
Reviewed by Timothy Hatcher. * Configurations/Base.xcconfig: Disable the generation of debugging symbols when building the Debug configuration on Leopard. This should cut the size of the object files that the linker needs to process by over 85%. This will hopefully allow them to fit in to the 32-bit address space of the Leopard linker. git-svn-id: svn://svn.chromium.org/blink/trunk@81050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Beth Dakin. Add support for relative positioning to table cells. Back out the code that hacked around the lack of support for offsetLeft, and add new tests to demonstrate that relative positioning works. Source/WebCore: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): * rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent): * rendering/RenderObject.h: (WebCore::RenderObject::isRelPositioned): * rendering/RenderTableCell.h: * rendering/style/RenderStyle.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: LayoutTests: * fast/table/relative-position-containment.html: Added. * fast/table/relative-position-offsets.html: Added. * fast/table/relative-position-stacking.html: Added. * platform/mac/fast/table/overflowHidden-expected.txt: * platform/mac/fast/table/relative-position-containment-expected.checksum: Added. * platform/mac/fast/table/relative-position-containment-expected.png: Added. * platform/mac/fast/table/relative-position-containment-expected.txt: Added. * platform/mac/fast/table/relative-position-offsets-expected.checksum: Added. * platform/mac/fast/table/relative-position-offsets-expected.png: Added. * platform/mac/fast/table/relative-position-offsets-expected.txt: Added. * platform/mac/fast/table/relative-position-stacking-expected.checksum: Added. * platform/mac/fast/table/relative-position-stacking-expected.png: Added. * platform/mac/fast/table/relative-position-stacking-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://bugs.webkit.org/show_bug.cgi?id=56230hyatt@apple.com authored
layer, since first layouts and printing mess up otherwise. Reviewed by Beth Dakin. * page/FrameView.cpp: (WebCore::FrameView::layout): git-svn-id: svn://svn.chromium.org/blink/trunk@81048 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
+ Add more tests that belong there. + Sort the tests that are there. + Add PASS to the lines that are there since these tests are known to pass and a passing result for them shouldn't cause a test run to go orange. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81047 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alice.liu@apple.com authored
Reviewed by Dan Bernstein. * DumpRenderTree/mac/PerlSupport/Makefile: Add whitespace when joining "-arch" with the architectures passed in as arguments. git-svn-id: svn://svn.chromium.org/blink/trunk@81046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow and limited that overflow only to content that the layer painted. Reviewed by Simon Fraser. Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with the other ports. Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer. I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch), but the behavior should be the same. No new tests, since this is untestable on ports that invalidate on a resize. * page/FrameView.cpp: (WebCore::FrameView::layout): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleDidChange): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::removeOnlyThisLayer): * rendering/RenderLayer.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81045 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
Also, added yet more tests to the linux debug crash sweeping through the layout tests. * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-linux/fast/html/details-open1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open1-expected.png: Added. * platform/chromium-linux/fast/html/details-open2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open2-expected.png: Added. * platform/chromium-linux/fast/html/details-open3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open3-expected.png: Added. * platform/chromium-linux/fast/html/details-open4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open4-expected.png: Added. * platform/chromium-linux/fast/html/details-open5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open5-expected.png: Added. * platform/chromium-linux/fast/html/details-open6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open6-expected.png: Added. * platform/chromium-linux/fast/html/details-position-expected.checksum: Added. * platform/chromium-linux/fast/html/details-position-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added. * platform/chromium-mac/fast/html/details-open1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open1-expected.png: Added. * platform/chromium-mac/fast/html/details-open1-expected.txt: Added. * platform/chromium-mac/fast/html/details-open2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open2-expected.png: Added. * platform/chromium-mac/fast/html/details-open2-expected.txt: Added. * platform/chromium-mac/fast/html/details-open3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open3-expected.png: Added. * platform/chromium-mac/fast/html/details-open3-expected.txt: Added. * platform/chromium-mac/fast/html/details-open4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open4-expected.png: Added. * platform/chromium-mac/fast/html/details-open4-expected.txt: Added. * platform/chromium-mac/fast/html/details-open5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open5-expected.png: Added. * platform/chromium-mac/fast/html/details-open5-expected.txt: Added. * platform/chromium-mac/fast/html/details-open6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open6-expected.png: Added. * platform/chromium-mac/fast/html/details-open6-expected.txt: Added. * platform/chromium-mac/fast/html/details-position-expected.checksum: Added. * platform/chromium-mac/fast/html/details-position-expected.png: Added. * platform/chromium-mac/fast/html/details-position-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added. * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added. * platform/chromium-win/fast/html/details-open1-expected.checksum: Added. * platform/chromium-win/fast/html/details-open1-expected.png: Added. * platform/chromium-win/fast/html/details-open1-expected.txt: Added. * platform/chromium-win/fast/html/details-open2-expected.checksum: Added. * platform/chromium-win/fast/html/details-open2-expected.png: Added. * platform/chromium-win/fast/html/details-open2-expected.txt: Added. * platform/chromium-win/fast/html/details-open3-expected.checksum: Added. * platform/chromium-win/fast/html/details-open3-expected.png: Added. * platform/chromium-win/fast/html/details-open3-expected.txt: Added. * platform/chromium-win/fast/html/details-open4-expected.checksum: Added. * platform/chromium-win/fast/html/details-open4-expected.png: Added. * platform/chromium-win/fast/html/details-open4-expected.txt: Added. * platform/chromium-win/fast/html/details-open5-expected.checksum: Added. * platform/chromium-win/fast/html/details-open5-expected.png: Added. * platform/chromium-win/fast/html/details-open5-expected.txt: Added. * platform/chromium-win/fast/html/details-open6-expected.checksum: Added. * platform/chromium-win/fast/html/details-open6-expected.png: Added. * platform/chromium-win/fast/html/details-open6-expected.txt: Added. * platform/chromium-win/fast/html/details-position-expected.checksum: Added. * platform/chromium-win/fast/html/details-position-expected.png: Added. * platform/chromium-win/fast/html/details-position-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added. * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@81043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dbates@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=55438 Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add when landing changeset 81041 <http://trac.webkit.org/changeset/81041>. * Scripts/build-webkit: git-svn-id: svn://svn.chromium.org/blink/trunk@81042 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dbates@webkit.org authored
Reviewed by David Kilzer. Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject() https://bugs.webkit.org/show_bug.cgi?id=55438 Separate out the EFL- and WinCE-specific logic from the port-independent logic in webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the CMake arguments for feature defines. * Scripts/build-webkit: - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments. - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit(). - Sorted forward declarations. - Initialize $makeArgs with the empty string so as to simplify its use in string operations; Modified call sites as needed. * Scripts/webkitdirs.pm: - Added cleanCMakeGeneratedProject() to clean a CMake build. - Added buildCMakeGeneratedProject() to build using generated build system. - Added buildCMakeProjectOrExit() which is a facade for building a CMake project. - Added generateBuildSystemFromCMakeProject() to generate the build system from a CMake project. - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit(). git-svn-id: svn://svn.chromium.org/blink/trunk@81041 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
oliver@apple.com authored
Reviewed by Gavin Barraclough. Ensure all values are correctly tagged in the registerfile https://bugs.webkit.org/show_bug.cgi?id=56214 This patch makes sure that all JSCell pointers written to the registerfile are correctly tagged as JSCells, and replaces raw int usage with the immediate representation. For performance, register pressure, and general saneness reasons I've added abstractions for reading and writing the tag and payload of integer registers directly for the JSVALUE64 encoding. * interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain): * jit/JIT.h: * jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): * jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader): * jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs): * jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): * jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor): * jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell): 2011-03-11 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. Ensure all values are correctly tagged in the registerfile https://bugs.webkit.org/show_bug.cgi?id=56214 Make sure everything builds still. * bridge/c/c_class.cpp: * bridge/c/c_runtime.cpp: * bridge/jni/JavaMethod.cpp: * plugins/PluginViewNone.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81040 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
luiz@webkit.org authored
* html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::defaultEventHandler): * rendering/RenderDetailsMarker.cpp: (WebCore::createDownArrowPath): (WebCore::createUpArrowPath): (WebCore::createLeftArrowPath): (WebCore::createRightArrowPath): git-svn-id: svn://svn.chromium.org/blink/trunk@81039 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
Reviewed by Eric Carlson. FullScreen: Handle entering full screen security restrictions https://bugs.webkit.org/show_bug.cgi?id=56264 * fullscreen/full-screen-css.html: Use runWithKeyDown. * fullscreen/full-screen-remove-ancestor.html: Ditto. * fullscreen/full-screen-remove.html: Ditto. * fullscreen/full-screen-request.html: Ditto. * fullscreen/full-screen-twice.html: Ditto. * fullscreen/full-screen-test.js: * fullscreen/full-screen-iframe-allowed-expected.txt: Added. * fullscreen/full-screen-iframe-allowed.html: Added. * fullscreen/full-screen-iframe-not-allowed-expected.txt: Added. * fullscreen/full-screen-iframe-not-allowed.html: Added. (runWithKeyDown): Added. Wraps the command in a keyDown/keyPress listener. * platform/mac-wk2/Skipped: Added new tests to skipped list. * platform/qt-wk2/Skipped: Ditto. 2011-03-13 Jer Noble <jer.noble@apple.com> FullScreen: Handle entering full screen security restrictions https://bugs.webkit.org/show_bug.cgi?id=56264 Tests: fullscreen/full-screen-iframe-allowed.html fullscreen/full-screen-iframe-not-allowed.html Disable full screen documents in the following conditions: 1) requesting element is in an iframe which does not have a webkitallowfullscreen attribute. 2) page is not processing a user gesture. * dom/Document.cpp: (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks to see if elements contained in IFRAMES are allowed to enter full screen. (WebCore::Document::webkitRequestFullScreenForElement): Checks if page is currently processing a user gesture. * dom/Document.h: * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr. * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::allowFullScreen): Added. * html/HTMLFrameElementBase.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81038 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=56303 Patch by Anton D'Auria <adauria@apple.com> on 2011-03-14 Reviewed by David Levin. Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor. * storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): git-svn-id: svn://svn.chromium.org/blink/trunk@81037 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
steveblock@google.com authored
Reviewed by Oliver Hunt. JavaMethod.cpp does not compile with V8 https://bugs.webkit.org/show_bug.cgi?id=56306 Moved the ScopeChain.h include to JavaStringJSC. No new tests, build fix only. * bridge/jni/JavaMethod.cpp: * bridge/jni/jsc/JavaStringJSC.h git-svn-id: svn://svn.chromium.org/blink/trunk@81036 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
luiz@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=51071 Reviewed by Dave Hyatt. Source/WebCore: Tests: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-mouse-click.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html http://www.w3.org/TR/html5/interactive-elements.html#the-details-element The main <summary> element is the first <summary> element of a <details> element. All other childs of the <details> element are rendered only if the attribute 'open' is set. Click event toggles the 'open' attribute. * html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::HTMLDetailsElement): (WebCore::HTMLDetailsElement::findMainSummary): (WebCore::HTMLDetailsElement::childrenChanged): (WebCore::HTMLDetailsElement::finishParsingChildren): (WebCore::HTMLDetailsElement::parseMappedAttribute): (WebCore::HTMLDetailsElement::childShouldCreateRenderer): (WebCore::HTMLDetailsElement::defaultEventHandler): * html/HTMLDetailsElement.h: (WebCore::HTMLDetailsElement::mainSummary): Method createRenderer added to class HTMLSummaryElement. * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createRenderer): * html/HTMLSummaryElement.h: The first <summary> element is positioned at the top of its <details> parent. The area occupied by this main <summary> element is the interactive area of the <details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer is created and added to the corresponding RenderDetails object. * rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::destroy): (WebCore::RenderDetails::summaryBlock): (WebCore::RenderDetails::contentBlock): (WebCore::RenderDetails::addChild): (WebCore::RenderDetails::removeChild): (WebCore::RenderDetails::setMarkerStyle): (WebCore::RenderDetails::styleDidChange): (WebCore::RenderDetails::getRenderPosition): (WebCore::RenderDetails::markerDestroyed): (WebCore::RenderDetails::summaryDestroyed): (WebCore::RenderDetails::moveSummaryToContents): (WebCore::RenderDetails::createSummaryStyle): (WebCore::RenderDetails::replaceMainSummary): (WebCore::RenderDetails::createDefaultSummary): (WebCore::RenderDetails::checkMainSummary): (WebCore::RenderDetails::layout): (WebCore::RenderDetails::isOpen): (WebCore::RenderDetails::getParentOfFirstLineBox): (WebCore::RenderDetails::firstNonMarkerChild): (WebCore::RenderDetails::updateMarkerLocation): * rendering/RenderDetails.h: (WebCore::RenderDetails::interactiveArea): (WebCore::RenderDetails::removeLeftoverAnonymousBlock): (WebCore::RenderDetails::createsAnonymousWrapper): (WebCore::RenderDetails::requiresForcedStyleRecalcPropagation): A marker is added to the main <summary> element to indicate the current value of the 'open' attribute of the <details> element. * rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): (WebCore::RenderDetailsMarker::destroy): (WebCore::RenderDetailsMarker::lineHeight): (WebCore::RenderDetailsMarker::baselinePosition): (WebCore::RenderDetailsMarker::computePreferredLogicalWidths): (WebCore::RenderDetailsMarker::layout): (WebCore::RenderDetailsMarker::getRelativeMarkerRect): (WebCore::RenderDetailsMarker::isOpen): (WebCore::createPath): (WebCore::createDownArrowPath): (WebCore::createUpArrowPath): (WebCore::createLeftArrowPath): (WebCore::createRightArrowPath): (WebCore::RenderDetailsMarker::orientation): (WebCore::RenderDetailsMarker::getCanonicalPath): (WebCore::RenderDetailsMarker::getPath): (WebCore::RenderDetailsMarker::paint): * rendering/RenderDetailsMarker.h: (WebCore::toRenderDetailsMarker): * rendering/RenderSummary.cpp: (WebCore::RenderSummary::RenderSummary): (WebCore::RenderSummary::destroy): (WebCore::RenderSummary::parentDetails): (WebCore::RenderSummary::styleDidChange): * rendering/RenderSummary.h: * rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): LayoutTests: * fast/html/details-add-summary-1-and-click.html: Added. * fast/html/details-add-summary-1.html: Added. * fast/html/details-add-summary-10-and-click.html: Added. * fast/html/details-add-summary-10.html: Added. * fast/html/details-add-summary-2-and-click.html: Added. * fast/html/details-add-summary-2.html: Added. * fast/html/details-add-summary-3-and-click.html: Added. * fast/html/details-add-summary-3.html: Added. * fast/html/details-add-summary-4-and-click.html: Added. * fast/html/details-add-summary-4.html: Added. * fast/html/details-add-summary-5-and-click.html: Added. * fast/html/details-add-summary-5.html: Added. * fast/html/details-add-summary-6-and-click.html: Added. * fast/html/details-add-summary-6.html: Added. * fast/html/details-add-summary-7-and-click.html: Added. * fast/html/details-add-summary-7.html: Added. * fast/html/details-add-summary-8-and-click.html: Added. * fast/html/details-add-summary-8.html: Added. * fast/html/details-add-summary-9-and-click.html: Added. * fast/html/details-add-summary-9.html: Added. * fast/html/details-mouse-click-expected.txt: Added. * fast/html/details-mouse-click.html: Added. * fast/html/details-no-summary1.html: Added. * fast/html/details-no-summary2.html: Added. * fast/html/details-no-summary3.html: Added. * fast/html/details-no-summary4.html: Added. * fast/html/details-open-javascript.html: Added. * fast/html/details-open1.html: Added. * fast/html/details-open2.html: Added. * fast/html/details-open3.html: Added. * fast/html/details-open4.html: Added. * fast/html/details-open5.html: Added. * fast/html/details-open6.html: Added. * fast/html/details-position.html: Added. * fast/html/details-remove-summary-1-and-click.html: Added. * fast/html/details-remove-summary-1.html: Added. * fast/html/details-remove-summary-2-and-click.html: Added. * fast/html/details-remove-summary-2.html: Added. * fast/html/details-remove-summary-3-and-click.html: Added. * fast/html/details-remove-summary-3.html: Added. * fast/html/details-remove-summary-4-and-click.html: Added. * fast/html/details-remove-summary-4.html: Added. * fast/html/details-remove-summary-5-and-click.html: Added. * fast/html/details-remove-summary-5.html: Added. * fast/html/details-remove-summary-6-and-click.html: Added. * fast/html/details-remove-summary-6.html: Added. * fast/html/details-writing-mode.html: Added. * platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-1-expected.txt: Added. * platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-10-expected.txt: Added. * platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-2-expected.txt: Added. * platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-3-expected.txt: Added. * platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-4-expected.txt: Added. * platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-5-expected.txt: Added. * platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-6-expected.txt: Added. * platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-7-expected.txt: Added. * platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-8-expected.txt: Added. * platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-9-expected.txt: Added. * platform/qt/fast/html/details-no-summary1-expected.txt: Added. * platform/qt/fast/html/details-no-summary2-expected.txt: Added. * platform/qt/fast/html/details-no-summary3-expected.txt: Added. * platform/qt/fast/html/details-no-summary4-expected.txt: Added. * platform/qt/fast/html/details-open-javascript-expected.txt: Added. * platform/qt/fast/html/details-open1-expected.txt: Added. * platform/qt/fast/html/details-open2-expected.txt: Added. * platform/qt/fast/html/details-open3-expected.txt: Added. * platform/qt/fast/html/details-open4-expected.txt: Added. * platform/qt/fast/html/details-open5-expected.txt: Added. * platform/qt/fast/html/details-open6-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-1-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-2-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-3-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-4-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-5-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-6-expected.txt: Added. * platform/qt/fast/html/details-writing-mode-expected.txt: Added. * platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81035 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson@apple.com authored
Clean up IconDatabaseBase header. Reviewed by Sam Weinig. -Get rid of the "PlatformString.h" include and replace it with a forward declaration. -Group methods by which are used in WebCore directly and which are used in WebKit ports. This'll make it easier to use in external frameworks (like WebKit2). * loader/icon/IconDatabase.h: * loader/icon/IconDatabaseBase.h: (WebCore::IconDatabaseBase::retainIconForPageURL): (WebCore::IconDatabaseBase::releaseIconForPageURL): (WebCore::IconDatabaseBase::iconForPageURL): (WebCore::IconDatabaseBase::setIconURLForPageURL): (WebCore::IconDatabaseBase::setIconDataForIconURL): (WebCore::IconDatabaseBase::iconDataKnownForIconURL): (WebCore::IconDatabaseBase::loadDecisionForIconURL): (WebCore::IconDatabaseBase::importIconURLForPageURL): (WebCore::IconDatabaseBase::importIconDataForIconURL): (WebCore::IconDatabaseBase::open): git-svn-id: svn://svn.chromium.org/blink/trunk@81034 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
weinig@apple.com authored
<rdar://problem/8988982> https://bugs.webkit.org/show_bug.cgi?id=54288 Reviewed by Darin Adler. * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::chooseIconForFiles): Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles. git-svn-id: svn://svn.chromium.org/blink/trunk@81032 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
podivilov@chromium.org authored
Unreviewed, rolling out r81026. http://trac.webkit.org/changeset/81026 https://bugs.webkit.org/show_bug.cgi?id=56313 Breaks gtk 64-bit tests (Requested by podivilov on #webkit). * inspector/debugger/xhr-breakpoints-expected.txt: Removed. * inspector/debugger/xhr-breakpoints.html: Removed. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r81026. http://trac.webkit.org/changeset/81026 https://bugs.webkit.org/show_bug.cgi?id=56313 Breaks gtk 64-bit tests (Requested by podivilov on #webkit). * inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear): * inspector/InspectorBrowserDebuggerAgent.h: * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._createXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.BreakpointManager.prototype._createXHRBreakpointId): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._serializeToJSON): (WebInspector.XHRBreakpointView): (WebInspector.XHRBreakpointView.prototype.compareTo): (WebInspector.XHRBreakpointView.prototype.populateEditElement): (WebInspector.XHRBreakpointView.prototype.populateLabelElement): (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): * inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.set attached): git-svn-id: svn://svn.chromium.org/blink/trunk@81030 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function. https://bugs.webkit.org/show_bug.cgi?id=56312 Test: inspector/utilities.html * inspector/front-end/utilities.js: 2011-03-14 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function. https://bugs.webkit.org/show_bug.cgi?id=56312 * inspector/utilities-expected.txt: Added. * inspector/utilities.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81029 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: re-implement xhr breakpoints. https://bugs.webkit.org/show_bug.cgi?id=56252 * inspector/debugger/xhr-breakpoints-expected.txt: Added. * inspector/debugger/xhr-breakpoints.html: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2011-03-12 Pavel Podivilov <podivilov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: re-implement xhr breakpoints. https://bugs.webkit.org/show_bug.cgi?id=56252 - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints - store xhr breakpoints in a separate setting - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane Test: inspector/debugger/xhr-breakpoints.html * inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear): * inspector/InspectorBrowserDebuggerAgent.h: * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged): * inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached): git-svn-id: svn://svn.chromium.org/blink/trunk@81026 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: move breakpoints restoring to debugger presentation model. https://bugs.webkit.org/show_bug.cgi?id=56123 * http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): 2011-03-14 Pavel Podivilov <podivilov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: move breakpoints restoring to debugger presentation model. https://bugs.webkit.org/show_bug.cgi?id=56123 DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since setBreakpoint/removeBreakpoint are now called from DPM only. * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled): (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.reset): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled): git-svn-id: svn://svn.chromium.org/blink/trunk@81025 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Unreviewed, rolling out r81015. http://trac.webkit.org/changeset/81015 https://bugs.webkit.org/show_bug.cgi?id=56308 A Similar patch landed in r76960 (Requested by philn-tp on #webkit). * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@81024 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: don't use innerText, use textContent instead. https://bugs.webkit.org/show_bug.cgi?id=56307 * inspector/elements/edit-dom-actions-expected.txt: * inspector/elements/edit-dom-actions.html: * inspector/extensions/extensions-audits-expected.txt: 2011-03-14 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: don't use innerText, use textContent instead. https://bugs.webkit.org/show_bug.cgi?id=56307 * inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.snippet): * inspector/front-end/ElementsTreeOutline.js: * inspector/front-end/GoToLineDialog.js: * inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): * inspector/front-end/ShortcutsHelp.js: (WebInspector.ShortcutsSection.prototype.renderSection): (WebInspector.ShortcutsSection.prototype._renderHeader): git-svn-id: svn://svn.chromium.org/blink/trunk@81023 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Text editor] Disable live-edit in favor of the text editor https://bugs.webkit.org/show_bug.cgi?id=56176 * inspector/front-end/Settings.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81022 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter https://bugs.webkit.org/show_bug.cgi?id=56095 * inspector/front-end/TextViewer.js: (WebInspector.TextViewer): git-svn-id: svn://svn.chromium.org/blink/trunk@81021 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: move breakpoints restoring after live edit to debugger presentation model. https://bugs.webkit.org/show_bug.cgi?id=56179 Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel. * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): git-svn-id: svn://svn.chromium.org/blink/trunk@81020 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Optimize backend-frontend data transfer volume for CSS styles https://bugs.webkit.org/show_bug.cgi?id=56111 * inspector/styles/styles-new-API.html: * inspector/styles/styles-source-offsets.html: 2011-03-10 Alexander Pavlov <apavlov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Optimize backend-frontend data transfer volume for CSS styles https://bugs.webkit.org/show_bug.cgi?id=56111 This change reduces the getStylesForNode() payload more than twice for BODY elements. * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties): * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.parsePayload): git-svn-id: svn://svn.chromium.org/blink/trunk@81019 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jknotten@chromium.org authored
Reviewed by Steve Block. Detach Geolocation from Frame when Page destroyed. https://bugs.webkit.org/show_bug.cgi?id=52877 Ensure that all geolocation permission requests are cancelled when the page is detached from its frame. Fix fast/dom/Geolocation/window-close-popup.html to ignore position error generated on watch when window is closed. * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added. * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added. * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added. * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt-wk2/Skipped: 2011-03-14 John Knottenbelt <jknotten@chromium.org> Reviewed by Steve Block. Detach Geolocation from Frame when Page destroyed. https://bugs.webkit.org/show_bug.cgi?id=52877 On Page destruction, any outstanding Geolocation permission requests should be cancelled, because the Geolocation can only access the client indirectly via m_frame->page(). Page destruction is signalled by a call to the Frame::pageDestroyed() method. This explictly calls DOMWindow::resetGeolocation which ultimately calls Geolocation::reset. Geolocation::reset() detaches from the GeolocationController, cancels requests, watches and single shots, and sets the permission state back to Unknown. Frame::pageDestroyed() is also called by FrameLoader even though the page is not destroyed. We should still cancel permission requests, because the GeolocationClient will become inaccessible to the Geolocation object after this call. Frame::transferChildFrameToNewDocument also indirectly calls Geolocation::reset when the frame is reparented between pages. Ideally we would like the Geolocation's activities to continue after reparenting, see bug https://bugs.webkit.org/show_bug.cgi?id=55577 Since GeolocationController is owned by Page, and all Geolocation objects will now unsubscribe from the GeolocationController on pageDetached(), we no longer need to call stopUpdating() from the GeolocationController's destructor. Instead we can simply assert that there should be no no observers. See related bug https://bugs.webkit.org/show_bug.cgi?id=52216 . Introduced new method 'numberOfPendingPermissionRequests' on GeolocationClientMock to count the number of outstanding pending permission requests. This provides a reusable implementation for client-based implementations of the LayoutTestController's numberOfPendingGeolocationPermissionRequests method. Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html * page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocation): * page/DOMWindow.h: * page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument): * page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating): * page/Geolocation.h: * page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController): * page/Navigator.cpp: (WebCore::Navigator::resetGeolocation): * page/Navigator.h: * platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests): * platform/mock/GeolocationClientMock.h: 2011-03-14 John Knottenbelt <jknotten@chromium.org> Reviewed by Steve Block. Detach Geolocation from Frame when Page destroyed. https://bugs.webkit.org/show_bug.cgi?id=52877 Add accessors to the WebGeolocationClientMock to allow the number of pending geolocation permission requests to be queried. * public/WebGeolocationClientMock.h: * src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests): 2011-03-14 John Knottenbelt <jknotten@chromium.org> Reviewed by Steve Block. Detach Geolocation from Frame when Page destroyed. https://bugs.webkit.org/show_bug.cgi?id=52877 Extend the layout test controller to expose the number of pending geolocation requests, so that we can test that the requests have been cancelled on page close. * DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests): * DumpRenderTree/mac/UIDelegate.h: * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests): git-svn-id: svn://svn.chromium.org/blink/trunk@81018 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: REGRESSION: Messed up with the tabIndex for text editor https://bugs.webkit.org/show_bug.cgi?id=56183 * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleKeyDown): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing): * inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): git-svn-id: svn://svn.chromium.org/blink/trunk@81017 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
alex@webkit.org authored
Rebaseline GTK+ tests after r80996. * platform/gtk/fast/text/soft-hyphen-2-expected.txt: * platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added. * platform/gtk/fast/text/soft-hyphen-4-expected.png: Added. * platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81016 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
crogers@google.com authored
Reviewed by Xan Lopez. Add all web audio auto-generated files to GTK make system https://bugs.webkit.org/show_bug.cgi?id=50497 No new tests since these are build-system tweaks. * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@81015 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jknotten@chromium.org authored
Reviewed by Steve Block. Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html https://bugs.webkit.org/show_bug.cgi?id=56202 By testing for geolocation watch errors, the test tests more than it should, which can cause a flaky result as demonstrated by https://bugs.webkit.org/show_bug.cgi?id=56126 . * fast/dom/Geolocation/resources/window-close-popup.html: * fast/dom/Geolocation/script-tests/window-close-crash.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81014 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
alex@webkit.org authored
Update more expectations after r80857. * platform/gtk/fast/layers/video-layer-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81013 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
since that is where the crash occurs. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81012 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Not reviewed: remove the flaky part of the new inspector test for now. * inspector/elements/edit-dom-actions-expected.txt: * inspector/elements/edit-dom-actions.html: git-svn-id: svn://svn.chromium.org/blink/trunk@81011 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
