- 07 Jun, 2019 40 commits
-
-
Edin Kadric authored
events that don't happen over the textfield (or the open menu). Bug: 953185 Change-Id: I84af8df0ea97da1e3bb1daebc823697523811e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638126 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#667111}
-
Caitlin Fischer authored
Bug: 953678 Change-Id: Ice4d2d54793b2d1029ee9143db45443808a87bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646712 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667110}
-
Vladislav Kuzkokov authored
Refactor to |base::OnceCallback| where possible. Bug: 968109 Change-Id: I55a23349b7b4769d3f68d34624237a2f2255c1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646015Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#667109}
-
Caitlin Fischer authored
Bug: 970351 Change-Id: Iff672776690e8f7cdc3e38e69e6e1a658489f801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642814Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#667108}
-
Daniel Bratell authored
ShaderTracking introduced a new namespace ui::gl which made the symbol "gl" resolve differently inside the ui namespace. That is why the style guide doesn't allow nested namespaces with the same name as top level namespaces. This caused problems in some jumbo builds where the compiler knew more about available namespaces. Bug: 969155 Change-Id: I6674c75c3ea06e78fcf7fbf063c688163e8044b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649501 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667107}
-
Daniel McArdle authored
Because the cookie parser is permissive, we can get in a situation where ToCookieLine() produces a string longer than the original input. When this exceeds the maximum cookie line length, that longer string cannot be parsed. This CL prevents the fuzzer from flagging these kinds of errors. Also changes the behavior of the fuzzer's mutator calling code. According to ParsedCookie's header file, only SetName/SetValue may be called on an invalid ParsedCookie (when IsValid returns false). Bug: 971385 Change-Id: I16a412b5204f8d5f19496ab7f158d992960c5bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647389Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#667106}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=eseckler@chromium.org Change-Id: I1ed5e83463d74f354c44cf15bf9ea64199304d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649507 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#667105}
-
Adithya Srinivasan authored
The RenderWidgetHostView for the predecessor is destroyed by the time the ack is sent. We can safely ignore this ack, as all pending touch events are already acked when the RWHV is destroyed (see TouchEventAckQueue::UpdateQueueAfterTargetDestroyed). Bug: 969714 Change-Id: I40d8a390b4f5b67115733850f8ad2ab7e6ecfa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645159Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#667104}
-
Antonio Gomes authored
As part of the process to Onion soup content/renderer/media/stream, this CL moves webaudio_media_stream_source.cc|h to blink. Note that for consistency with the other files whose header is exposed to Chromium in public/platform/modules/mediastream, the .cc file was place in renderer/platform/exported/mediastream/. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I57fb0e3357b91b584149ad36a5e6abeb74d469cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647197 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#667103}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c949ab0757a2..711b593e4b58 git log c949ab0757a2..711b593e4b58 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 philip.race@oracle.com * src/base/ftinit.c (FT_Set_Default_Properties): Fix crash. Created with: gclient setdep -r src/third_party/freetype/src@711b593e4b58 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com Change-Id: Ib9bb33dd3a4214e107145895b83eda0726056113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#667102}
-
Martin Robinson authored
When creating GPtrArrays for this interface, we should create them with a proper destruction function, so that the AtkObjects they contain are properly dereferenced. Also, when calling these functions internally, we should dereference the return value. Finally, we remove IdsToGPtrArray, because it is easy to misuse, for example, by passing in a GPtrArray that does not have a proper destruction function. This is an issue because IdsToGPtrArray added AtkObjects to the array and increased their reference count. Bug: 971966 Change-Id: I7b4358c0558b2e0489ab9fb7442f4d97d45e6951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649164 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#667101}
-
Martin Robinson authored
This change adjusts code to follow Chromium code style a bit more closely. 1. Static variables are grouped together more tightly. 2. A static methods are moved to the anonymous namespace, which makes it static in accordance with Chromium code style. 3. The runtime ATK table cell interface is moved to a struct and returned via base::Optional which helps to prevent accidental misuse. Bug: 945289 Change-Id: Id9fd76b7fd675df29366bcd4cddee00a00d2a37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649315Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22d2d256c5d9..81513b8eb5f0 Created with: gclient setdep -r src-internal@81513b8eb5f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: Ifd8970bfa93df5833af8c152e61c6c9070e7873f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667099}
-
Marc Treib authored
BridgeBuilder is constructed on the UI thread, but then basically lives on a background thread - in particular hands out WeakPtrs to itself, for use on the background thread. However, before this CL, its destruction used to happen on the UI thread again. This introduces a race between invalidating the WeakPtrs (on the UI thread) and using them (on the background thread). The fix is to destroy the BridgeBuilder on the background thread, via base::OnTaskRunnerDeleter. Bug: 970354, 971881, 906995 Change-Id: I2acbdb63de7d291f2703242691c30f48acda5907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649503 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#667098}
-
Carlos Caballero authored
Looks like BrowserTaskExecutor is being deleted while the IO thread is still running and thus capable of posting tasks. Also browser tests are like prod, we shouldn't manually shut down pools and schedulers. Bug: 963702 Change-Id: I1cb953acc4b495631fe269af9e06b94fbe5f2a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628748 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#667097}
-
Maksim Moskvitin authored
SyncEncryptionHandler was owned SyncManagerImpl. It involved plumbing of Encryptor and bootstrap keys during the initialization of SyncManagerImpl. Additionally, in follow-up changes we are going to introduce ModelTypeController logic in SyncEngineBackend and it would require backward plumbing of ModelTypeControllerDelegate, if we didn't change ownership. As a side change, UserShare now also owned by SyncEngineBackend, since SyncEncryptionHandlerImpl depends on it. Bug: 922900 Change-Id: Ie45f35963d0f07dc4702ca4e047bcdf8cd816160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648235 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9721f2b99ee600eb737b4d6c3284fd9ff7b4d566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649402Reviewed-by:
-
Maksim Moskvitin authored
In order to simplify initialization of SyncEncryptionHandler and its dependencies and upcoming transfer of SyncEncryptionHandler ownership, SynEncryptionHandler now exposes Cryptographer, NigoriHandler and KeystoreKeysHandler. USS implementation of SyncEncryptionHandler (aka NigoriSyncBridgeImpl) returns nullptrs as Cryptographer and NigoriHandler, since they are needed only in Directory world. Bug: 922900 Change-Id: I519d4f682ab990fdefadfdfedda713df14fea2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645779 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: I8624e0f1b0c3ff2d7479e6912fc11dbbfa14b5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646999Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Cr-Commit-Position: refs/heads/master@{#667093}
-
Maksim Moskvitin authored
Nigori's model type processor and worker work on the same sequence. It causes issues in case we use proxy processor between them, since code caused task posting can live in this sequence as well and wait for task completion right after posting (which would never happen, since we blocked current sequence with wait). Since all interactions between Nigori's processor and worker are now synchronous, we don't need to invalidate pointers owned by worker to avoid delayed tasks. This change needs rollback in case of moving Nigori model to UI thread. Bug: 922900, 943019 Change-Id: I6dda2d813d6bf67b446caf97791164f0ce86e029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635681 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f4eff3d09256..abea78f985f4 git log f4eff3d09256..abea78f985f4 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 perezju@chromium.org [Telemetry] Remove SkipValue Created with: gclient setdep -r src/third_party/catapult@abea78f985f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921616 TBR=oysteine@google.com Change-Id: I8ea4b54dfa0c86f2eca7a6c927e328877544935a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649450Reviewed-by:
-
Denis Kuznetsov authored
Main changes: * most of old screen contents now resides under entprise-enrollment DOM element. * oobe_screen_oauth_enrollment.js is now only responsible for intercation with C++ code. * Fixed previous error that enrollment was not avaliable on login screen (if device is restarted when OOBE is completed, but device is not owned yet). * accessing internal elements is done via this.$['id'] rather than $('id') * SAML notice padding is set on #oauth-enroll-step-contents element. Bug: 811556 Change-Id: I7324bc1de3b7a76cb5e5be63637275e24a435e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645359 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#667090}
-
Himanshu Jaju authored
Bug: 966030 Change-Id: Id6f24392364a376c9234d68ecc154e131a95002f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626592 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#667089}
-
Ramin Halavati authored
Tab.Count.Incognito and Tab.Count.Guest histograms are added to record the number of tabs opened in each incognito or guest mode window. Bug: 966747 Change-Id: Icce2ebed7c559f359df4e5b726eb6e6e753ff155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647854Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#667088}
-
Aaron Tagliaboschi authored
Freezes the Google QUIC Crypto handshake to the same constant string as the "freeze user agent" feature. Bug: 957187 Change-Id: I6cce0c562a4069e2b0f5708d8d890ee78f0d76b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596354 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#667087}
-
Mohamed Amir Yosef authored
Recent UMA metrics suggest that UpdateLoginSync() unexpectedly fails to update remote passwords in the password manager when processing remote passwords from the server. This CL is introducing a UMA metric to record the exact reason of failure. Bug: 971717, 902349 Change-Id: If32d8639041f8b03cbfa4ed144a6e4e62bed0186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648345Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#667086}
-
Etienne Pierre-doray authored
This is a reland of 79759021 Fix: define destroy function for FLSAlloc with WINAPI calling convention. Bot win_archive can now compile. Original change's description: > [TLS]: Add native tls perftests > > Change-Id: I08289ef9d8e1cb665393823495e292a9cbc236c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645220 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667051} Change-Id: If5fa5833f9df30a56cca634c2d9ce3373e6072ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649499Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#667085}
-
Adam Rice authored
This is a direct port of the JavaScript implementation of transferable streams, and is functionally equivalent. The majority of the implementation is in a new C++ file, transferable_streams.cc. ReadableStreamNative and WritableStreamNative now have working Serialize() and Deserialize() functions. The base classes have been modified to delegate to these. Test expectations have been updated since transferring streams now works. See https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit for the C++ port design doc, and https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit for the transferable streams design doc (mostly relevant to the V8 Extras implementation). BUG=902633 Change-Id: Id638ec16b40fe2c38ca6cccf7335be4cae2a4a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642755 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#667084}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b4697aa45589..7f47e1a27c39 git log b4697aa45589..7f47e1a27c39 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 fmayer@google.com Merge "Revert "Add Mapping / Frame / Callstack to InternedData."" 2019-06-07 fmayer@google.com Merge "Add Mapping / Frame / Callstack to InternedData." Created with: gclient setdep -r src/third_party/perfetto@7f47e1a27c39 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5877bca5492806c93263bb517ebe7ebda5b8eef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649451Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //device. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 970209 Change-Id: I7806dfa6ee829e27a4c25b19b0d4d3cc4e857d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648338 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667082}
-
Jan Wilken Dörrie authored
Bug: 957532 Change-Id: Ie2ac835dcfa316c0b309d4355e3847f9661f5a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649498Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667081}
-
Maksim Sisov authored
CreateShmBasedBuffer uses uint64_t type for the length parameter, but the definition uses size_t instead. This CL fixes this inconsistency. Bug: 578890 Change-Id: I3deac38340422d7c2098d226966312ad16eb831b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649156Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#667080}
-
Juan Antonio Navarro Perez authored
TBR=crouleau@chromium.org Bug: 971998 Change-Id: Ifc468d1bcecd09756c15b392d999f8f78499f3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649500Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#667079}
-
Askar Aitzhan authored
Treat topics with a prefix of cs- as public topics. Update AffiliatedInvalidationServiceProvider to spin up FCMInvalidationService on device level invalidations with custom sender_id. Add ability to switch between Ticl and FCM with a feature flag. Bug: 939039 Change-Id: If1f1c877f1074438b938a019a1fda6ae42a1228b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564119 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#667078}
-
Juan Antonio Navarro Perez authored
Most but not all stories have been disabled due to flakes. The few remaining ones still flake every now and then. Better to unconditionally disable all until the root cause is fixed. TBR=crouleau@chromium.org Bug: 971674 Bug: 964960 Change-Id: I23c0ffef7250b9140606d103feb2442ab9dab195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649160Reviewed-by:
-
Yannic Bonenberger authored
base::WriteClangCoverageProfile() must only be called if the buildflag |use_clang_coverage| is set to true. This CL enforced that by requiring that the corresponding header can only be included if CLANG_COVERAGE is enabled. Change-Id: I473694c05d8e27206d7f849e3ae4d83ba6fd5d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640397Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#667076}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //net. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 970209 Change-Id: I863a80f7f07bd95b09a1d225814a0420ca0a865a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648172 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
Expanded DeviceLoginScreenDefaultScreenMagnifierType and ScreenMagnifierType policies, removed unnecessary DockedMagnifierEnabled. Fixes policy escape using hotkeys. Bug: 953262 Change-Id: Id6c1e0814b914ec8824365023eb77dc0052dea98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611922 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1621135 this CL implements the same for PasswordStore::UpdateLogin() PasswordStore::UpdateLogin() can fail for various reasons. Before this CL: UpdateLogin() returns an empty change list in case of error. After this CL: UpdateLogin() accepts an optional output parameter to report the exact error. This is required for Sync machinery to understand the reason of failure. Follow up patches will consume this output parameter. Bug:971717 Change-Id: I73568cadb91e8a102181c1ffd871733a48242e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648225Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f23fb0caa01..22d2d256c5d9 Created with: gclient setdep -r src-internal@22d2d256c5d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I75a5cc6d9cc82deb2c9dc6ce7bdb86637e3af66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649459Reviewed-by:
-
