GitLab

Fix crash when creating a desktop shortcut for apps with missing icons (use the default app icon instead).

BUG=79282
TEST=See bug.


Review URL: http://codereview.chromium.org/7065037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6992067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83904
TEST=none


Review URL: http://codereview.chromium.org/7069016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86663 0039d316-1c4b-4281-b951-d872f2087c98

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/

For ppapi, use the CG bitmap copy only if Skia
is not used.

Otherwise, adjust the Mac-specific code to convert
the canvas to a CGContext as needed.

Also, add a CG-specific entry point for painting
so that the delegate can paint using a WebCanvas,
while the proxy paints with a CGContext.

This change adds a code path that will be enabled
in the future, but does not modify any
existing code, so there is no functional change.

BUG=79463
TEST=none

Review URL: http://codereview.chromium.org/6823081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83667
TEST=see bug

Review URL: http://codereview.chromium.org/7065046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86661 0039d316-1c4b-4281-b951-d872f2087c98

Print Preview: Add some debug logging so one can time when print preview operations starts/finishes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6979005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86660 0039d316-1c4b-4281-b951-d872f2087c98

This patch covers integrating the the WebUI based login with cros, so that when --dom-login is passed in on boot the WebUI login screen is used, keyboard comes up and the user can login.

I have refactored the WebUI login code to not use a subclass of the Browser class. I have removed the unneeded DOMBrowser* classes. This work was based off a combination of the BackgroundView and the TouchBrowserFrameView. If there is comments or variable names that betray this please let me know. I have endevoured to update the comments, but significant portions of code were pulled in.

Since both of the TouchBrowserFrameView and WebUILoginView have common code for having a a touch keyboard there is some refactoring to be done that will remove duplicated code between the two. This will be dealt with in a follow on CL.

The animation of the keyboard has not been included in this CL, mostly because I was having issues getting it to correctly size and this CL is pretty large already. This will be resolved in a follow on CL.

I am also converting from the use of DOM to WebUI at the moment, so some of the new code uses WebUI instead of DOM. I will be uploading a follow on CL that finishes this conversion.

This CL depends on http://gerrit.chromium.org/gerrit/706 and http://gerrit.chromium.org/gerrit/759 landing before it to work correctly.

It also depends on http://codereview.chromium.org/7014021/ to build.

Patch from Ryan Harrison <rharrison@chromium.org>

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6973029
Patch from Ryan Harrison <rharrison@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15368
TEST=Click on 'Show All Download' link in download panel or any downloaded file. Instead of multiple windows, the same window should get selected and become active.
Review URL: http://codereview.chromium.org/6969057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83908
TEST=none


Review URL: http://codereview.chromium.org/7031056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14964
TEST=Ctrl-o, Ctrl-r, Ctrl-b and ctrl-s should no longer work. ctrl-n, ctrl-w will continue to work.
Review URL: http://codereview.chromium.org/6990067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86656 0039d316-1c4b-4281-b951-d872f2087c98

Fixup order of elements in the ScriptableObject interface header. It's supposed to match the .CC file but had gotten seriously out of sync.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7065036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86655 0039d316-1c4b-4281-b951-d872f2087c98

if it doesn't find the requested key in the "Private" NSS database.

This fixes the ownership process because the ownership key is created
in the public database because that needs to happen before the TPM is
owned and available (and it's not really all that sensitive to begin
with).

BUG=chromium-os:15645
TEST=Built a new recovery image, wiped a device with it and verified
that I was able to sign in as a new user and add users and forget
networks.  It also showed me as the owner of the device.

Review URL: http://codereview.chromium.org/7066032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83899
TEST=none


Review URL: http://codereview.chromium.org/7031055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83891
TEST=none


Review URL: http://codereview.chromium.org/6987021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82590
TEST=Use instant to navigate to a page that is currently being prerendered. Observe it does not crash.


Review URL: http://codereview.chromium.org/7034043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86651 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST='Private networks' option should always show up in ChromeOS Networks menu.

Review URL: http://codereview.chromium.org/7031040

TBR=stevenjb@google.com
Review URL: http://codereview.chromium.org/7053015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86650 0039d316-1c4b-4281-b951-d872f2087c98

PathProvider on the Mac always returned the FILE_EXE for FILE_MODULE,
which isn't necessarily correct.

BUG=NONE
TEST=BUILD


Review URL: http://codereview.chromium.org/7019041

TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/6992071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86649 0039d316-1c4b-4281-b951-d872f2087c98

This speeds up the plugin significantly, making it much more usable in a debug build on mac.

BUG=NONE
TEST=BUILD


Review URL: http://codereview.chromium.org/6990068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86648 0039d316-1c4b-4281-b951-d872f2087c98

__file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`,
but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`.
And that confuses the xcode project generator, which will complain about hash
collisions if these paths are serialized in absolute form.

BUG=82230
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86551

Review URL: http://codereview.chromium.org/7066030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86647 0039d316-1c4b-4281-b951-d872f2087c98

And make them easier to read.

BUG=NONE
TEST=Run remoting.

Review URL: http://codereview.chromium.org/6992069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83755
TEST=Make sure the CompactNav bar shows up when changing hosts or scheme (e.g., from https to http) but doesn't show otherwise.

Review URL: http://codereview.chromium.org/7069002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86645 0039d316-1c4b-4281-b951-d872f2087c98

- added sample references to devtools pages

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6948003


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81179
TEST=none


Review URL: http://codereview.chromium.org/7068013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST='Private networks' option should always show up in ChromeOS Networks menu.

Review URL: http://codereview.chromium.org/7031040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83825
TEST=none


Review URL: http://codereview.chromium.org/7008004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86641 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82356
TEST=Run example plugin out-of-process, click on it.  Before this, it crashes the plugin.  After, behaves as expected.

Review URL: http://codereview.chromium.org/6966043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83551
TEST=See 83551. Ensure that popups in compact nav mode are stable and can be clicked on without crashing.
Review URL: http://codereview.chromium.org/6992031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=dragging onto dots works still, clicking on dots works still

Review URL: http://codereview.chromium.org/7067043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual (made sure it pixel-matched the old find bar, in both normal and GTK+ theme modes)

Review URL: http://codereview.chromium.org/6992017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/6966018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82824
TEST=doesn't say anything on startup

Review URL: http://codereview.chromium.org/7066029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86635 0039d316-1c4b-4281-b951-d872f2087c98

. Crash when deleting via context menu. This was happening because
  BookmarkMenuDelegate didn't keep a handle to the menu item it added
  the items to.
. If other bookmarks folder is empty it wouldn't show a menu item for
  (empty).
. Deleting the last item in the other folder would prematurely close
  the menu.
. Hit DCHECK when adding empty menu (long standing issue).

BUG=83746
TEST=from the wrench menu on windows right click a bookmark, delete
     it, and make sure you don't crash.
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7066034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86634 0039d316-1c4b-4281-b951-d872f2087c98

Added an easy hook for enabling / disabling the tests as needed.

BUG= none
TEST= none


Review URL: http://codereview.chromium.org/7067037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=58437
TEST=go to <https://2029.globalsign.com> and verify the EV status

Unit Test (This test has been DISABLED because it fails
when "./netunittests" is run, though it passes individually.):
"net_unittests --gtest_filter=X509CertificateTest.GlobalSignR3EVTest"

Review URL: http://codereview.chromium.org/7037031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86632 0039d316-1c4b-4281-b951-d872f2087c98

PathProvider on the Mac always returned the FILE_EXE for FILE_MODULE,
which isn't necessarily correct.

BUG=NONE
TEST=BUILD


Review URL: http://codereview.chromium.org/7019041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15687
TEST=Disable / reenable wifi and check animation

Review URL: http://codereview.chromium.org/7067030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86630 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86625 - This change implements a first pass in the effort to remove the dependency of PlatformDevice within Chrome.  The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.

A new set of helper functions is provided for the PlatformDevice entry points.  Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData.  The new helper functions forward calls to the interface cached in the metadata.

BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013

TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/6987019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63545
TEST=Use contextMenus.create() with "page" context and targetUrlPattern; verify that menu does show.


Review URL: http://codereview.chromium.org/7057029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86628 0039d316-1c4b-4281-b951-d872f2087c98

media_matrix_data_public.csv for videos that are in
trunk/deps/avperf/{bear,tulip}. 

Bug fixes includes:
* CSV file abnormality
* the order of returned tuples in _GenerateMediaInfo and LookForMediaInfoInCompactFormByNickName was incorrect
* not recognize the second column of CSV as tag
* par_filename was not set in the case of matrix driven test. 

Added features:
* -c and -z option to control the number of tests


Review URL: http://codereview.chromium.org/6992026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83828
TEST=NONE

Review URL: http://codereview.chromium.org/7053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86626 0039d316-1c4b-4281-b951-d872f2087c98