- 06 Feb, 2020 39 commits
-
-
David Black authored
This is achieved by flattening the existing AssistantWebView into AssistantWebContainerView. Note that a follow up CL will take the name 'AssistantWebView' and reassign it to what is now called 'AssistantWebView2'. Bug: b:146520500 Change-Id: I242085c039317936047341193ba05c857a144182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040199Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#738778}
-
Yoshifumi Inoue authored
Make NGInlineCursor::PositionForPointInChild() to call NGFragmentItem::PositionForPoint() with child local offset This patch changes |NGInlineCursor::PositionForPointInChild()| to call |NGFragmentItem::PositionForPoint()| with child local offset instead of offset in container because |NGFragmentItem::PositionForPoint()| expects local offset as |NGPaintFragment:: PositionForPointInText()|. This patch fixes following tests (at least): - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-user-select-none.html - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-before-style.html - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html Failure counts is decreased to 206 from 215. Bug: 982194 Change-Id: I839e9f480bb98501fb463da0dae6b42b2eb2b0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038590 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738777}
-
Brandon Wylie authored
Replace the regular grey mic with the colorful one. This will allow experimenting the following configurations: - Regular voice search, grey mic. - Assistant voice search, grey mic - Assistant voice search, colorful mic To support this addition, I needed to factor out the logic into its own service which can be used by NewTabPageLayout and LocationBarLayout. It also increases the modularity of the feature, which will make merges easier. Bug: 1046170,1045203 Change-Id: I728beffa69d0db75eeafd48dcf1918cfacfcbf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023300 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#738776}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2b2837f5716..989bb5e74cd4 git log d2b2837f5716..989bb5e74cd4 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 treehugger-gerrit@google.com Merge "traced_perf: feed samples through libunwindstack" Created with: gclient setdep -r src/third_party/perfetto@989bb5e74cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iedbf4a5704c1603b75e0db6b367e6286b8be8483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738775}
-
Changwan Ryu authored
Bug: 975908 Change-Id: I066741b274f2f64b81197e44f97a0c20ebc957fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036364Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738774}
-
Patrick Monette authored
ModuleDatabase::GetInstance() may only be called on ModuleDatabase::GetTaskRunner(). DisableThirdPartyBlocking() is a static method that can be called from any sequence which internally calls GetInstance() on the correct sequence. Bug: 1049211 Change-Id: Ie99d93eeaded2e8e90cb9ba1f99457b55b70a78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039772 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738773}
-
Darwin Huang authored
Miscellaneous spellfixes. No functional changes. Instances of "necessary" and "board". Change-Id: Ib3c9031ca98cdd2f7ebc661a62692b9ebba8c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040063 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738772}
-
Robert Sesek authored
DelaySandboxInitialization() is not called anywhere and is dead code. ProcessRegistersWithSystemProcess() was used under the V1 sandbox architecture to warm-up access to various IOKit services. Under the V2 sandbox architecture, there is no warm-up phase and the sandbox profiles simply allow access to those resources where needed. This allows base::PowerMonitorDeviceSource to be simplified, since the IOServices can be directly connected to rather than pre-allocated. Change-Id: I56769c90bd7fd9d8a5c3b8d16dc8166a53b5ce03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039390 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#738771}
-
Thomas Guilbert authored
Currently, we jump to the compositor thread in order to set the new frame presented callback on the VideoFrameCompositor. This CL is a small change that allows us to set that callback from the main thread. This should help minimize the amount of frames we miss in video.rAF calls. Bug: 1012063 Change-Id: I521eb0bf0a6e71f59552c60276006e1884c1f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040436 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738770}
-
Ben Pastene authored
The PRE_* test fails, while the non-PRE test passes, causing browser_tests to fail on bots (but the build remains green): https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34103 See crbug.com/1045100 for fixing the build status report. Bug: 1035156 Change-Id: I70d28db7cc800a40e5f7d6ca8312510a3bf95c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017670Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#738769}
-
Kenichi Ishibashi authored
* Let WriteToDiskCache{A,S}sync() assign resource ID internally * Add WriteToDiskCacheWithIdSync() that works as the same as the previous WriteToDiskCacheSync() NewResourceId() call will become async once we move ServiceWorkerStorage to the storage service. This CL reduces NewResourceId() calls so that we don't have to make all call sites async in the future. Bug: 1046335 Change-Id: I9ad57f8920bd5e157bd4ba8262699f72148b5bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035637 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738768}
-
Tim Song authored
This is a first pass, adding the plumbing and implementing a simple subset of the detailed notification interaction metrics. Follow-up CLs will implement the rest of the metrics. BUG=1047053 Change-Id: Idafc1cdf804097710a53f5d312fd9a30a7bcfa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037025Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738767}
-
Sujie Zhu authored
We add FIDO auth toggle on Clank Autofill Payment settings page. The toggle is shown only when 1) autofill is enabled 2) sync is enabled 3) feature flag is enabled. The requirement check is accomplished by adding one more PersonalDataManager bridge function. We reuse FIDOAuthEnabled preference to show current user's status and record user's intention (intent to opt in/out). The preference is exposed to Java side in order to get/set the preference via PrefServiceBridge. Local tested video (Googlers only): https://drive.google.com/a/google.com/file/d/1nJ1pSJZu1e5oV6qle_Piog6-a-v7kmZs/view?usp=sharing For more detailed background (Googlers only): go/autofill-auth-clank-settings Bug: 949269 Change-Id: Iefad4c953eee4dc00ec54627810b135c1eec6206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029255 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#738766}
-
Ehimare Okoyomon authored
Implement a bridge to connect Java UI to the CookieControlsService for a consistent backend with the web implementation. Bug: 1040091 Change-Id: I023e96d39c14aad20d3d82ff46e560916e595115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035894 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
shrekshao authored
Bug: 1013369 Change-Id: I04a8ce5ce11fb6a5d67acc782c2e297224b8685b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029236 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738764}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01005814aa9a..2fe6351af3c1 git log 01005814aa9a..2fe6351af3c1 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 John.Emau@microsoft.com Console: fix no scroll bug in context selector 2020-02-05 Rob.Paveza@microsoft.com Mismatched SASS source maps cause Performance recording to fail 2020-02-05 aerotwist@chromium.org [e2e] Updates separaters 2020-02-05 aerotwist@chromium.org [e2e] Moves hosted mode server to JS side 2020-02-05 tvanderlippe@chromium.org Remove hello world e2etest 2020-02-05 tvanderlippe@chromium.org Add remaining console startup tests 2020-02-05 khamu@microsoft.com High contrast fix in Console tools panel 2020-02-05 aerotwist@chromium.org [e2e] Moves shared logic out of e2e 2020-02-05 aerotwist@chromium.org [e2e] Fix exit code and paths for bots. 2020-02-05 rayankans@google.com [BackgroundService] Show tooltip over `other domains` checkbox Created with: gclient setdep -r src/third_party/devtools-frontend/src@2fe6351af3c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040254,chromium:1047671,chromium:1048378,chromium:1048978,chromium:1049155 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4a5055ceddfc99536987fbf78148ee9a6befa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040250Reviewed-by:
-
Isabella Scalzi authored
Add a test that tests deleting an item from Quick View that is part of a check selection. Bug: 803259 Change-Id: Icf9c77eee2fbeb400a981a0ecbe481addffaae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038295 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738762}
-
Avery Musbach authored
They were for OverviewController::OnOverviewButtonTrayLongPressed which was moved to SplitViewController in https://chromium-review.googlesource.com/c/chromium/src/+/2024447 Bug: None Change-Id: Id1e0b88c50f05d292040a7a9f04d83bd762c2d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040382Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#738761}
-
Livvie Lin authored
When navigating to an error page and then to an error page, going backwards to the first error page does not trigger ErrorRetryStateMachine::DidFailProvisionalNavigation, which breaks the page functionality. This likely occurs since the page is getting loaded from cache, so prevent the breakage by reloading. Bug: 1044768 Change-Id: If1ac325a175fc529086490f3064ec5199cc4ee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032185 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738760}
-
rbpotter authored
Add preprocess=true for some Polymer 3 Web UI/settings files that use <if expr>. Bug: 1026426 Change-Id: If89264703c33983570e4733d4ea4a5927effb81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040530Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738759}
-
Isabella Scalzi authored
Add a test that opens a file with Quick View in single-select mode and deletes it. Checks that the file is deleted, and that Quick View closes. Bug: 803259 Change-Id: I65200e1aac35d86c64c188e9cc30cc0fa9f73ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026553 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d28c5fe2b8b8..6c23cd33e6fe git log d28c5fe2b8b8..6c23cd33e6fe --date=short --first-parent --format='%ad %ae %s' 2020-02-05 brucedawson@chromium.org Fix duplicate header file entry 2020-02-05 brianosman@google.com Stop using Skia's specialized min/max functions 2020-02-05 tsepez@chromium.org Remove stray CJX_Object::InstanceManager_{Set,Move}Instances() decls. 2020-02-05 tsepez@chromium.org Cover CJX_InstanceManager methods from javascript tests. Created with: gclient setdep -r src/third_party/pdfium@6c23cd33e6fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048779 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1ce1dfa948cd87e8332e014d4bdeae98d888c935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040015Reviewed-by:
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/4c93e8d76db8..75bbf98f4e18 2020-02-01 bnc Change default QuicStream priority when using IETF QUIC. 2020-01-31 wub gfe-relnote: In QUIC, check nonretransmittable_frames, instead of packet length, to determine if a serialized packet is a MTU probe or not. Protected by --gfe2_reloadable_flag_quic_better_mtu_packet_check. 2020-01-31 wub gfe-relnote: If batch writer is used in a QuicConneciton, flush it right after a MTU probe is sent. Protected by --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe. 2020-01-30 bnc Sent PRIORITY_UPDATE frame when priority changes. 2020-01-30 wub gfe-relnote: Check handshake timeout before idle timeout in QuicConnection. Protected by --gfe2_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Id057ddca51b6bb8f5c219285a444023a7c08a071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037636 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#738756}
-
Khushal Sagar authored
Buffer allocation for the display compositor is currently done before overlay processing. This order is incorrect since we need to know whether buffers used by the compositor need to support alpha and this is not known until overlay processing. If a quad is promoted to an underlay then the display compositor buffers will need to support alpha. R=dcastagna@chromium.org,ccameron@chromium.org Bug: 946360 Change-Id: Ibb854cdb7764d4f6f6f41e490012416f9f0497ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026968 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738755}
-
Demetrios Papadopoulos authored
This is to avoid specifying the same rewrites over and over again, during the Polymer 3 migration. Bug: 1026426 Change-Id: If866cd3e8c5be2d3a2344a20ead7cdaaae3a43ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040431 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Kazuhiro Inaba authored
This CL plumbs the address change event to the Web UI dialog, so that it can listen all the necessary events even after the address has changed, and take appropriate response (like automatically closing the dialog after the pairing is established.). BUG=1045310 TEST=ARC++ CTSVerifer BLE Secure Client test (see the bug for the detail) Change-Id: I023404adf561d6da2ac1148470a15b9e57b8ea1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016775Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#738753}
-
bttk authored
https://source.chromium.org/chromium/chromium/src/+/d5c435e0b76ef29580d018cdbe8717fefd2ddd03 Bug: 1048429 Change-Id: Iaa866a5414324ba380d7d8fbc5fcc21ed1aa7ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037050Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738752}
-
Ben Pastene authored
According to the comment in the code, disabling this test disables all benchmark smoke checks in telemetry_perf_unittest. That seems like a critical set of tests to lose coverage for. So this re-enables them. Also increases the shard count of telemetry_perf_unittest's on the chromebook tester since this increases its runtime significantly. Bug: 1041328 Change-Id: I849a04c57c8f9ac4eb687e93b85322b67cb47cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032325Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#738751}
-
Michael Thiessen authored
Also adds a presubmit to ensure we don't add new java URI usage. Change-Id: I4df1b96fd737f19b8d632140d0899377ba8cc63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002743 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Fixes the naming of "web_runner.cmx" and "cast_runner.cmx", which were previously being suffixed with the release channel name (e.g. "web_runner-beta.cmx"). Bug: 1049378 Change-Id: Ic60203e31e1bf694fc6696d9c948d74fa0822020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040386Reviewed-by:
James Robinson <jamesr@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738749}
-
Christopher Cameron authored
Change gfx::DisplayColorSpaces to be a class instead of a struct, and hide its members (except to mojo serialization). Include a gfx::BufferFormat for each configuration. This will be needed - On Android to indicate that we can use 565 formats for opaque content. - On CrOS to indicate that we should use 1010102 formats for HDR - On macOS to indicate that we should use f16 formats for HDR - On Windows to indicate that we should use f16 or 1010102 for HDR This will eventually need to be plumbed through viz::OutputSurface::Reshape, gl::GLSurface::Resize, and glResizeCHROMIUM. Those function take a "has alpha" argument, the value of which will be able to be inferred from the buffer format. Bug: 1049334 Change-Id: I9bc8f2258496808de603a35cf6c0356bce5ff102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038077Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Connie Wan authored
See the attached bug for the related crash. I wasn't able to repro the crash, but a -1 index seems like a likely candidate. The previous code did catch it: https://chromium-review.googlesource.com/c/chromium/src/+/1999088/10/chrome/browser/ui/views/tabs/tab_strip.cc#b1081 So I added a check in here for a -1 index, to see if that fixes the issue. Bug: 1049240 Change-Id: I670ae27d0fe3899e2985575eeb395bfbb68f4cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040060Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#738747}
-
Jinsuk Kim authored
This CL addresses a crash (CHECK_EQ being hit) on desktop when a RenderProcessHost instance is still alive while the associated ProfileDestroyer is on its way to destruction. This started happening after https://crrev.com/c/1971031 landed to fix other crash on Android by delaying the destruction the off-the-record profile, which would have destroyed the RPH before hitting the CHECK_EQ. This CL moves the off-the-record profile destruction task where it was but uses |DestroyOffTheRecordProfileNow| instead. This change takes care of the desktop crash but also makes sure the clean up task required for the Android issue comes before the profile destruction. Bug: 1040839 Change-Id: Iabab0a304a802d1bd64adec255e88d81b6987cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032385 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738746}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4dc7c627..d2d1b4e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic90962bddeca474d4f08a1533d12d2451ea0eebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039830Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738745}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0eb8359beb5..7e44d3cbb30e Created with: gclient setdep -r src-internal@7e44d3cbb30e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1045987,chromium:973101 Tbr: jbudorick@google.com Change-Id: Ic5e4cf0bed1dbb939c4ba5efa17cd03a4f5483c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738744}
-
Philip Rogers authored
These signals were for an experiment to reduce compositing under memory pressure. This project is no longer being pursued because it is not clear the benefits of the intervention are worth the cost. The design doc has more information, including the raw numbers: https://docs.google.com/document/d/1oOebUZfMbW1lxgPifANu8BfPDN9BzRxXBRbvxZxnK8Q/view Bug: 1031634 Change-Id: I3700bd6d3c85dc1d187c79d7fd2b1b5d81d8c798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028752Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738743}
-
Rachel Wong authored
Bug: 1014839 Change-Id: Ie568d00cd2a40b104ea204b6e73e6a73f8cb5e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029389Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#738742}
-
Sinan Sahin authored
Bug: 1048972 Change-Id: I3f06cf95efc9e96679326a41ccf29caa38f0bc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039594 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738741}
-
Xiaoqian Dai authored
According to the new spec, we enforce a 96dp minimum drag distance no matter whether the drag starts within the snap region. The window has to drag either inside 16dp from the screen edge or a minimum 96dp distance into the snap region to be snapped. Bug: 1049158 Change-Id: I9102acd772f3e8ae27078998225f6efcc34f2a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039140 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
- 05 Feb, 2020 1 commit
-
-
Andrew Moylan authored
Adding config before experiment/rollout to Beta in M81. Bug: 937063 Change-Id: I6cfd07ff8e79b6dd7162344e1505ce11f2cbca63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037301 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
