- 17 Jul, 2018 40 commits
-
-
Alex Sakhartchouk authored
Makes fling speed feel more natural. Bug: none Test: flashed, flinged Change-Id: I8b181dbe0e9dec00f1e7a91799bbd83e86bea48b Reviewed-on: https://chromium-review.googlesource.com/1140503 Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575681}
-
Florian Uunk authored
The previous DCHECK meant that we can't introduce a new type in the future without breaking old clients. Instead, just ignore types we don't know about. Bug: 864428 Change-Id: Iaa31e2b0e6d501e14fcc1fa840110fc22f5c100a Reviewed-on: https://chromium-review.googlesource.com/1140058Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575680}
-
sczs authored
Bug: 826367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6f3659b846ecf118e1c5710a77ba020ba6eb2d25 Reviewed-on: https://chromium-review.googlesource.com/1123692Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#575679}
-
Gabriel Charette authored
This is a reland of 4714a9fc (PS1 is the original CL) Reverted @ https://chromium-review.googlesource.com/c/chromium/src/+/1137893 for a perf regression. Suspected cause : |IncomingTaskQueue::message_loop_scheduled_| wasn't equivalent to |was_empty| after all since |incoming_queue_| being empty doesn't mean |outgoing_queue_| is empty (hence setting a bit to false when both |outgoing_queue_| and |incoming_queue_| are empty is important to avoid scheduling more than necessary. Original change's description: > [MessageLoop] Refactor ScheduleWork and TaskAnnotator logic out of IncomingTaskQueue > > This was extracted from > https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17 > in an attempt to simplify it (and is now a precursor to it). > (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController > there but after grokking the resulting CL it's simpler under MessageLoop > as done in this CL) > > This CL splits the logic in IncomingTaskQueue which took care of > scheduling the MessageLoop into a dedicated class. In that follow-up CL: > MessageLoopTaskRunner will interact directly with the task Observer and > take IncomingTaskQueue completely out of the picture (merely a data > structure holding various task queues at that point). > > IncomingTaskQueue also took care of detaching on MessageLoop shutdown > which was moved to the new Controller class as well. > > message_loop.cc is the best place for this extracted logic as it all > pertains precisely to MessageLoop's implementation detail (how > ScheduleWork should be invoked). > > This CL simplifies locking as well by having a clear separation between > the two locks instead of two locks in the same class used > interchangibly. |incoming_queue_lock_| is now strictly for incoming > tasks. |message_loop_lock_| is now strictly for > ScheduleWork()/DisconnectFromParent(). > > Note: |message_loop_scheduled_| was dropped as it was redundant (always > equal to |!was_empty|). This last statement was incorrect. The equivalent of |message_loop_scheduled_| was incorporated into |was_empty| in PS2 of this reland. > > Performance wise, the perf tests show that this change is a noop : > * While BasicPostTaskPerfTest became simpler (executed less code) with > this CL : > The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead > reintroduces that overhead to show that it's still the same (or > slightly in favor of this CL). > * And the IntegratedPostTaskPerfTest are the same. > * Augmented perf tests to 30 seconds which yields more reliable results. > (and ran old ones under 30s mode too when comparing) > * Results : > https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit > > Bug: 860252 > Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe > Reviewed-on: https://chromium-review.googlesource.com/1127262 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574048} Bug: 860252 Change-Id: Ibe52413366e9b3ff38c9cb51616f9b8938ca68ad Reviewed-on: https://chromium-review.googlesource.com/1137894Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#575678}
-
Javier Ernesto Flores Robles authored
Creates the provider that will contain the buttons to bring up manual fallbacks for autofill. Gated behind the manual fill flag. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia36af25fc1e45f92e892b72a058b92d00c135b9c Bug: 845472 Reviewed-on: https://chromium-review.googlesource.com/1135323 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575677}
-
Ulan Degenbaev authored
They are replaced by - Memory.Experimental.Renderer2.V8 - Memory.Experimental.Renderer2.V8.AllocatedObjects The corresponding CL in V8 that removes recording: https://chromium-review.googlesource.com/c/v8/v8/+/1101197 Bug: 852415 Change-Id: I1357ced8536386d7083666edc66862661e073e84 Reviewed-on: https://chromium-review.googlesource.com/1101033 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#575676}
-
manuk authored
In the touch layouts, LOCATION_BAR_ICON_SIZE is 20, but kFaviconSize is 16, leading to different location bar icon image sizes depending on what icon is displayed and causing the omnibox text to jump when the icon size changes. For example, when typing a url, the 20px globe icon is displayed; wheras when typing a search url, the default search provider's favicon is displayed if available, which for Google is the 16px G icon. To avoid this, we set the location bar icon's size as LOCATION_BAR_ICON_SIZE, which is large enough to contain all icons. This is not an issue in other layouts, where both constants are 16. Bug: 860295 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9bc7a1b0b6b5a1f3dc6f4d2239d8fc2305c5063 Reviewed-on: https://chromium-review.googlesource.com/1135700 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575675}
-
Justin Novosad authored
Null ptr checks were missing on context_provider_wrapper, resulting in crashes after a GPU context loss. BUG=863752 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4b6f1fc394deb3f5567fee1da6f74b66aa7db79d Reviewed-on: https://chromium-review.googlesource.com/1140282Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#575674}
-
Xiaocheng Hu authored
Bug: 864585 Change-Id: Id88cbb9f2d0cb487bf1285988d015b356633916c NoTry: True Tbr: robliao@chromium.org, ellyjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1140533Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575673}
-
Kyle Milka authored
Vertically center custom background images. kCSSBackgroundPositionTopCover was previously added to align custom backgrounds, change this to kCSSBackgroundPositionCenterCover. Bug: 862789 Change-Id: I7905f21bcb8f54fd2710784b4dc16da8820ec1dd Reviewed-on: https://chromium-review.googlesource.com/1140364Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#575672}
-
Bill Orr authored
Rather than VRDisplayHost calling into a specific device to request a session, this change allows VRDisplayHost to choose the correct device to match the options. VRDisplayHost is no-longer tied to a single device, and there is now only one VRDisplayHost per VRServiceImpl. VRDisplayInfo and VRMagicWindowProvider should be returned as part of session creation, which will be addressed in followups. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic305b3f1243f91b512da34ac936fe14bfb4a8d76 Reviewed-on: https://chromium-review.googlesource.com/1107484 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575671}
-
Jérôme Lebel authored
Creating SigninEarlGreyUI class to contain all the EarlGrey helpers for sign-in. -[SigninEarlGreyUI signinWithIdentity:] is created to be used everywhere sign-in is needed in EarlGrey tests. The following methods are being moved into SigninEarlGreyUI class -[SigninEarlGreyUtils checkSigninPromoVisibleWithMode:] -[SigninEarlGreyUtils checkSigninPromoVisibleWithMode:closeButton:] -[SigninEarlGreyUtils checkSigninPromoNotVisible] -[ChromeEarlGreyUI signInToIdentityByEmail:] -[ChromeEarlGreyUI confirmSigninConfirmationDialog] |signInToIdentityByEmail:| is renamed by |selectIdentityWithEmail:|, to match its behaviour. This patch will help future work to migrate to the unified user consent UI. -[SigninEarlGreyUI confirmSigninConfirmationDialog] cannot be removed until crrev.com/i/652748 is landed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I537679ec7673ec75100e122d5903d9454bd5a21a Reviewed-on: https://chromium-review.googlesource.com/1138621 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575670}
-
Aldo Culquicondor authored
Bug: 833878 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If087700c9d318711c81bd5a0e50d929e960bd61d Reviewed-on: https://chromium-review.googlesource.com/1138399Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575669}
-
Ivan Sandrk authored
In the previous implementation, there was a bug where the ARC remote user command wasn't being run if it was issued while the user wasn't logged in. The command would be received upon log-in and immediately executed, while the ARC instance wasn't ready yet. Fixed this by waiting for ARC to be ready in case it wasn't already. Bug: chromium:860587 Change-Id: Ie14c5e9ac8c7437e149c84f56cc70ad63cb0b1e8 Reviewed-on: https://chromium-review.googlesource.com/1138249Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575668}
-
Réda Housni Alaoui authored
no video format Devices like Pinnacle Dazzle are listed in DirectShow with their video formats while listed in MediaFoundation with no available video format at all. This makes the capture factory fallback to DirectShow implementation when it contains at least one video format and its MediaFoundation counterpart has none. Bug: 862395 Change-Id: I5d02f97971d4cf98372e12bb96c0b7ad9cc6d9c3 Reviewed-on: https://chromium-review.googlesource.com/1137817 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575667}
-
Dan Harrington authored
This makes some test output more readable. I've added the implementations to the test_support library so we don't accidentally link these functions into Chrome. The definitions are included alongside the types being printed, opposed to a test support header file, to avoid ODR violations Change-Id: Ica0aa9629f9cf745b0a4e42b3536d9537b34bfc7 Reviewed-on: https://chromium-review.googlesource.com/1101472 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575666}
-
Michael van Ouwerkerk authored
Bug: 853728 Change-Id: I0d46d3004852fbbd0cb4a0793bbb899e43f38b2c Reviewed-on: https://chromium-review.googlesource.com/1130526 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575665}
-
Rohit Rao authored
During a side swipe to change tabs, we remove the content area from the view hierarchy. This was causing issues with the downloads UI, as we were attempting to set up constraints before the view hierarchy was reassembled. This CL swaps the order of calls to sideSwipeViewDismissAnimationDidEnd and setCurrentTab, to ensure that the view hierarchy is fully reassembled before any of the tab change machinery is invoked. BUG=849827 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iba2642f949a10d1a31ed32ae3763fed244022fdf Reviewed-on: https://chromium-review.googlesource.com/1138351Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575664}
-
Henrik Boström authored
Prior to this CL, there was a separate observer class for SetLocalDescription() and SetRemoteDescription(). In this CL, the WebRtcSetRemoteDescriptionObserver is renamed to WebRtcSetDescriptionObserver (to reflect it is used both for local and remote descriptions) and the WebRtcSetDescriptionObserverHandler is split up in a "Local" and "Remote" handler version. WebRtcSetDescriptionObserverHandler is updated to use the TransceiverStateSurfacer. In Plan B this is a refactoring that shouldn't make any functional changes, but in Unified Plan this setup will allow the creation of transceivers as well. The RTCPeerConnectionHandler is updated to wire both local and remote descriptions to use the same observer. The WebRtcSetDescriptionObserverImpl takes care of adding and removing receivers. Prior to this CL this is something we did for remote descriptions but not local ones. Because SetLocalDescription() does not change the set of receivers in Plan B, this should not make a difference. But in Unified Plan, the same codepath needs to run in both local and remote cases because in Unified Plan both SetLocalDescription() and SetRemoteDescription() modifies the state of transcievers. In an upcoming CL the "...ObserverImpl" will not just add and remove receivers but also take care of updating transceivers if Unified Plan is used. This CL also: - Removes RTCPeerConnectionHandler::SetLocalDescriptionRequest because it is not used anymore. - Removes SessionDescriptionRequestTracker, because it doesn't do much and the only remaining use was in CreateSessionDescriptionRequest which is updated to do the equivalent of its use of the tracker. Bug: 777617 Change-Id: I8a5726f25764c1e57ec18e7eb96decf083fc8333 Reviewed-on: https://chromium-review.googlesource.com/1136441Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#575663}
-
Evan Stade authored
Remove incognito member variable from CustomFrameHeader and make the text color part of the AppearanceProvider (in Mash, this relies on window properties). Also move some functionality from CustomFrameViewAsh to HeaderView so that when BrowserNonClientFrameViewAsh uses HeaderView, it will benefit from it as well. Bug: 837705 Change-Id: I7cb4aa654b37a6a9f8f73864c745f15245a15fc3 Reviewed-on: https://chromium-review.googlesource.com/1117883 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575662}
-
Justin Cohen authored
Bug: 857431 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1c8ae739deab88470f40e5b3c2e241406ecb233e Reviewed-on: https://chromium-review.googlesource.com/1138797 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Justin Cohen authored
Bug: 860129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6dec83e03cc51b5ce8239aebd8a5e22639a1996d Reviewed-on: https://chromium-review.googlesource.com/1139633Reviewed-by:
-
Michael Lippautz authored
Manual revert of 47b8c934 Change-Id: I1ae7917e2e458c36f8e6f7dce19cbef34437d411 Reviewed-on: https://chromium-review.googlesource.com/1140297Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575659}
-
Matthew Jones authored
This patch adds the data saver promo to the top of the overflow menu when Chrome Duet is enabled. The top divider for the promo has been removed and promo now scrolls off when the menu is scrolled (only in Duet). Supporting this patch is a change in how the header view is provided to the menu. Instead of passing the view directly, its layout ID is passed instead, bringing it more in line with the footer version. To get access to the inflated view, this patch also added AppMenuPropertiesDelegate#onHeaderViewInflated. Bug: 847632 Change-Id: I1c332199f6760d1ba1f30262e122bf30ab4c835e Reviewed-on: https://chromium-review.googlesource.com/1136714Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575658}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6fb8ba4e8660..d691aeeb956f git log 6fb8ba4e8660..d691aeeb956f --date=short --no-merges --format='%ad %ae %s' 2018-07-17 geofflang@chromium.org Vulkan: Implement GL_CHROMIUM_copy_texture with CPU copies. Created with: gclient setdep -r src/third_party/angle@d691aeeb956f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6652dc3c69e45f5eb685a4c38d827f9d98610c4a Reviewed-on: https://chromium-review.googlesource.com/1140255Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575657}
-
Rohit Rao authored
BUG=862255 TEST=On iPhoneX, rotate into landscape and open the Bookmarks. The bubble should not overlap with the notch, in both LTR and RTL languages. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I07c2215e7b3b6e01ee8e39cae6d03054199cb205 Reviewed-on: https://chromium-review.googlesource.com/1140195Reviewed-by:
-
Jacob Dufault authored
LoginDisplayHost owns ExistingUserController, this makes it more obvious and also simplifies instance creation. Bug: 851012 Change-Id: I8dc24c743aeb71070801009b2b4ec6472ee16409 Reviewed-on: https://chromium-review.googlesource.com/1125029Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#575655}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f623bafe. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21499 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I89fa9a8ca22e9f3f23db0d78438a6052aa533f06 Reviewed-on: https://chromium-review.googlesource.com/1140136 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575654}
-
Peter Boström authored
Creates a SkPath that matches the inkdrop shape and use that as the focus ring. In the future, hopefully the inkdrop shape can be generated from the same path so that they are forced to stay in sync. For now though they are less separate as the focus ring shape is generated using the same insets as the inkdrop. This focus ring is installed for ToolbarButton, BrowserAppMenuButton and ToolbarActionView (all are visibly toolbar buttons). Bug: chromium:862925 Change-Id: I898d2d9c6a9e058e9f84aff37615ebf3ab41cee7 Reviewed-on: https://chromium-review.googlesource.com/1139221Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#575653}
-
Robert Liao authored
Scenarios like dragging a window out of the tabstrip disable animations. This change forwards that request to NSWindow so the animation disable request is respected. BUG=863625 Change-Id: Ie25def791d30d35d7df804c4348fbad6cd0ae5ff Reviewed-on: https://chromium-review.googlesource.com/1138814Reviewed-by:
-
Rayan Kanso authored
This method is meant to standardize how each database task executes its callback, and terminates the DatabaseTask. Most DatabaseTasks have an ad hoc way of doing this anyway. This also has the extra benefit of making reporting failures via UMA easier, since there will be one place to report from, rather than having it scattered all over the file. Also remove GetNumRequestsTask since it is not used anymore. TBR=avi@chromium.org Bug: 780025 Change-Id: I1d8793fd9a25ef52f19737958a65e0b0e774bde0 Reviewed-on: https://chromium-review.googlesource.com/1128079 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575651}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b69a335b882..3d33483bb985 git log 0b69a335b882..3d33483bb985 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 treehugger-gerrit@google.com Merge "trace_processor: thread table implementation" 2018-07-17 treehugger-gerrit@google.com Merge "trace_processor: Process vtable implementation" 2018-07-17 lalitm@google.com Merge "perfetto: add taylori to OWNERS file" 2018-07-17 lalitm@google.com perfetto: add taylori to OWNERS file 2018-07-17 taylori@google.com trace_processor: thread table implementation 2018-07-17 taylori@google.com trace_processor: Process vtable implementation Created with: gclient setdep -r src/third_party/perfetto@3d33483bb985 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: Ib0baf1bf5ee6a38339bbcba926169ab04c9c4444 Reviewed-on: https://chromium-review.googlesource.com/1140253 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575650}
-
Denis Kuznetsov authored
Also add safeguard checks as policy dump might be requested by log upload job at times when not all services might be available for the profile. Bug: 863075 Change-Id: I45a88711c202800f89282dc0028e079bddb4324e Reviewed-on: https://chromium-review.googlesource.com/1136533Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#575649}
-
Georges Khalil authored
Delay the deletion of cloud_policy_client_ so it has time to clean up and avoid the UAF. Change-Id: I57c3afef17f2e07cb89d9fb1e79641c964415b17 Bug: 863933 Reviewed-on: https://chromium-review.googlesource.com/1138411Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575648}
-
Philip Jägenstedt authored
There haven't been any crashes or timeouts in a long time, only normal failures: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%2Fworkers%2Fopaque-origin.html See https://github.com/web-platform-tests/wpt/issues/11188. Change-Id: I933124b8c406fd202a7d382350cfe259d6607d79 Reviewed-on: https://chromium-review.googlesource.com/1140053 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#575647}
-
Peter Mayo authored
This test is passing in the virtual/sharedarraybuffer/ suite. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.worker.html Local experimentation indicates this change fixed the timeout: https://chromium-review.googlesource.com/1108744 Bug: 716320 Change-Id: I4091c71917bc79453442d6bd46fd2194be831a60 Reviewed-on: https://chromium-review.googlesource.com/1139379Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
-
Dan Harrington authored
integrity can appear on <link> and <script>. Since all <script> elements are removed, this CL only affects <link>. If a stylesheet is loaded, the integrity attribute is removed when writing MHTML. If the stylesheet didn't load, the <link> element is removed when writing MHTML. Bug: 826139 Change-Id: I5a80a9d07edd995d736b9b6230a805fed51162a3 Reviewed-on: https://chromium-review.googlesource.com/1110263 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575645}
-
Xiaocheng Hu authored
When TextIterator is passed with iteration range fulled contained in the leading collapsed whitespaces of ::first-letter, it currently doesn't stop in the first letter part, but advances to remaining text with invalid parameters. This patch fixes it by fixing an existing stop condition: - Old condition: stop if the current text box starts at iteration range end - New condition: stop if the current text box start at or after the iteration range end. The condition is also written in a more intuitive way. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2768d41ec5e792353023ca77749575383020ae18 Reviewed-on: https://chromium-review.googlesource.com/1137697Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575644}
-
Owen Min authored
This reverts commit 0b46e1db. Reason for revert: Causing multiple layout tests failed based on findit. Original change's description: > Forms: Add a UseCounter for opening popups while a file chooser is opening > > We'd like to fix a confusing UI issue, and to know the impact > of a possible fix. > > Bug: 637639 > Change-Id: I7af67ac314f61723c7904cf0fee408ac2b60e774 > Reviewed-on: https://chromium-review.googlesource.com/1139940 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575575} TBR=keishi@chromium.org,tkent@chromium.org Change-Id: I4bd3877c33ea7a70a7a7d0d53b7cbb1411240da3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 637639 Reviewed-on: https://chromium-review.googlesource.com/1140393Reviewed-by:
-
Rohit Rao authored
We do not add a blur effect when Reduce Transparency is enabled, which was causing the incognito toolbar to display with a white background. Instead, fall back to the pre-refresh incognito toolbar color. BUG=862860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I55e4305527c19c90faa00672fc2b80321eca7b4c Reviewed-on: https://chromium-review.googlesource.com/1138344Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575642}
-
