- 06 Aug, 2019 40 commits
-
-
Antonio Gomes authored
... down to renderer/platform/mediastream. The .cc and test_.cc respective files also got moved from renderer/platform/export/mediastream to renderer/platform/mediastrea/. BUG=704136,919392 R=guidou@chromium.org Change-Id: Ia981d447b28e2b7ad5bcadba3abb13ebc4111f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739388 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#684348}
-
Geoff Lang authored
If the passthrough command decoder is default, it may get used when it is not supported in compositor_unittests and cc_unittests. BUG=882580 Change-Id: I890315332e07bb61328fc9cb063f4abbdafa0194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739308Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#684347}
-
Anushruth authored
Added chrome_all_tast_tests, cros_browser_sanity_test and base_unittests to chromeos-kevin-google-rel R=bpastene@chromium.org Bug: 988587 Change-Id: I2117296c33c99f72063d6ffac71e007b4c481710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737100Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#684346}
-
Aaron Leventhal authored
When VoiceOver uses an action to press a checkbox, it requests and reports the new checked state immediately. However, because of Chrome's cross process model, the checkbox/radio/switch checked state is still the previous state, as the round trip has not yet updated the object. This uses a hack to temporarily override these objects with what the state is expected to become. Once the system catches up with itself, it will update the object with the true checked state, which should be the same. Bug: 971429 Change-Id: Ifcc15b281413f02cecf951ac6e4e31890d4c05c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727210 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#684345}
-
Amr Aboelkher authored
Show the cursor highlight accessibility feature only if one of the following conditions have meet : -Its not being controlled by any policy -Its being controlled by a policy and the value of the policy is force on Bug: 552439 Change-Id: I48823a53cb0ebbaf2edc732de56452871ee08eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725915 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#684344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b9d6775dfb5f..600679a1c326 git log b9d6775dfb5f..600679a1c326 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 khokhlov@google.com Maintain compatibility with both jsoncpp versions 2019-08-05 rsavitski@google.com Merge "traced_probes ftrace: cap the per-cpu pages read per drain period" 2019-08-05 ilkos@google.com Merge "Combine heap profiler stats" 2019-08-05 fmayer@google.com Merge "Move profile.packet to perfetto.third_party package." 2019-08-05 treehugger-gerrit@google.com Merge "UI: Fixed timeline scrubbing" 2019-08-05 treehugger-gerrit@google.com Merge "Improve extension for perfetto trace recording." 2019-08-05 hjd@google.com Merge "Update rollup config to remove warning" 2019-08-05 hjd@google.com Make bad config the right amount of bad 2019-08-05 hjd@google.com Merge "Add bad config to test/config" 2019-08-05 fmayer@google.com Merge "Add //src/base to dep for pprofbuilder." 2019-08-05 fmayer@google.com Merge changes Iff458990,If7f8d5f2,Ia79e6e0b 2019-08-05 ilkos@google.com Add pid to the frame stats metric 2019-08-05 taylori@google.com Merge "perfetto-ui: Only quantize tracks with too much data" 2019-08-05 ilkos@google.com Merge "Enhance heap profiler metrics" 2019-08-02 hjd@google.com Merge "perfetto-ui: Fix ui" 2019-08-02 treehugger-gerrit@google.com Merge "no-stall mode: Track stats about packet loss" 2019-08-02 treehugger-gerrit@google.com Merge "client api: Don't hang if a not-yet-started session is stopped" 2019-08-02 fmayer@google.com Merge "Use ProfiledFrameSymbols for symbolization." 2019-08-02 treehugger-gerrit@google.com Merge "processor: Export LegacyEvent raw events as JSON" 2019-08-02 taylori@google.com Merge "perfetto-ui: Fix tslint errors" 2019-08-02 treehugger-gerrit@google.com Merge "perfetto-ui: Make 'm' timespan select work on all selections" Created with: gclient setdep -r src/third_party/perfetto@600679a1c326 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:b/133745684 Change-Id: I81653eaafcaf2aad1da8bec5e8d9cbae305ef704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684343}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc89641e4a1d..af9ce667581c Created with: gclient setdep -r src-internal@af9ce667581c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8f34bfa2aa99cceea99aa151f64fb339553a9522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738430Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684342}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e6c294dba63..61b15905b014 git log 2e6c294dba63..61b15905b014 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8776a388..9d357a52 (684182:684300) Created with: gclient setdep -r src/third_party/webrtc@61b15905b014 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I9b75c13119bb8f8d430fce5530686c60fb434733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684341}
-
arthursonzogni authored
Add 4 tests that regressed recently after: https://chromium-review.googlesource.com/c/chromium/src/+/1654739 Bug: 991194 TBR=ahemery@chromium.org Change-Id: I9f3c93ab99a3c34e7cff0a936078f1343d98bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738377Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88681ddd1d38..3a543aafd4e6 git log 88681ddd1d38..3a543aafd4e6 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 aparchur@google.com Reland "[skottie] Add onTextProperty support into PropertyObserver." Created with: gclient setdep -r src/third_party/skia@3a543aafd4e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I01e8a19011358ffa29f3d38915c29365cf645de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684339}
-
Vadym Doroshenko authored
Context: code for filling passwords in DOM is very convoluted. For username first flow, we need to fill only usernames, which is hard to do in the current setup. Let's refactor! This CL contains: 1.FillFormOnPasswordReceived is removed. It basically delegates filling to FillUserNameAndPassword, which is used now. 2.Checking origin of parent frames moved to a helper method. 3.2 arguments removed from FillUserNameAndPassword, they may be computed from other args anyway. The further CL will contain more simplification to FillUserNameAndPassword. Bug: 875768, 959776 Change-Id: Id1658401a8ec683a1a8db1117e816fe87f7dbaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738554Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#684338}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=vakh@chromium.org Bug: 968047 Change-Id: I82e8243a4dc3bea555c09c8c407f5f855c39c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729222 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#684337}
-
Wei-Yin Chen (陳威尹) authored
Bug: 964406 Change-Id: I1a6f0969d6361afb00a5f5a4d800c4ad29ff7b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735777 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684336}
-
Robert Flack authored
As a result of aligning the animation clock to raf, the animations in play-state.html start a bit earlier. This resulted in the test flaking regularly. By waiting for a render and relaxing the time allowed this test no longer flakes. I've added another test to ensure that animations which start with the initial document load are indeed caught by an animationstart event. Bug: 986019 Change-Id: Ib0dff60ddfef4f0395e422ac94bbdc78cc660017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727370Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684335}
-
Leonard Grey authored
Bug: 956433 Change-Id: I7991566418c52643711d79c7fe9d20852ae203b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729469Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#684334}
-
Noel Gordon authored
This reverts commit 679d952d. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=987448#c31 Original change's description: > Revert "[Sheriff] Disable SingleProcessBrowserTest.Test on Win." > > This reverts commit 2a6e4af1. > > Reason for revert: The test should no longer be flaky on Windows. > > Original change's description: > > [Sheriff] Disable SingleProcessBrowserTest.Test on Win. > > > > Flaky. > > > > TBR=rockot@google.com > > > > Bug: 987448 > > Change-Id: I6db59e7ce6ac618320e10bfe85b1aa700e0fbce1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730902 > > Reviewed-by: vitaliii <vitaliii@chromium.org> > > Commit-Queue: vitaliii <vitaliii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683173} > > TBR=rockot@google.com,vitaliii@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 987448 > Change-Id: Ia37df33292f76bf965d07da3168933586e564061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736439 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#684053} TBR=rockot@google.com,vitaliii@chromium.org Change-Id: I3b1083a892df5cfa536f3553082b27f31acfdbd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738562Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#684333}
-
Tim Volodine authored
Flaky on recent runs of android waterfall bots. BUG=990555 TBR=hartmanng@chromium.org,adithyas@chromium.org NOTRY=true Change-Id: I2a605b491db96b494f94a20c3451207dc3bd64e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738592Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684332}
-
Jared Saul authored
Accidentally missed this as part of https://chromium-review.googlesource.com/c/chromium/src/+/1717490 Bug: 868552, 902366 Change-Id: I7e68bc0ada1f48cd465dadbe9a171b09e6f8743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733410 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#684331}
-
Balazs Engedy authored
This reverts commit 1d544254. Reason for revert: Causes virtual/cache-storage-parallel/external/wpt/service-workers/service-worker/interfaces-sw.https.html to time out on Linux MSAN. Original change's description: > Reland "CacheStorage: Allow reads to be executed in parallel." > > This is a reland of cca6943d > > Original change's description: > > CacheStorage: Allow reads to be executed in parallel. > > > > This CL adds the CacheStorageParallelOps feature with the associated > > "max_shared_ops" parameter. Enabling the feature and setting the > > parameter to greater than one will allow read-only cache_storage > > operations to run in parallel. By default parallel operation is > > disabled. > > > > The overall design is to treat each CacheStorageScheduler as if it > > has its own read-write-lock. When an operation is scheduled it must > > be flagged as either "shared" or "exclusive". Some number of shared > > operations (determined by the feature param) may run in parallel. > > Exclusive operations always run by themselves without parallelism. > > > > This CL also includes the ServiceWorkerCache.PeakParallelSharedOps > > histogram which will measure how much parallelism we actually see in > > practice. The peak is measured across a small time period defined by > > when an idle scheduler begins running its first shared op to until it > > stops running all shared ops. > > > > Bug: 985379 > > Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008 > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > > Commit-Queue: Ben Kelly <wanderview@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680986} > > TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org > > Bug: 985379 > Change-Id: I83d8ce38a647b00e658dc1e2e17828468475cc66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737031 > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684049} TBR=dmurph@chromium.org,jwd@chromium.org,jam@chromium.org,rayankans@chromium.org,wanderview@chromium.org Change-Id: I879f85342779a56f445cb6a157aeb5d74fcd3771 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738591Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684330}
-
Balazs Engedy authored
This reverts commit 35ad15e3. Reason for revert: virtual/audio-service/external/wpt/mediacapture-streams/idlharness.https.window.html times out on Linux MSAN. Original change's description: > Reland "Add web tests virtual suite for audio service - Take 2" > > This reverts commit 75b38795. > > Reason for revert: Adding expectation to address Linux Leak failure > > Original change's description: > > Revert "Add web tests virtual suite for audio service - Take 2" > > > > This reverts commit 8d648953. > > > > Reason for revert: Causing failures on WebKit Linux Leak > > > > Failure output: > > 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: > > 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) > > > > Original change's description: > > > Add web tests virtual suite for audio service - Take 2 > > > > > > Adds extra expectations with respect to reverted > > > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > > > > > Bug: 976696 > > > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#683565} > > > > TBR=guidou@chromium.org,armax@chromium.org > > > > Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 976696 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508 > > Reviewed-by: Chris Sharp <csharp@chromium.org> > > Commit-Queue: Chris Sharp <csharp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683600} > > TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 976696 > Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Henrik Grunell <grunell@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683979} TBR=grunell@chromium.org,guidou@chromium.org Change-Id: I0d414e093d158e3142091e376ec7d49926a357c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738560Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684329}
-
arthursonzogni authored
Bug: 991178 Change-Id: I89d7ab57849e1a5db8ef0355d525249032316abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738455 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684328}
-
Tamer Tas authored
We have Blink layout test bots on 3 different platforms using the {blink_downstream} recipe. {chromium_integration} uses src-side definitions for compilation and blink tests. This CL creates the src-side bot definitions for Chromium integration with Blink Layout tests. R=machenbach@chromium.org TBR=jbudorick@chromium.org Bug: chromium:883629 Change-Id: I5b303b1d1dd26cc4a2b3804a8e762b69020069df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736680 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#684327}
-
Nico Weber authored
Bug: 990921 Change-Id: I12d2775011b4ed8e560117b4c1a3f49b710e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739307 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684326}
-
Varun Khaneja authored
Reverts: * crrev.com/c/1597540: Which seems to have introduced the UAF. See crbug.com/973928#c21 * crrev.com/c/1731698: Since that speculative CL did not fix the issue. Since I'm out of ideas about what's causing the crash, this CL will help establish that crrev.com/c/1597540 did indeed cause the issue. R=dvadym Bug: 948767,973928 Change-Id: I08e2023a607153c248676ef2c6203674dc2cabdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736113 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#684325}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a22cab8a6532..2e6c294dba63 git log a22cab8a6532..2e6c294dba63 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 titovartem@google.com Refactor test_peer.cc to reduce amount of arguments passing around 2019-08-06 tommi@webrtc.org Fix CallClient so that it calls Call::GetStats() on the right thread. Created with: gclient setdep -r src/third_party/webrtc@2e6c294dba63 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I8ed742a4c3fbd3a502b13013c32c2c2a8382f2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738989Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684324}
-
Omer Katz authored
This flag will be used by https://crrev.com/c/1730054. Submitting as separate CL so that if 1730054 needs to be reverted, we still have the flag in the code to use in further CLs. Bug: 986235 Change-Id: I3300937e864f6e3fcd40d6c0a463fae04911e71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725643Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684323}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5ada98d0bb33..698b56a8f024 git log 5ada98d0bb33..698b56a8f024 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 afdx@google.com Add 'copy object' transformation (#2766) 2019-08-02 paulthomson@users.noreply.github.com fuzz: change output extension and fix usage string (#2778) 2019-08-01 geoff@vonture.net Remove extra ';' after member function definition. (#2780) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@698b56a8f024 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@chromium.org Bug: None Change-Id: I25899d747028e6b74209da308804b9fcc74a98ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684322}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/131b9f32457c..c802efc06a40 git log 131b9f32457c..c802efc06a40 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 perezju@chromium.org [Telemetry] Add content types to artifacts Created with: gclient setdep -r src/third_party/catapult@c802efc06a40 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:966835 Change-Id: Ie30c1734cc76cc7533e1e924c49b4289afddfb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684321}
-
Antonio Gomes authored
CL also converts an instance of base::Bind, routing it to CrossThreadBindingRepeating. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifbc6ea703c425697f7cbfd41e854365266def511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736930 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684320}
-
Dominic Farolino authored
This CL adds prefetch browsertests for main-resources, and subresources to ensure that the main-resource implementation doesn't break SplitCache. The tests all run with the SplitCacheByNetworkIsolationKey feature enabled to prepare for the implementation of Cross-origin Prefetch + SplitCache. The scenarios tested are as follow: - Cross-origin as=document prefetch reuse as top-level-navigation - This tests that the cross-origin resource is cached with a NetworkIsolationKey corresponding to its origin. Therefore, it can be reused for top-level-navigations - Cross-origin as=document prefetch not reused as cross-origin subresource - This tests that even though cross-origin as=document prefetches are cached under an atypical NetworkIsolationKey, their reuse is restricted to top-level-navigations. - Cross-origin prefetch subresources are not able to be reused from cache in a cross-origin context. (AKA, we didn't break SplitCache). - Cross-origin prefetch subresources are able to be reused by the frame that fetched them. (AKA, we still didn't break SplitCache). - Cross-origin prefetch subresources not reused as top-level navigations - As the comment in the code suggests, even though this is safe, a resource must be committed to a single cache partition. Therefore, if a cross-origin subresource is prefetched, it cannot be used anywhere else but in the frame that fetched it. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ie50844463a838c5fabd5a153cd0caf720a59da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732869 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#684319}
-
Jan Wilken Dörrie authored
This change updated leak_detection_api.proto to use the LookupSingleLeak messages. Furthermore, it drops the PasswordsLeakCheckService definition, as this is not necessary for a REST API call. Bug: 986298 Change-Id: I0ad7e48ce3892cb46b8d0ed08f4a44de6b3a7212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738693Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#684318}
-
Ren-Pei Zeng authored
Use the VAAPI frame mapper instead of the linear frame mapper (i.e. mmap()) to read the correctly synced output frame of MJDA. Bug: 991136, b:120057531 Test: jpeg_decode_accelerator_unittest Change-Id: Ibf3bee74176fa879a800bcd893ab9f222e65ebbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739306Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684317}
-
Antonio Gomes authored
... from WTF, instead of std::string and std::vector, respectively. Additionally, this CL also moves this file out of the Blink exposed API. Note that not all std::vector use from media_stream_constraints_util_audio.cc used replaced, given that it, it requires unrelated changes to media_stream_constraints_util_sets.h. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie2f5565fc0c320a16fc5afa4c71a27431e319881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737016 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684316}
-
Owen Min authored
Also rename DevicePolicy to DeviceLocalAccountPolicy in PolicyConversion. Bug: 989249, 983174 Change-Id: I05219823615a429d991d225119ffcc4541a5b790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726797Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684315}
-
arthursonzogni authored
All the tests are failing for the same reason. The NavigatonSimulator needs to be updated to take into account the navigations using the BackForwardCache. Bug: 989924 Change-Id: If79b33ca9217771e073b06c5fab5b020d0ad598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738375Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684314}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If2e3299848b12319ec9674c74b59222127362195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684313}
-
Amr Aboelkher authored
Show the dictation accessibility feature only if one of the following conditions have meet : -Its not being controlled by any policy -Its being controlled by a policy and the value of the policy is force on Bug: 552439 Change-Id: Id76a331ecfaed2fdcf24a65bd56552287b92bb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725640 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#684312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f3e8b89c4fe8..fc89641e4a1d Created with: gclient setdep -r src-internal@fc89641e4a1d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic5ba4efdde08030400abb68c6641086327ccb9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739131Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684311}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd07fe70..2ec7afe6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea41d910ecfdb5d716d58eb517c871246dd1aa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739286Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684310}
-
Marc Treib authored
Previously, these tests were reusing TestNavigationObserver instances for multiple navigations, which apparently doesn't work. This CL moves the TestNavigationObserver stuff directly into the NavigateTabBack/Forward helpers, so that individual tests don't have to care about this. Note that the similar NavigateTab helper uses ui_test_utils::NavigateToURL which already does the waiting, so nothing else is required there. Bug: 972871 Change-Id: Iafa796be4da091afcdb279824c6c873f4e6ae62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736682Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#684309}
-