- 23 Jul, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2f0a34a..109b30b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0a46268501a25b41a92c22e769a4a87c107fa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715404Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4e3b218e9695..68d97adf88de git log 4e3b218e9695..68d97adf88de --date=short --no-merges --format='%ad %ae %s' 2019-07-23 senorblanco@chromium.org Prefer <cstring> to <string.h>. Created with: gclient setdep -r src/third_party/dawn@68d97adf88de The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I4597f2403819781dbf96662788ad263d248784b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680066}
-
Jun Mukai authored
- The folder-view's expansion / shrink can be fully done through ui::LayerAnimator since it can animate all of the properties. - Item view can update the rounded corner and insets with animation on folder-item. It still has a slide-animation in item_view for the indicator circle of the non-folder items. I believe this can be done through the ui::LayerAnimator though it would need some amount of refactoring while it won't affect the performance so much; so this CL leaves it as-is. Bug: 983308 Test: manually Change-Id: Ib954280e3c72fd7c1add1b863349d4793059e14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710048 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680065}
-
Piotr Bialecki authored
Change-Id: I474cc8a67e92ad3ebee7dcd97a2d67f5f50c133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709692 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#680064}
-
danakj authored
We are removing the WebLayerTreeView interface as it is redundant with WebWidgetClient now that we always composite web contents. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. The HaveScrollEventHandlers() method is only used in blink_unittests and they can get at the TestWebWidgetClient, so remove it from the public APIs entirely. WebPagePopups don't have scroll event handlers, and even if they did they don't need to tell the compositor. Add a comment and a NOTREACHED() instead of code. R=dcheng@chromium.org Bug: 912193 Change-Id: I5aed86e0773953428aded533df4395c29f3bd451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713746 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680063}
-
Juanmi Huertas authored
Fixing a clusterfuzz bug by ensuring that ExistingDrawingCanvas and DrawingCanvas will fail in the same conditions (the context is lost and there is no canvas to draw to). Bug: 982321 Change-Id: I3ac02f605ed1b41c50a3179e1d69d61d25f528a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708154Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#680062}
-
Dan Harrington authored
This CL hides ClientPolicyController, and makes it a singleton. Access to policy data is now provided through regular functions. ClientPolicyController was already immutable, so making it a proper singleton is just a mechanical change. This has a benefit that we no longer construct multiple copies of ClientPolicyController, and no longer need to thread it through so many interfaces. A potential downside is that injecting fake policies for testing would have been easier before this change. However, there's still several ways to do it, and we haven't yet found a need for this. Bug: 883559 Change-Id: I5b0919f9d91d91c53d9897b8469f9031d45c6996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678780 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#680061}
-
Will Cassella authored
The CL uses the new 'conditional modules' feature to auto-install the VR DFM upon updating Chrome on supported devices. This should provide a much better experience when launching Chrome from the DDH for the first time on devices where the cost of having the VR DFM unused is minimal. This is only used on monochrome_bundle builds. Bug: 961796 Change-Id: I79b095205b5dd947484738034bf50a2a0c4c8ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714144Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#680060}
-
Tarun Bansal authored
Add the redirect URL scheme to the redirect learning table. Next CL will use the value of the scheme for preconnect. Change-Id: I9b129a5a2f1dce3f378f1a44f7e92587f84eae03 Bug: 983234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700886 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680059}
-
Lei Zhang authored
- Remove the check for |is_android|, since the code is never built on Android at all. Replace with an assert and merge two sources sections. - Explicitly write out conditions for files to be included. Change-Id: Ieed8e43001ce4281a84c737a26056b3cfd6f0225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714218Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#680058}
-
Andrew Luo authored
Bug: 924194 Change-Id: I51fa3da0276d8cf15a7357369d58e5e9912702d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683671 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#680057}
-
chrome://managementdpapad authored
Bug: 986481 Change-Id: I3eb011a34bb225eb137c1ee80e95774ed0d6753f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714384 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#680056}
-
Lei Zhang authored
Forward declare instead. Also fix nits along the way. Change-Id: I746a551d1ba7ac4eb85034a96464a8aaf600d6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714667Reviewed-by:
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 985613 Change-Id: I6fcd40bac09ecc66ae6eca328f2628b2e0641e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710050Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680054}
-
Sean Gilhuly authored
Set a bit in GpuDataManagerImplPrivate::FallBackToNextGpuMode() to remember that the hardware acceleration was disabled by fallback, and add a new error message in GpuAccessAllowed() to account for it. This branch could be hit if the GPU process crashed repeatedly, and SwiftShader was not available as a fallback option. Bug: 986819 Change-Id: I93e2c08900b308e5897b3068053d7704324048ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714811Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#680053}
-
Maksim Moskvitin authored
New test cover compatibility of USS and Directory implementation in term of storing keys derived from custom passphrase. We setup custom passphrase encryption with USS implementation and then verify, that Directory implementation can decrypt data without providing custom passphrase again (by loading it from prefs). Bug: 922900 Change-Id: I9c902a4f6c59b7f41f344ab60e725d7ff59ad88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710542 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#680052}
-
Adam Raine authored
CompositorColorAnimationCurve and CompositorColorKeyframe were created to handle color valued keyframes on the compositor. Logic was also added to use these new types when a CompositorKeyframeColor is used. A unit test was added for this new functionality. Bug: 883721 Change-Id: Icae9860fbe19f29a6ef5b5dd906582c8f9163bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698667 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680051}
-
Eugene But authored
ios/web/common directory contains common code shared between //ios/web and the rest of the layers (//components, //ios/chrome, //ios/web_view). This directory does not contain the public API to create and manage web contents (//ios/web/public is public API directory). The files which are moved in this CL contain 2 functions: - bool UrlHasWebScheme(const GURL& url) - bool UrlHasWebScheme(NSURL* url)) Both these functions conceptually belong to ios/web, but they don't belong to ios/web/public. ios/web/common is existing directory, which mirrors content/common, and ios/web/common seems like the most appropriate place for these functions among existing directories. The proposal to move the files was discussed on this doc: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit Bug: 942244 Change-Id: Ib5c09134b3026f25e545fb436c9313b71b7a4c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709000 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#680050}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/21a940d42fee..c80b0e954187 git log 21a940d42fee..c80b0e954187 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 robertphillips@google.com Make rest of GrGpu::wrapBackend* methods take a GrColorType (take 2) 2019-07-23 jlavrova@google.com Fixing the build Created with: gclient setdep -r src/third_party/skia@c80b0e954187 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I52264a6af3599cc3c9de80c0dab5ce478fd45aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715384Reviewed-by:
-
Maksim Moskvitin authored
Once explicit passphrase is known by the client, it should be persisted somewhere to not ask user to provide it on every Chrome startup. While for USS implementation we're going to use different way for key persistence, we still store it in preferences, because: 1. It allows to start experiments without complete implementation of new persistence approach. 2. It allows to disable USS Nigori implementation and continue using Directory implementation without asking user to enter passphrase again. Bug: 922900 Change-Id: I2295872752b23901c7f0915b1d156e28dc54d961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709326 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Jinfeng Ma authored
When devicePixelRatio is greater than 1, the viewport size of the CSS media query may appear as non-integers. This can happen in Chrome for Android if the UseZoomForDSF flag is enabled. For example: <meta name="viewport" content="width=device-width, initial-scale=1"> <style> @media (width: 393px) { p { color: red; } } </style> <p>text</p> If the device width is 1081 physical pixels and devicePixelRatio is 2.75. The viewport width of the CSS media query will be 393.091px. Change-Id: I25ee4da1ebdbd57202fa8c5e360138a8058f578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695522 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: -
Dan Harrington authored
The related feature is being launched in M77 Bug: 986516 Change-Id: I12f2757458a4c28f60ece771bbc1f09c7f82af72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715229Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#680046}
-
Asanka Herath authored
DLOPEN_KERBEROS macro controls whether //net dlopen()s a GSSAPI library for supporting Kerberos authentication. When DLOPEN_KERBEROS is not defined, //net links statically to the GSSAPI library. The latter option is only expected to work if //net (and in turn Chromium) is being built on the host on which it is going to run. Code for the case where DLOPEN_KERBEROS is not defined is not compiled let alone tested on any known Chromium configuration. This CL removes the !DLOPEN_KERBEROS logic (i.e. code for using a statically linked GSSAPI library). However //net still needs to distinguish between platforms where an external GSSAPI library is used vs platforms where Negotiate authentication tokens are minted via other mechanisms. As of this CL, the platform variations are: * Windows : Negotiate authentication is supported via Windows' SSPI. //net has a static dependency on SECUR32. * Android : Uses an external authenticator as described in [1]. * macOS, Linux, ChromeOS, Fuschsia: Uses an external RFC 2744 compliant GSSAPI library. Kerberos/Negotiate related GN variables are: * use_kerberos : Set to 1 if Kerberos support is desired. Currently support for HTTP Negotiate authentication scheme is gated on this flag. Note that future CLs will rename this to use_negotiate_auth in order to be consistent with what the flag actually does. None of the authentication logic in //net is Kerberos specific. If set to 0, then none of the negotiate library logic is compiled. * use_external_gssapi : Set to 1 on platforms where an external GSSAPI library needs to be loaded in order to support negotiate authentication. Currently this is set to true on all Posix platforms excluding Android. In addition, it is also set to true on Fuschsia. [1]: https://www.chromium.org/developers/design-documents/http-authentication/writing-a-spnego-authenticator-for-chrome-on-android R=eroman@chromium.org Bug: 980575 Change-Id: If006fcd9d0f2579698737ddfcadbe8f901d98a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685493Reviewed-by:Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680045}
-
Tim Judkins authored
This change makes it so that when passed a fully qualified URL, getURL does not return the string as-is. Bug: 984696 Change-Id: Ib82e41b13071bb6ec6fde5f98dbd2eade593d272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705579 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680044}
-
Matt Falkenhagen authored
Bug: 985259 Change-Id: I45417af4401589c7ab47d61c63792e362ff37963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712952 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680043}
-
Ted Choc authored
BUG=975753 Change-Id: Ic2f7207594400613bb3b26ddcbd78df44947864c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707824Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#680042}
-
Hector Carmona authored
This is dead code and should not be accessible by our users. Bug: 956680 Change-Id: I2da85dbada54ea683417b8309dff46f08d1dcca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713443Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#680041}
-
Katie D authored
TBR=anastasi@google.com Change-Id: I29d87e40386290a2642aa2b5e226faab157e0a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715564Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#680040}
-
Akihiro Ota authored
This change ensures that ChromeVox language switching is turned off if the feature flag is absent. This change is motivated by the following scenario: 1. Run Chrome with language switching flag. 2. Turn on ChromeVox language switching. 3. Restart Chrome without language switching flag. 4. Language switching remains enabled because ChromeVox saves preferences. Since feature flag is not present, there is no way to turn language switching off. Change-Id: I62dd741f0e6710282760b9eccdc75f371c917371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713030Reviewed-by:
-
Dominik Laskowski authored
Content protection would be reported as enabled while mirroring to an external display with an unsecure (e.g. analog) connection type. Bug: 929449 Test: display_unittests Change-Id: I4929ff4fa591616f27eaed01875455c86504e91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674404 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#680038}
-
Matt Menke authored
Currently, nothing passes in anything other than a default constructed one. Consumers will be updated one-at-a-time in followup CLs, and the default empty NetworkIsolationKey will be removed from method declarations. Bug: 966896 Change-Id: If5cc69299de2b0fc6886c304710ffa40423f9536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672147 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This aligns PlzWorker to be more like PlzNavigate for service worker related objects. This will allow moving service worker to the UI thread by allowing PlzWorker to use ServiceWorkerNavigationLoaderInterceptor like navigations do. Previously, navigations stored ServiceWorkerProviderHost info in ServiceWorkerNavigationHandle, while PlzWorker did it itself: WorkerScriptFetchInitiator::CreateScriptLoaderOnIO created the provider host and passed the host to WorkerScriptLoaderFactory, and eventually WorkerScriptLoader::CommitCompleted called host->CompleteWebWorkerPreparation. The host's info was passed to WorkerScriptFetchInitiator::Start's callback, so the caller could pass it to the worker in the renderer. Now, DedicatedWorkerHost or SharedWorkerHost hold the handle and take the info from it to pass to the renderer on commit. WorkerScriptLoader::CommitCompleted gets a pointer to the handle and calls CompleteWebWorkerPreparation on its host. Refactoring-only. As a result of the refactoring, we no longer make a ServiceWorkerProviderHost for workers whose URL is not a service worker supported scheme (essentially https or chrome-extension). Previously we would make the host but it wouldn't be used because it would have a blank URL as UpdateUrls() was never called on it by the interceptor. Bug: 985259 Change-Id: I999c69f0cb3bc6f37ef854c96322b0774ec84a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712510Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Clark DuVall authored
This was causing users to be in the ForcedOff finch group. See bug for more details. Bug: 985362 Change-Id: I0dfba2f062f51d61bf93d1920931bfeb0a79b639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715424Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680035}
-
Shivani Sharma authored
This CL adds frame origin to the network isolation key created for a navigation resource. Includes tests that enable the feature kAppendFrameOriginToNetworkIsolationKey to test the changes. This also includes a fix that FollowRedirect with a non-empty new_url should use that to create the NIK. Also added a test for that. For this change to be tested properly, it has to be in network_context_unittests rather than url_loader_unittests. Moved all the existing tests to network_context_unittests as well. Bug: 984130 Change-Id: I842ce4b172c0b43bcbe0e5479abe35318437d436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699374 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680034}
-
Jared Saul authored
Bug: 986495 Change-Id: I7dd05b34559aee36129a813993854cda37c54870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713944Reviewed-by:
-
Shakti Sahu authored
This CL adds special handling for .ogg files to be shown in the audio section on download home. Bug: 982090 Change-Id: I10c09f799ea196044f5dfcac31445d3076750dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713870Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680032}
-
Lan Wei authored
In ExecutePerformActions function, we have checked if all the coordinates stored in input_state for all pointers are integers. Right now, we did not clear the states from the previous session, which makes this check fail for some wpt pointerevent tests. https://wpt.fyi/results/pointerevents/ pointerevent_touch-action-keyboard.html?label=master&label=experimental We will add it back once we have added the ExecuteReleaseActions function after running each test in wpt serve. Bug: 606367 Change-Id: Ifda3d57fd8cc0506f713ee26984eb2cbceff02ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713249Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#680031}
-
Richard Knoll authored
The small icon of notifications on L+ are not colored by default. Bug: 986848 Change-Id: If03bfa76c6c389fbdbc07015462638ee4867978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715184 Commit-Queue: Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680030}
-
rajendrant authored
Bug: 985857 Change-Id: I405e210985953effd5b258a1de2c1ce560e2e2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714211 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680029}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/ad0248681e65..0b5bfaebe8ba $ git log ad0248681..0b5bfaebe --date=short --no-merges --format='%ad %ae %s' 2019-07-22 quiche-dev gfe-relnote: Initialize uninitialized private member variable QuicSpdyClientBase::max_allowed_push_id_ 2019-07-22 bnc Fix includes in quic_spdy_stream_body_buffer.{h,cc}. 2019-07-22 renjietang Modify push_promise related methods to prepare for H3 push promise. 2019-07-22 renjietang Clean up build dependency for Qpack streams. 2019-07-22 bnc Split out QuicSendControlStream from quic_spdy_session_lib build target. 2019-07-22 quiche-dev Internal QUICHE change 2019-07-21 vasilvv Hex encode the path challenge buffer. 2019-07-21 dschinazi Fix logging of QuicNewTokenFrame 2019-07-21 bnc Use HttpFrameType instead of int literals in HttpDecoder. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: I824d34ea12cdc6ef8dbe7501e4d67203ea85b596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714627 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680028}
-
