- 17 Mar, 2020 40 commits
-
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: I667692eb3dd172921fec09cf93f66e33cd0a7024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099475Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750896}
-
Kunihiko Sakamoto authored
This reverts commit a471ff9b. Reason for revert: DumpAccessibilityEventsTest.AccessibilityEventsMenuListCollapse* are still flaking on Win7 bots. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100813 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/65070 Original change's description: > Reland "Ensure UI Automation GetFocus reaches focused node in web content" > > This is a reland of 756820dd > > The original CL was reverted due to test failures on Win7. > > On both Win10 and Win7, UI Automation was generating an initial focus > event when the test listener first connects. On Win10, this initial > focus event comes from a window managed by the operating system > (ClassName=ApplicationManager_ImmersiveShellWindow). Since that element > is outside the scope of the test app, the test listener throws it out. > On Win7, the initial focus event comes from an element in our web > content, so the test listener logs it. > > My suspicion is that the difference in behavior is due to mitigations > for focus stealing introduced between Win7 and Win10. Regardless, the > fix is to generate separate expectation files for Win7. > > Original change's description: > > Ensure UI Automation GetFocus reaches focused node in web content > > > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > > node's subtree that currently has focus. When an element in web content > > has focus, and a delegate in Views is asked for focus, that delegate can > > only reach as far as the web content root. Calling GetFocus() again on > > the web content root ensures that the platform API returns the currently > > focused node. > > > > Bug: 928811 > > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > > Reviewed-by: Ian Prest <iapres@microsoft.com> > > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#749386} > > Bug: 928811 > Change-Id: I32e59febfb6dbb7b5386c155c252c880a0f2ebc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101930 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#750781} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I064dad632ef4379f6132e4d1a2f17bd558e8293e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105691Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750895}
-
Ahmed Mehfooz authored
This cl ensures that short notification timeouts are not enabled if at boot the user has enabled Chrome Vox, magnifier, autoclicks or select to speak. Bug: 1059017 Change-Id: I033ea01ee30330a3238bd13f5c94fd21c028734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105763 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750894}
-
Hiroki Sato authored
Previous CL (http://crrev/c/2024635) wired ARC window title to its root node. However, this made ChromeVox announce window title twice. One is from the window title and the other is from a name of the root node. This CL partially reverts the previous change and makes default fallback focus to the window itself. This change also makes only the root window of each ARC task be modal instead of assigning to every root node. Android framework sends only actionable windows to AccessibilityService. Bug: b:150342403 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open any ARC app and title is not announced twice. Change-Id: Ie6527af9b01c03a175517dcfe7d88ca29b4b034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099671 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750893}
-
Fredrik Söderqvist authored
This makes it possible to discern "no valid filter" from "contents does not need recording". In turn this makes it possible to skip the corresponding FinishEffect() call when there's no valid filter. This allows simplifying FinishEffect() and drop the Abort() method on SVGFilterRecordingContext. The call to SVGFilterRecordingContext::BeginContent() is sunk out of PrepareEffect() and likewise the clearing of the invalidation mask is hoisted. Bug: 109224 Change-Id: I440a0d85f93ec0bd0d043a4f3545d793364b9f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105374Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#750892}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c701b5aaf3e3..58bd5d914210 Created with: gclient setdep -r src-internal@58bd5d914210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052382 Tbr: jbudorick@google.com Change-Id: I5ed549b27088659b53a9681015706adce27a1f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750891}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95b327de31c6..a17558c9f702 git log 95b327de31c6..a17558c9f702 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6d7621ab..21cbc653 (395 commits) 2020-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cb9a86a9d867..d24752e63ae4 (10 commits) Created with: gclient setdep -r src/third_party/skia@a17558c9f702 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ib473240da3556efcf63d70c1d07ad7b7af401f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750890}
-
Camillo Bruni authored
The EscapableScope is the related to V8's EscapableHandleScope where a a Local value can be returned to an existing outer HandleScope. This is a preparatory CL to support top-level await modules. Bug: 1022182, v8:9344 Change-Id: Icadad0169977b7c2b2edc266f6884c2094426bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105297Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750889}
-
Eriko Kurimoto authored
This CL fixes the test regarding referrer policy with shared workers. worker.php contains evaluation error because postMessage() is not defined in SharedWorkerGlobalScope, but as postMessage runs after onconnect handler is registered, the evaluation error is ignored and had seemed to be running correctly. Bug: n/a Change-Id: I895bdb54b97122dd6d9828096fc2154fbb6fb2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106043 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#750888}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I43f83a1264087e8a986c3685e0816e519429340c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102534Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750887}
-
Camillo Bruni authored
The new feature flags enables top-level await for JavaScript modules. TC39 proposal: https://github.com/tc39/proposal-top-level-await Bug: 1022182, v8:9344 Change-Id: Icdba59e1b988c636b041d600e6c003bad2dd2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105375Reviewed-by:
-
Dominic Farolino authored
This CL makes HTMLImageElement aware of `crossorigin` attribute value mutations, and respond by invoking ImageLoader::UpdateFromElement if the attribute's state changes. This queues a microtask to finish the image loading steps. This change does not influence the crossorigin attribute state used to influence any image request, because the crossorigin attribute state used to configure image requests (in blink::ConfigureRequest) is already referring to the element's latest. Instead, this change simply invokes ImageLoader::UpdateFromElement (enqueueing an ImageLoader::Task microtask) when an image's crossorigin attribute state changes, even after an image has been fetched. This makes our implementation of the HTML Standard's image element's relevant mutations [1] more compliant, passing more relevant mutations web-platform-tests. See also [2]. [1]: https://html.spec.whatwg.org/multipage/images.html#relevant-mutations [2]: https://docs.google.com/document/d/1Xp34FIbbZnJILl0PNd1sfs_3z1HSriUVyRUgnAesGZk/ Bug: 384251,774706,1061685 Change-Id: I11e66800309df96aea61226932b9aa40c3cc5d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102992 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750885}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d24752e63ae4..a8acd7799b44 git log d24752e63ae4..a8acd7799b44 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 jmadill@chromium.org Roll third_party/zlib/ c2eb8a7f7..156be8c52 (1 commit) Created with: gclient setdep -r src/third_party/angle@a8acd7799b44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Iff86ba4be052c57aea6fb1a7b1bb4ef4142fe522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107134Reviewed-by:
-
Tarun Bansal authored
This is no longer needed with the turndown of Data Reduction Proxy. Change-Id: I1e8a49831ce5ed33b164416c4fc66ddaf0842971 Bug: 1048736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101252 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#750883}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I5c264d586240ddd4b66724f0b7dae82c274224fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107173Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750882}
-
Charlene Yan authored
Records the number of tabs in the current group when a page is loaded. Records 0 if the active tab is not in a group. Bug: 1040657 Change-Id: I0a1cadfd64168f3d4d6362b8e95cc023781f62e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024108Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750881}
-
Hesen Zhang authored
- Implemented proto_conversion for query_tile_entry. - Added unit test for proto_conversion and query_tile_store. - Fixed some lint/nits. Bug: 1060805c Change-Id: Ife1245aa6749ad2e534351c8b66a7e819adf1d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103656 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Josh Simmons authored
Enforce a limit on the maximum number of smbfs shares that can be mounted by request of the user. When the limit is reached, the user will see the message "Error mounting share. Too many SMB shares are already mounted." in the "Add file share" dialog box. Fixed: 1060396 Change-Id: I21467250d7c273d34591f351bc955a4e7d041a45 Test: unit_tests --gtest_filter="SmbServiceWithSmbfsTest.MountExcessiveShares" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100052 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750879}
-
Dominic Farolino authored
This CL fixes a very tricky timing issue I grappled with debugging: I noticed that a non-deterministic amount of the worklet-referrer tests always failed in Chromium when run from the wpt.live site, e.g., https://wpt.live/worklets/paint-worklet-referrer.https.html. This was NOT reproducible locally via any of the following: a.) `./wpt serve` and running the tests in Chromium b.) run_web_tests.py to run them automatically with Chromium I made a dummy WPT PR [1] just to trigger a wpt.live deployment so I could debug my changes in the wpt.live environment, where the tests were failing for some reason. The main referrer test window opens up a bunch of child windows which run a test, and report their results back to the main window IN ORDER. The test were failing for two reasons: - assert_equals: expected "LOADED" but got "RESOLVED" - assert_equals: expected (string) "RESOLVED" but got (object) object "[object Object]" This indicated some type of timing issue between the child windows, and I suspected that one window was reporting back its results when the main window was expecting a different child's results. I dug into the second assertion failure above, logging the "object". It was a timeout object automatically reported by the testharness. This made me think that the child windows were being kept open too long after their test finished, and automatically reported an "extra" timeout object back to the main window, when it was expecting a later child window's results. I finally realized that on line 3, there was a call `add_completion_callback(() => win.close())`, the intention being to close a child window after its test completed. I found in the testharness API docs, that add_completion_callback doesn't call the callback after the test completes, but only after *all* tests complete [2]. This means all child windows were being kept open for the entire duration of the main test. This caused some child windows to report the timeout object to the main window when the server is slow, like on the wpt.live site, but never was reproduced. The fix is to not use add_completion_callback. We could instead use add_result_callback which would work, but it is global, so it would end up attempting to invoke window.close O(n^2) times for O(n) tests (I've confirmed this). The best solution is to plumb each promise_test object through, and add a cleanup callback that closes the child window. This CL implements that. With this fixed, it might save a lot of debugging hours in the future \o/. [1]: https://github.com/web-platform-tests/wpt/pull/22269 [2]: https://web-platform-tests.org/writing-tests/testharness-api.html#callback-api R=nhiroki@chromium.org Bug: N/A Change-Id: Icac7e58a5bfc218a86549f11804b2bc856b815f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103999Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fd33ba2dd8a..aedd57803884 git log 7fd33ba2dd8a..aedd57803884 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@aedd57803884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4443261fc75107bedd040ef96429fa4184ae4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107137Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ad56875dec9..c701b5aaf3e3 Created with: gclient setdep -r src-internal@c701b5aaf3e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibca58fd04a7fc3b2789fc4f42d3ab10cdf1b4c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106925Reviewed-by:
-
Jaeyong Bae authored
This patch means adding unit test to ensure local data is not lost on sign-in. The scenario 1) signed out 2) add local payment methods 3) sign in 4) assert that the local data still exists Bug: 1041111 Change-Id: I030e96592334c2e7a181a18c9906617ea54bce8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094842Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#750875}
-
Andrew Xu authored
When showing home launcher by gesture swipe from shelf, the virtual keyboard may show due to the feature called "transient blur" (which means that if focus was lost but regained a few seconds later, we would show the VK again). So hide the virtual keyboard explicitly in this situation. This CL is for a release-blocking issue of M-81. Add the unit test later. Manually tested on kukui and scarlet devices. TBR=xiyuan@chromium.org Bug: 1057320 Change-Id: I56ef6d8799082d6febe7f48497bc2d2263cd6586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106958Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750874}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b48e62ed204..95b327de31c6 git log 6b48e62ed204..95b327de31c6 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3a50a43df988..440fc9959f06 (1 commits) Created with: gclient setdep -r src/third_party/skia@95b327de31c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I1ad278321468f06d1b038bc5fba11df70fb7b809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106932Reviewed-by:
-
danielng authored
Integrating the UI for Crostini mic settings (cl:2079718) into CrostiniManager. When mic sharing is enabled in the settings UI, CrostiniManager will hence forth allow Crostini to access the mic (this takes effect when Termina is restarted). This is all behind a flag currently, and the UI is based on PM mock-ups (see PRD here go/guestos-mic). Bug: 1016193 Change-Id: I3e0ac16032d1a8b88d91b829703ca166348759c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086359 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#750872}
-
Kai Ninomiya authored
This new isolate excludes blink/perf_tests and almost all of WPT, which are not needed to run these tests. This reduces the isolate size for our webgpu_blink_web_tests steps on CQ, reducing overhead on dawn-win-*-deps-rel from ~8min to ~2min. blink_web_tests: 36M net 920M out 92K testing 1511M third_party 2467M (total) -> 896M zipped webgpu_blink_web_tests: 36M net 920M out 92K testing 60M third_party 1016M (total) -> 272M zipped Bug: 1061273 Change-Id: I210e3a3ab279aa10144d402b4acd86548adb96bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101354 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#750871}
-
Kunihiko Sakamoto authored
This reverts commit 9b8ade13. Reason for revert: Suspected for CrostiniUpgraderBrowserTest.All failure on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4053 Original change's description: > Crostini Upgrader: Do not proceed if user cancels backup > > Previously if the user cancelled the backup, we would proceed with the > upgrade as though the user had elected not to backup at all. > > With this change, the flow will instead return to the initial screen > when the user cancels, rather than proceed. > > Bug: 1061203 > Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#750833} TBR=nverne@chromium.org,hollingum@google.com Change-Id: I7013aeba5b114186425d4279b8ef877c2bddcb79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105664Reviewed-by:
-
Jerome Jiang authored
Since encoder needs decoder, there is only 1 flag now for both. Bug: 1055917 Change-Id: If09ae1eddda2855371599718fda0b8f4372ab44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103318Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#750869}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/93f88af15b3c..2550e967241f git log 93f88af15b3c..2550e967241f --date=short --first-parent --format='%ad %ae %s' 2020-03-17 enga@chromium.org Fix OpenGL over-eager lazy zero initialization for textures 2020-03-17 enga@chromium.org Fix Vulkan over-eager lazy zero initialization for textures Created with: gclient setdep -r src/third_party/dawn@2550e967241f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I998101d7c83a2331c1c5316398b6396aca318021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106930Reviewed-by:
-
S. Ganesh authored
Includes IDL changes and setup. Bug: 1053729 Change-Id: Ia36e527845c17784b761d7ec8bc5b6ee27c99d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106479Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750867}
-
Thanh Nguyen authored
Bug: 1061978 Change-Id: Ia656d1e96c16ae09d00aeb0eabc660b768f0d14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106037Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750866}
-
Jinsuk Kim authored
TabUma is an optional Tab UserData object that keeps track of tab restoring/state transition event, and collects relevant UMA stats. It's instantiated only for the Tab with a notable creation state or restoration results. And a new TabUma object is created every time tab restoration fails, and replaces the old one. With this CL, TabUma is always instantiated upon Tab creation and lasts till the tab goes away. This comes at a cost of having an instance doing potentially no actual work but has a few benefits: - TabCreationState doesn't need to be passed to Tab any more. TabBuilder instantiates TabUma and does the required initialization. - TabUma-related tasks can be moved out of Tab and confined within TabUma class itself using TabObserver events. Now the restoration result is passed to a single TabUma per tab through TabObserver. A new test was added to make sure tab state transition works as expected before and after the CL. Bug: 995903 Change-Id: I8f59bf52542325da06129f76a4a32229cdd9dbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087861Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#750865}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I13d481ca786243348a386bd6b85c27060d9ef0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107140Reviewed-by:
-
Dominick Ng authored
This CL de-extension-ifies ApkWebAppInstaller, and updates its tests to be run over both the extension backend and the new web app backend. BUG=1062145 Change-Id: I6277fc02873eb1b99101cf69eda57db9f332494e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106035 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#750863}
-
Koji Ishii authored
Following bot results are included. 1696 1697 1698 1700 1704 1706 1707 1708 1710 1711 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1736 1737 1738 1739 1740 1741 1742 18 lines were removed and 12 lines were deflaked by consecutive results since 1726. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5becdff55e1644efb999c9dccd8889b77b9d40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100429Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750862}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d7d65c5e8ac..7fd33ba2dd8a git log 2d7d65c5e8ac..7fd33ba2dd8a --date=short --first-parent --format='%ad %ae %s' 2020-03-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fd33ba2dd8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibed47a90b337d622c7a4d215ad59a6f2f5d81054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106929Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/55bf4ea1..ae2152e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75e4c64648871a7d72f009dd7fe48103a9d69685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105777Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750860}
-
Kei Nakashima authored
This reverts commit 32f57805. Reason for revert: I mistakenly add a wrong file. Original change's description: > Added a function |InsertBefore| to NewLinkedHashSet. > > Implemented |NewLinkedHashSet::InsertBefore| and added test for it. > > Change-Id: I987a8c82c329565125d3a42f674b28d18e91ef38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103015 > Commit-Queue: Kei Nakashima <keinakashima@google.com> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750825} TBR=yukishiino@chromium.org,haraken@chromium.org,bartekn@chromium.org,keinakashima@google.com Change-Id: I568bcc2ce4801c57e0e2b4f88f2be93d5e78d226 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106699Reviewed-by:
-
David Munro authored
Bug: None Test: crostini unit tests and browser tests Change-Id: I07aaa9e92881b522d0e533831b44ba13a46b59ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106036 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
-
Noel Gordon authored
Apparently the png was never created but its sha1 was, and that tricks ./translate.py (see bug). Remove the .sha1 file to untrick that tool. Bug: 1062142 Change-Id: I7e01ae2293ae6036118467e6eb29b6e7889043ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106700 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750857}
-
