- 17 Dec, 2019 40 commits
-
-
Camille Lamy authored
This CL removes the provisional DocumentLoader from FrameLoader. This corresponds to the step 8k in the linked doc in the bug. Bug: 855189 Change-Id: I8da13d8556fea3051e9172d9042c50dca565c92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670867Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#725492}
-
Sigurd Schneider authored
This is pre-work for https://crrev.com/c/1969347 Bug: chromium:1025144 Change-Id: I6f3ad4f547e7e4c12cf7b140322f616b07fa88cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969345Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#725491}
-
Philipp Hancke authored
The webcam on the Acer Aspire F5-573g notebook is reported not to work with MediaFoundation. Add it to the blacklist. BUG=1034644 Change-Id: Icbbe4c6ce4e5991f9e46d36217f498567c1c9f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970554Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#725490}
-
Mikel Astiz authored
During recent discussions with UI review, it was noted that the string should be properly capitalized according to Google's style guide. Bug: None Change-Id: I3d0941fceacfd854db3bb9c9cf24f79bcef449dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970014Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#725489}
-
Mathias Carlen authored
Disable flaky test DirectActionAvailabilityWebappTest#testCoreDirectActionInWebappActivity. R=arbesser@google.com Bug: 1033006 Change-Id: Ice0a39c7bcaa3ed56a56d53ae06be016a13b4529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970557Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#725488}
-
Andreas Haas authored
This CL replaces calls to DeprecatedByteLengthAsUnsigned by calls to ByteLengthAsSizeT. Unfortunately the content of the ArrayBuffer is copied into a WTF::Vector, whose maximum size is smaller than the maximum size of an ArrayBuffer. Therefore I reject the incoming ArrayBuffer with a kNotSupportedError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=chcunningham@chromium.org Bug: chromium:1008840 Change-Id: I50ffdc4a53613ec121f7e58a6e0dc6874a936f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954520Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#725487}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. As a consequence, assertions had to be moved and local variables needed to be changed to size_t. There should be no need to check for >32-bit sizes because the existing error handling should be rejecting those already. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=knollr@chromium.org Bug: chromium:1008840 Change-Id: I371fb265ae9e8ec47b94e350574740e78b5d9794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964590 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725486}
-
Andreas Haas authored
This CL replaces calls to deprecatedLengthAsUnsigned by calls to lengthAsSizeT. Unfortunately the content of the ArrayBuffer is copied eventually into a WTF::Vector, whose maximum size is smaller than the maximum size of an ArrayBuffer. Therefore I reject the incoming ArrayBuffer with a RangeError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=toyoshim@chromium.org Bug: chromium:1008840 Change-Id: I35bf42a6a4e7ea010e483ee5853304a7e76eba56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963797Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#725485}
-
Tim van der Lippe authored
Change-Id: I1aba9c3f01af3b1e66976492797e74088c232a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970471 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#725484}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a RangeError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=yhirano@chromium.org Bug: chromium:1008840 Change-Id: I0bc971e990c4d1e10e9a25b02d88e5a127a472b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964492Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#725483}
-
Vasilii Sukhanov authored
There is no proof that there was an error in scrypt. Nevertheless, we should be careful and not encrypt an empty string. Bug: 986298 Change-Id: I4f4e254231aaf0648eb010e97d0c1ba1b7e59fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969992Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#725482}
-
Frédéric Wang authored
The mathsize and dir attributes are defined modulo ASCII case-insensitive equivalence and are mapped to CSS font-size and direction properties [1] [2]. Since the CSS keywords are themselves defined modulo ASCII case-insensitive equivalence [3], there is not need to filter out other (Unicode) case-insensitive equivalent keywords (e.g. "ſmall") in the MathML Code, they will be rejected by the CSS parser. This CL replaces DeprecatedEqualIgnoringCase with EqualIgnoringASCIICase and adds tests to ensure that (Unicode) case-insensitive equivalent strings remain disallowed. [1] https://mathml-refresh.github.io/mathml-core/#global-attributes [2] https://github.com/mathml-refresh/mathml/issues/178 [3] https://www.w3.org/TR/css-values-4/#keywords Bug: 6606 Bug: 627682 Change-Id: Ice84368c8cc7e8fff9faccb454c23fad87b99d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970615Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#725481}
-
Maksim Ivanov authored
Add a test mixin for the TestCertificateProviderExtension class for the sign-in profile force-installed scenario, in order to simplify its usage in browser tests. Unlike using policy::SigninProfileExtensionsPolicyTestBase, this approach allows to reuse this helper in complex tests that involve other components and therefore cannot inherit from that class. This mixin is used in the CryptohomeKeyDelegateServiceProviderTest tests, and will also be used in the future tests of the Chrome OS smart card user login. Bug: 1033936 Change-Id: If004303d68c59c8d3cdcaa185afe4090bec76fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969349 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#725480}
-
Finnur Thorarinsson authored
There's a newer one that handles target density properly. https://developer.android.com/reference/android/graphics/drawable/BitmapDrawable.html#BitmapDrawable(android.graphics.Bitmap) Bug: 656015 Change-Id: Idd90cd3c31669ee954a269646e61b094a631d97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965331Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#725479}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29760046..3b8e5aa3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If8c29fd84d362b667ebf6f1b6ffc024f84cd13c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725478}
-
Alice Wang authored
This CL inlines the static method IdentityServicesProvider.getIdentityManager. Bug: 1032542 Change-Id: I306f6a127ad3bd15f1fd81ed9364986e01418f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967493Reviewed-by:
-
Chih-Yu Huang authored
In general, image format conversion is time-consuming task. ImageProcessor, the interface for image conversion, should offload the conversion tasks to a different thread to avoid occupying the working thread for long time. Originally, thread hopping is handled by each implementation. It makes implementations complicated and error-prone. In this CL, we refactor the structure of ImageProcessor. We add a new interface "ImageProcessorBackend". Each implementation change to inherit this interface. The interface only works on backend sequence. ImageProcessor becomes a concrete class instead of a interface. It has a ImageProcessorBackend instance, and is in charge of handling sequence hopping between client sequence and backend sequence. ImageProcessor also guarantees to call or destroy the client's callback on the client sequence. Bug: 1028889 Test: run vda_tests on kukui and hana Test: build media/gpu/{chromeos,vaapi,v4l2} Change-Id: I0f7774bc62adc7d4b4adf68ab33d95d9013656be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942600 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#725476}
-
Mathias Carlen authored
Disable DirectActionsInActivityTest#testDirectActionsDisabled for now. R=arbesser@google.com Bug: 1034712 Change-Id: Id182a34a3b66dff335228abbb2e2dceda72b4460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970617Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3987.0-1576497572-benchmark-80.0.3987.5-r1 to 81-3987.0-1576497268-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4f84fde9e4528482f7a0388bd79544052bc10f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725474}
-
Christian Dullweber authored
Add the same link that is used in the old cookie blocked UI. Bug: 1033892 Change-Id: I6ecda77d3cafb4cc4326b6e5cd0ec75af9199118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967179 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#725473}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3987.0-1576496920-benchmark-80.0.3987.5-r1 to 81-3987.0-1576494869-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I49510b56b15e2dbab301dd9071d2b33b79893efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971451Reviewed-by:
-
sandromaggi authored
Changes colors and fonts to fit Clank UX definitions. Before: https://screenshot.googleplex.com/5M9tVLfMaOb After: https://screenshot.googleplex.com/GPk7xE35jzq Bug: b/144417635 Change-Id: I6c5ea2598a1f56c8eb8d6abef323170449714cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963802 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/da2f64ae4a74..064614205d70 git log da2f64ae4a74..064614205d70 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 janscheffler@chromium.org Add localized error to selected network rows 2019-12-17 szuend@chromium.org Revert "Let console asserts show up in the test results" 2019-12-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-16 janscheffler@chromium.org Remove line from BUILD.gn 2019-12-16 aerotwist@chromium.org Migrates internal refs of ui/ to esm 2019-12-16 tvanderlippe@chromium.org Let console asserts show up in the test results Created with: gclient setdep -r src/third_party/devtools-frontend/src@064614205d70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1030258 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I564f1d2a1cbefecc861a89875d1b8463f4eaa552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971261Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe75c49875fd59b44b1e746a11d79f66f9e997c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971259Reviewed-by:
-
Virender Singh authored
This CL moves MockRenderThread::IsUseZoomForDSF implementation to be consistent with declaration order. Bug: 1007169 Change-Id: Iae5cc30bd5320a6c1f7780dddd13fafde21b1e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952783Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#725468}
-
Eugene But authored
Remove references from GN to files which no longer exist. Bug: None Change-Id: I4e6f63d3d4daf34bfb5371c716ed059bd0cc8c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969056 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#725467}
-
Sigurd Schneider authored
Previously, blink would react to the v8_enable_raw_heap_snapshots flag, but this flag is about to get deprecated, as the option may be controlled via an argument to V8's inspector interface in the future (takeHeapSnapshot). Bug: chromium:1034504 Change-Id: I9fd6082853ce1e80214f236d5f50bd620bafbbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969579 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#725466}
-
Kuo Jen Wei authored
Focus to confirm button right after entering review video page. Focus to confirm button after play button hidden. Bug: 1020239 Test: Manually test with chromevox. Change-Id: Ibb33be2cc6648bde4c4cc33b11e3411ee42f798a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971299 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#725465}
-
Peter Marshall authored
There are potential ordering problems with sending all messages over the IO session, as it is not associated with the DevToolsAgent mojo interface, like the normal session is. We don't actually need this part to fix the bug we're trying to fix so this CL reverts that part of the change. Bug: 1010534 Change-Id: I8509a283dc454e53275e83f60f3f3c1c0c1df1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967184Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#725464}
-
Oriol Brufau authored
If a marker uses viewport units (vw or vh), they should be recalculated when the size of the viewport changes. This patch updates node traversal methods to include ::marker, so that it's taken into account when updating viewport units. However, this is only fixed for markers with non-normal content, since otherwise they aren't implemented as real pseudo-elements yet. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-014.html The test still fails because it includes cases with 'content: normal'. Change-Id: I7495dd5c4bbd84d6286635a63199bfcc663c62c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970015Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#725463}
-
Benoît Lizé authored
A recent change (see crbug.com/983348) made the allocation of discardable memory return nullptr in some cases, instead of crashing. Skia is not expecting this, triggering a nullptr dereference. This goes back to the previous behavior (crash in case of allocation failure), while the proper fix is to make skia expect a nullptr return value. As a consequence, this fix is temporary until upstream skia is updated. Bug: 1034271, 983348 Change-Id: Idc3937898e897a19ca4e6793ab4e79626fe1b319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968985Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#725462}
-
Ilia Samsonov authored
Manual tests should not flake on win bots anymore. Bug: 993020 Change-Id: Ia9e8109cc062afd43622f319a50e902c7fc4cc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966287 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#725461}
-
Frédéric Wang authored
No behavior change. Bug: 6606 Change-Id: I94cc3088f8aa8d670261a4d9f12293245e8a051b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970611 Auto-Submit: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#725460}
-
Tomasz Moniuszko authored
This fixes testing namespace mismatch in base/test/test_suite.h. Bug: 1033442 Change-Id: Iaa9d621dffc8a5e17d3357e9307f0cf834b23f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963853Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#725459}
-
Sergio Villar Senin authored
We are doing this as part of the removal of individual file dependencies from chrome/browser/DEPS. The web_input_event.h file has many dependencies that could prevent it from moving to public/common (as common cannot depend on other parts of blink). We can remove most of them to the files which actually have dependencies. Bug: 1008303 Change-Id: I51839f97473363ca86132d548ad5882eb17e1013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969673Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#725458}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::WEB_APPS to run using the transport layer when kSplitSettingsSync is enabled and the OS sync feature is on. Manual test: Run chrome --enable-features=SplitSettingsSync,SyncManualStartChromeOS, DesktopPWAsWithoutExtensions,DesktopPWAsUSS Add an account Enable OS sync in the first-run dialog Verify chrome://sync-internals shows Web Apps are syncing, even though browser sync is off. Also added automated tests to sync_integration_tests. Bug: 1013466, 1031549 Change-Id: I2cdb4ccf6b4027ce45044d945f02913482ad239d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970290 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#725457}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3 git log 96354f5047bf..38d7fbaad0a3 --date=short --first-parent --format='%ad %ae %s' 2019-12-16 afdx@google.com spirv-fuzz: Transformations to add types, constants and variables (#3101) 2019-12-16 greg@lunarg.com Make Instrumentation format version 2 the default (Step 1) (#3096) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@38d7fbaad0a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I1c000795bd1a56663a5cd581a3bc5cc19e873fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971258Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates the code using the unsafe static_cast to using the new mechanism to downcast to subclasses of WebUIController, implemented in crrev.com/c/1959199. Bug: 1006361, 1002647 Change-Id: I72797397f0427450b988897335c43903a96dc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962253Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
Now that all the Fourcc producers return only valid instances, we can remove the invalid Fourcc constructor as well as the invalid state itself. Bug: 1031082 BUG=b:143498574 Test: Chromium builds for arm-generic and Eve. Change-Id: Ic603fbe3e8e50a2d88eeaf851261d26021a1358c Change-Id: If3960b8f56269109a15e2f82f39cf456b5b61528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961303 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#725454}
-
Alexandre Courbot authored
ToVaFourCC() is not guaranteed to return a valid value for any of the Fourccs we recognize, so make it return an Optional in case the conversion cannot be performed to force the user to check the returned value. BUG=1031082 BUG=b:143498574 TEST=Chrome compiles on Eve. Change-Id: I6910fccc871bb3baf86ca8ed1431419cfbc7743b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957200Reviewed-by:
-
