- 25 Sep, 2018 40 commits
-
-
Bill Budge authored
- Moves metadata caching messages from RenderMessageFilter to a new Mojo API. - Adds CodeCacheHostImpl to implement the messages in the browser process. Bug: chromium:867347 Change-Id: If8b0181a501ead11a5e0adbeef162b263b3f6ac0 Reviewed-on: https://chromium-review.googlesource.com/1217885 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#594027}
-
Ian Clelland authored
Feature Policy is properly associated with a document, rather than a frame. This series of CLs moves both the feature enabled check and the reporting methods from Frame/LocalFrame to SecurityContext/Document. This mechanical CL renames the existing methods to mark them as deprecated. Follow-up CLs will implement the new methods and change call sites to use those instead. Bug: 888668 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3511a6299c9582175412463d43521c3578db27c2 Reviewed-on: https://chromium-review.googlesource.com/1240857Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#594026}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates Android's ContextualSearchDelegate and the respective unittests away from URLFetcher. Bug: 773295,872875 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifd2f3afd0db3ceaf75f6a8f972259c656ec7db69 Reviewed-on: https://chromium-review.googlesource.com/1221729 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594025}
-
Michael Lippautz authored
Garbage collection needs to be finalized before unsetting the EmbedderHeapTracer pointer. Otherwise, an already running GC may not be properly finalized and the GC is left in a undefined state which the subsequent follow up GCs discover. Bug: 843903 Change-Id: I4dc73005174a1b99dfda96ef379fe62bf5b34dbe Reviewed-on: https://chromium-review.googlesource.com/1243247Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594024}
-
Devlin Cronin authored
ExtensionBuilder has SetManifestKey(), but "version" is pretty common (and fairly core to the extension object), so add a convenience method for setting it. Add a quick unittest for the same, and update a smattering of places that previously used SetManifestKey(). Bug: 832958 Change-Id: I55de79360e698f8f9983c24a0e0d5fdb8b3fff9b Reviewed-on: https://chromium-review.googlesource.com/1242196Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594023}
-
Nico Weber authored
LocationBarViewMac is replaced with a stub for now, since a bunch of tests need a non-null object. Bug: 832676 Change-Id: I71a2baddb540c24bc129141a0f08a1dfc5856aff Reviewed-on: https://chromium-review.googlesource.com/1242135 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594022}
-
danakj authored
Currently both methods branch on making a widget for main-frame or a non-main-frame (but in both cases a local root). Instead have callers to these decide what they are doing, as they already know if they are making a main frame's widget or not, and call the appropriate method after splitting. The result is RenderWidget::CreateForFrame() is not called for main frames, but WebFrameWidget::CreateForMainFrame() is. And RenderWidget::CreateForFrame() is called, along with WebFrameWidget::CreateForChildLocalRoot() for non-main-frames. This makes RenderFrameImpl's interaction with the RenderView and its RenderWidget far more explicit and direct, instead of having RenderWidget pull things off many levels of plumbing from the RenderFrameImpl, when it can use things directly. Some TODOs added about questionable DeviceScaleFactor things, and where we should like to create RenderWidgets in the future, instead of pulling them off RenderView, probably. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: I220a892f6f4a1c9f73f196e31766c07f13bac33e Reviewed-on: https://chromium-review.googlesource.com/1229417 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594021}
-
Aga Wronska authored
A few of the demo setup screens are instances of regular OOBE screens. After resume the information about demo mode is not preserved. It results with resuming screen in regular OOBE flow and can cause error state. Bug: 879291 Test: Manuall + WizardController browser tests Change-Id: I47176b8d0d801141ca05ee710028b9a019f77e54 Reviewed-on: https://chromium-review.googlesource.com/1232953Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#594020}
-
Chris Lu authored
Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: I370379e55e962695a8eabf609972ca5dc39bd211 Reviewed-on: https://chromium-review.googlesource.com/1239535Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#594019}
-
David Grogan authored
Before this, auto margins were always resolved as 0 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38f45a656d993aa12ee5afff720d4db3239bbb45 Reviewed-on: https://chromium-review.googlesource.com/1220398 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594018}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74c179bb9bb9..b36a4816a546 git log 74c179bb9bb9..b36a4816a546 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Add OpenGL line segment rasterization. 2018-09-25 fjhenigman@chromium.org Vulkan: work around vkCmdCopyBuffer bug. Created with: gclient setdep -r src/third_party/angle@b36a4816a546 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I3e9bd5449538329cc8b497355d67757c0c5ab837 Reviewed-on: https://chromium-review.googlesource.com/1243543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594017}
-
Mikel Astiz authored
Now that sessions have their own KeyedService, we can migrate away from ProxyModelTypeControllerDelegate, which was needed before for the subtle reason of avoiding a dependency cycle during initialization of ProfileSyncService. This removes a transitional state and simplifies reasoning about the datatype's state (controller and bridge are always in a consistent state). Bug: 883199 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia52284c8eb61314486807a626580dbe132401051 Reviewed-on: https://chromium-review.googlesource.com/1243086 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594016}
-
rbpotter authored
Fix this test to pass with Polymer 2. Bug: 875452 Change-Id: Ic2f9c38409f3659b0b4cfee7abe51e2ea562903f Reviewed-on: https://chromium-review.googlesource.com/1239717Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594015}
-
Christian Fremerey authored
Add an API to the video capture service that allows observers to register and receive events whenever virtual devices are added or removed. Design Doc: https://docs.google.com/document/d/1CW6wslQFvV9FMIMkpyCzh2TcASr7LLXrawAtlgSecg8/edit?usp=sharing Test: services_unittests --gtest_filter=VideoCaptureServiceDeviceFactoryProviderTest* Bug: 885256 Change-Id: I49dfe298bc4d19d9b4b417ec658b899b4898ce1f Reviewed-on: https://chromium-review.googlesource.com/1237378Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594014}
-
rbpotter authored
- Make cr-input full height of radio button so there is no border area where the hand pointer appears. - Ignore pointer events on link container when disabled. - Fix bug where "----" was considered valid input in pages. Bug: 884603, 887823, 888493 Change-Id: Ie9b7f2c42b12d7e2a7026f405b1a61b774578589 Reviewed-on: https://chromium-review.googlesource.com/1242037Reviewed-by:
-
Xi Cheng authored
1) Change DetermineImageDirectory() from being a private class member to being in the anonymous space; 2) Make RegisterTemporaryImage() early return when there is no image data. 3) Clean up the headers. Bug: 888276 Change-Id: Ib7006121d279bfc8147ad6ae71382a95b94d05be Reviewed-on: https://chromium-review.googlesource.com/1239728 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#594012}
-
Francois Doray authored
This method is invoked when all the frames in a process are frozen. In an upcoming CL, we will empty the working set of a process when all its frames are frozen. Bug: 885293 Change-Id: I3f3d15ccb605d47f71cbfb30dd8e88121c70dbe2 Reviewed-on: https://chromium-review.googlesource.com/1236461Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#594011}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iabb07283ec32b93bd9ec0a4ace317645410c8a64 Reviewed-on: https://chromium-review.googlesource.com/1236932 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594010}
-
Jérôme Lebel authored
Adding item/cell to display a cell with a image on the left, a multiline title and an optional multiline detail text. This item/cell is used in crrev.com/c/1231333 to show sync error from: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3e63bc1501_10_15 See: https://drive.google.com/open?id=1i0FEUwRI4RsRIYYHjxoqFyFxk3q7JfMZ Collection cell catalog: https://drive.google.com/open?id=16G_97-5oZZV1TKrxM3JYqXXISTXn-hTV Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ieb3c5f0fcb814d5d8808a096e2a01d280aafa151 Reviewed-on: https://chromium-review.googlesource.com/1236338 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#594009}
-
Avi Drissman authored
BUG=887925 TEST=WebContentsImplBrowserTest.JavaScriptDialogsNormalizeText Change-Id: Ibea163e5cc8822c427d2278717b5d1c8316d6be4 Reviewed-on: https://chromium-review.googlesource.com/1243226Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594008}
-
Daniel Rubery authored
Currently, the values are all offset by one. The "SUCCESS" bucket in UMA corresponds to the "UPLOAD_SUCCESS" enum value, which makes the top-level metric look okay. But the "UPLOAD_SUCCESS" bucket in UMA is actually the "UPLOAD_CANCELLED" enum value, which is very misleading. Change-Id: I0732ebb0070b064c27d23c1d81c4072220df7725 Reviewed-on: https://chromium-review.googlesource.com/1243667Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#594007}
-
Kevin Strohbehn authored
Bug: 876940 Change-Id: I3838f52b4f2501e488d4c4a9efeb08f1d26b81b4 Reviewed-on: https://chromium-review.googlesource.com/1242455Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#594006}
-
Aaron Leventhal authored
Bug: 889089 Change-Id: I8dccdccb7de9f742cf6657106739039b59fcd824 Reviewed-on: https://chromium-review.googlesource.com/1243584 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594005}
-
Fabrice de Gans-Riberi authored
The sized_buffer mode was renamed to buffer in Garnet. This change keeps the service implementation in sync. See: https://fuchsia-review.googlesource.com/c/garnet/+/201201 https://fuchsia-review.googlesource.com/c/garnet/+/201203 Bug: 874155 Change-Id: I74061afd6e92d0397c286391efbd36f02373008c Reviewed-on: https://chromium-review.googlesource.com/1243569 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594004}
-
Ben Kelly authored
The ashmem_create_region() API documentation indicates the size should be specified in "page-aligned bytes". Bug: 887357 Change-Id: I874914f57408663a380d39d61fddbaf986e6ff24 Reviewed-on: https://chromium-review.googlesource.com/1238673Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#594003}
-
Peter K. Lee authored
This CL rolls MDC components to its origin/stable branch and fixes the BUILD.gn file to contain new files. This CL replaces http://crrev/c/1238472 Bug: 883921 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I421525fd4194cd292004952767753b241cd38da0 Reviewed-on: https://chromium-review.googlesource.com/1241975 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15052410fda2..297caafc5805 git log 15052410fda2..297caafc5805 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 benjaminwagner@google.com [infra] Enable QuadroP400 bots on rack:2 Created with: gclient setdep -r src/third_party/skia@297caafc5805 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I718f199165bcd9d006146790b22ba693dfd951af Reviewed-on: https://chromium-review.googlesource.com/1243604Reviewed-by:
-
danakj authored
So don't try to handle both anymore. DCHECK this is the case. R=dcheng@chromium.org, piman@chromium.org Bug: 720116, 419087 Change-Id: Ia10e77f6c81da37eacb1000ca679d1055b2ea372 Reviewed-on: https://chromium-review.googlesource.com/1239004Reviewed-by:
-
Orin Jaworski authored
This feature param prepares the way for experimentation with new omnibox pedal development. Two pedal suggestion modes are already implemented, ready to be gated by this feature flag. A subsequent CL will hook this feature into chrome://flags . Change-Id: I04ec30cb01308f1e98be87c3bbe18592ee6eb30b Reviewed-on: https://chromium-review.googlesource.com/1235200 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#593999}
-
Tanya Gupta authored
R=ramyan@chromium.org Bug: 882822 Change-Id: I1a70d25d39a927d0a07a2a77420f0b696513c788 Reviewed-on: https://chromium-review.googlesource.com/1241795Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#593998}
-
David Black authored
Per UX guidance, mic should open for both launcher entry points when in tablet mode. Otherwise, we will use keyboard input modality. Later we will also factor in user preference. Bug: b:116509014 Change-Id: I5961f48aa2c8c808dde1a55307e8fd149fabe22c Reviewed-on: https://chromium-review.googlesource.com/1241760Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#593997}
-
Xi Cheng authored
While "Double Pointer" is commonly used in C, let's use (implicit) move semantics in the modern C++ era. Bug: 886957 Change-Id: I15693413a8a2474fb8200fc1778d4f9fe4656905 Reviewed-on: https://chromium-review.googlesource.com/1242298 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593996}
-
Clark DuVall authored
The error handling in WebRequestProxyingURLLoaderFactory was causing some objects not to be destroyed. This now uses a pattern similar to signin::ProxyingURLLoaderFactory. Bug: 888707 Change-Id: I033bd11c4281b238cebeb7924cc334a0264ff3b4 Reviewed-on: https://chromium-review.googlesource.com/1242297Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593995}
-
Robert Sesek authored
Bug: 832676 Change-Id: Ibeba925bbd23e5eb33aeaf748bc2f48161db6a96 Reviewed-on: https://chromium-review.googlesource.com/1243727Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593994}
-
Ryan Harrison authored
Currently if a search term in the PDF text has been broken over two lines by a soft hyphen, find will not correctly identify it as a match. This is rooted in the fact that the result of FPDF_GetText includes a marker for soft-hyphens, 0xFFFE, which causes the match to fail. This CL adds in filtering this character from the text being searched over, so that these matches can pass. This requires changes in the SearchUsingICU method to strip ignorable characters from the string before searching, and correctly converting the results back into the non-stripped index space. Ranges also have had filtering for 0xFFFE added in, so that the highlights created by searching are properly placed. BUG=chromium:788799 Change-Id: I06c8181358cdebe6454c36437065592820637808 Reviewed-on: https://chromium-review.googlesource.com/1234998 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#593993}
-
Eugene But authored
Bug: 887273 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99e171f64a20c7dba9f8984d05cb509b00d01ea5 Reviewed-on: https://chromium-review.googlesource.com/1243166Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593992}
-
sczs authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5775e79501baf6787e86c275ea7dbdbff5f6a5f6 Reviewed-on: https://chromium-review.googlesource.com/1239545 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#593991}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I4d72bf67afb654ee6752c7a3c02a03f9b3c7dc80 Reviewed-on: https://chromium-review.googlesource.com/1242459Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#593990}
-
John Chen authored
This CL is one step in making InitSession command W3C compliant. It expands Capabilities object to include all capabilities that are specified in the W3C spec. Changes include: * Re-ordered fields in Capabilities into W3C section and ChromeDriver specific section. Entries in W3C section are listed in the same order as they appear in W3C spec. * Added browserName, browserVersion, and platformName capabilities. They will be needed for proper firstMatches handling. * Added fields needed for timeouts capability. Parsing and using of these fields will be added in an upcoming CL. * Replaced legacy name unexpected_alert_behaviour with W3C-compliant name unhandled_prompt_behavior. * Modified Capabilities::Parse to accept all capability values, including those not yet supported by ChromeDriver. Added another method Capabilities::IsSupported to check for unsupported options. This is needed for upcoming W3C-compliant capability validation. Bug: chromedriver:1997 Change-Id: I5f53341cf47f77a1853f40028b1efe6f0b69c611 Reviewed-on: https://chromium-review.googlesource.com/1241213 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#593989}
-
Ahmed Fakhry authored
This CL is a preparation for turning the feature on by default. It fixes the following issues: - Editable elements focus change notifications are broadcasted to all listeners from all render view hosts. Handle it only for the active webcontents. - The value of DoBrowserControlsShrinkBlinkSize() should never change while scrolling is in progress. It should also return false when the feature is disabled regardless of the current shown ratio. - A gray patch that used to show at the bottom of the page. We should never set the shown ratio of the browser immediately without asking the renderer to do it first and call us when done. For that we need to defer switching the status to disabled until the renderer calls us with the final shown ratio value, only then we know both the browser and the renderer are synchronized and we can layout the browser view. - The active webcontents can be null in unit tests. - Expose top-controls related fields from behind OS_ANDROID. BUG=867063, 885223, 884453 TEST=Manual, passes existing tests, passes all tests with the feature enabled by default. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3bc7747a745619dd6f789d25a2a1609bbe8f15db Reviewed-on: https://chromium-review.googlesource.com/1217754 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593988}
-
