GitLab

BUG=625646

Review-Url: https://codereview.chromium.org/2569953003
Cr-Commit-Position: refs/heads/master@{#439176}

Convert the preprocessor define to a buildflag
//header defined in //media. The build arg is kept in //build/config/features.gni due to a dependency on WebRTC (described in a comment).

R=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2572883002 .
Cr-Commit-Position: refs/heads/master@{#439175}

BUG=none
TEST=unit tests

Review-Url: https://codereview.chromium.org/2557663002
Cr-Commit-Position: refs/heads/master@{#439174}

BUG=666885

Review-Url: https://codereview.chromium.org/2585453002
Cr-Commit-Position: refs/heads/master@{#439173}

https://skia.googlesource.com/skia.git/+log/99ad164886ba..138ea97c1aca

$ git log 99ad16488..138ea97c1 --date=short --no-merges --format='%ad %ae %s'
2016-12-16 brianosman Add color space to picture image as a creation parameter
2016-12-16 robertphillips Add GM for filtering bug
2016-12-16 reed hide deprecated SkImage::preroll
2016-12-16 bsalomon move src/gpu/batches -> src/gpu/ops
2016-12-16 bsalomon Rename GrTestBatch and subclasses to Op

BUG=673261

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2581253002
Cr-Commit-Position: refs/heads/master@{#439172}

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2579223002
Cr-Commit-Position: refs/heads/master@{#439171}

Update the stings for the first and second run Data Reduction Proxy promos.

BUG=674645

Review-Url: https://codereview.chromium.org/2583633002
Cr-Commit-Position: refs/heads/master@{#439170}

Reparenting the content CVC isn't necessary anymore; it won't be receiving input as the presentation view now captures it, and we can set the CVC size directly, rather than having it inherit the size from its parent view. This was also adding a lot of complexity and makes switching tabs/WebContents difficult.

BUG=673536

Review-Url: https://codereview.chromium.org/2579163002
Cr-Commit-Position: refs/heads/master@{#439169}

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.

There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.

Screen shots are attached in crbug.
BUG=673522

Review-Url: https://codereview.chromium.org/2571553003
Cr-Commit-Position: refs/heads/master@{#439168}

Copy-pasted from Marshmallow 64 bit tester (+ s/MMB29Q/NRD91N/)

BUG=663803

Review-Url: https://codereview.chromium.org/2482793007
Cr-Commit-Position: refs/heads/master@{#439167}

Temporary turn the new SDF algorithm feature off.

See here for more detail.
https://codereview.chromium.org/1643143002

TBR=jvanverth@google.com
BUG=

Review-Url: https://codereview.chromium.org/2581563004
Cr-Commit-Position: refs/heads/master@{#439166}

Clamps the character ranges for which bounds are requested so that they fall within the number of pixel offsets provided by Blink.

Blink doesn't always return the location of all the characters in  an inline text box.
BUG=674273
R=dmazzoni@chromium.org
TESTED=manually using NVDA's Python Console and by calling get_characterExtents(offset, 0) and (offset, 1) on a few paragraphs

Review-Url: https://codereview.chromium.org/2579323002
Cr-Commit-Position: refs/heads/master@{#439165}

BUG=630769

Review-Url: https://codereview.chromium.org/2583683002
Cr-Commit-Position: refs/heads/master@{#439164}

(1) Create SafeBrowsingErrorUI in security_interstitials component. Move
display and command handling logic from SafeBrowsingBlockingPage to
SafeBrowsingErrorUI.

(2) Move all SB interstitial related strings from
c/a/generated_reources.grd to
components/security_interstitials_strings.grdp

(3) Deprecate all interstitial related rappor metrics, since nobody is
using them.

BUG=666100

Review-Url: https://codereview.chromium.org/2575623002
Cr-Commit-Position: refs/heads/master@{#439163}

GpuMain depends on display_compositor in cc, and GpuService depends
on gfx and geometry mojoms.

BUG=643746

Review-Url: https://codereview.chromium.org/2583933002
Cr-Commit-Position: refs/heads/master@{#439162}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1d9e2948..2590cbab

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2577383002
Cr-Commit-Position: refs/heads/master@{#439161}

6 new passing tests, likely from incremental paint property fixes:
https://crrev.com/1ea99b023ae5c0d7a421b2e308fa910aa6bd107c

1 new css blend mode failure, likely from the recent blend mode work.

1 untriaged failure in popup menu positioning.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2579213003
Cr-Commit-Position: refs/heads/master@{#439160}

BUG=672060,672851

Review-Url: https://codereview.chromium.org/2585633002
Cr-Commit-Position: refs/heads/master@{#439159}

To retrieve:
  *all devices: call synced_devices()
  *unlock keys: call unlock_keys()
  *tether hosts: call tether_hosts()

BUG=672263

Review-Url: https://codereview.chromium.org/2561683002
Cr-Commit-Position: refs/heads/master@{#439158}

BUG=674699

Review-Url: https://codereview.chromium.org/2580973002
Cr-Commit-Position: refs/heads/master@{#439157}

ConvertFromI420 to I420 supports destination stride for subrects.
Mips MSA scaling and RGB565 conversion

Change log:
https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d
https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d

BUG=libyuv:662,libyuv:660,libyuv:634
TEST=libyuv unittests pass on try bots.

Review-Url: https://codereview.chromium.org/2580953002
Cr-Commit-Position: refs/heads/master@{#439156}

BUG=none

Review-Url: https://codereview.chromium.org/2584913002
Cr-Commit-Position: refs/heads/master@{#439155}

ImageCursor->SetDisplay() is called in Init() so that all cursors are loaded at
launch. This fixes the bug where the cursor image is positioned off to the left
in Chrome mash.

BUG=615861

Review-Url: https://codereview.chromium.org/2268563003
Cr-Commit-Position: refs/heads/master@{#439154}

This change is intended to have no behavioural changes. Some of the math
is slightly adjusted the root frame coordinates. The root frame
coordinates are calculated via:
A/scale - B/scale + VO + OO
as it was previously
(A-B)/scale + VO + OO

If this is a problem we can store translateX and translateY as the actual
coordinates instead instead a computation.

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG=625684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2539283002
Cr-Commit-Position: refs/heads/master@{#439153}

In preparation for making the icon in Physical Web omnibox suggestions
tappable, add a highlighted version of the icon. This version will be
shown when the icon is tapped.

BUG=630769

Review-Url: https://codereview.chromium.org/2578313002
Cr-Commit-Position: refs/heads/master@{#439152}

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2577123002
Cr-Commit-Position: refs/heads/master@{#439151}

Revert of Support saturation overrides in saturated_cast (patchset #7 id:180001 of https://codereview.chromium.org/2578613002/ )

Reason for revert:
Suspect breaking base_unittests (missing test name in unittest macro).
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38202

Original issue's description:
> Support saturation overrides in saturated_cast
>
> This is a requirement for adding a full saturated type implementation.
>
> BUG=672489
> NOTRY=true
>
> Committed: https://crrev.com/186c7dbbea5eef852bf0c4277d1da16f56f9156e
> Cr-Commit-Position: refs/heads/master@{#439061}

TBR=eae@chromium.org,jschuh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672489,674849

Review-Url: https://codereview.chromium.org/2582063002
Cr-Commit-Position: refs/heads/master@{#439150}

There is a lot of repeated code in other_options_settings.js. Simplify
the code and make it easier to add additional options if needed in
future.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576233003
Cr-Commit-Position: refs/heads/master@{#439149}

This class was moved to  renamed clone of
ios/chrome/browser/ui/network_activity_indicator_manager.* since
//ios/web should not be managing the system wide network activity
indicator’s UI state.

BUG=620887

Review-Url: https://codereview.chromium.org/2566493003
Cr-Commit-Position: refs/heads/master@{#439148}

see https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_devices_manager.cc?type=cs&sq=package:chromium&rcl=1481185182&l=68:

MediaDevicesManager now first asks AudioManager for device names, and then goes back to AudioManager for group ID of each device.
Since AudioManager will be moved to a separate process, we want to minimize the number of roundtrips.

BUG=672467
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563653002
Cr-Commit-Position: refs/heads/master@{#439147}

Implement HandleIntent() and RequestIntentHandlerList()
within FakeIntentHelperInstance.

BUG=633243

Review-Url: https://codereview.chromium.org/2579193003
Cr-Commit-Position: refs/heads/master@{#439146}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7a32fcc6a55e..035bbd33b52e

$ git log 7a32fcc6a..035bbd33b --date=short --no-merges --format='%ad %ae %s'
2016-12-16 dgozman Do not send null preventFling in SynthesizeScrollGesture.

BUG=664683

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2577063004
Cr-Commit-Position: refs/heads/master@{#439145}

For graceful shutdown, this CL introduces OnShutdown
observer callback.
Along with the change, EventRouter now properly calls RemoveObserver
in the callback.
ArcServiceManager::IsInitialized() is now no longer needed. Remove it.

BUG=672829
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2581953002
Cr-Commit-Position: refs/heads/master@{#439144}

The arrow operator is not supported on some old IOS versions.

BUG=674807

Review-Url: https://codereview.chromium.org/2581223002
Cr-Commit-Position: refs/heads/master@{#439143}

This method was now empty and has been replaced by asynchronous active
stylesheet update in updateActiveStyleSheets().

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2559613002
Cr-Commit-Position: refs/heads/master@{#439142}

This CL adds a mechanism to isolate sheet-specific code previously in
PaymentRequestDialog to Controller classes. This will allow for clearer
view creation and event handling as the different sheets in the dialog
are implemented.

BUG=667872

Review-Url: https://codereview.chromium.org/2579513002
Cr-Commit-Position: refs/heads/master@{#439141}

BUG=674858
TBR=junov@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2581233002
Cr-Commit-Position: refs/heads/master@{#439140}

This is part of the migration phase for TaskScheduler, design doc:
https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa5k/edit

Also generalizes BrowserThreadImpl away from the underlying thread's MessageLoop
and id in favor of TaskRunners and BrowserThreadState.

Cool side-effect: BrowserThreadImpl::StartWithOptions() no longer blocks on the
underlying thread starting (it used to via GetThreadId()), it now takes a reference
to its TaskRunner and lets the thread itself start on its own schedule :).
This wasn't previously intended to block (BrowserThreadImpl::StartAndWaitForTesting() is
supposed to be used for that) but had unintentionally regressed in http://crrev.com/408295
because GetThreadId() implicitly waits (http://crbug.com/672977).

Another nice improvement is that ~BrowserThreadImpl() now cleans the BrowserThreadGlobals
associated with it, this has the side-effect to force proper destruction order of
TestBrowserThread in tests which brought forth a few precursor cleanups
(https://crbug.com/653916#c24) which will from now on be enforced by this CL.

When redirection is disabled, the logic should be the exact same as before.
 - Threads are brought up.
 - Tasks are posted to their MessageLoop (albeit through their TaskRunner now).
 - On shutdown, threads are joined one by one.

When redirection is enabled, we try to mimic this logic.
 - Redirection TaskRunners are only live (|accepting_tasks|) for the same period that the
   matching thread would be.
 - On shutdown, we block on each TaskRunner's queue being flushed one-by-one
   in the same order as in the no-redirection case (this almost identical to
   real threads join % one slight difference documented in detail in
   BrowserThreadImpl::StopRedirectionOfThreadID()).

BUG=653916, 672977
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

TEST=
 A) "out\Release\chrome.exe"
    Runs/shuts down the exact same as before.

 B) "out\Release\chrome.exe --force-fieldtrials=BrowserScheduler/Enabled/ --force-fieldtrial-params=BrowserScheduler.Enabled:Background/3;3;1;0;10000/BackgroundFileIO/3;3;1;0;10000/Foreground/3;3;1;0;10000/ForegroundFileIO/3;3;1;0;10000/RedirectSequencedWorkerPools/true/RedirectNonUINonIOBrowserThreads/true"
    Runs/shuts down smoothly and chrome://tracing confirms that redirected BrowserThreads are running on TaskSchedulerWorkers.

Review-Url: https://codereview.chromium.org/2464233002
Cr-Commit-Position: refs/heads/master@{#439139}

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578153002
Cr-Commit-Position: refs/heads/master@{#439138}

Downloads initiated via clicking on an anchor with a 'download'
attribute should behave the same way with regard to cookie handling as a
download initiated via a top level navigation.

This CL adds logic to set the initiator origin for URLRequests initiated
in response to such downloads so that the handling of SameSite cookies
follows suit with top level navigations.

R=mkwst@chromium.org, clamy@chromium.org
BUG=648043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2561903002
Cr-Commit-Position: refs/heads/master@{#439137}