GitLab

After UI review, we decided we don't want to display a confirmation dialog if the user turns off "Let chrome run in the background" when there are no windows open. We'll just silently exit.

BUG=76828
TEST=Install background app, close all browser windows, right click status icon and uncheck "Let chrome run...", should see no confirmation dialog.

Review URL: http://codereview.chromium.org/7064009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=local appengine instance connects via OAuth2 and ClientLogin

Review URL: http://codereview.chromium.org/7054029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86374 0039d316-1c4b-4281-b951-d872f2087c98

We need to call cleanUpDrag() even if there is no data change after the drag (to remove the mask).

BUG=none
TEST=drag a tile onto its own position (i.e. null drag). Resize window to be wider. There shouldn't be any visual obstruction of the tile grid.

Review URL: http://codereview.chromium.org/6992011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86373 0039d316-1c4b-4281-b951-d872f2087c98

(WebCore::CSSStyleSelector::loadPendingImages and WebCore::RenderStyle::hasPseudoStyle)

BUG=83674,83676
TEST=reliability bots

Review URL: http://codereview.chromium.org/7064016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86372 0039d316-1c4b-4281-b951-d872f2087c98

For M12 we experimented with eliding common prefixes in tab titles.

After lots of feedback we've decided to remove this feature.

BUG=83668
TEST=Testing
Review URL: http://codereview.chromium.org/7067007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86371 0039d316-1c4b-4281-b951-d872f2087c98

The gpu blacklist is no longer applied due to a regression.  I decided not to put this fix together with the rest of gpu blacklist logic regression recovering as this is more urgent and simple to fix.

BUG=83639
TEST=gpu blacklist is applied. if a gpu feature should be blacklisted, it will.
 
Review URL: http://codereview.chromium.org/7065012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86370 0039d316-1c4b-4281-b951-d872f2087c98

Fixes bug http://code.google.com/p/chromium/issues/detail?id=83661

BUG=83661
Review URL: http://codereview.chromium.org/6992008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86369 0039d316-1c4b-4281-b951-d872f2087c98

Replace "http" etc with the url_constants version.  This was a previous TODO for webplugin_proxy.cc, and I fixed the other places as well.
Review URL: http://codereview.chromium.org/6990043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76788
Review URL: http://codereview.chromium.org/7067005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86367 0039d316-1c4b-4281-b951-d872f2087c98

fix these two problems:
1. dragging out of the window makes the tab drag representation jump to (0,0)
2. dragging onto a second NTP window results in the tab drag representation appearing in the source window

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6992009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86366 0039d316-1c4b-4281-b951-d872f2087c98

dom-ui sync: Eliminate jank when customizing sync settings. Also, tweak chrome.send message identifiers to that they are less likely to conflict.

BUG=80477
TEST=Invoke 'Customize' sync setings, dialog should fade-in smoothly.
Review URL: http://codereview.chromium.org/7057038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86365 0039d316-1c4b-4281-b951-d872f2087c98

R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7066011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86364 0039d316-1c4b-4281-b951-d872f2087c98

now the chrome logo should always show, but the attribution only shows if the theme has one. I also moved the attribution to the right side because it looks more balanced over there (this didn't break horribly for any of the handful of themes I tested on). Leaving it on the left side, right next to the chrome logo, looks cluttered.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6966022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86363 0039d316-1c4b-4281-b951-d872f2087c98

function "spdy_settings_.Clear()" to the function "void SpdySessionPool::OnIPAddressChanged()".

BUG=55868
TEST="./net_unittests --gtest_filter=SpdySessionTest.ClearSettingsStorage" and "./net_unittests --gtest_filter=SpdySessionTest.ClearOnIPAddressChanged".

Review URL: http://codereview.chromium.org/7046016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86362 0039d316-1c4b-4281-b951-d872f2087c98

Change for preparation for reference-build for PerfBot. PerfBot will be downloading binaries (pyauto.py and its library) for particular build and compare it with current build. This change is preparation for that. It enables media_perf tests to use different binary if reference build option (-a) is used. When the option is set, media_perf_runner runs the test with current build and then reference build (specified by REFERENCE_BUILD_DIR in pyauto_media.py), which I set bogus directory for now.



Review URL: http://codereview.chromium.org/7031020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86361 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zea@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86360 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zea@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86359 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r86333.  Apparently it doesn't work on x64 either.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76232
TEST=Everything sync.

Review URL: http://codereview.chromium.org/6995008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86357 0039d316-1c4b-4281-b951-d872f2087c98

TEST= See https://sites.google.com/a/chromium.org/dev/developers/design-documents/pepper-plugin-implementation for running in Chrome.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1671
Review URL: http://codereview.chromium.org/7049021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Check that Me2Mom still works.

Review URL: http://codereview.chromium.org/7065009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83640
TEST=Manual

Review URL: http://codereview.chromium.org/6992007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Host plugin doesn't crash when started.

Review URL: http://codereview.chromium.org/6961043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86353 0039d316-1c4b-4281-b951-d872f2087c98

Final gyp patch to make use of the new cross-platform POSIX defines toolkit_uses_gtk, os_posix, and use_x11. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence.  Solaris was made to use ALSA also, as libasound has been ported to FreeBSD and Solaris as a wrapper around the native OSS.

Review URL: http://codereview.chromium.org/7055003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86352 0039d316-1c4b-4281-b951-d872f2087c98

Integrated obfuscation with quota; all unit tests now pass with or without the flag that turns on obfuscation.

BUG=none
TEST=unit tests


Review URL: http://codereview.chromium.org/7057032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86351 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86340

Review URL: http://codereview.chromium.org/7065008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86350 0039d316-1c4b-4281-b951-d872f2087c98

- rewrite the mapping from PP_FileOpenFlags_Dev to PlatformFileFlags.
- let ppb_flash_file_impl and ppb_file_io_impl use the same mapping logic.
- CreatePlatformFile: resolve the conflict between the win and posix implementation. Before this change, the win implementation didn't allow PLATFORM_FILE_TRUNCATE to be used with any of the (OPEN|CREATE)(_ALWAYS)? flags; while the posix implementation required it to be used with them.
- add more test cases to test the behavior of different PP_FileOpenFlags_Dev combinations.
- also unify the conversion from PlatformFileError to Pepper error.

BUG=68489
TEST=New test cases in test_file_io.cc

Review URL: http://codereview.chromium.org/7038032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=chrome builds with touchui and chromeos

Review URL: http://codereview.chromium.org/6966020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86348 0039d316-1c4b-4281-b951-d872f2087c98

(base::internal::lockimpl::lock___extensioncontentsettingsstore::geteffectivecontentsetting___content_settings::extensionprovider::getcontentsetting)

BUG=83657
TEST=reliability bots

Review URL: http://codereview.chromium.org/7064007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86347 0039d316-1c4b-4281-b951-d872f2087c98

Note that this code only affects users (developers) who turn on the NaCl flag, and it's temporary code until NaCL is turned on by default.

BUG=81010
TEST=about_flags_unittest

Review URL: http://codereview.chromium.org/7049012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86346 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Review URL: http://codereview.chromium.org/7065008

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/6966021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65874
TEST=Added API test.

Review URL: http://codereview.chromium.org/7042021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86343 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7038012/.

BUG=83062
TEST=PrerenderStatusManagerTests, PrerenderBrowserTests

Review URL: http://codereview.chromium.org/7060012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86342 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Review URL: http://codereview.chromium.org/7065008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86340 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderContents::Destroy() is called in response to
TabContents destruction.

Re-enables PrerenderBrowserTest.PrerenderHttpAuthentication,
which ran into the issue on ChromeOS.

BUG=82835,82913
TEST=PrerenderBrowserTest.PrerenderHttpAuthentication on ChromeOS

Review URL: http://codereview.chromium.org/7017014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86339 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to regression of Autofill preferences pane.  See bug 83629.

BUG=82868, 83629

Review URL: http://codereview.chromium.org/7038024

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83638
TEST=none
Review URL: http://codereview.chromium.org/7063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Connections still work.

Review URL: http://codereview.chromium.org/7067002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7045020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83438
TEST=none

Review URL: http://codereview.chromium.org/7038045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86334 0039d316-1c4b-4281-b951-d872f2087c98