- 12 Jun, 2020 40 commits
-
-
rajendrant authored
Bug: 1053696 Change-Id: I5888a658babb384833873b1ef54e5c9466af10e0 TBR: robertogden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244193Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#777986}
-
James Cook authored
This reverts commit 29ca85f8. Reason for revert: Seems to cause flaky analyzer step failures on https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel Example: https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/568950 Exception: Failed to open ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html while trying to flatten ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html. (No such file or directory) Original change's description: > [CrOS settings] Add bluetooth_pairing_dialog resource files > > Split bluetooth_pairing_dialog resources into > bluetooth_pairing_dialog_resources.grd > and bluetooth_pairing_dialog_resources_vulcanized.grd > > Bug: 1090882 > Change-Id: I0d9855aaaf21db900f27f92b7b38d7ab1daac18a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239147 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777891} TBR=sky@chromium.org,khorimoto@chromium.org,tjohnsonkanu@google.com Change-Id: I4af97b356a782dcb6cb88472d8528c54350e9871 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243855Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#777985}
-
Dominic Mazzoni authored
Without this, they won't appear in the dashboard. Bug: 992074 Change-Id: I1792d7b2a2b1bb280fb5deef319cdc2ff46bafd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242116Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#777984}
-
sczs authored
Check Bug for more context. Bug: 1094467 Change-Id: I8e1182e83b7c0e52a05196c2821f0e33bf953c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243732 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#777983}
-
Vincent Boisselle authored
When using the feed header menu mSectionHeader.toggleHeader() has side effects needed by the subsequent steps to set the SectionHeader data model before updating the SectionHeaderView through updateVisuals(). Bug: 1094437 Change-Id: Id539e2f060398cde9b8319bf6d791e032202a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243601 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#777982}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I48373df609cd406f0282751e10dcf981d5879853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777981}
-
Jia authored
This is following an accessibility and UI review request. Bug: 1068851 Change-Id: I64d35e3f2254f5a597d2d67a579cc323a7c57ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241363Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777980}
-
Anastasia Helfinstein authored
Per the request of UI review, changing the back button for the Switch Access action menu to be a close button instead. Screenshot of the updated UI: https://screenshot.googleplex.com/pdygC1X43na AX-Relnotes: n/a. Bug: 1094415 Change-Id: I066ea888d9bf092a8fdd84846658cedfc4a9288a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243581Reviewed-by:
-
Moe Ahmadi authored
Change-Id: Iaa3a5b3a452e67aab6af4eccb4b1a4ce4f5335e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242746 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#777978}
-
Sinan Sahin authored
Since we started caching the animations to clean-up on destroy, we've been keeping the Animator instances once they're created. This ignores the colors passed in #show and #updateContent, also keeps using an old status bar color. The fix is to simply remove the if null checks to create the Animators. Bug: 1094373 Change-Id: Ibf6de0c66626f3a9fe7f58214d765d18696530f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243493Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#777977}
-
Lei Zhang authored
HandleMessage() has gotten a bit too big. Move many message handlers into their own methods. Change-Id: Icc117a1056fdebe839b26defe3481b5416f0e014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242587Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#777976}
-
Garrett Beaty authored
The current state of the main console does not match what is desired by the sheriffs and will need to be updated, so these consoles provide an overview of the CI builders that can affect the health of the CQ like the main consoles currently do. Change-Id: If04339aa0a74a16bf566367d2d0cc355c8c2aef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242192 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#777975}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5c9f7af77d0e..1663b1d04df9 2020-06-12 brandon1.jones@intel.com Make D3D12 Fuzzer Only Build On Windows 2020-06-12 yunchao.he@intel.com Vulkan: use one barrier if we can for non-pass operations 2020-06-12 cwallez@chromium.org Don't store unnessary SubresourceRange members in TextureBase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic3ebea7906a8678c7b333c07c7aa8c2fae84a7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243458 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I874464a4548fb6be0dc2a9fca265f89eafb2d105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243492Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#777973}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/660b9dfbe395..80d38188db27 2020-06-12 brgoddar@microsoft.com Grid: Add settings for grid highlight config behind experiment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7f00ec51cca97e041c502f9764a1e52002367a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241297Reviewed-by:
-
Garrett Beaty authored
Further adjustments may be required once branch sheriff responsibilities are clarified and a more maintainable solution can be crafted. Change-Id: I30df4e95e9d57c6b330f4d75af0e31c35500efa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243712 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777971}
-
Hazem Ashmawy authored
Crash keys can be absent (null) in some cases like if it's a crash from an old version. Switch statements in java assume non-null values which causes NPE when checking for channel info on old crashes. To avoid this , we will use getCrashKeyOrDefault method. In addition, always show crashes if they are from UNKOWN/DEFAULT channel to avoid hiding crashes from older versions. Fixed: 1093898 Test: Build default channel, trigger a crash. Test: Manually remove channel info from log file and open the crash UI Change-Id: I1a445d59a267cb7f41b400b36caa7bf7a31296e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243291 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777970}
-
Jun Kokatsu authored
This change groups tests of Trusted Types for WebUI into 10 WebUI pages per test to minimize the size of the file. This change also fixes a bug where `CallJavascriptFunction` might be called before allowing JS. See: crrev.com/c/2242372 Bug: 41905 Change-Id: I5f28e056ca3bcb3f39678e2b6009e66316848322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242656Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777969}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591977558-7170645d7cf66fa796ff151165a33077272cf120.profdata to chrome-mac-master-1591991989-bc016108b2b5e29558a9e9ceecfec9b523f83fb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I096c4097a7e99739babf900e02b35d607304372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243467Reviewed-by:
-
Sahel Sharify authored
This cl sends the merchant provided updated payment details (in response to a change event) to the invoked native payment app. Change[PaymentMethod|ShippingAddress|ShippingOptions] calls with invalid arguments are responded immediately with a blank bundle only containing the error message. Bug: 1026667 Change-Id: I458120ecaf328140bd711c8e26e41978c71fe9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240048Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777967}
-
Peng Huang authored
Bug: None Change-Id: I89d721e8dc5f1ad322ba1ecea0b45c0e4b97d5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242040 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777966}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I839e5f0c35af8b3a84384a2004409e468d83e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241296Reviewed-by:
-
Ian Kilpatrick authored
Previously we'd always miss the layout-result cache if a sub-tree had an orthogonal root present. This was required as we didn't store the ICB size on the constraint space, so we couldn't determine if this subtree actually needed layout or not. This caused a 2^dom_depth layout explosion for FlexNG. As FlexNG is our first multi-pass layout, always missing the layout result cache in these cases caused extremely long layout times. This patch removes this cache-miss, by instead marking all the writing mode roots as needing layout if the ICB size changes. Bug: 1092747 Change-Id: Iaa58d00d6184ad30554ffb9fdf8c2b68fad40623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242378Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#777964}
-
Scott Violet authored
BUG=1087464 TEST=getAndRemoveBrowserPersistenceIds Change-Id: I3a7cb7da302f91a92353a5a19c07d558d2ebbe6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242683 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777963}
-
Domenic Denicola authored
Now that I've written a bunch of them, I'm confident in building some abstractions to deduplicate the testing code. This additionally adds jsdoc documentation for all of the exported functions in helpers.mjs. Bug: 1042415 Change-Id: I3e2220708f4d5afff5a815de876971db3f689826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229435Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777962}
-
Daniel Cheng authored
base::SequenceBound uses alignof(T) to calculate the alignment requirement for the stored type; however, alignof(T) can be smaller than sizeof(void*) (e.g. for a class with no fields or virtuals). Clamp the alignment parameter at a minimum of sizeof(void*) to ensure the preconditions for calling AlignedAlloc() are not violated. Change-Id: I3e2126b70472181ada6e7a60280db1b656b9bff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242972 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777961}
-
Miguel Casas authored
VA-API offers "normal" and "Low Power" encoding ("entry point", in libva parlance). Certain platforms such as JSL/TGL only offer Low Power ones. VaapiTest.DefaultEntrypointIsSupported verifies that the default entry point is among the supported ones. For that it calls VaapiWrapper's GetDefaultVaEntryPoint(). However, the low-power/normal decision is not there, but near its callsite in VaapiWrapper. This CL moves the low-power encoding entry point decision logic to VaapiWrapper::GetDefaultVaEntryPoint() so the test sees the same thing as the actual production logic. Bug: b:158713599 Change-Id: I477c86a3a1c36a8c0a3598a7406944bae8341249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243268Reviewed-by:Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#777960}
-
Frank Tang authored
Cherry-pick pull/1152to fix minimum group digits Needed to fix Minimum Grouping Digits for Intl.RelativeTimeFormat Add ability to use locale default for minimum grouping digits - patches/grouping_digits.patch - upstream PR: https://github.com/unicode-org/icu/pull/1152 - upbstream bug: https://unicode-org.atlassian.net/browse/ICU-21109 https://chromium.googlesource.com/chromium/deps/icu.git/+log/46f53df..9e7dae8 9e7dae8 Cherry-pick pull/1152to fix minimum group digits e4b8586 Remove *.mk files which no longer exist c981f19 Sort the list in the filter files w/o changes All these three has no dat size impact. Bug: v8:10443 Change-Id: I3b4e32fae2e50c804bc906c5e279f198b35ad752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242745Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777959}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b64ecd9960d5..6f727da62bb0 2020-06-12 handellm@webrtc.org Revert "RtpTransceiverInterface: introduce SetOfferedRtpHeaderExtensions." 2020-06-12 mbonadei@webrtc.org Clobber x86 win bots. 2020-06-12 mflodman@webrtc.org Search and replace gendered terms according to style guide: 2020-06-12 sprang@webrtc.org Adjusts allowable thread count for vp9 decoders. 2020-06-12 danilchap@webrtc.org in AV1 Encoder remove hack of removing temporal delimiter OBU 2020-06-12 titovartem@webrtc.org Revert "Generalize NetworkQualityMetricsReporter to support multiple peers in test" 2020-06-12 nisse@webrtc.org Delete MediaTransportFactory from android and objc apis 2020-06-12 kron@webrtc.org Add decoder support for VP9 profile 1 I444 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051821 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ce7966a40274a7b07b0e6a89f2321ecb6fd48b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243169Reviewed-by:
-
Angela Yoeurng authored
There was no case to handle KeyEvents for the Button Row buttons previously. This was added so Enter and Space will trigger the button's actions. This CL moves some of the business logic to PopupModel, merging the handling of Mouse/ButtonPressed events and Key events Keyword entry method was also changed to Tab rather than Keyboard shortcut. Bug: 1091351 Change-Id: I2818e47860d8993bbb99836c40d60197b8ef7e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233780 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#777957}
-
Jarryd Goodman authored
Change-Id: Ieb7efb546b20c35f2711cc3c05f85165f7b93767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243457 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777956}
-
James Long authored
Rough code, mostly copied from wnwen's visualization, as a framework for future visualization work. It is forecast that this code will be restructured heavily in the future, hence the lack of more thorough documentation. npm is used for this project, please read the README on how to run locally. The dependencies so far are: - ESLint - d3 (however, as we continue to identify what is required, I plan to break this up so we only import the v4 microlibraries we actually need) The page is currently served the JSON file via a small Python script. This is easy to use for development, but will hopefully be replaced with either a user file upload or being served from somewhere else. Bug: 1093962 Change-Id: I8d35ae2cde64581ff7d22fb06a29cd850e42cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242171 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#777955}
-
Andrew Grieve authored
Allows us to remove special-casing in java target name patterns. Bug: None Change-Id: I5377b75ea8539194fbf0b88f646ac8869d8fc062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243261 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777954}
-
Hazem Ashmawy authored
This reverts commit 1a25897e. Reason for revert: Mitigate crashes caused by the change Original change's description: > [AW] Keep the MetricsBridgeService running while having active tasks > > Although MetricsBridgeService has a sync AIDL interface where all its > calls block till they finish, recordMetrics does it job > asynchronously behind the scenes where it posts the actual recording > task to a background TaskRunner. This may result in some rare cases > that the service may be killed by the system (because all clients had > unbound the service) while still having some writing tasks in the > background that haven't finished yet. To solve this: > > - Make SequencedTaskRunner static so that all service instances > created by the system will share the same task runner avoiding, > possible race conditions writing to file. > - Make the service both start and bound service. The service will > start itself with the first client binding and it will manage its > own lifecycle to ensure that it stays running until it has finished > its writing tasks. Service will not be destroyed by the system until > all clients unbind and the service calls stopSelf() > See https://developer.android.com/guide/components/bound-services. > > There is no evidence that this actually happens and there is no > reliable way to reproduce this in tests but this is still a potential > bug that should be fixed. > > Fixed: 1082572 > Test: /bin/run_webview_instrumentation_test_apk -f "*MetricsBridgeServiceTest*" > Change-Id: I5e8e9226379f4b2b38f8b720405f78603ae2b3c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235597 > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776763} TBR=ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1093300 Change-Id: Ibb65885ddfb223e32c0d83fa4f28faa26aad8ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241838Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#777953}
-
Kyle Ju authored
It will read the comment history and dump all comments to https://chromium-review.googlesource.com/c/chromium/src/+/2241634/. Also tweak the Gerrit CL SHA so that the SHA is unique identified to each CL. Testing command: third_party/blink/tools/wpt_export.py --credentials ~/.credentials --surface-failures-to-gerrit Output: https://chromium-review.googlesource.com/c/chromium/src/+/2241634 Bug: 1027618 Change-Id: I3a4932524488072cdbb820ccabdd4dd9a079cd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242001 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#777952}
-
Daniel Murphy authored
This adds sync tests for the following cases: * Installing the same app independently on two different profiles * Above, but then uninstalling on one profile. * Syncing of user display mode between profiles * Installing a non-syncing app, then installing a sync version on the second profile, and verifying that the first installation is now syncing. * Unsynced apps are not synced * Local installation parameters override sync parameters (app title) The following bug is uncovered by these tests: * Installing an app on two profiles, and then uninstalling on one, can lead to inconsistent results (not just the racy who-wins - one profile could end up with the app installed, while the other has it uninstalled, even after sync runs). https://crbug.com/1091867 Bug: 1025156 Change-Id: I9b22b84ade5dbe82b43127d30f9426923fc8b251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231283 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#777951}
-
Yoshifumi Inoue authored
This patch moves |EndPositionForLine()| template function before template parameter class to use |EndPositionForLine()| for preparation of [1]. [1] http://crrev.com/c/2139612 EditingNG All-In-One Bug: 707656 Change-Id: I19a95ad805d2ace4e0bc704a8d39c983d830392f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241068 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Robert Flack authored
This reverts commit 10be77c2. Reason for revert: blink_web_tests failing webaudio/Analyser/realtimeanalyser-fftsize-reset.html Example failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51317 https://test-results.appspot.com/data/layout_results/Mac10_11_Tests/51317/blink_web_tests/layout-test-results/results.html Original change's description: > Use SIMD for the main loop for k-rate Oscillator > > The main processing loop for the k-rate Oscillator is updated to use > SSE2 instructions to speed up processing. > > Four tests fail because we have slightly reduced accuracy. Testing > shows that the loss of accuracy is due to using a float for > virtual_read_index in the loop instead of a double as previously. A > implementation using a double passes all the original tests but does > show that it does lose performance. I think the change in accuracy is > acceptable. > > WebAudio Bench results from a linux machine. In summary, the SIMD > version is about 60% as much time (about 1.75 times faster). > > Without CL: > TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV > Baseline 713 713 748 757 766 877 760.25 18.35 > Oscillator 949 949 972 990 1005 1132 990.78 24.35 > > With CL: > TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV > Baseline 728 728 747 756 763 908 757.46 16.81 > Oscillator 521 521 549 564 581 874 566.87 27.77 > > Bug: 1013118 > Change-Id: I2d1cb14f47db32e27d8baf79fb015885ba6b1eb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229639 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777865} TBR=dalecurtis@chromium.org,rtoy@chromium.org,hongchan@chromium.org Change-Id: I68e94bbf15de74332f0a0c0fa4f83aa5fbcb7f06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243536Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777949}
-
Josh Simmons authored
This is a bloom filter over fast hosts. Also updating PerformanceHintsObserver to check this type if no hint was found in link hints or page hints. Apologies for the large change count in the unittests. This is mostly due to rearranging tests and adding a using statement for ::testing:_. Bug: 1087123 Change-Id: Ie25145f28354a17955b16b87ebb6c36601b23ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238357 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777948}
-
John Abd-El-Malek authored
Move SubprocessMetricsProvider from chrome to components/metrics so that it can be shared with WebView and WebLayer. Renderer metrics are still not working, but this is a precursor. Keeping it separate so it's easy to review. Bug: 1090682 Change-Id: I3546c684f7b0eded7545e60422ba65b7f1b44898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242235Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#777947}
-
