- 11 Sep, 2019 40 commits
-
-
Anthony Vallee-Dubois authored
Bug: 976352 Change-Id: I9e125f2a7d2dfe24691e8097623cbc65866fe353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796002Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695796}
-
Andrew Grieve authored
Bug: 1000382 Change-Id: I5af4f79b7092c1ad9e459f4f2401e19e08139288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797174 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#695795}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7e2441234b94..a1727db1acca git log 7e2441234b94..a1727db1acca --date=short --no-merges --format='%ad %ae %s' 2019-09-11 harimb@google.com Revert "Add support of AudioRecord.Builder in the ADM for Android" Created with: gclient setdep -r src/third_party/webrtc@a1727db1acca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I93fb3c110c17db4eb55050ec3bddd42e5e2c2fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695794}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4a9804e2. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/linebox NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie688514c5d7d1690b80b57123dd18ef9173c628d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799083Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695793}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/shape_detection. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: Ic6a5245d25a2a75218813cbb33670842a1140ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786681 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695792}
-
Alexei Filippov authored
The stack traversal call seems to be long enough causing blocking other threads from execution. BUG=1002285 Change-Id: I24980c72d5fcddd395eaaaab4e7fba32563c250c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797322Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695791}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/53f6b23..faee8bc faee8bc Fix Hungarian number format. Bug: chromium:992694 Change-Id: I2cb0d74607a1331ef9df76607ff3f63f4009046f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798885Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695790}
-
Jacob DeWitt authored
Per guidance from the UI team, these types of dialogs should only have yes/no equivalent buttons. They should not have an 'X' close button at the top right corner that allows the user to ignore the dialog without making an explicit decision. Dialogs that no longer have an 'X' button as a result of this change: 1) Asking user if they want to enter a WebXR session. 2) Confirm form resubmission dialog. 3) Chrome extension asking for permission to download a file. 4) Page asking for directory access. Bug: 985017 Change-Id: I109f5bc7d5e493f16170b9ab3599e7d7dd647c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797093Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695789}
-
Ionel Popescu authored
This reverts commit 21feee22. Reason for revert: unblock <select> menu doesn't close on scrolling the page using touch on ChromeOS Original change's description: > Fixed popup flicker effect for select dropdown. > > The current behavior for a popup is to destroy it, create it and destroy it > again if the element which was clicked/tapped was already owning the popup. > This behavior is causing a flicker effect when animation/drop shadow is added > to the popup. > > This behavior can be changed to just store the popup, send the event > to the element and later destroy the popup if needed. > > The popup will be destroyed in the following cases: > 1. when another element which could open a popup was clicked/tapped > - WebViewImpl::OpenPagePopup is going to call CancelPagePopup > 2. when the user has clicked/tapped outside of the popup or on the element which > had already a popup opened - by checking if the saved popup is > the same as the current one > > Because of the way EventSender::HandleInputEventOnViewOrPopup is implemented > adding a web_test will not be able to test the impacted scenarios: a popup > should be dismissed when clicking outside of its area and another one should be > opened when clicked/tapped on an element which supports having a popup > (if first popup owner != second popup owner). > Currently EventSender::HandleInputEventOnViewOrPopup will always send the input > event to the popup if there is one. The real world implementation is that the popup > will not receive the event if the click/tap event is outside of its area and the > WebView is responsible for dismissing it. > > Bug: 992238 > Change-Id: I13b7848e6e734e981d4fb9782e68a3d8123bc5ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745769 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#693370} TBR=avi@chromium.org,chrishtr@chromium.org,tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992238, 1002020 Change-Id: Idbcc637e2f004ed09bb6cca2324a49fe8709110f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797059 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695788}
-
Reilly Grant authored
This change configures the WakeLock feature as an Origin Trial. Since the Origin Trial and Runtime Feature infrastructure has been merged generation of feature_policy_helper.cc needs to depend on runtime_enabled_features.json5 to avoid incremental build failures. Bug: 257511 Change-Id: Ifd8ad0053b88b6701bb5ba3e58a93490fef49d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797825Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695787}
-
Stephen Martinis authored
This is a reland of bd916257 Original change's description: > Switch mac_chromium_compile_db_ng to builderless > > Bug: 999206 > Change-Id: I91c01200552c4170ac6d18badd5bdd113396526d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792461 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694874} Bug: 999206, 956776 Change-Id: I9fa138a8fa53073b46d69c0322ada905533f8374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796630 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#695786}
-
Yasmin authored
Bug: 995256 Change-Id: If5f6a1130860e091c9610e2e6ec21150748aa830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787326 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#695785}
-
rbpotter authored
- Split Polymer related externs into a separate pending_polymer.js file - Remove externs for IronIconsetSvg and use IronIconsetSvgElement directly instead. The Polymer related externs cause compiler errors when pending.js is included for Polymer 3 targets. Bug: 965770 Change-Id: Ibbef711a85463eab3e86b027a31e10f7a2324a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797165 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#695784}
-
Piotr Bialecki authored
The phone-ar-plane-detection-anchors.html is mostly a copy-paste of phone-ar-plane-detection.html with minor changes to leverage anchors API. Change-Id: I96a8a02e67dade63030d425dc2c3e58088bf253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796524 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#695783}
-
Ryan Sturm authored
This CL replaces the behavior of sampling the 10 largest links on the page with beahve to filter entire pages via UKM event filtering. We set reasonable limits on the repeated evets (10 for clicked, and 40/100 for anchor elements). The 40/100 is inherited from the renderer, which only sends that many metrics to the browser. Bug: 1001593 Change-Id: If12e30e1a2cf50cb3975f5bc3749faac4534e241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797329 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695782}
-
Mohamed Heikal authored
trybot_commit_size_checker.py is used by the binary size trybot to do the heavy lifting with regards to checking regressions. This cl adds some extra metadata to the json output of the script that would allow a gerrit plugin to display said metadata directly on the gerrit cl page. Bug: 921090 Change-Id: I75486a3548931dae5a0bf5cd76c287023dc8da2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795633 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#695781}
-
Kevin McNee authored
Portals should not receive input, which includes any child frames of a portal. This behaviour regresses with VizHitTestSurfaceLayer, so we include a new test for this. Currently, it only runs for the VizHitTestSurfaceLayer disabled case until this is fixed. Bug: 1002228 Change-Id: I2cf81bc62bcddda2eb4fa42f0d24d2d5865ff1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795494Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#695780}
-
Ryan Hansberry authored
This code was written with the assumption that the key label of the AuthorizationRequest sent to cryptohome while creating easy unlock keys be empty, in order to act as a wild card. This CL always passes an empty an empty key label to that AuthorizationRequest, instead of using the copied label of the |user_context_|. Bug: 1002336 Change-Id: Icfccf46ed479a1e7a29e8d09837e1223d62a4caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797205Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#695779}
-
Meilin Wang authored
This change adds logic to check for the device lid state by observing the lid state switch when DSP is enabled, and stop DSP from recording when the lid is closed. In this way, the Assistant cannot be waked up by voice queries when the lid is closed. Bug: b/139313417 Test: run unittest in this CL. Change-Id: I1765db4f16e43ac7a5de71acde9dff253be8f363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758991 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695778}
-
Daniel Clark authored
Change UIA LocalizedControlType of <header> from "banner"/"group" to "header" for all scopes per https://w3c.github.io/html-aam/#el-header and https://w3c.github.io/html-aam/#el-header-ancestorbody Change UIA LocalizedControlType of <footer> from "content info"/"group" to "footer" for all scopes per https://w3c.github.io/html-aam/#el-footer and https://w3c.github.io/html-aam/#el-footer-ancestorbody To achieve this, introduce the new ax::mojom::Roles: kHeader, kHeaderAsNonLandmark, and kFooterAsNonLandmark (kFooter already exists). The extra roles are necessary because the mappings for <header> and <footer> change based on their position in the document. kHeader and kFooter are identical to kBanner and kContentInfo respectively, except for their LocalizedControlTypes. kHeaderAsNonLandmark and kFooterAsNonLandmark are identical to, kGenericContainer, again with the exception of LocalizedControlType. TBR=stevenjb@chromium.org Bug: 996457 Change-Id: I3f061c8a47c9e04bc22af26b2cda865eef69fc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763243 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#695777}
-
Yue Ru Sun authored
Change-Id: I2d5ad7fcf8cf9ee45ead9ee4d2e3ba56e93ec387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796644 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Auto-Submit: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
-
Tatiana Buldina authored
Update ScrollElementRegionIntoViewHelper() to look for kElementClickIntercepted instead of kUnknownError. Reason was in https://crrev.com/634697 which changed VerifyElementClickable() function to return kElementClickIntercepted instead of kUnknownError. Bug: chromedriver:2856 Change-Id: Ic2eee972663df9163e6fa6c56adcca1512e14efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797706Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695775}
-
Owen Min authored
A report may be separated into multiple requests when it's too big. Bug: 956237 Change-Id: I3c888c8d01d064d247c146079f8d1cfcb7662bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795805Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695774}
-
Rohit Rao authored
DCHECKs crash the running XCTest without producing any useful log output. Instead, switch to XCTAssertTrue() so that an error message will be displayed when bots are misconfigured. BUG=1002739 Change-Id: If902ea15e2b89090fcd355ad7bfb04828e71561a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799082 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695773}
-
Changwan Ryu authored
Also, this CL fixes settings and a typo. Bug: 994939 Change-Id: Ied967e8a15f6c1a83ca5947d5a569d0c66a8191c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797325Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695772}
-
Rahul Arakeri authored
This CL fixes an issue with the print dialog scrollbars being unusable due to hit test failure. In ScrollBegin, when the scroll_node is being set up, IsInitialScrollHitTestReliable returns false. This leads to the scroll_node remaining unset and hence scrolling fails. Bug: 996540 Change-Id: I77c79ff079766b351f1a2068a19b774a98f80b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764901 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695771}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba36ee78262a..3c70f9acfc33 git log ba36ee78262a..3c70f9acfc33 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 nigeltao@google.com Add a GifTest for the Haeberli hack 2019-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-11 benjaminwagner@google.com Omit benches that time out on Pixel3a Created with: gclient setdep -r src/third_party/skia@3c70f9acfc33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I6cd515a838d00c7322c72f22548b59d26cf32715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797494Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fc09aa89b962..d195c8eb28db git log fc09aa89b962..d195c8eb28db --date=short --no-merges --format='%ad %ae %s' 2019-09-11 dberris@chromium.org Pinpoint: Always send email on issue updates Created with: gclient setdep -r src/third_party/catapult@d195c8eb28db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: None Change-Id: I50f8d440cfa30f62938f08a4dc811e6c294e4449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799027Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This reverts commit b6532ab4. Reason for revert: likely caused CI test failures. crbug.com/1001970 Original change's description: > Reland "Enable flag TabToGTSAnimation by default" > > This is a reland of a90f0d96 > > Original change's description: > > Enable flag TabToGTSAnimation by default > > > > Also update the default parameter of zooming-min-sdk-version to M. > > > > TBR=twellington@chromium.org > > > > Bug: 964406 > > Change-Id: I3a23e20511f9ecb48ed70fd6952f36b06191817c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743106 > > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Mei Liang <meiliang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689627} > > TBR=mdjones@chromium.org > > Bug: 964406, 997065 > Change-Id: Iff003fda8274e0715b3e9ab492286218b649cdbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767611 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694616} TBR=mdjones@chromium.org,wychen@chromium.org,meiliang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964406, 1001970 Change-Id: I962deeba786428a6bd0ec82d063f5163d1aa1e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797094Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695768}
-
Yuchen Liu authored
Move Fuchsia CDM codes (CDM and Decryptor) into //media: 1. Create new interface FuchsiaCdmProvider, which handles fuchsia::media::drm::ContentDecryptionModule request. This is to remove mojo dependency from media. MojoFuchsiaCdmProvider wraps the mojo interface FuchsiaCdmProvider. 2. Move media/filters/fuchsia/stream_processor_helper*|sysmem_buffer_* into media/fuchsia/common, so that they can be shared by media/fuchsia/cdm and media/filters/fuchsia. 3. media/fuchsia/cdm becomes a submodule of media. 4. media/cdm is visible to media/fuchsia/cdm, for AesDecryptor. Bug: 966191 Test: Component build. Change-Id: I8ebbd5f33080a3ced4a91b85262af8f1e7df0ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790739Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695767}
-
Fabrice de Gans-Riberi authored
* Implement handling of the chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner. * Remove handling of the fuchsia.web.AdditionalHeadersProvider API in CastRunner as it is deprecated. * Adapt the integration test to use the new API. Bug: 976975 Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695766}
-
Kurt Horimoto authored
The reset occurred under the previous assumption that the toolbar heights only change for navigation to/from the NTP, where the primary toolbar height is 0.0. This assumption is incorrect because the heights can also be updated due to trait collection changes. The navigation case for NTP is already handled by FullscreenWebStateObserver:: DidFinishNavigation(), so removing the calls to ResetForNavigation() does not break that case. Bug: 896675 Change-Id: I2fd1b101f3057e6f3f3bb61802fc1683a1ab0862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1328234 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#695765}
-
Ian Prest authored
This change fixes an infinite loop in `OneShotAccessibilityTreeSearch`. If the search starts at the root of a tree, goes backwards, and wraps around to the last node, it will loop forever in `SearchByWalkingTree`. The problem is that `stop_node` is set to NULL, so it is never matched. The fix is to ensure that stop_node gets set to the root element (i.e., the start_node) so that we don't loop through the tree more than once. Bug: 1001200 Change-Id: I67d8abd5e6044b2a125a633d39c7581e45cc7411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790255Reviewed-by:
-
Olivier Robin authored
The shortcut handler is already executed when application becomes active. Executing it in performActionForShortcutItem will result in two execution which can cause issues (e.g. if action is to trigger camera). Bug: 1000940 Change-Id: Id89a1c1c88fc9594599772cb0170c7c6e08deded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789523Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695763}
-
Jonathan Backer authored
This reordering allows us to issue SwapBuffers a little bit sooner by moving DDL destructor after. Bug: 974359 Change-Id: Iba9a81815cf1166d3d31bd9312adc8e0834bf512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797175Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#695762}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/dom_distiller. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bengr@chromium.org Bug: 891670 Change-Id: Id769068426f8af6e23a32f62202883e3a2a8789e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787106 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ben Greenstein <bengr@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695761}
-
Stephen Martinis authored
We currently have no way of tracking usage of this tool. Tagging the builds created by it should allow us to do some basic estimation of usage numbers. Change-Id: Ie73a2a8019a5eb79a9b7f4e0f004b81f05251f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797699Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#695760}
-
Vasiliy Telezhnikov authored
This CL adds implementation to CreateSharedImage overload with |pixel_data| to SharedImageBackingFactoryAHB. Bug: 1002057 Change-Id: I246284c6df5f75c25bbedd69658d4fdfaac0f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792579 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695759}
-
David Bienvenu authored
This reverts commit 250c173e. Reason for revert: <reverting did not fix crbug.com/999467> Original change's description: > Revert "Migrate pinned icons in ImplicitApp subdirs." > > This reverts commit 4105186f. > > Reason for revert: <crbug.com/999467> > > Original change's description: > > Migrate pinned icons in ImplicitApp subdirs. > > > > Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the > > subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why > > Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories, > > but we should handle them. > > > > Bug: 980239 > > Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb > > TBR: > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722 > > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681035} > > TBR=msarda@chromium.org,grt@chromium.org,davidbienvenu@chromium.org > > Bug: 980239 > Change-Id: I2b19e825ccd0f1bd2975678d9acb1ad7ff90cc6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787560 > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693898} TBR=davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 980239 Change-Id: Ibe0af2947a119bdccea80067fe86f0d1d5bb7af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797692Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695758}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1b4c0ba92e..5a5ffe52a944 git log 5f1b4c0ba92e..5a5ffe52a944 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 capn@google.com Update link to dEQP repository 2019-09-11 capn@google.com Fix OpenGL/EGL entry function calling convention Created with: gclient setdep -r src/third_party/swiftshader@5a5ffe52a944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137875321,chromium:b/140700303 Change-Id: Idfa6f95ef7341f1b02c7ee017af3f904bf385df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797492Reviewed-by:
-
