GitLab

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=benwells@chromium.org

Bug: 825327
Change-Id: I18dfde173f4dec69a3ab5040a0f62e1e09005fce
Reviewed-on: https://chromium-review.googlesource.com/1024394Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553633}

I believe that in old times when this locale reset was introduced (https://codereview.chromium.org/6347045), MacOS was not excluded for some particular reason just Linux was the main target.
Here (https://bugs.chromium.org/p/angleproject/issues/detail?id=2493) is another reason to force C locale on MacOS too.

Bug=720222

Change-Id: I1cdc92e0b5561e0659e7b1bac7ec27655a2c73f6
Reviewed-on: https://chromium-review.googlesource.com/1025091Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553632}

ImageBitmap resize layout tests write an extensive amount of debug
information to the console, as requested by Skia team. Apparently
sometimes the test finishes before all the degug info are printed
to the console, causing the tests to be flaky on try bots. This
CL hides the debug info behind a test option, so they can be printed
only if necessary.

Bug: 829953
Change-Id: I32955d2b49074cdf68ab7e59766d91fc560286cf
Reviewed-on: https://chromium-review.googlesource.com/1026200Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553631}

Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/renderer_host/media/video_capture_unittest.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=mcasas@chromium.org

Bug: 825327
Change-Id: I2a142815884495810e2e4b1b9df911a70827e076
Reviewed-on: https://chromium-review.googlesource.com/1024475Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553630}

crrev/c/989249 mistakenly inset the frame of native content the height of the
bottom toolbar.  Instead, native content should appear underneath the bottom
toolbar, but set it's collection view inset so everything is visible on scroll.
This way we can show a blur under the bottom toolbar.

This CL reverts those changes to ios/web to inset native content, and instead
moves the contentInset logic to BVC.  This is somewhat similar to how this
should work when NTP moves out of native content, although the method in which
we set contentInset will change.

Bug: 836205
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3518ad167f9f1ddcc9b65b087fad4869429747f8
Reviewed-on: https://chromium-review.googlesource.com/1026231
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553629}

During navigation, in RenderFrameHostManager::CommitPending, when the
navigation results in creation of a new RenderWidgetHostView, the
sequence of events in that function is that
- the old RenderWidgetHostView is hidden
- the new RenderWidgetHostView takes content from the old one
- the new RenderWidgetHostView is shown

On macOS, this can result in a one-frame flicker where there is no
content present (between the hide and the show). Fix this by adding
a ScopedCocoaDisableScreenUpdates for the duration of CommitPending.
This will make all Cocoa changes in the function be atomic.

In order to include ScopedCocoaDisableScreenUpdates in a non-objective-C
file, move its ScopedCocoaDisableScreenUpdates implementation out of
the header file.

Bug: 829523
Change-Id: If541ef8985cf7990d63a79435b179f84339a9372
Reviewed-on: https://chromium-review.googlesource.com/1024968Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553628}

I'm not sure whether it should be this way - maybe
waiting for the page load (WaitForPageLoad) should
imply waiting for the focus as well; but this does
fix the previously flaky test. I've clarified the
name of the test also, since all this does is to
show that the two HeadlessWebContents instances
are independently focused at the same time.

R=caseq@chromium.com, eseckler@chromium.com

Bug: 828042
Change-Id: I174863b49ae525605a6aacb8750880d02fae3246
Reviewed-on: https://chromium-review.googlesource.com/1026993Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@google.com>
Cr-Commit-Position: refs/heads/master@{#553627}

TBR=ellyjones@chromium.org,liaoyuke@chromium.org

Bug: 828031
Change-Id: Ie98ee83cee2d4c98c29a2ac1290728da5b87c4a7
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1028482Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553626}

Using wpt-import in Chromium 3972cc6c.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."
52308ad8 "Deprecate document.origin"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16261

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: Ica2f31344885a0a9b97973fd187dfd0efe6c67d6
Reviewed-on: https://chromium-review.googlesource.com/1027903
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553625}

This is in preparation of updating iron-input to its latest version

Bug: 812926
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cbcb4869fadac14956ac5c9e9a9d3d7289dda46
Reviewed-on: https://chromium-review.googlesource.com/1026639
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553624}

This change fixes changes some platform checks to TOOLKIT_VIEWS and
allows the test to assume that Mac is always running with views
enabled.

Also the information about undo selection restoration has been moved
to http://crbug.com/836490.

BUG=834754,836490

Change-Id: I906e78fb4649c646f79c2d18e6d4222b7a25050d
Reviewed-on: https://chromium-review.googlesource.com/1026881Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553623}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=slan@chromium.org

Bug: 825327
Change-Id: I01b6eb1a65d3989f830b34c989ec5a8bbf0ffe41
Reviewed-on: https://chromium-review.googlesource.com/1024530Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553622}

https://github.com/google/error-prone/releases/tag/v2.3.1

Bug: 834756
Change-Id: I658f503b854ea02fb70f63e3ee110502e6f4d7dd
Reviewed-on: https://chromium-review.googlesource.com/1024915Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553621}

Bug: 835994
Change-Id: I817b6ced87513054339397f825f695019cd68a36
Reviewed-on: https://chromium-review.googlesource.com/1025043Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553620}

During a recent roll of wpt tools, wptserve was broken and it was very
hard to debug. A few changes are made to improve the debuggability and
overall code health of wptserve management in blinkpy.

* Stop discarding the output of wptserve. Set the logging level to info
  (the default is debug) and preserve the output, so that it can be
  dumped out when something goes wrong.
* When checking and killing wptserve, we now poll the process before
  sending the null signal, as `kill -0` a defunct process will still
  succeed. We can now reap zombies much faster :)
* Lastly, _check_and_kill no longer does blocking wait inside. Now,
  _wait_for_action(_check_and_kill) makes more sense and matches the
  pattern in ServerBase better; and we send SIGKILL as a last resort
  (on POSIX).

apache_http.py is modified by the way to replace an unnecessary popen
with run_command. httpd exits immediately after it spawns the daemon,
so there's no use holding onto the defunct main process.

Change-Id: I441d36739451ad1e37afc6afe8f3c089cf224822
Reviewed-on: https://chromium-review.googlesource.com/1026889Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553619}

The tests of the constructors was in the constructor directory.  Time
to move each of these into the individual node directories so they're
associated with the node.

Update the paths as well so we can find audionodeoptions.js.

First step in moving these to WPT.

Bug: 745778
Change-Id: Iccaca6387f8d7359c357c9f22cf56d989d38d7c5
Reviewed-on: https://chromium-review.googlesource.com/1024403
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553618}

Somes time the background color of the title string in
CustomFrameViewAsh does not update. This cl fixes this bug.

Bug: 834465
Test: Manual.
Change-Id: Iee99678c0a947f4db8cbb06611f2fca0600cd72d
Reviewed-on: https://chromium-review.googlesource.com/1024606Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553617}

DownloadTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: If536e7da72deb5934305bf0a68b011b6b55582d5
Reviewed-on: https://chromium-review.googlesource.com/1026070Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553616}

Bug: skia:7794
Change-Id: I0d54fe15df6faed64bb057c3e74ebbeffc212616
Reviewed-on: https://chromium-review.googlesource.com/1027904Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553615}

This CL implements image manager, which is on top of FeedImageDatabase.
FeedImageManager will take request for images, check if the image is
cached in disk or not, if not, FeedImageManager will try to download
the image and cache it. FeedImageManager also does the garbage
collection for images not used recently.

Bug:807360

Change-Id: Id2f572abd72a2dc29dfa30e2573dc200715a4714
Reviewed-on: https://chromium-review.googlesource.com/1014461
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553614}

In db110f78, IDC_EXIT was changed to be
handled by Chrome instead of Ash. This reverts that change.

Originally, I thought Chrome would have to register the IDC_EXIT command
so that menus would show that shortcut in the relevant row. However,
the Exit command isn't shown in the Chrome OS app menu so it should be
fine to skip registering it completely and let Ash handle it.

Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot
be eaten by a webpage. This site is useful for manually testing that:
  http://unixpapa.com/js/testkey.html


Bug: 834092
Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3
Reviewed-on: https://chromium-review.googlesource.com/1024876
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553613}

Bug: 799482
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4b1a7da98378bc349986e92bfc1df845b655b0fc
Reviewed-on: https://chromium-review.googlesource.com/1025045Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553612}

-This CL re-introduces the ClearBrowsingData modal presentation from HistoryCoordinator
via HistoryTableVC.

-Creates a new displayPrivacySettings localDispatcher command.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia62f7f491b39e49c7d90bffb8bf42504ff343a13
Reviewed-on: https://chromium-review.googlesource.com/1026873Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553611}

https://webrtc.googlesource.com/src.git/+log/09408115cda7..ff61273c010c

$ git log 09408115c..ff61273c0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:836790,chromium:None,chromium:836729,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icfa9b26e7de7db99d2c8f985b198097bb7805e49
Reviewed-on: https://chromium-review.googlesource.com/1028222Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553610}

The background color of a new tab is set to the root background
color of the old tab (https://codereview.chromium.org/2737553004/).
Prior to my change, the root background color will be auto
corrected to the correct color by receiving the next CompositorFrame
(UpdateBackgroundColor is called in SubmitCompositorFrame).
However, after my change, since no new render frame metadata is
created by switching tabs, the new tab will be set with root
background color of the old tab. When we open another new tab,
the same color will carry to the new tab creation.

I have worked on rewriting the background color setting logic,
https://docs.google.com/document/d/1GLJzDVYuOsnTjysYAnCDWxUFofvxDBHtqTgYE60sEC8

I believe the complete fix requires more testing before merging to M67,
so I reverted SetRootBackgroundColor related logics in this CL.

Bug:830540

Change-Id: I6f9efaa580f4cac67b2aa3493cdcc093b92076f5
Reviewed-on: https://chromium-review.googlesource.com/1027208Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553609}

This will be implemented if necessary

Bug: b/73383411
Test: local build
Change-Id: I895c9e58e301a94d9814cb4f95247dd8e0131469
Reviewed-on: https://chromium-review.googlesource.com/1026465Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553608}

With this change we will stop using *1234 to obsfucate the card
number when we show a suggestion, for example, on a name field.
We can simply use ****1234 in all places instead.

The change applies to both the new and the deprecated dropdown.

Bug: 768881
Change-Id: Ic17c28f668dc0bed42f220d474a72924f02c7ad5
Reviewed-on: https://chromium-review.googlesource.com/1026213
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553607}

this cl changes:
- Move ash::prefs::kDockedMagnifierEnabled registration to chrome to
  avoid ShouldShowAccessibilityMenu() crash.

original changes:
The plan is to make MagnificationManager a class to make mojo calls to
ash for FullscreenMagnifier or DockedMagnifier when
- Focus changed in page.
- Corresponding feature is enabled.
This CL removes DockedMagnifierClient and merges it into
MagnificationManager.

TBR=dcheng@chromium.org

Bug: 817157, 831258
Test: existing tests and played on device working fine.
Change-Id: Ie8346291f03cc50b1b2580489413c3e45f6e38c8
Reviewed-on: https://chromium-review.googlesource.com/1018823
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552583}
Reviewed-on: https://chromium-review.googlesource.com/1027080Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#553606}

Make the iOS implementation more similar to other platforms by sending
FormFieldData.is_autofilled to the JS in order to avoid filling fields that
are not autofilled (e.g., <select> elements with default values in hidden
sections).

With this change, there is no need for checking to see if the element's
value has changed in order to mark the element as autofilled. There are
cases where the element's value doesn't change but it must be marked as
autofilled, e.g., a <select> element for credit card expiry month whose
default value is 'January' where the expiry month of the credit card used
for autofill is also January.

This CL avoids sending autofill data for fields with empty values to the JS
side since they're already ignored in JS.

Bug: 827108
Change-Id: If68d25cfa86eedd1467cd766fa55e7560048e660
Reviewed-on: https://chromium-review.googlesource.com/1026513
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553605}

This test needs the not-yet-implemented fullscreen behavior described
in the linked bug.

TBR=rdevlin.cronin@chromium.org

Bug: 836327
Change-Id: Id383aa9e5092cf707119f1940978965027479853
Reviewed-on: https://chromium-review.googlesource.com/1028176Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553604}

Restores the arc app notification badging on shelf icons by re-wiring
ArcNotificationManager get app id code path through mojo.

- Change ArcNotificationManager to handle get app id asynchronously;
- Add GetArcAppIdByPackageName to AshMessageCenterClient mojo interface;
- ArcNotificationManager use the mojo call to get app id;

Bug: 768439
Change-Id: I199636b374d539677d93e35be1fd4f7b9b900bca
Reviewed-on: https://chromium-review.googlesource.com/1012123Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553603}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=xdai@chromium.org

Bug: 825327
Change-Id: I25abbbca04c9753f602fa6c9d654f797aecd13bb
Reviewed-on: https://chromium-review.googlesource.com/1024294Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553602}

This reverts commit 34aec165.

Reason for revert: Reverted the wrong CL.

Original change's description:
> Revert "Reland "Remove ".dd" extension from VR icons""
> 
> This reverts commit 2aea307c.
> 
> Reason for revert: Introduces syntax error in build/android/gyp/compile_resources.py
> 
> Original change's description:
> > Reland "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit 14ebddd2.
> > 
> > Reason for revert: Fixing regex.
> > 
> > Original change's description:
> > > Revert "Remove ".dd" extension from VR icons"
> > > 
> > > This reverts commit c00fe466.
> > > 
> > > Reason for revert: Breaks canary push
> > > 
> > > Original change's description:
> > > > Remove ".dd" extension from VR icons
> > > > 
> > > > Bug: 834499
> > > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#552773}
> > > 
> > > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > > 
> > > NOTRY=true
> > > 
> > > Bug: 834499
> > > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553577}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 834499
> > Reviewed-on: https://chromium-review.googlesource.com/1028095
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553578}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I59661b7afd876e22e61455e766fdb7094ca5667e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028096
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553599}

TBR=ellyjones@chromium.org,mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I310cf29d1a60eb23de841faf0dd092961af017b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028373Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553601}

This reverts commit bf799ef8.

Reason for revert:
Breaks CrSettingsIncompatibleApplicationsPageTest test in official builds.

Google internal failing bot:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/83282

Externally visible Clang ToT official bot:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1359

Original change's description:
> WebUI MD Refresh: Update paper-button styling up to spec.
> 
>  - Move some styles from shared_style_css.html to paper_button_style_css.html.
>  - Update paper-button styles per latest spec.
>  - Collapse previously different types of buttons "primary" and "action" into a
>    single button type.
> 
> Note this change is intentionally changing the shared styling for buttons. If a
> certain WebUI page needs a different pre-MD refresh style, should be updated
> individually to override (hopefully there are no such cases though).
> 
> Bug: 832173
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I8558db8ffd121ad09b100f8ba6ab4d843022f73f
> Reviewed-on: https://chromium-review.googlesource.com/1013330
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553382}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I0489c01e20af79b61db0e9ce1fdc2f292c178c98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028371Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553600}

This reverts commit 2aea307c.

Reason for revert: Introduces syntax error in build/android/gyp/compile_resources.py

Original change's description:
> Reland "Remove ".dd" extension from VR icons"
> 
> This reverts commit 14ebddd2.
> 
> Reason for revert: Fixing regex.
> 
> Original change's description:
> > Revert "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit c00fe466.
> > 
> > Reason for revert: Breaks canary push
> > 
> > Original change's description:
> > > Remove ".dd" extension from VR icons
> > > 
> > > Bug: 834499
> > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#552773}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > NOTRY=true
> > 
> > Bug: 834499
> > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553577}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028095
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553578}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I59661b7afd876e22e61455e766fdb7094ca5667e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028096Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553599}

This reverts commit c4a6b926.

Reason for revert: Fixing bad merge...

Original change's description:
> Revert "Reland "Remove ".dd" extension from VR icons""
> 
> This reverts commit 2aea307c.
> 
> Reason for revert: Bad merge. No idea how that happened.
> 
> Original change's description:
> > Reland "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit 14ebddd2.
> > 
> > Reason for revert: Fixing regex.
> > 
> > Original change's description:
> > > Revert "Remove ".dd" extension from VR icons"
> > > 
> > > This reverts commit c00fe466.
> > > 
> > > Reason for revert: Breaks canary push
> > > 
> > > Original change's description:
> > > > Remove ".dd" extension from VR icons
> > > > 
> > > > Bug: 834499
> > > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#552773}
> > > 
> > > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > > 
> > > NOTRY=true
> > > 
> > > Bug: 834499
> > > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553577}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 834499
> > Reviewed-on: https://chromium-review.googlesource.com/1028095
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553578}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I41383360a58384fae4498e79dd637c755d24a424
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028370
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553597}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: Id1accbf1f59a27afc03d16e1b2b29789c5b5df63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028332
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553598}

This reverts commit 2aea307c.

Reason for revert: Bad merge. No idea how that happened.

Original change's description:
> Reland "Remove ".dd" extension from VR icons"
> 
> This reverts commit 14ebddd2.
> 
> Reason for revert: Fixing regex.
> 
> Original change's description:
> > Revert "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit c00fe466.
> > 
> > Reason for revert: Breaks canary push
> > 
> > Original change's description:
> > > Remove ".dd" extension from VR icons
> > > 
> > > Bug: 834499
> > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#552773}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > NOTRY=true
> > 
> > Bug: 834499
> > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553577}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028095
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553578}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I41383360a58384fae4498e79dd637c755d24a424
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028370Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553597}

This reverts commit e8acf697.

Reason for revert: Tests do not pass in official build configuration.

Google internal official bot link:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/83286

Externally visible clang ToT bot configured the same way:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1359

Original change's description:
> Print Preview Componentization: Migrate preview area error tests
> 
> Migrate some tests for errors that appear in the Preview Area:
> - No PDF plugin
> - Invalid Settings
> - Bad cloud print certificate
> 
> Bug: 814860
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ia87708ef2bc326d794b3be0f6aa9adeb87e5a3c2
> Reviewed-on: https://chromium-review.googlesource.com/1015850
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553416}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: I1431bd7e9c3bf612ecb979893b1ea1914134c7ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814860
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028331Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553596}

std::ptr_fun and std::bind2nd are deprecated in C++11, and removed in
C++17. This CL removes their usage, so that the code base is ready for
C++17.

Bug: 752720
Change-Id: I5a33143768a32864367f6889c4d1dbd0a26ee9e2
Reviewed-on: https://chromium-review.googlesource.com/1025541Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553595}

Change-Id: I2333926b6d37544a535c6683078fd4f22f75aad9
Reviewed-on: https://chromium-review.googlesource.com/1017008
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553594}