- 14 Feb, 2020 40 commits
-
-
Victor Costan authored
This CL removes the feature flag gating IndexedDB large value wrapping. The feature will be rolled out using Chrome's standard waterfall release model. Bug: 844782 Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#741600}
-
Nick Harper authored
ProofVerifierChromium will reject certificates that don't chain to a known root unless the hostname matches one specified in --origin_to_force_quic_on. That flag also allows a wildcard "*" to force QUIC on for all origins, but that wasn't handled in ProofVerifierChromium. Now it is. Change-Id: I9576bcfbb14aac8956a81731d35190062e469b23 Bug: b/144497826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048034Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741599}
-
Elly Fong-Jones authored
* In PlatformVerificationDialog, a lambda now wraps all three callbacks to pass the needed response codes, and the overrides are removed * In ToastDialogView, the dismiss callback is used directly as the DialogDelegate close callback, and the ::Close override is removed * In EchoDialogView, the listener is used directly as a receiver for the success callbacks. The contract of the listener is "it receives zero or more calls to OnMoreInfoLinkClicked, then exactly one call to either OnCancel or OnAccept", which fits neatly into the DialogDelegate model, since the cancel/accept callbacks can only be run when the dialog is already closing (and therefore no more button presses can be delivered). * In RequestPinView, a dead override of ::Cancel is removed; the default ::Cancel just returns true already. Bug: 1011446 Change-Id: I5b7489799327d497f9e6f948620a0e0918680d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044133Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741598}
-
Alex Gough authored
Bug: 1052442 Change-Id: I51a9476de93f1401b2de902834849fb031fe7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057629 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741597}
-
David Schinazi authored
This histogram is no longer used anywhere, we just forgot to mark it as obsolete when its usage was removed with this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1277929 Bug: 815241 Change-Id: I38bb63d4396f900e86f3353ff97637fb711f155a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055688 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741596}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fd618192985..71b3dd56da8d git log 2fd618192985..71b3dd56da8d --date=short --first-parent --format='%ad %ae %s' 2020-02-14 cwallez@chromium.org Fix clean CMake builds Created with: gclient setdep -r src/third_party/dawn@71b3dd56da8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4a259be22b7abdf77f251814c651b4a297d57ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741595}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9478dbffef45..8f64176566f7 git log 9478dbffef45..8f64176566f7 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 nuskos@google.com Merge "Add trigger packets to the slices table." 2020-02-14 treehugger-gerrit@google.com Merge "shmem: Require memfd in in-tree android builds" 2020-02-14 treehugger-gerrit@google.com Merge "Switch to using variadic parameters rather then a int input." Created with: gclient setdep -r src/third_party/perfetto@8f64176566f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7133307ef832c95b7b8941e2b40cfa53831b7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741594}
-
Becca Hughes authored
We were using GURL/url::Origin in different places for storing origins which meant some had a trailing / and some did not. This resulted in duplicates. BUG=1051204 Change-Id: I098e42358ec42904125bd2f62b399c43c319d983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051293 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741593}
-
Sammie Quon authored
And rearranged the setters/getters to match the order as well. Test: none Bug: none Change-Id: Ia0fe3548895d1741398b36985e88eb23a2d3bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057585Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#741592}
-
Yulun Wu authored
Change-Id: Ia857192db462c08121220b205071757f763c2d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057288Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741591}
-
Erik Chen authored
Change-Id: I160bba87701cb16d012aff495bcc63fd08c76b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057632 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741590}
-
David Black authored
Improves readability of UMA dashboard. Bug: b:144875278 Change-Id: Id5493c5d0060e4fca7b2956ab87fa5c1775ce4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055995Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#741589}
-
Ionel Popescu authored
This change adds drop shadow to popups for FormControlsRefresh by using the [NSWindow hasShadow] property. Since the Mac window shadow also has its own border, the HTML provided border for the popups [1] is changed to be transparent to avoid having a weird UI. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2036250 Bug: 1000898 Change-Id: Iadf89e7a122614b6dba95b745be2af79476da98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052264 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741588}
-
Wez authored
Fix several BUILD.gn rules which have |deps| on FIDL APIs, but which expose headers which #include the fidl.h bindings for those APIs. Such dependencies in source_set()s, libraries, etc, need to use |public_deps| otherwise their dependents do not inherit the FIDL API's include paths correctly. We seem to have been getting away with this, but it proved to be a problem for the GN SDK transition. Bug: 1050703 Change-Id: I4e16a27d2169ec9c693d359e9ee742efc043dc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056549 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741587}
-
Ahmed Mehfooz authored
StackedNotificationBarIcon. Issue 100% reproducible without the fix. With the fix the crash does not happen. Confirmed over 3 runs for each case. Bug: 1050685 Change-Id: Id3e5f7204f7f124a1d258b2f45864b451ff6647a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055846Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741586}
-
Sylvain Defresne authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/866cee927378..adb2011e9efd $ git log 866cee927..adb2011e9 --date=short --no-merges --format='%ad %ae %s' 2020-02-12 56741989+copybara-service[bot] [FlexibleHeader] Added property for minimumHeaderViewHeight (#9649) 2020-02-12 randallli manual edit of changelog 2020-02-12 yarneo fix snapshot tests for CI (#9698) 2020-02-12 randallli modified version number to 104.0.0 2020-02-12 randallli Revert "Bumped version number to 103.2.0." 2020-02-12 randallli Hand-modified CHANGELOG.md API diff. 2020-02-12 bryanoltman [TextFields] Update snapshot goldens (#9691) 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Bumped version number to 103.2.0. 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Automatic changelog preparation for release. 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCFloatingActionButtonThemer (#9662) 2020-02-11 randallli add deps on availability for a bunch of components (#9679) 2020-02-11 randallli [Availability] add Availability build file (#9678) 2020-02-10 rsmoore [CODEOWNERS] Remove romoore@ (#9660) 2020-02-10 randallli [private] Update snapshot tests. (#9666) 2020-02-07 no-reply Internal Change 2020-02-07 no-reply [Material][Availability] Migrates Buttons to MDCAvailability. 2020-02-07 no-reply [Material][Availability] Migrates the Banner to MDCAvailability. 2020-02-07 galiak [Dialogs] Update comments describing private margin properties. 2020-02-07 featherless [ButtonBar] Assign the UIBarButtonItem's tintColor to the button's text color. 2020-02-07 galiak [Dialogs] Update comments describing private margin properties. 2020-02-07 featherless [FlexibleHeader] Resolve precision warning due to use of floating point. 2020-02-07 no-reply [Material][Availability] Migrates elevation to MDCAvailability. 2020-02-07 andrewoverton Add Swift-friendlier names to TextControl text fields 2020-02-07 featherless [Availability] Add an umbrella header. 2020-02-07 featherless [FlexibleHeader] Add missing self-> within a block. 2020-02-07 no-reply [Material][Availability] Migrates Feature Hightlight to MDCAvailability. 2020-02-07 galiak Renaming "custom" category to "customize". 2020-02-07 galiak Renaming "custom" category to "customize". Created with: roll-dep src/ios/third_party/material_components_ios/src Bug: 1051926 Change-Id: I849814fabc76b655909a91889cafe7913c97e6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057285Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741585}
-
Javier Ernesto Flores Robles authored
Abstract ConfirmationAlertViewController from PasswordBreachViewController to be reused in the credential provider extension. Create shared dynamic_type_util to share PreferredFontForTextStyleWithMaxCategory. Create ios/chrome/common/ui/... to have a common folder for shared UI. Create ios/chrome/common/ui/util/... to have a common folder for shared util UI. This follows the convention in ios/c/b/... Bug: 1045453, 1045452, 1045448 Change-Id: I0fc661f6a83fe80b312eb5e32611c76d3b43c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055552 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741584}
-
Li Lin authored
QuickAnswers.SelectedContent.Length is recorded to learn about users usage pattern. Bug: 1051751 Test: Manual Change-Id: Iba7c9ecf605cf39cc7d65864eb54d9ff6ef12be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053288 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741583}
-
Eugene But authored
This callback is called when back/forward buttons visibility state is changed. This does not provide any useful signals for finding steps to repro. Bug: 1046223 Change-Id: Ia93bd11ee1d444de2b9525d5f4781b524184b60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057117 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741582}
-
Greg Guterman authored
Important: Land together with https://crrev.com/c/2040570 In an effort to achieve the replacement of masternames with buckets (https://crbug.com/914522), we need an interim solution where master and bucket configs co-exist, while we migrate downstream code over to use the bucket side. I'm planning on adding 'project' and 'bucket' into the source side spec in waterfall.pyl Because I'm adding it at the master level, it means all masters have to be constrained to 1 bucket. Luckily, only one master currently has builders in two different buckets: chromium.fyi belongs to both chromium.goma and chromium.ci buckets. Therefore, as a prerequisite to adding this new bucket config, this CL splits chromium.goma.fyi off from chromium.fyi. Also removes some builders that weren't removed from the corresponding mb_config_bucket.pyl file in previous commits to mb_config.pyl. Also merges consoles/chromium.fyi.goma.star into consoles/chromium.goma.fyi.star because we can't find a reason for them to be separate. Change-Id: Iba12ad30c050b67396577165779768ad2f196f7e Bug: 1049220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039597 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#741581}
-
haozhe authored
The correct css_animation and css_transition composite order require to walk the tree which is slow and causing a perf issue. Perf Job link: https://pinpoint-dot-chromeperf.appspot.com/job/125ecb68620000 https://pinpoint-dot-chromeperf.appspot.com/job/17471fd0620000 Bug: 1047316 Change-Id: I85e2446bab351ccbef989ae1a9cb62e8434ff236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032716 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741580}
-
Alexander Timin authored
This config has dummy URLs and dummy memory limit and is used to test the config parsing logic. The testing of the feature in question is provided by the buildbots: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-debug https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-debug R=asvitkine@chromium.org Change-Id: Ie4a2af2196e9a8e104a3616c0a9f6fedaa86a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057267 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#741579}
-
Sammie Quon authored
This is so we can share the code with CompositorAnimationRunner and some classes which record their own smoothness, such as AppsGridView. Creates a Recorder class which computes smoothness that can be used in mentioned classes. Test: run existing tests Bug: 1051490 Change-Id: Ic562fbb74bcd74c7554277a8167aaaa8fbf4a51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053123 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#741578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a710b74a3690..c663845357d0 Created with: gclient setdep -r src-internal@c663845357d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049646 Tbr: jbudorick@google.com Change-Id: Ib99aa0f760a1a6b028508d980af3ad6b91432757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057488Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741577}
-
Vasilii Sukhanov authored
That question came up during security review. We should enforce HSTS at least for the password leak check API. However, it's benificial to enforce it for all possible APIs. Bug: 1049177 Change-Id: Ieacb6675c195c89606cc3a8d956bdfa855b8b64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057125 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741576}
-
Matt Jones authored
TBR: asvitkine@chromium.org, vincb@chromium.org Bug: 1052440 Change-Id: Ia4cb7f08876b46f6597185937aaefedbcf2975b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056745 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741575}
-
Sajjad Mirza authored
Sometimes the value of sys.prefix (or sys.real_prefix in vpython) includes the bin/ directory within the python installation, and sometimes it does not. To accommodate this, check both prefix/bin and prefix itself for the python executable. Bug: 1049421 Change-Id: Ia7c072dc0b4b8232ec8fdce20f9211e3c978a3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055976 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#741574}
-
Bin Wu authored
Updated QUIC flags and fixed tests due to the newly added ACK in the connection closes of TLS1_3 connections. Roll src/net/third_party/quiche/src/ 084a860a7..4e083db26 (10 commits) https://quiche.googlesource.com/quiche.git/+log/084a860a79b5..4e083db26373 $ git log 084a860a7..4e083db26 --date=short --no-merges --format='%ad %ae %s' 2020-02-14 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_cut_inflight_hi_gradually. 2020-02-13 renjietang Remove QuicStream::PeerAddressOfLatestPacket. It's only used in debug string, and isn't necessary. 2020-02-13 nharper Remove use of GetNumSentClientHellos from //third_party/quic tests 2020-02-13 renjietang Add perspective_ member for QuicStream. 2020-02-13 danzh gfe-relnote: fix UBSAN failure in QuicCircularDeque. No protected. 2020-02-13 fayang gfe-relnote: Do not pad server initial connection close packet. Protected by blocked gfe2_reloadable_flag_quic_enable_version_t*. 2020-02-13 renjietang Change QuicStream::CloseConnectionWithDetails() to QuicStream::OnUnrecoverableError. 2020-02-13 wub gfe-relnote: In QuicPacketReader, use QuicClock::Now() instead of kernel provided systime for receive time. Protected by --gfe2_reloadable_flag_quic_use_quic_time_for_received_timestamp2. 2020-02-13 wub Internal QUICHE change 2020-02-13 fayang gfe-relnote: In QUIC, always bundle ACK with connection close with TLS handshake for debugging purpose. Protected by blocked gfe2_reloadable_flag_quic_enable_version_t*. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=zhongyi@chromium.org Change-Id: I1e6a8cc27a34b1f8544532ee38d3acbf4b45c253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057446 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#741573}
-
Wez authored
A visibility rule applying to cast_runner_browsertests__exec was added in https://chromium-review.googlesource.com/c/chromium/src/+/1529685 Making assumptions about the naming of targets defined inside templates is fragile, and this dependency isn't required, so remove it and the associated visibility rule. Bug: 933617 Change-Id: If05af64d54944b7cafb403aae3036981ca1e0698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050306 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741572}
-
Tanya Gupta authored
the user denies permission for Chrome to prompt for camera permission. Screenshot: https://screenshot.googleplex.com/himQOS9PQrY Bug: 1046574 Change-Id: I0df3cf870f0f08e5f0bc08e0dd4f8d963f4797ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037860 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#741571}
-
Ehsan Kia authored
Bug: 1052026 Change-Id: Id7e396d64b1c3002472e7b2a694d3e4a719648c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055705 Commit-Queue: Ehsan Kia <ehsankia@google.com> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#741570}
-
Ahmed Fakhry authored
When an automatic schedule is being used, users can toggle the status of Night Light manually from the system tray or the system settings. This manual setting used to get reverted, and the schedule used to get reapplied in the following cases: - Switching users. - Resume from suspend. - Receiving a new geoposition. This CL makes it possible to remember manual toggles, and reapply them if possible. BUG=999397 TEST=Manually, added new tests. Change-Id: Idb1b76cf24c95e0833a65542f0b0ffa341195c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049950 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#741569}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c55cadc7..330671f6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I483fa18ce938424da66c2c32400e5cc3f503bf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741568}
-
Mark Cogan authored
This test is failing ~95% of the time on simulator as well, so disabling it pending further investigation. Bug: 1043625 Change-Id: I60d1193297633545153ff537747739c1e5aec370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057524Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741567}
-
Hidehiko Abe authored
With this CL, we can inject sysroot precisely. BUG=1043804 TEST=Built locally. Change-Id: I459a45eca86f96c4b143b055b588cd50e24f283a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057503 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#741566}
-
Olya Kalitova authored
Fixes message for Crostini container configuration error during Crostini installation. Test: none Bug: b:148645840 Change-Id: I5cd85b3f42e9fdda48e26d4aa7bd8a8a9c2472c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056910Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#741565}
-
Danyao Wang authored
Bug: 1046064 Change-Id: I874f84ec9e47633fab5f605733dca7667b0c5a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053516Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#741564}
-
Chris Mumford authored
This reverts commit 6d1a45d2. Reason for revert: Failing KnownExpectedFonts/GetFallbackFontTest.GetFallbackFont/SEthiopicLam. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/47644 Original change's description: > Add unittests for Fallback Fonts on MacOS > > This CL is adding unittests for some basic scripts on MacOS. > > Previously, on MacOS, an empty array of test candidates was > used. We are adding some of basics languages. > > Bug: 1022455 > Change-Id: I5f1e32feb40cc6c3a6bf22f96821b9e78ceb3906 > Fixed: 5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001142 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741488} TBR=robliao@chromium.org,drott@chromium.org,etienneb@chromium.org Change-Id: I5dcded54887c6ee8897936033b06bdcb2772cf71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056758Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#741563}
-
John Budorick authored
This reverts commit d1ad8abe. Reason for revert: failures were just the death throes of a dying bot. Original change's description: > Revert "[iOS] Remove xcode clang bots" > > This reverts commit 3893c26b. > > Reason for revert: Dangling reference to ios-simulator-xcode-clang.json. > > https://sheriff-o-matic.appspot.com/chromium/examine/chromium.read%20build%20config > > Original change's description: > > [iOS] Remove xcode clang bots > > > > Bug: 1049646 > > Change-Id: If024c2185409167031bcdaf3a801e73cb1c61b0b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042679 > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741519} > > TBR=justincohen@chromium.org,martiniss@chromium.org,michaeldo@chromium.org > > Change-Id: I2e0e630a1c4f5ed5706a40a34a5c479e1dff31f1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1049646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057583 > Reviewed-by: Chris Mumford <cmumford@google.com> > Commit-Queue: Chris Mumford <cmumford@google.com> > Cr-Commit-Position: refs/heads/master@{#741528} TBR=cmumford@google.com,justincohen@chromium.org,martiniss@chromium.org,michaeldo@chromium.org Change-Id: I5d2e02e4f3cd2b16c727fbd2f123b50e4e31dfe4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056755Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#741562}
-
Scott Violet authored
My suspicion is history initialization is failing. I'm adding some logging to verify that. No doubt if faviconservice creation returns null there will be other places assuming non-null that need to be fixed. BUG=1024959, 1052127 TEST=none Change-Id: I425e0b32d8543f46c1db7f18b232bbd65c898b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057093Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741561}
-