GitLab

This fixes a bug introduced in https://codereview.chromium.org/1305933007
which replaced a call to startOneShot that takes seconds with a call to
postDelayedTask that takes milliseconds

BUG=497761, 510398, 528666
R=alexclarke@chromium.org
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/1304383004

git-svn-id: svn://svn.chromium.org/blink/trunk@201877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit bb5572c1de7405160a32b80c6224477b13eaac14.

Conflicts:
	Source/core/css/resolver/StyleResolver.h

TBR=kochi@chromium.org
BUG=487125

Review URL: https://codereview.chromium.org/1332493002

git-svn-id: svn://svn.chromium.org/blink/trunk@201875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify parseShadowValue by getting rid of ShadowParseContext.

BUG=404023

Review URL: https://codereview.chromium.org/1318093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Reland of moved unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1306693007/ )
> 
> Reason for revert:
> I don't think this contributes any of "too many opened files".
> (as is commented bay jianli
> https://code.google.com/p/chromium/issues/detail?id=524248#c7 )
> 
> Will revert and reland the original patch.
> 
> 
> 
> Original issue's description:
> > Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ )
> > 
> > Reason for revert:
> > Speculative revert for causing "Too many opened files in the system".
> > 
> > https://code.google.com/p/chromium/issues/detail?id=523598
> > 
> > 
> > Original issue's description:
> > > Removed unused CascadeOrder.
> > > 
> > > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.
> > > 
> > > [1] https://codereview.chromium.org/1298173004
> > > 
> > > BUG=487125
> > > 
> > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019
> > 
> > TBR=kochi@chromium.org,rune@opera.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=487125
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082
> 
> TBR=rune@opera.com,jianli@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487125
> 
> Review URL: https://codereview.chromium.org/1313713005

TBR=kochi@chromium.org

Review URL: https://codereview.chromium.org/1331573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

'static const' initialization in functions is considered as
thread-unsafe (data race).  Removes 'static const' initialization, and
uses simple 'const' initialization instead.

Note: 'static' keyword in the top-level 'static const' initialization
has no meaning.  'const' implies file-scope, so no need to explicitly
write 'static' in that case.

BUG=526963,526959

Review URL: https://codereview.chromium.org/1324643005

git-svn-id: svn://svn.chromium.org/blink/trunk@201870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData (patchset #4 id:60001 of https://codereview.chromium.org/1225233005/ )

Reason for revert:
blink_perf.css regression
https://code.google.com/p/chromium/issues/detail?id=513378#makechanges

Original issue's description:
> Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData
> 
> BUG=509911
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199288
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199294

TBR=haraken@chromium.org,yutak@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509911

Review URL: https://codereview.chromium.org/1330763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |inSameLine()| for introducing
composed tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only block containers that don't establish new formatting contexts are
allowed to ignore (and thus potentially overlap with) floats.

This obviously also applies inside multicol, but we had a check that actively
prevented that. This was some residue from CSS regions support (shared
implementation with multicol), which had a much more sophisticated positioning
implementation, which we've removed ages ago.

BUG=528179
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1325323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before laying out, we try to estimate and set the logical top of the child, but
it may turn out after one layout pass that the estimate was wrong, due to
margin collapsing, float clearance or pagination.

So sometimes we need to reposition and relayout once or even twice inside
layoutBlockChild(). This was done with slightly poorly duplicated code.
Refactor into positionAndLayoutOnceIfNeeded() (and
markDescendantsWithFloatsForLayoutIfNeeded()). One instance of this duplicated
code used to sit in adjustBlockChildForPagination(). Moved it into
layoutBlockChild(), to make it easier to understand what's going on (and to
give adjustBlockChildForPagination() one less thing to worry about - one
parameter removed). Renamed |result| to |newLogicalTop| in
adjustBlockChildForPagination(), and |logicalTopAfterClear| to |newLogicalTop|
in layoutBlockChild().

No behavioral changes were actually intended, but when unifying
almost-duplicated code, some changes are inevitable. Added some tests for
something that now works, and used to fail. In the subsequent layout passes we
forgot to check if the new position changed how we were affected by floats.

R=jchaffraix@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1315353005

git-svn-id: svn://svn.chromium.org/blink/trunk@201866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |absoluteCaretBoundsOf()|
by templatizing original |absoluteCaretBoundsOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1330743002

git-svn-id: svn://svn.chromium.org/blink/trunk@201865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change enables individual CSS properties to track multiple animations
occuring on them at the same time and to composite the animations together
as defined by the Web Animations spec:
http://w3c.github.io/web-animations/#combining-effects

This behaviour guarded by the StackedCSSPropertyAnimations flag and is
only enabled for experimental Blink by default.

BUG=437696

Review URL: https://codereview.chromium.org/1329843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch improves getFallbackFamily() to find fallback fonts from a
character code for a generic family when the specified character is
Unified Han Ideographs.

In this case, Blink uses ICU default locale. This patch improves:

1. Japanese and Korean can disambiguate by languages. Comparing
   fullName can fail on, for instance, English OS with display language
   set to these languages.
2. zh-HK maps to USCRIPT_TRADITIONAL_HAN, same as what
   localeToScriptCodeForFontSelection() in LocaleToScriptMapping does.

BUG=509680

Review URL: https://codereview.chromium.org/1311043010

git-svn-id: svn://svn.chromium.org/blink/trunk@201863 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FormDataList::Item class represents a name string in a form data, or a value in
a form data.  A value can be a string or Blob, but a name string is always a
string.  Representing a name string by Item class is overkill.  This CL adds
m_key member to Item class.

Odd items in FormDataList::m_items represented name strings, and even items in
FormDataList::m_items represented values. Now each of items in
FormDataList::m_items represents a pair of a name string and a value.  This
makes the code much simpler.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1314013007

git-svn-id: svn://svn.chromium.org/blink/trunk@201862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528110

Review URL: https://codereview.chromium.org/1329863002

git-svn-id: svn://svn.chromium.org/blink/trunk@201861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To implement MIDIPort#open(), #clear(), and #close(), let's add new
interfaces to implement backends for them.

Backend will be implemented in chromium side soon. Once it gets ready,
I'll update Web MIDI IDLs and modules/webmidi implementations to use
these interface to be up to date.

BUG=471793, 471798

Review URL: https://codereview.chromium.org/1327993003

git-svn-id: svn://svn.chromium.org/blink/trunk@201860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |VisiblePosition| called
|VisiblePositionInComposedTree| with glue function
|createVisiblePositionInDOMTree()|, which is a stub function for applying
DOM tree version of functions in "VisibleUnits.cpp", e.g. |isLogicalEndOfLine()|
|nextPositionOf()| and so on, for making patch size smaller.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1319753004

git-svn-id: svn://svn.chromium.org/blink/trunk@201859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch copies "FrameSelection.{cpp,h}" to "SelectionEditor.{cpp,h}" as
a preparation of moving |FrameSelection::modify()| to |SelectionEditor| class
for inheriting change history.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes
NOTRY=true

Review URL: https://codereview.chromium.org/1331543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ScriptPromiseProperty to return same promise every time, until the
FontFaceSet switches from loaded to loading state. This is in line with
the spec, and also simplifies the code a bit.

TEST=fast/css/fontfaceset-ready.html
BUG=510434

Review URL: https://codereview.chromium.org/1313853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes "move-by-line-006.html" to use "monospace" font instead of
"Ahem" font to mitigate flakiness on local Windows desktop.

When I run "move-by-line-006.html" on local Windows desktop, it is flaky, e.g.
failed on parallel test execution but succeeded on single execution.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1314643006

git-svn-id: svn://svn.chromium.org/blink/trunk@201856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@7e34e95043bc21d087cd3e4d96e39050dea4a601
imported web-platform-tests@32ba9293b8e933dc7d2c2521eedac32ec86f457b

* css-writing-modes-3
  - 1 removed file removed from W3CImportExpectations.
  - 8 files renamed.
  - 1 test bug fixed in upstream and now pass.

* shadow-dom
  - 1 test updated, still fail.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=492664, 505364

Review URL: https://codereview.chromium.org/1308393009

git-svn-id: svn://svn.chromium.org/blink/trunk@201855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves an implementation of |LayoutView::commitPendingSelection()| to
|PendingSelection::commit()| as a preparation of moving it to "editing/",
for reducing exposing editing functions to layout layer.

Following patch will move |PendingSelection| to "editing/".

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315423006

git-svn-id: svn://svn.chromium.org/blink/trunk@201854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1329763004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1329023002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528177

Review URL: https://codereview.chromium.org/1315983010

git-svn-id: svn://svn.chromium.org/blink/trunk@201851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Initialize simple members in header files
* Mark const members as such
* Range-based iteration over containers
* Remove unused typedefs
* Use nullptr instead of 0

No behavior change.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1323323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch:
- Use WI.SourceMap.Entry instead of an array tuples.
- Establish correct reversed mappings

BUG=527993,463023
R=pfeldman

Review URL: https://codereview.chromium.org/1328843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes constructBidiRunsForLine() to handle the nested
'unicode-bidi: isolate' runs with the correct containing isolate.

crbug.com/274717 fixed the nested case by updating currentRoot to the
root of the last nested runs. While this fixed simple cases, it does
not set the correct root when nested in multiple levels.

The wrong root can let highestContainingIsolateWithinRoot() to find
ancestors up to the root elements. This will find ancestors that were
already processed, and results in an infinite loop.

BUG=520282

Review URL: https://codereview.chromium.org/1328633002

git-svn-id: svn://svn.chromium.org/blink/trunk@201847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was inadvertently added in this CL:
  https://codereview.chromium.org/1318963006

TBR=chrishtr@chromium.org
BUG=527617

Review URL: https://codereview.chromium.org/1303043005

git-svn-id: svn://svn.chromium.org/blink/trunk@201846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527681

Review URL: https://codereview.chromium.org/1312033008

git-svn-id: svn://svn.chromium.org/blink/trunk@201844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently it affects all iframes, but only the main resource.

BUG=

Review URL: https://codereview.chromium.org/1328763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add inline style in the element's scope. (patchset #1 id:1 of https://codereview.chromium.org/1322753006/ )

Reason for revert:
This caused regression.
https://code.google.com/p/chromium/issues/detail?id=528370


Original issue's description:
> Add inline style in the element's scope.
> 
> Style attribute declarations were added in a separate scope after all
> other author origins. Instead add style attribute declarations right after
> collecting matching rules from the element's scope. This means that we can
> override values set on the style attribute from outer scopes, like we can
> with values from inner scope's stylesheet.
> 
> Without this fix, you would get green on orange below:
> 
> <style>html /deep/ span { color: green; background-color: lime }</style>
> <host>
>   <host:root>
>     <style>span { color:red }</style>
>     <span style="background:orange">Green on orange?</span>
>   </host:root>
> </host>
> 
> With this change, we will get green on lime.
> 
> The regression (issue 526634) was not relying on this, but it would be
> more complex code to fix the regression without fixing the style attribute
> cascading order.
> 
> R=kochi@chromium.org,hayato@chromium.org
> BUG=526634
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201620

TBR=hayato@chromium.org,rune@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526634

Review URL: https://codereview.chromium.org/1329013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527617

Review URL: https://codereview.chromium.org/1318963006

git-svn-id: svn://svn.chromium.org/blink/trunk@201840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The methods are logically const (besides setData, which was left
unchanged). The mutable fields are merely caches, to make subsequent
nearby accesses (which are likely) faster.

Make BMP methods using FastSharedBufferReader const.

BUG=439655

Review URL: https://codereview.chromium.org/1309363006

git-svn-id: svn://svn.chromium.org/blink/trunk@201839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was walking the children of the root (usually the <head> and <body>) on
every call even if nothing was dirty. This meant each call was 5 branches
plus a trace macro, the macro often being more expensive than the no-op work.

Lets instead abort early if nothing is dirty and skip the trace macro when
possible to avoid polluting traces with trace overhead spam.

BUG=527982

Review URL: https://codereview.chromium.org/1328013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- introduce ResourceTreeModel.{suspendReload,resumeReload} to temporarily
    suspend page reloading;
- use the former to disable page reload for the period we fetch trace in
    the network FilmStripRecorder, as we can't start tracing while
    still retrieving traces;
- disregard DeferredTempFile writes after file was deleted;
- properly indicate frames are being recorded in FilmStripView when reload
    happens during frame recording.

This gets rid of "Tracing is already started" and other errors while repeatedly
reloading a network panel with screenshot recording on.

BUG=

Review URL: https://codereview.chromium.org/1314783010

git-svn-id: svn://svn.chromium.org/blink/trunk@201837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By default, pass the data as a single, pre-merged SharedBuffer, to imitate
decoding an image whose encoded data is stored in the Blink MemoryCache.

Add an option (supplied by a command line flag) to supply the data in chunks.
This simulates network traffic. It also allows us to better evaluate the
impact of calling SharedBuffer::data() in every call to decode.

TBR=tkent@chromium.org
BUG=467772

Review URL: https://codereview.chromium.org/1318713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The GN optimization config setup is being moved. This patch allows blink to switch between the new and old ones.

Review URL: https://codereview.chromium.org/1330693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1323613005

git-svn-id: svn://svn.chromium.org/blink/trunk@201834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1310923003

git-svn-id: svn://svn.chromium.org/blink/trunk@201833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is valid to do this:

linearRampToValueAtTime(0, 1);
setValueCurveAtTime(curve, 1, 1);

Previously, this caused an error because the code thought the two
methods overlapped.

BUG=528423
TEST=audioparam-setValueCurve-exceptions.html updated with more tests

Review URL: https://codereview.chromium.org/1328963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201832 bbb929c8-8fbe-4397-9dbb-9b2b20218538