- 23 Jun, 2020 7 commits
-
-
Robert Ogden authored
This utility is still being used by Isolated Prerender. Bug: 1097850 Change-Id: I2dde603516e7b446aa851dbec3776288c1c521b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258773Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#781068}
-
Brian Sheedy authored
Suppresses a flake in WebGL2 conformance's deqp/functional/gles3/shadermatrix/sub_dynamic.html test. TBR=ynovikov@chromium.org Bug: 1093482 Change-Id: I30c321811842293b7dc370fd23db506047059270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258675Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/768e91f7e3ba..9aba625ec30a 2020-06-22 michaelludwig@google.com Move setSampleMatrix and setSampledWithExplicitCoords into child registration 2020-06-22 awscreen@chromium.org Allow custom typeface deserializing of picture typefaces. 2020-06-22 senorblanco@chromium.org DawnTestContext: print validation errors with SkDebugf. 2020-06-22 fmalita@chromium.org Simplify SkParse::FindNamedColor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044996 Tbr: lovisolo@google.com Change-Id: If109dd5ea7eabc3a8b3292b0f305472dc89e382c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781066}
-
Jonathan Freed authored
This TTL has been used ever since the phase 3 was launched, so we should make it the default. Change-Id: Ica44b263d75564bfb46287928f003d299c81989f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255224 Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781065}
-
Travis Skare authored
Bug: 1096155 Change-Id: I79307ae7ca1f902e75fc7e0c5edc832c86e395c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254530 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781064}
-
Ovidio Henriquez authored
This change adds getDevices() to be measured by Web Feature. Bug: 577953 Change-Id: I23a9dd4b6cca6e713be98ad54653e5a51b4df92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258346 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#781063}
-
Timothy Loh authored
As per UI review guidance, this CL adds a minimize button to the Plugin VM installer, alongside the already present close button. Bug: 1094944 Change-Id: I377ff42c1ccf14c75b4f4636a4f6ad0de2a45739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249245Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#781062}
-
- 22 Jun, 2020 33 commits
-
-
Marijn Kruisselbrink authored
Bug: 1086845 Change-Id: Ifac1e7050b64f790482b2a06d0ef01814edc83e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258683 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781061}
-
Dana Fried authored
Was using wrong threshold for visibility; "zero" size for tabs is actually equal to the minimum possible tab size due to dividers and tab overlap. Bug: 1094051 Change-Id: I34f9a42a2029e5dbddcadff4327404b7316b060e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258637 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781060}
-
evliu authored
This CL adds a callback to the speech recognition client that is called when all of the mojo pipes are bound, indicating that the speech recognition service is available. Bug: 1096632 Change-Id: I153685c95be5d3de818de9ed06b51e039dae8573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252566Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#781059}
-
Brian Sheedy authored
Removes usage of //third_party/pymock in Blink in favor of the version made available via vpython. This is so that //third_party/pymock can eventually be removed. Bug: 1094489 Change-Id: Idf2fdfdb3a5cb5b9279a72dbc8d6803425b11f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255135Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781058}
-
John Lee authored
This CL updates the animation function to use the previous and new indices of the moved tab. This allows for more efficient animation of pinned tabs (CL coming soon) as indices are needed to determine the vertical and horizontal movements of the pinned tabs within a grid. Bug: 1082344 Change-Id: I9835baa597fac941df83c3113112bd8c18d44bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258333 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#781057}
-
Jimmy Gong authored
- Fixes a bug in which ChromeVox was unable to read print job entries. - This is because |jobEntryAriaLabel_| was returning early due error in checking for invalid fields. - Also adds labeling to the cancel print job button. Bug: 1097411 Change-Id: Ib65e14c8a282edb861a95ebd9643d8feec16aeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255670 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781056}
-
Matthias Körber authored
This change adds UKM and UMA logs to track user edits of autofilled field values resolved by type. Change-Id: Ied82b4deaadba4481660f567ef7e81eca735677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#781055}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b200086d. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." 45c98a0e "Origin isolation: test initial about:blank" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I4afc359f97836bafc69d718e4820b6aa81e6d141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257726Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781054}
-
Chong Gu authored
Enable blink_unittests, headless_unittests, headless_browsertests, and screenshot_sync_tests on Fuchsia CI bots. Adds ~15 minutes of bot time and ~2 minutes of run time per build. Bug: 1090068,757053,1058255 Change-Id: I547b5e8b6bd7b7a606c7c4ff4febcb6ef99d2158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255200Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#781053}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib9e1ff5426bd74e4eb9b51345752c51d162119e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781052}
-
Chris Dalton authored
Bug: skia:10419 Change-Id: I4f6926d7e4039edf9e16549c1ebd4db60011e1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253344 Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781051}
-
Dominic Farolino authored
This CL removes unnecessary checks around the script returned from ScriptLoader::TakePendingScript, since the return value is always non-null. R=hiroshige@chromium.org, kouhei@chromium.org Bug: N/A Change-Id: I6fa93b01657c3315d5c8b6714cc9ffb867808d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258338 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781050}
-
Sicheng Li authored
In this CL, we fixed the screenOrientation when launching with a landscape splash screen, it started with a portrait mode. We fixed this by setting the android:screenOrientation="screenOrientationLockType", reading from the Web manifest file, for the individual activities. Bug: 1032570 Change-Id: I1ae59a5171a5a032aa79fdc5123239074e2a58f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248321 Commit-Queue: Sicheng Li <scli@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781049}
-
Emily Stark authored
This experiment shows the path on page load and then fades it out after a fixed delay. We're not currently planning to experiment with this variation, so this CL cleans it up. Change-Id: I4e7be11aab643654af820397ffae2e9a684161b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254152 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781048}
-
Dmitry Torokhov authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/60f6f4105492..bd15beb76e99 $ git log 60f6f4105..bd15beb76 --date=short --no-merges --format='%ad %ae %s' 2020-06-12 dtor system_api: define VM permission service protocol 2020-05-05 kevinptt runtime_probe: add protobuf fields for input_device 2020-05-27 fletcherw lorgnette: cleanup ListScannersProto method 2020-06-10 omorsi system_api: Add chaps key permissions proto 2020-06-16 omorsi system_api: Refactor system_api/BUILD.gn 2020-06-17 fletcherw system_api: add UNSPECIFIED to lorgnette enums Created with: roll-dep src/third_party/cros_system_api Bug: 1071872 Change-Id: Ide26a8965f20b6e8413250b9ed9893c6006924d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257997Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#781047}
-
Xiyuan Xia authored
PaginationModel fires 2 TransitionEnded on invalid page selection. One for page selection and one for reverting it. Only the first one is intended. Bug: 1097508 Change-Id: I92480a807bd20e515dddcd0d564262b66f94f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258419Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781046}
-
Alison Maher authored
Currently, during layout of fragmented positioned elements, we are retrieving the incorrect ContainingBlockInfo. This change updates GetContainingBlockInfo() to take the containing_block_fragment of the positioned element into account, if one exists. Bug: 1079031 Change-Id: Ib37f4e1c548b04fe4d870a870c12bae8cb655fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248619 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781045}
-
Azeem Arshad authored
These are key metrics for cellular networking features and are being used actively. Extending expiry to 2021-06-30. Fixed: 1089036, 1089035, 1089034 Change-Id: Icd949d5f2ea1b6e4bdb73738bbda30046a3821f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252866Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#781044}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592845188-326bac214e029df6175b867be1c279c818f51cfd.profdata to chrome-win64-master-1592848702-1e1967415d9c07114dc1aabb08c26a82150dd920.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I918cc961d9d8c004fc19052c2ba58052c955e39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/92379bff49c2..4cf65bcab596 2020-06-22 rharrison@chromium.org Rolling 4 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If13903b95c5246becb3857d663e72057fe6179da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781042}
-
Owen Min authored
Add 'future_on' definition in policy_templates.json and add_new_policy.md. Add a new section in add_new_policy.md about launch policy. Add new rule for modifying existing policies. Bug: 1076560 Change-Id: Ifa75657c17b74f15c5432078f3d494e57d074478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252955 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#781041}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6c865efa23e..4150b9e6e16d 2020-06-22 jalyn@microsoft.com Custom Shortcuts: replace ListWidget with ListControl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide6457ac4a3d57d59783529d93197306c70be228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258373Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781040}
-
cfredric authored
Bug: 997047 Change-Id: Ib49fad152333483faf2fa3f2ab2528271db58b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246841 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#781039}
-
Kevin Babbitt authored
Refactoring in preparation for making system color keywords compute to themselves. Remove one-off flags for storing "is current color" and store StyleColor values directly - these will be flexible enough to retain system color keywords (and in the future, color-mix) through computed-value time. Bug: 1081945 Change-Id: I8184473b7180c13d08a76bf63f582af834accf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252475 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781038}
-
Lei Zhang authored
A subdir, with more owners. Change-Id: I49a9d6f0b9ad1103847c6e779f254e465ea0ae74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253698Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781037}
-
Brian Sheedy authored
Adds an 'ignore': '1' pair to the JSON uploaded to Skia Gold by the instrumentation tests if the test is being run on an unsupported configuration and the test has not explicitly opted into failing on unsupported configurations, i.e. when baselines for a test are not actively maintained. This is so that unrelated CLs don't get comments posted to them by Gold because a test on an unsupported configuration happened to produce a new image on that CL. This mainly applies to the Pixel 2 w/ P configuration, as it's run on many Android changes but not listed as a supported configuration yet. Bug: 1057851 Change-Id: I74c2fffd8f5bb80412cd070d9240a34d6f335df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258343Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781036}
-
Alexander Timin authored
At the moment we generate an initial fake navigation for a blank window.open(), which leads to RenderDocumentHostUserData being destroyed and the data set when WebContents was created. Add a logic to prevent this from happening — more specifically, do not reset per-document data when we see a strange navigation (DidCommitNavigationInternal with a navigation which is not in a WaitingForCommit state). R=alexmos@chromium.org,dcheng@chromium.org,sreejakshetty@chromium.org CC=bfcache-bugs@chromium.org BUG=1071232 Change-Id: Ib8db0c3006819f2ea41f7fd8174de8ea426d6db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235598 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#781035}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I40a2c37d4c3597bfca324a6c352e459c3cb71923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258580Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781034}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9fe157e1c0710981964e1df92051abab985bae6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258113Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#781033}
-
Maksim Moskvitin authored
This CL adds migration from backward-compatible keystore mode (e.g. when data is encrypted with old passphrase, but Nigori can be bootstrapped using only keystore keys) to full keystore mode (e.g. keystore key is used for encryption). New behavior is guarded by killswitch. Bug: 1094326 Change-Id: I15035deac241dd1cb934eb592194c32f061f400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243292 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781032}
-
Xiang Ji authored
This reverts commit 60536744. Reason for revert: According to https://chromium-review.googlesource.com/c/chromium/src/+/2242194, the behavior changes of these two policies don't seem correct. Comments from Moe: That does not sound correct. chrome://newtab redirects to chrome-search://local-ntp/local-ntp.html or chrome://new-tab-page (based on the ntp-webui feature flag) when Google is the DSP; or redirects to a third-party NTP, if applicable. In off-the-record profiles (guest and incognito) there is no directs and the WebUI page is associated with chrome://newtab. The NTP URL to point to should always remain chrome://newtab. Original change's description: > Fix a test failure due to the change of Chrome new tab page url > > Validation: > Tryjobs, the failure was from another test > > Change-Id: I2db090b308c05887485edfef894140c6d89c3b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254705 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Xiang Ji <jxiang@google.com> > Cr-Commit-Position: refs/heads/master@{#780527} TBR=zmin@chromium.org,jxiang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2b4c27aecac5a12a668083cfb0eee5f6249c5aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258674 Commit-Queue: Xiang Ji <jxiang@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781031}
-
Maks Orlovich authored
Instead, report just the failure to Cookie.CommitProblem Bug: 1052953 Change-Id: Ie49bfecdcc060df093759f0a8d753df6f5ff24c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256445 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#781030}
-
Cammie Smith Barnes authored
Our CreativeOriginStatus metric is recorded as unknown for approximately 70% of ads. We want to see how much of this indeterminacy is due to frame throttling, so we add another histogram that splits by whether there is any unthrottled frame in the ad frame tree. The CreativeOriginStatus metric relies on FCP, which for cross-origin frames can be very large. This is partially due to the flow where: a frames starts outside the viewport and is throttled; frame is later scrolled into the viewport, becomes unthrottled; frame receives FCP. Because paint-timings are relative to navigation start for the frame, the values are skewed. This change propagates some additional info, a best-effort timestamp of when a frame is first not throttled, up to the browser process to address this. Continuation of https://chromium-review.googlesource.com/c/chromium/src/+/2088037 which had inexplicable trybot failures. This is the same code ported into a fresh CL. Tests: third_party/blink/renderer/core:unit_tests out/Default/blink_unittests --gtest_filter=*PaintEligibility* chrome/test:unit_tests --gtest_filter=*CreativeOrigin*Throttling chrome/test:browser_tests --gtest_filter=*CreativeOrigin* Bug: 1049125 Change-Id: I8c9ddd41870ce9797ff0f01de853f7576efd4606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161606 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781029}
-