GitLab

This causes trichrome's dex to be compile with "speed" rather than
"speed-profile", which is a substantial binary size regression.

Also adds a histogram to track when the work-around happens.

Bug: 1152970, 1159608
Change-Id: I25e2c350b54724613234b23505078f5df88d9cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602657
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840328}

Bug: 1152274
Change-Id: I6677026925fc0914197e51de557ab5df37d08c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595835Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840327}

This change introduces a count histogram for the number of routines a
user runs during one session in the Diagnostics App. The count starts at
zero each time the app is opened, and it is emitted when the app is
closed.


Bug: 1128204
Change-Id: I5dc7eec4f33006a9694c6c694d5a83a06d59a3a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570345
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840326}

This flag has been matching the value of the overlay-scrollbars flag
since M63 so we can remove it. It's used in the corresponding
LayerTreeSettings member. The setting can now (remain) always-disabled
on Android and enabled on other platforms whenever overlay scrollbars
are.

Bug: 746342
Change-Id: I799dcfd52e97d0ee1745ad73d19951341e9f25f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605883Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840325}

This change implements a new NetworkCallback class used for listening to
changes to the default network on Android.  It includes two fixes:
1. Avoids calling synchronous ConnectivityManager methods which
   is prohibited inside NetworkCallbacks.  This is a preemptive fix, not
   known to actually be causing issues.
2. Catches onCapabilitiesChanged() which includes cellular connections
   transitioning to and from SUSPENDED states.  Failing to catch this
   could leave the NetworkChangeNotifier in an incorrect disconnected
   state, see crbug.com/1120144.
This new NetworkCallback is used on Android R and newer versions to
limit retesting and as these are the only versions experiencing issues.
I've tested this thoroughly on Android R.  Additional automated testing
isn't feasible given the code's closeness with Android APIs involving
immutable classes with no public constructors (e.g. NetworkCapabilities).

Bug: 1120144
Change-Id: If77d4524f8f8e0be78563412176c2ea2d07f00c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605304
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840324}

Notable differences from the existing fake CI bots:
1. Instead of splitting the bots by dEQP/non-dEQP they are split now by
   Chromium/ANGLE-specific, which means:
2. Suites which don't depend on Chromium, like angle_end2end_tests and
   angle_perftests now run together with dEQP suite.
3. Some tests suites were removed from ANGLE bots - gpu_unittests,
   as well as all GLES2 conformance tests.

Bug: angleproject:4483
Change-Id: I5aac17351c8067c6f53a1527be3285cbd80822ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603577
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840323}

Due to the fact that we reuse TSF document for text fields with same
input type, we should property reset the state by clearing focus before
re-using the document.

Bug: 1162974
Change-Id: Ia92187705e93cc064e992e28c8638d5647e06ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610147Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Reviewed-by: Siye Liu <siliu@microsoft.com>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#840322}

The current token expired on December 29th, and should be updated.

Change-Id: Ia7dbcd367b5bb0ba6b536b0bd44fba5039fbaa19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611688
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840321}

Bug: 1157892
Change-Id: I386fb6bc5377c0a32c504eac5d8f0f92497a2943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599446Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840320}

BUG=1157672

Change-Id: Ib31d8dd60486f8634d9477ad82d5d9bbbc095dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590428
Commit-Queue: Alice Gong <alicego@google.com>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840319}

Bug: 1027683
Change-Id: Idd35bc8cdb81f7e04ddfd997d28d128902e1ee4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611288
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840318}

This CL adds a lacros browser test that creates a lacros window,
triggers overview mode, and then closes the window while overview mode
is still active.

Change-Id: Ib16b9f8dedabc49a3f1722bd6416f9c99ec7a8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601260
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840317}

This class added an unnecessary layer of complexity to access
memory instrumentation functionality.

Follow-up: Rename //services/resource_coordinator/ to
//services/memory_instrumentation and remove "memory_instrumentation"
subdirectories.

Change-Id: I556423d2004ab0d2b2462ae5b0cac529712d50de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593829Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840316}

Bug: 1149691
Change-Id: I9d89fed2bab361c8ea34d24ed0a42f40041b09d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593246
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840315}

This CL converts a pattern in extensions tests where a RunLoop quit
closure is bound to a callback argument. In most of these cases we can
simply convert to a OnceClosure.

printer_provider_apitest has one exception that's a RepeatingClosure
because the API actually may call the callback multiple times. In this
case, the quit closure must be copied so it must be a RepeatingClosure.

Bug: 1152268
Change-Id: I4a201cbd78d818f1793b94a8c106d62bb59ba8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605647
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840314}

This is the usual boilerplate in SessionManagerClient and friends to
expose the new function.

BUG=chromium:1073940
TEST=None

Change-Id: Id9144ac921d8ab5f26f0874da9476838a3ebef5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560271
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840313}

This saves significant time in offer/answer.

Bug: webrtc:12215
Change-Id: Ifec4e8fbb630f09b68299b880a94055f7a068027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596266Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840312}

Disable showing of offline pages using finch.
This will be used to disable showing offline pages on Android
R and later where offline detectivity is broken.

Bug: 1138728, 1120144
Change-Id: Ic0665a117981ef91f85807f33818dabb3d08cca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564217Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840311}

Seems that WebViewImpl may be null, but that doesn't make much sense.
Add a few checks to see if they fire.

BUG=1160652

Change-Id: I5979a5ad62d91f9b8868d5ce72f29b47297e2c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611126Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840310}

Add instructions for rubber stamping expectations.

Bug: 1159542
Change-Id: Ifc546f0e8915ed2291322d4af38a8066c40ac728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611667Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840309}

This CL updates each card in the OS Settings page such that rows that
appear at the very top of the card do not have top borders to prevent
double borders caused by a top border and the card's shadow.

Bug: 997034
Change-Id: I0a5a3ee7810bcfc994103ac8eea06e17b43fe2fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605625Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840308}

This CL changes LocalToRemoteSyncer::Continuation from Callback to
OnceCallback.

Bug: 1152272
Change-Id: Ie839b5982775429332c48d9c3930151a74f42423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604677
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840307}

TBR=govind@chromium.org

Change-Id: I562a07104074aba6a105abc5c9f9ad04dd854003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611525Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840306}

This renames SiteSettingsClient to SiteSettingsDelegate to match other
similar interfaces, and merges SiteSettingsHelpClient and
WebappSettingsClient into SiteSettingsDelegate so there's only one
interface for embedders to implement.

Things were originally split into multiple interfaces to help group
methods together and make it easier to reason about. Whether or not that
actually worked is debatable, but now that we've removed the need for
multiple of these sub-interfaces, the 2 that remain should be merged
into the main one.

Bug: 1077007
Change-Id: Ia02d8e47d38d1b4878b4a4d0cda5ccbb74de6352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594441
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840305}

Noticed when trying to enable UnnecessaryParentheses that many generated
files were failing the check. It is likely not worth fixing errorprone
checks for generated files, and we can save on build times by not
compiling generated files with errorprone.

Bug: None
Change-Id: I52f69d3d69dfe61e78143cffd34700e5ada05bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606128
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840304}

Screenshot: https://screenshot.googleplex.com/iGaHZcsb7RMuKDB.png

Bug: 1093185
Change-Id: I09ccf1b5cbe68ebcf479727cd616710578ca6e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611334Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#840303}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: If6cf34eb2161289cb3551ca44dee6e4acf841d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611112
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#840302}

I'm no longer actively working on Chromium.

Replace myself with smcgruer@ in most places. Note that
third_party/blink/web_tests is already owned by all committers (*) and
the OWNERS files within are only informative.

Regarding blinkpy, Stephen has made significant contributions there:
https://chromium-review.googlesource.com/q/owner:smcgruer%2540chromium.org+blinkpy+-%2522import+wpt%2522+-%2522roll+wpt%2522
so I'm confident with this nomination.

Change-Id: I38eac7d102ecf86dc9273acde496ca6d9d072c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611086Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840301}

Bug: 1152274
Change-Id: I9a067d0db2d6ad05d353db9f655272cd16bc4efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595601Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840300}

This uses the shared main thread context to convert these frames into
SkImages. Since there's no reason to create a new IO-thread context,
the entire conversion process is moved to the main thread.

Fixed: 1161825
Test: https://plnkr.co/edit/k6Itrjzzj60vT2fC?preview
Change-Id: I5e161cfc1e498442409f577d279a85c8c1322522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611341Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840299}

There is no guarantee native will be initialized when
onConfigurationChanged is called

Bug: 1162510
Change-Id: Iac48e4dc0c9ab3c6a080a72afeee52657fd32aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606874
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840298}

This CL handles transition keyframes when we composite background
color animation.

Bug: 1153670
Change-Id: I9252db7f7344472d8fc9f1866d1f5b2a038dd2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589114
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840297}

These methods are uncalled via CompositorDependencies interface.

BUG=1097816

Change-Id: Id5d6ffd39246f6ff55b965c04c38a7e0403ab409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587372
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840296}

The Filter callback in this class may be called multiple times so this
should be a RepeatingCallback. We also convert to pass-by-value to
indicate a transfer of ownership.

No change to call sites as they already use BindRepeating.

Bug: 1152268
Change-Id: I82df5dcc1a505cac4b778af1495209b3c74f6db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605875Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840295}

It is not possible to define GetInstance() generically - i.e. one code
path would return a ProfileProtoDB<Foo>* and another
ProfileProtoDB<Bar>*. The only way of unifying these would be to return
a void pointer, however, that would start to require a lot of static
casting. It is much cleaner to define the GetInstance() methods per
template.

Bug: 1159157
Change-Id: I4cbc39f9a4f03346e7f30179b13b3b18a47f1f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597658Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840294}

This upgrades the Add Supervision WebUI to Polymer 3 and removes all
HTML imports.

Previously, most of the UI was in Polymer 2 using HTML imports. We had
two targets for post_message_api.js, including one that modulized it
so OOBE and EDU Coexistence could use PostMessageAPIServer in JS
modules.

Now, everything is a module. No duplicate post_message_api.js target
is needed.

* Update the Add Supervision UI to a Polymer 3 component, replacing HTML
  imports with JS import statements and using html_to_js to templatize
* Remove modulization, make everything just a .js module
* Remove webview examples that didn't work and aren't necessary

Bug: 1111430
Change-Id: I54d441fb965e6cbf1bd982b86ec4bfa611c63f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600822Reviewed-by: Dan S <danan@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840293}

Add a story to track performance of subsequent open tab search with loading case

Bug: 1099917
Change-Id: I8e37f2f5f6771adcf35923f0c92af61c03d16f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605386Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840292}

This CL cleans up some remaining trivial callsites currently using
base::Bind where the called method already takes a modern
{Once,Repeating}Callback.

Bug: 1152268
Change-Id: I0c36a55354195899f6c2a0c134ac4da63a5a4339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602557Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840291}

This field points past the end of an allocation; therefore, it can
refer to an invalid allocation slot, which will lead to a crash in
the CheckedPtr constructor.

Bug: 1158039
Change-Id: Iaa141a51e680994a4c6bc9aabb6039621424706b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611704
Auto-Submit: Sergei Glazunov <glazunov@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840290}

This CL adds a presubmit script for the coverage related merge scripts
to make sure unit tests are enforced when changes are made.

Change-Id: Ifde0971374cba3f48c921bdc8ec404cca5eb1d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611327
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840289}