- 04 Sep, 2019 40 commits
-
-
David Black authored
Experiment IDs will be provided via finch and passed to the proactive suggestions server for triggering on the backend. This will allow us to reconcile server side logging and UMA logging with respect to experiment arms. Bug: b:139199715 Change-Id: I208b606f607ef165bd7ddbc18a912dc3dcd34c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783698 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#693411}
-
rbpotter authored
Change cr-toast-manager's cr.define to use: cr.define(... () => { function foo() {} let bar = ... return { foo: foo, }; }); syntax, to make it simpler to autogenerate the Polymer 3 version of this code by matching the polymer autogeneration script's approach to that of the JS modulizer script. It is possible to modify the autogeneration script to handle the code as-is, but this requires adding more annotations (e.g. to indicate whether variables should be let or const) and more complexity in the script (e.g. to replace ": " with "= " and to correctly handle arrow syntax). Also fixing some typechecking errors that were found by the compiler after changing the syntax. Bug: 965770 Change-Id: I7a725ad8513f4141bba13e13cd842133105cb60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784101Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693410}
-
Lambros Lambrou authored
This fixes an issue reported on recent MacOS version, where the ContinueWindow was not hidden after pressing either of the buttons. This is the same issue that affected the Share confirmation window, which was fixed in http://crrev.com/c3ed375625dabcfe3ceaf2ca17146a6b10fc3bf1 Change-Id: Id2a3e913a3e9fa5c47d05fbbc2e2b314eae3612d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785997 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#693409}
-
Haiyang Pan authored
This includes: - platforms;android-23 - system-images;android-23;google_apis;x86 Bug: 997376 Change-Id: I376c588d625c6ffb6ebdcd87a08a93d0a3be5c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769798Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#693408}
-
Albert J. Wong authored
Attempt to reland: https://chromium-review.googlesource.com/c/chromium/src/+/1773878 CFI bot identified a lifetime issue that manifested in a hang during TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedIframe/0 === Original commit message === RenderWidgetHost::GetVisualProperties() was doing 3 separate things (1) Actually calculating the VisualProperties (2) Checking against the last stored VisualProperties to determine if the stored copy needs updating. (3) Determining if an ack should be expected if an update is eventually sent with the result of this function. This CL breaks it out into 3 new functions: GetVisualProperties() - Generates the VisualProperties. This should be const but too much of the call chain underneath it did not annotate their getters with const that annotating would be too annoying. DidVisualPropertiesSizeChange() - Helper function that extracts a common query used by DoesVisualPropertiesNeedAck() and StoredVisualPropertiesNeedsUpdate(). DoesVisualPropertiesNeedAck() - Returns true if sending the given VisualProperties update to the renderer will generate an ack. StoredVisualPropertiesNeedsUpdate() - Returns true if the stored copy of the VisualProperties is different enough from the incoming one that it needs an update. Bug: 998273 Change-Id: Ifabce4e3232ee313bde937e6098dc83c2e616333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783669Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#693407}
-
James Cook authored
Some users directly navigate to chrome://help to check for OS updates. Add a banner with a link to About Chrome OS. Screenshot: http://screen/KARbXaGN2no Bug: 1000307 Change-Id: Id85031eec50d65e2f1e862ec664b60e9e74e9e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784011 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693406}
-
John Lee authored
Bug: 989131 Change-Id: I152d509958df396b667bd54da5a75eb056f10589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778597 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#693405}
-
Gordon Guan authored
Performing layout inflation synchronously on devices with low core count leads to startup time improvement (~170 ms empirically, on one specific device) Bug: 985545 Change-Id: I4ee8a54f34ae040d357a2817f4d40038dcbe903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783528 Commit-Queue: Gordon Guan <gordonguan@google.com> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693404}
-
Guido Urdaneta authored
The image may be null in some situations, so check if it is null before sending it as a frame. Bug: 997556 Change-Id: I567f12e6a9890152a86b551c82cc64d962ead302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782697 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#693403}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53a464d7b4f6..c382c68c4f88 git log 53a464d7b4f6..c382c68c4f88 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 dbeckett@google.com Adding in a promise option to EvaluateJavascript 2019-09-04 bsheedy@chromium.org Reland "Reland "Reland "Support minidump symbolization on ChromeOS""" Created with: gclient setdep -r src/third_party/catapult@c382c68c4f88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:992452,chromium:978952 Change-Id: Iae2d10124a8502f92e65141b60085dbd2389e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693402}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65b7843ab9b6..69265b03982f git log 65b7843ab9b6..69265b03982f --date=short --no-merges --format='%ad %ae %s' 2019-09-04 lalitm@google.com Merge "trace_processor: migrate GPU tables to new macros" Created with: gclient setdep -r src/third_party/perfetto@69265b03982f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0c9a2f6ea72cff8cee72e18da4aedf0bca1c9c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693401}
-
Bailey Berro authored
Updates the icon for the OS Settings Personalization page. Bug: 996425 Change-Id: Ia5976f8d5b886e047234f7651cb6712147e4e3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785005 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#693400}
-
Toby Huang authored
SupervisionTransitionScreenTest uses a lot of login functionality that's centralized within LoggedInUserMixin. Avoid code duplication by refactoring SupervisionTransitionScreenTest to use LoggedInUserMixin for logging in. Bug: 990909 Change-Id: Iaead0d13e9b170a5e8eb933828c562dbfac45c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776903Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693399}
-
Dominic Battre authored
Extending the lifetime as we want to track the metric as we experiment with re-engaging users in Q4/Q1. Bug: 984187 Change-Id: I141a2173f4655796f332e00b9f797df1ab714ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768328 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#693398}
-
Jan Krcal authored
This CL extends the latency metric for initial sync to all data types (previously, we recorded that only for types with ephemeral storage). Bug: 998501 Change-Id: If11f0969b74c699de8c6d9ae665932083379a806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773147 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693397}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iebd8212bac32c3bc19df732845b300b07a8b987a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693396}
-
dalyk authored
Now includes OpenDNS FamilyShield mapping. Bug: 985589 Change-Id: Ia526ddfb19eafe236c01c5f3b78b00b00c3c36f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784971Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#693395}
-
John Lee authored
Bug: 999094 Change-Id: I830363d723b495669eb22c0ed30c32ffb41182e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783664Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#693394}
-
Bettina authored
The current code does not decipher between multiple signed-in content area accounts. However, the SecurityEventRecorder only supports one signed-in account, whether it's consented or unconsented. The modal warning still shows for all signed-in content area accounts. Pingining is now only for unconsented signed-in account. All other content area signed-in accounts will not get pings. Bug: 999369,914410 Change-Id: If197c4085794025a4355c3d2a89c173f4c310178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777068 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693393}
-
Nick Harper authored
Bug: 994899 Change-Id: I458f7fdd5b925ab58b3bb522301d10be7612fee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772493 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693392}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aea4bca2621b..a6b07058f952 git log aea4bca2621b..a6b07058f952 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 thestig@chromium.org Add a test for glyph path rendering. 2019-09-04 thestig@chromium.org Add a pixel test for a fixed JBIG2 bug. 2019-09-04 thestig@chromium.org Remove CRLF line endings from link_annots.in. 2019-09-03 thestig@chromium.org Roll third_party/freetype/src/ 9adc3b35f..543a3b939 (31 commits) 2019-08-28 gourabk@microsoft.com Add embedder tests for progressive render public APIs Created with: gclient setdep -r src/third_party/pdfium@a6b07058f952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:601362,chromium:963885 Change-Id: Ib95fe39d0b40e4f159dd0dd4493b6bc4070d53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f38bc1796282..183971ca2a9f git log f38bc1796282..183971ca2a9f --date=short --no-merges --format='%ad %ae %s' 2019-09-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@183971ca2a9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ifd857731807e36960cae9958e6a41b580dd3612f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693390}
-
Lan Wei authored
When I changed dispatching events from synchronously to asynchronously, it causes some regression because we have not received the result from the actions but the tests already finished. We should make the default way of dispatching events as synchronously, when we really need send events asynchronously then we add this flag. Now I added this flag so I can enable the tests again. Bug: 999750 Change-Id: Ibe6185b63db4a731674e758cdf484896a6ced766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783641 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693389}
-
chrome://os-settingsBailey Berro authored
- Show the gear favicon when navigating to the chrome://os-settings page - Note: this is only relevant when os-settings is opened in a browser tab Bug: 977889 Change-Id: Id3c9ad8c8a06cb65e8c43b7ec5f0a9cdb580233c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771595 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#693388}
-
Joey Arhar authored
Bug: 856777, 849483, 868407 Change-Id: Iebcdfe2adb4fdfc55281ebd91fe8da100a08f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639277 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#693387}
-
jimmy gong authored
This reverts commit 56118b17. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make CupsPrintersManager a CrosNetworkConfigObserver > > - CupsPrinterManager will now detect for network changes. > - Previously, when the network changes CupsPrintersManager would > wait until ZeroConfDetector updates with new printers. > - This resulted in a small time frame in which CupsPrintersManager > would still retain stale printers from the previous network. > - This fixes that bug by clearing the all printers upon a network > change, ensuring only new printers are populated. > > Bug: 779602 > Test: unittests, end to end manual > Change-Id: I0efe9e0a2252378bca178dc4b6dcea4da6baa978 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764677 > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693364} TBR=zentaro@chromium.org,baileyberro@chromium.org,jimmyxgong@chromium.org Change-Id: I1a5ca385c7babae571722722890276efe9b65dd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785897 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#693386}
-
Anushruth authored
Added chrome tast tests with informational tests enabled to chromeos-kevin-rel-hw-tests We seem to have capacity for now (http://shortn/_StppJowPoi) R=bpastene@chromium.org Bug: 988581 Change-Id: Iba8d5acb1ccde68a7dc15a6ddc8555de0bc67c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781771Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#693385}
-
Robert Ma authored
See https://crbug.com/944117#c44 for more context. Also clean up redundant Mac-related configs in test_suite_exceptions.pyl Bug: 1000762, 944117 Change-Id: If9fac657e841543a5b6f671131e5c9a4fe6f154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784941Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#693384}
-
Sebastien Marchand authored
Bug: 995542 Change-Id: I4d0cd3f588fc71f3d203cc6135bcc994dfaa4c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774794 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#693383}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a63ee7f8a8b..88b1ffcb482a git log 7a63ee7f8a8b..88b1ffcb482a --date=short --no-merges --format='%ad %ae %s' 2019-09-04 wbbradley@chromium.org build api metrics: implement emit_metric tool Created with: gclient setdep -r src/third_party/chromite@88b1ffcb482a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib68c336d911e485353eaa658356f9d793051da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693382}
-
Ryan Hansberry authored
This filters out Bluetooth devices which cannot be paired to. The experiment conducted in crbug.com/976334 shows positive or neutral impact on all relevant metrics. Notably: * Bluetooth.ChromeOS.DeviceSelectionDuration.Settings.NotPaired.BLE: 95th percentile reduced from 26.8 seconds to 22.7 seconds. * Bluetooth.ChromeOS.DeviceSelectionDuration.Settings.NotPaired.Dual: 95th percentile reduced from 28.3 seconds to 26.6 seconds. Bug: 976334 Change-Id: Icff5f41553435ecc9f0a631460f7e8a01be1d9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784979 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693381}
-
Jun Mukai authored
The code still assumes AppListItemView is a direct child of AppsGridView. This fixes the correct bounds calculation. Bug: 999314 Test: the new test case Change-Id: I260137a2db41d943d6f7ddbf5176fb15dbc49810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779131 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693380}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f2782e0602c..7e44ec26d652 git log 1f2782e0602c..7e44ec26d652 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 mihu@microsoft.com GL_EXT_multisampled_render_to_texture extension. Part 1. Created with: gclient setdep -r src/third_party/angle@7e44ec26d652 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I1cb14684301b93d79af75af1710d8bd0d0913f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693379}
-
Vasiliy Telezhnikov authored
When Skia is running in ES2 mode over ES3 context (use_es2_for_oopr workaround) using R8 textures causes internal checks in Skia. This CL change format to LUMINANCE8 in these cases. Bug: 998882 Change-Id: Ifb350141c0b332fc2fbe6bc6155fff69a031a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783526 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693378}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc0b4a6f0420..142d30cdaa58 Created with: gclient setdep -r src-internal@142d30cdaa58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic14d3e8954ec3538054ba33247f26684ace5559f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693377}
-
Ryan Hansberry authored
Remove speculative debug CHECK added in crrev.com/c/1705014. Bug: 969135 Change-Id: I18d7867d6ba82818db2eb9992687c1541886b420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783881 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693376}
-
Daniel Clark authored
Change the LocalizedLandmarkType and LocalizedControlType for the contentinfo aria role from "content info" to "content information" per https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. Also update the LocalizedLandmarkType for <footer> when scoped to the body element to "content information", since it inherits this from the contentinfo role per https://w3c.github.io/html-aam/#el-footer. Note that this doesn't affect <footer>'s LocalizedControlType, which should be "footer" (but is currently still "content info"). That is handled in the separate change at https://chromium-review.googlesource.com/c/chromium/src/+/1763243. Bug: 997897 Change-Id: If958b2090447010f0c0f3839739354dd4a0ea683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772228Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693375}
-
Miguel Casas-Sanchez authored
This CL creates a chrome:flags entry for UseFakeDeviceForMediaStream, allowing for ChromeOS clients to replace the audio/video capture devices in the system with a fake capture device, a venerable PacMan with a timestamp. Such fake webcam has been around forever for testing and verification, in the form of a command line, that is used in a bazillion places, so this CL basically checks the FeatureFlag and appends the command line if needed, in MediaStreamManager, the singleton hanging from BrowserMainLoop where media capture first starts. The purpose of this flag is to facilitate debugging of webrtc+video capture on ChromeOS, by allowing the developers to switch off the capture stack entirely, verifying the WebRTC stack in isolation. Bug: b:140250310 Change-Id: Iac8ff27ac3cc1a178d58661f53b0ea9737f6d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783308Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#693374}
-
Lukasz Anforowicz authored
Bug: 992121, 992381, 988351, 997741 Change-Id: Ib243ea0a34fb001ea2ace63cef9017927c27c13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779424 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693373}
-
Hiroshige Hayashizaki authored
This CL regenerates mixed-content test files that reflects changes [1] and previous changes in https://crbug.com/906850 and removes old files. Purely mechanical. This CL largely renames test file names, and [2] contains old->new file name mapping data. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1783799 Bug: 906850 Change-Id: Ic13f66750bd3f45a362ed92fc5aaa4844420b474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783800Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#693372}
-