- 05 Sep, 2019 40 commits
-
-
David Bienvenu authored
This reverts commit 4105186f. Reason for revert: <crbug.com/999467> Original change's description: > Migrate pinned icons in ImplicitApp subdirs. > > Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the > subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why > Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories, > but we should handle them. > > Bug: 980239 > Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb > TBR: > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681035} TBR=msarda@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Bug: 980239 Change-Id: I2b19e825ccd0f1bd2975678d9acb1ad7ff90cc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787560Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#693898}
-
Miyoung Shin authored
This CL converts UkmRecorderInterface{Ptr, Request} in services, blink and content to the new Mojo types. Bug: 955171, 978694 Change-Id: Icb32c106509d909113c522f1ed363460ac5f6179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787023 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#693897}
-
John Chen authored
Remove reference to field trial SiteIsolationExtensions/Control, no longer exists. However, have to keep force-fieldtrials switch due to https://crbug.com/996865. Change-Id: If6b644d0cb6d6c6e860a1be22b33a37ec6a3b4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787989 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693896}
-
Staphany Park authored
Bug: 1000932 Change-Id: Iec2b4ffc50d8688b3727da7d4cfb8a4a1b22c63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787340 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#693895}
-
Ella Ge authored
This CL makes the pointer lock request also pass the PointerLockOption.unadjustedMovement (added in crrev.com/c/1764943) to browser with the pointerlock request IPC. It stores the boolean mouse_lock_raw_movement_ in RWHI whenever receive the OnLockMouse IPC, and use on GotResponseToLockMouseRequest. Storing the value because passing the boolean to RequestToLockMouse will get into too many code path. RWHI.GotResponseToLockMouseRequest() is the only caller to RWHV.LockMouse(), and RWHV.LockMouse is the only place that locks mouse. Bug: 982379 Change-Id: Ia930960bb3c16e249e26e154430c62a9bf06b8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767098 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693894}
-
yilkal authored
This CL hides virtual keyboard when parent access widget is being shown. It achieves this by doing the following: 1. Hide virtual keyboard when parent access widget is shown. 2. Prevent views::Textfield from calling views::Textfield:: ShowVirtualKeyboardIfEnabled() by making changes in ParentAccessView::AccessCodeInput and AccessibleInputField. Bug: 938705 Change-Id: I5199a8a6290e2cf47602b0ef130b4aa5c05b7ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784337Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693893}
-
Miyoung Shin authored
This CL converts PreviewsResourceLoadingHintsReceiver{AssociatedPtr, Ptr, AssociatedRequest, Request} in content to the new Mojo types. Bug: 955171, 978694 Change-Id: I9a2634259b9a737d775922bd0c8202914ea171e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783686 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#693892}
-
Dave Tapuska authored
value is usually defined as a variable on the json class so it causes a shadowed variable. Rename the variable on the stack to to_value_result this name is unique enough it doesn't cause shadowed variables. BUG=794619 Change-Id: I43bb753d1fdec6871386881641a3d59ab010d475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786582Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693891}
-
Weiliang Chen authored
Add implementation to SharedImageRepresentationFactory to actually call into the SharedImageManager to produce overlay representation. R=rjkroege Bug: 979795 Change-Id: I43ab5fc2d9c9b8db1e90b24cfe33edbd10381c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786300Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#693890}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/gfx. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msw@chromium.org Bug: 891670 Change-Id: Icf52c4d2d4b586cdec910c16988661fb2f2a0058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787240 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#693889}
-
Ahmed Fakhry authored
This CL fixes the overlap between the desks bar, and the splitview drag indicators when in portrait tablet mode. The desks bar is now shifted down when necessary to make room for the indicators. BUG=998239 TEST=Manually, Added new tests. Change-Id: Ic890a8d344a93551c617cb3f2212f19f869ab611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787158 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#693888}
-
ckitagawa authored
AFAICT this behavior was only necessary due to the upstream print caller not setting flags correctly. The upstream print code now uses the correct flags so modifying the GlobalPaintFlags in FramePainter is no longer required. Also manually tested printing on Linux Desktop. Bug: 510280 Change-Id: I4400b361fe5c389a60f0d758555360ca14b52a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783357 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693887}
-
Alison Maher authored
Video controls were broken in forced colors mode because default_forced_color_style_ was not set in the case of media conrols. Bug: 970285 Change-Id: I9e05335a893dbf8856c3093bcafa5d76beef268d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778651Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693886}
-
Xiaocheng Hu authored
This reverts commit 0a8524d2. Reason for revert: Reverting CHECKs back to DCHECKs in the next version Original change's description: > Verify if crbug.com/996037 has been fixed > > This patch turns a DCHECK into CHECK to verify if the DCHECK is still > hit on production builds. > > This patch will be landed into version 3903, and will be reverted in > the next version. > > Bug: 996037 > Change-Id: Ice5237e9a0761b991425b1dbe402350a6ddd9b86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784161 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693371} TBR=eae@chromium.org,xiaochengh@chromium.org,srinivassista@chromium.org Change-Id: I46ca89b68b901d0d86cc03a61ea851e2bdc8fdae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787031Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693885}
-
Robert Liao authored
This allows subclasses of TypographyProvider to delegate to DefaultTypographyProvider for styles already provided by the TypographyProvider. BUG=865318 Change-Id: Id2a8d8a6e08157198c98920c4ed9438170baec5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779536Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#693884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6f7d201f629..e2f7ff015b5e Created with: gclient setdep -r src-internal@e2f7ff015b5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1b168f18fb5a49c48cd1c589ad17744d654c1aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787853Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693883}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 89fe5345. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." 668359aa "[Trusted Types] Rework default policy error handling." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools smcgruer@chromium.org: external/wpt/css/css-position NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I776be5855b41d752054ce797230070f80d936355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787958Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693882}
-
Clark DuVall authored
Now to run the WebLayer shell on Android all you have to do is: $ autoninja -C out/foo run_weblayer_shell $ out/foo/bin/run_weblayer_shell Change-Id: Icc6e1d771a6e83387c4d7fec989ddbb043f4575c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787855 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#693881}
-
Himanshu Jaju authored
The action button is added to error notification if it is due to internet connectivity issue. Try again does what the name says. Manually tested for some conditions, works well :) Also removed translation files for non-existing texts. Bug: 996322 Change-Id: I64b15fdeaaaf95edf1a081d7f852e3f4ab167f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787549Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ed60ee797b6..6d991e313322 git log 1ed60ee797b6..6d991e313322 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 treehugger-gerrit@google.com Merge "Fix presubmit warning about js files" 2019-09-05 treehugger-gerrit@google.com Merge "proto: Minor changes to TrackEvent tracks" 2019-09-05 treehugger-gerrit@google.com Merge "ui: Show grab pointer when mouse over track shell" 2019-09-05 primiano@google.com Merge "tools(tmux): support target devices" 2019-09-05 fmayer@google.com Merge "Better docs for ProfilePacket." 2019-09-05 taylori@google.com Merge "perfetto-ui: Ensure userspace 'busy' slices are accurate" Created with: gclient setdep -r src/third_party/perfetto@6d991e313322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifeae5725b000389f7e8ba690936a7be3f8a6a215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693879}
-
Brian Geffon authored
The only thing in resource_coordinator_features is a flag for the performance_manager Windows WorkingSetTrimmer. That feature flag should really live in performance_manager features with the other similar flags. This CL moves that flag and then cleans up the files that are no longer needed after that move. BUG=chromium:988602 Change-Id: I0531ead60d5d1117046607a38d8165936f008ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783299Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#693878}
-
Evan Stade authored
Default argument values are banned on virtual functions. https://google.github.io/styleguide/cppguide.html#Default_Arguments Bug: none Change-Id: Ie3786e31165317dc2c3a156fc9437949f2eb80f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785740 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/domain_reliability. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 891670 Change-Id: Ia403dd784ffbbee2f9ca96e39bd58af6072cbb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786856 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693876}
-
Bill Budge authored
- Adds a reference in the streaming client to the cached module data, to keep it alive as long as streaming is ongoing. Bug: chromium:1001027 Change-Id: I8eb18b1adda2cbb47e76673e160fc0d6e51fdab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787462Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#693875}
-
Alison Maher authored
The effects of animating properties affected by forced colors mode should be overridden in forced colors mode if forced-color-adjust is set to auto. Bug: 970285 Change-Id: I5d0c86319204848ca7eea54bc5d68b4396700d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783338Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/chromeos. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jamescook@chromium.org Bug: 891670 Change-Id: I32b1cc16d0b36bdb79c3c7668aca9c90cbf0a4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787140 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#693873}
-
Javier Ernesto Flores Robles authored
Bug: 1000660 Change-Id: I11175c2e13f9751bacf095011d1a4c792c284afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784723Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#693872}
-
Staphany Park authored
Bug: 1000932 Change-Id: Ia6ae52ff439c1d7e8d759e6f083fb04d08663b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786616 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df4a44889317..d3de8dfbbb59 git log df4a44889317..d3de8dfbbb59 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 engeg@google.com Add a helper function to build_api to list services 2019-09-05 andrewlamb@chromium.org Disable hardware tests for all betty release builders. Created with: gclient setdep -r src/third_party/chromite@d3de8dfbbb59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I50c96e2bcce145a76ef8d50006ee958bb133d445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786029Reviewed-by:
-
rbpotter authored
This test is flaky only on Mac, just like CrElementsInputTest. Re-enable it on other platforms and add a comment referencing the bug for CrElementsInputTest. The flakes are likely due to the same cause, since these tests are identical other than the version of Polymer. Bug: 997944 Change-Id: Ife5e77c066496f702a3661457aa68d0f2af808c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785624Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693869}
-
John Budorick authored
Bug: 990885 Change-Id: I0f1d195cf150f003d535c93dc2dccd6057c2cf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788097 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#693868}
-
Daniel Rubery authored
When testing, I had disabled the whitelist checks. But this test doesn't actually do anything if the whitelist matches, so don't match the whitelist. Change-Id: I1e28b4deea59206dac3a2f99ccbc8aba8944fd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787160 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693867}
-
Ioana Pandele authored
This CL makes sure that the toggle is disabled and displayed as off when the feature cannot be used and replaces the old strings. Bug:986322 Change-Id: Idccdfb16755095a46ff5e05db5e3d2daaa7e6285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787544 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693866}
-
Jamie Madill authored
Bug: None Change-Id: Ibd16148a8b641131b8d5c22e9a58f77453f09f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784622Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#693865}
-
Jun Mukai authored
This is expected to be used by Tast test cases like https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1779242 Bug: 999365 Test: the new Tast test Change-Id: I4ba163dcb585a5785cea3b0ba1286337371b9156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779147Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Jun Cai authored
This CL does the following: 1. Updates infobar java code to assign a priority number to each infobar, and high priority infobar is shown in front of low priority infobar. If infobars have the same priorities, the most recently added one is shown behind previous ones. 2. Update the SMS infobar to have USER_TRIGGERED priority. Bug: 999222 Change-Id: I8f2b3ccb45dd8a6ec97ed4f0b246ac69ae60c7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783720 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693863}
-
Staphany Park authored
Bug: 1000932 Change-Id: I0b745dc4a35b3998dfd036f6900dccf5edead399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786973 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0e56cc64289..66e0feec40dc git log d0e56cc64289..66e0feec40dc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 jmadill@chromium.org Remove default template args in ResourceMap. Created with: gclient setdep -r src/third_party/angle@66e0feec40dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I2f5e5b37a9eaba61157c8965157592d3fd4a66d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787850Reviewed-by:
-
Jesse Schettler authored
Also, enable the flag for all channels except stable. Bug: b:130798103 Test: android-sh -c getprop | grep ro.boot.arc_print_spooler Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#693860}
-
Maksim Moskvitin authored
Added following histograms recording for USS Nigori (same as we have for Directory implementation): Sync.PassphraseType Sync.CryptographerReady Sync.CryptographerPendingKeys Sync.KeystoreDecryptionFailed Sync.CustomEncryption There are some remaining histograms, which we should add later: Together with full SCRYPT support: Sync.Crypto.CustomPassphraseKeyDerivationMethodOnNewPassphrase Sync.Crypto.CustomPassphraseKeyDerivationMethodOnSuccessfulDecryption Sync.Crypto.CustomPassphraseKeyDerivationMethodStateOnStartup Together with ping-pong prevention: Sync.AutoNigoriOverwrites Together with conflict resolution: Sync.ResolveSimpleConflict Bug: 922900 Change-Id: Ia5d6886ea7dd2855cf2240ffd14780c6158b7550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787600Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#693859}
-
