- 10 Apr, 2020 19 commits
-
-
Alan Cutter authored
This CL fixes the following warning in components_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ActivationStateComputingThrottleMainFrameTest> The ActivationStateComputingThrottleMainFrameTest tests were not being run. All/ActivationStateComputingThrottleMainFrameTest.NoPageActivationNotification_NoActivation/0 regressed during this time. Bug: 1069398, 1045846 Change-Id: I694129e58ba5272863ee810ee7949d7e34bc72ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143779 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#758099}
-
Alan Cutter authored
This CL removes the uninstantiated test suite GestureEventQueueWithSourceTest to fix the warning in content_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<GestureEventQueueWithSourceTest> Bug: 1045846 Change-Id: I82146898d77e36240b0e26a0dcf551228435cf35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143874 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758098}
-
Gyuyoung Kim authored
This CL migrates clip-path-columns-shape[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-columns-shape-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I146b61e8f0a841e71a05e7f93d823939e1a11ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143055Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758097}
-
Gyuyoung Kim authored
This CL migrates clip-path-css-transform-mutated[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-transform-mutated-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: Ibf032f065eefdbc6300255aa7a6a0e58066acd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143420Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2c5bcf86884..854ac61e90a4 git log e2c5bcf86884..854ac61e90a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 zmo@chromium.org Roll Dawn 11652ff8f8b3..6574f92747a2. Created with: gclient setdep -r src/third_party/skia@854ac61e90a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064305 Tbr: csmartdalton@google.com Change-Id: I7d729e9868ae9d1d54a1bd7120ec7fe8ac83deb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758095}
-
Gyuyoung Kim authored
This CL migrates clip-path-columns-svg-clippath-usou[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-columns-shape-002[-ref].html because this test was added by the same bug which added clip-path-columns-shape-001.html. Bug: 1063749 Change-Id: Ia2e300f39879db657e8d3246ae2e507f2518c3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143872Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates drop-shadow-clipped[-expected].html tests from paint/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to drop-shadow-clipped-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I503b5833769e7563bae92e2777dc9e2280a76ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141496Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758093}
-
Xida Chen authored
In this test, there are quite a few functions that returns certain member of a tracker_. This CL changes these functions to take the tracker_ as a function parameter because we are seeing some tests that is getting the members of some other trackers. There is no behavior change. Bug: None Change-Id: I7662ae052766bebd2961d034511e66bc1c7ba41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137824 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758092}
-
Sammie Quon authored
The stack points right at that line so it was pretty straightforward. I tried reproing locally and writing a regression test but it was a strange timing I couldn't get to work. The best I discovered was a semi-repro steps which showed |overview_item_| was indeed a nullptr. Test: manual Bug: 1069533 Change-Id: Ia525a029e5afbdf863880cd888135c9f105d503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144677Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#758091}
-
Alexander Cooper authored
This reverts commit 6bd4213d. Reason for revert:crbug.com/1068989 NOTE: While a local rebase was needed, it auto-resolved all conflicts. Original change's description: > Move VRService and dependencies to content > > Moves chrome/browser/vr/service and corresponding dependent metrics code > into content. Also moves not-yet published statics into content/public. > > As a result of the move a few changes had to be made: > * VRService needed to switch to PermissionControllerImpl > * Swapped two "NULL"s to "nullptr" > * Renamed usages of XRRuntimeManagerStatics to XRRuntimeManager > * Deleted WebVRServiceProvider and directly hooked up VRServiceImpl in > browser_interface_binders > * Switched ChromeXrIntegrationClient::GetInstance usages to use > ContentBrowserClient->GetXrIntegrationClient (and removed > ChromeXrIntegrationClient::GetInstance) > * Created GetXrDeviceServiceForTesting to manage dependencies for tests > * ukm::GetSourceIdForWebContentsDocument replaced with > WebContents::GetLastCommittedSourceId > * XrRuntiemManagerUnitTest needed some singlethreaded task environments > added due to changes in tests (requirements from using mojom) > > It seems like linking //device/vr into a source_set causes one of the > static initializers from gvr_shim to get counted now (perhaps being > optimized out when in a static library?) > > Bug: 1031622 > Change-Id: Id856e6cb68471a9960f54c663ece417461067541 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125016 > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756439} TBR=avi@chromium.org,dcheng@chromium.org,rockot@google.com,agrieve@chromium.org,klausw@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031622 Change-Id: I53417c92341f7fe32cb0ad5f7e845a477006db77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144834 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#758090}
-
Trent Begin authored
Errors from cros_healthd can be reported back to the DeviceStatusCollector. Update telemetry handling code to check for and log any errors. Bug: chromium:1041153 Change-Id: I264011d1d36bf3f2ec44c81e23256f1125156a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140717 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758089}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia0b022f289860602db81cb3e0c5c619adeddf210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143421Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758088}
-
Reilly Grant authored
These tests are flaking on macOS and Linux. Bug: 1068579 Change-Id: Ic4f541261efa0962fcebcabccff7c23fc7ffa12a Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144426Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758087}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 841beecf. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" c53a40f4 "Update size.attributes.parse.trailingjunk" 162244b5 "[css-filters] Move multiple-references-id-mutate-crash-2.html to WPT" f33018d0 "Handle k-rate AudioParam inputs for OscillatorNode" 6ddc6aba "Fix flakiness in FCP-only tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7da21102250a6ce11be051aaeec3c8903e3523c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144514Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758086}
-
Peter Wen authored
This version of lint is up-to-date with Android Studio and the lint team intends to keep it that way. We no longer need a separate tools-lint directory for an up-to-date version of lint. Bug: 1069186 Change-Id: I8846406c4787d36863718489c3c54c4b1438d79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144367 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#758085}
-
Reilly Grant authored
This change disables the following tests which have been observed to be flaky: * ActionsMatchedCountAsBadgeText * BlockAndRedirect * BlockRequests_Incognito * BlockRequests_MultipleExtensions * MultipleRulesets * RendererCacheCleared Bug: 1069665 Change-Id: Ic37473d4c318f24820721bd623eac8804ee1b987 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144410Reviewed-by:
-
Becca Hughes authored
Right now we have a lot of strings in the schema_org generated code and this adds overhead and can be a bit slower. This adds a "schema_org_name_generator" build task that generates unsigned int hashes for all names in the schema. Unfortunately this is separate because the hash function is not available in Python. Change-Id: I567a48b388d1e9f5e20e6f5e153402e736c4d0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144773 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758083}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I44232fadd22401237f6d6d351ed9ebc672c2168a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140602 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758082}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a5bd129758..90ff937ff645 git log e9a5bd129758..90ff937ff645 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chonggu@google.com [Telemetry] Add support to get Fuchsia system log file when tests fail. 2020-04-09 dproy@chromium.org [telemetry] Update docs about how to do measurements today Created with: gclient setdep -r src/third_party/catapult@90ff937ff645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064398,chromium:1069256 Tbr: oysteine@google.com Change-Id: I0e5528eba855026eb0e4f1f2ddda10f9c2824b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144986Reviewed-by:
-
- 09 Apr, 2020 21 commits
-
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/masking/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1870b644bf10b10947e897027aeb5765aac388a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143821Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
-
Reilly Grant authored
This reverts commit 279bc245. Reason for revert: The new test is failing on macOS: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17872 Original change's description: > Fix no-startup-window to not open browsers in session restore. > > Removes check for process_startup when deciding not to open browser > windows when no-startup-window is specified on the command line. > > Adds support for restoring last opened profiles to > ProcessCommandLineAlreadyRunning, if no browser windows are open. > > Bug: 850919 > Change-Id: I53db8b682f3838a8b871239b73d447cfafdb99d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134594 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757830} TBR=pkasting@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: I28b57fcfde0a0d30cccbe5b8d50b68af36679dae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143945Reviewed-by:
-
Piotr Pawliczek authored
See the title. BUG=none TEST=on my workstation Change-Id: I4f2e717fe0fe9b369ebc00171e54451fc88bd05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144838 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758078}
-
Aaron Gable authored
The NaCl SDK can't run on 10.15, so the compiles are run with enable_nacl=false, so we can't build and run this target. Bug: 1057776 Change-Id: If1f6018431ee680b4c97db51e3be14b01337020d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116569 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#758077}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/99ccc1759668..50f449b1dfd7 git log 99ccc1759668..50f449b1dfd7 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 treehugger-gerrit@google.com Merge "tp: move and rename ftrace_utils -> types/task_state" Created with: gclient setdep -r src/third_party/perfetto@50f449b1dfd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I78ae56cc035acc96393c7be51edb4d268697272a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144435Reviewed-by:
-
Garrett Beaty authored
The following changes were made to the console: * The order of the platform subcategories within each OS category was made consistent. * The order of the short names for each os/platform combo was made consistent. Bug: 1067057 Change-Id: I6348fe2253e8eff8ba9cedd2999adf10be1c595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139421 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Ankit Kumar authored
This CL adds tab handling in PDF. A tab event now allows the user to move from the last annotation on a page to first annotation on the next page. Unit tests have been added to validate the scenario. Bug: 989040 Change-Id: I46106e88946bdc3e667c9897cbcba3ff418aecfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061634 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758074}
-
evliu authored
This CL renames the generic pieces of the live caption feature from "SODA" to "Speech Recognition". The SODA-specific pieces will not be renamed including the presandbox hook, logic to retrieve the paths of SODA-specific files, SODA component, and SODA client. Bug: 1069284 Change-Id: Ic379b68cae607e77959a24368d93677a805b2713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142765 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758073}
-
Liquan (Max) Gu authored
The test coverage report shows that some new added code have not been covered by tests[1]. This patch adds test coverage for these lines. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2141244/9/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java This patch also dedup the redundant codes with the newly added method #assertPaymentAppsHaveIdentifiers() to give you a refreshed feeling. Bug: 1064740 Change-Id: I104385d2fe26f00e6e2477211c5a5123a9eff045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144314 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758072}
-
Esmael El-Moslimany authored
During a shortcut drag, an iframe behind ntp-most-visited will prevent 'dragover' events from firing. To workaround this, 'pointer-events: none' can be set on the iframe. When doing this after the 'dragstart' event is fired is too late. We can instead set 'pointer-events: none' when the pointer enters ntp-most-visited. 'pointerenter' and pointerleave' events fire during drag. The iframe 'pointer-events' needs to be reset to the original value when 'dragend' fires if the pointer has left ntp-most-visited. Change-Id: Ib06d78d6d6bc05a1bf96c3e080f1ed4fb76a9b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142750Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758071}
-
Ankit Kumar authored
This CL renames |PDFiumEngine::last_page_mouse_down_| to |PDFiumEngine::last_focused_page_|. This is part of a larger effort to make focus move from one page to the next on a tab event. Bug: 989040 Change-Id: I22cab91bb4965afaeae1755b51c11d88f69aeafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060444 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/605c93fb246c..55d00afb3680 git log 605c93fb246c..55d00afb3680 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 brcui@microsoft.com Focus default element after showing Settings screen 2020-04-09 brgoddar@microsoft.com Network: Expand Parent Frame Nodes on Reveal Created with: gclient setdep -r src/third_party/devtools-frontend/src@55d00afb3680 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068747,chromium:1069337 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9e9be7a18c54df06499bc178d01ad1b5289ea281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144979Reviewed-by:
-
Johann authored
This is a reland of ffcf2b75. It was reverted in a33a9505 due to an alert triggering for heap allocations. After discussion it sounds like this was the straw the forced the camel to allocate a new page and had an outsize impact on heap size. Fixed: chromium:1068911 Original change's description: > presentation controller: remove execution context > > The PresentationController class does not need > ExecutionContextLifecycleObserver since the mojo::Receiver was migrated > to HeapMojoReceiver. The replacement wrapper includes management of the > presentation_controller_receiver_. > > Change-Id: I1c96f897a7b604a23d3e7f0bd61a3b0598faa2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137162 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756871} Change-Id: I5270d6ca2483aa2815aaea59cacb2a8f627e5595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142876Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#758068}
-
Vladimir Levin authored
This patch aligns the code with the new requirement to have paint containment on subtree-visibility != visible elements. R=cbiesinger@chromium.org, chrishtr@chromium.org Change-Id: I0e6b04e013f906b1c52329448f008f365be1a171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144358 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758067}
-
Reilly Grant authored
Assigns ownership of this directory to the master list of Serial API owners in //content/browser/serial. Change-Id: I9b9cc4410658d66f2a9293b2e732f8cd264a4f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144829 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#758066}
-
Nigel Tao authored
This commit does not change behavior, other than adding new tests. Also remove a couple of stale TODOs from the opening json_reader.h comment, that proposed deviating further from the JSON spec. "git blame" says that these TODOs were added by commit e724599d on 2008-07-29, more than 11 years ago. They're not going to be done. Bug: 1069271 Change-Id: I2e1221ca8054c7912fcdf2723d8e3e114a580898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139533 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Chris Cunningham authored
Clearing the DB sometimes hangs on Android. Timing should reveal what steps operations are hanging (clearing and otherwise). Also adds additional tests to VideoDecodePerfHistory to verify no logic bugs if Clearing is the first operation performed (triggers initialize). Bug: 1040098 Change-Id: Ica13972256c883a840ebf66d03fddadc01add3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135528 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#758064}
-
Nazerke authored
This CL modernizes the AlertCoordinator, ActionSheetCoordinator, InputAlertCoordinator, ReadingListContextMenuCoordinator - to use |browser| in the initializer - to remove the public property for dispatcher, webStateList and browserState if they are - to use self.browser to get browserState, webStateList and dispatcher values. This CL updates the unit tests. Also this change includes some cleanup work such as renaming ReadingListContextMenuCommands to be ReadingListContextMenuDelegate as ReadingListContextMenuCommands was not configured through the dispatcher. The second part of the bug fixture is planned to make changes in MicrophonePermissionsManager in ios_internal. The last part is suppose to migrate away from downstream AlertCoordinator use and update PasswordController by passing a browser value. Bug: 1029346, 1047869, 1047876, 1065041, 1058017 Change-Id: I2513138a2e4b559c84b81f1935fe99a5908dfbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134241 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758063}
-
Harald Alvestrand authored
This verifies that replaceTrack() actually replaces the track. Adds a new helper function to add a "signal" square into a noise track. Bug: none Change-Id: Ia90535c984d65adcdf2c63a5700b08d7c1e384c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141913 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#758062}
-
Khushal Sagar authored
We enforce that the display frequency chosen must be in perfect cadence with the video playback rate. This doesn't allow the display to run at 30Hz with videos updating at 24Hz. Remove this restriction and choose the display frequency closest to the desired playback rate. R=dalecurtis@chromium.org Bug: 976583, 1069662 Change-Id: Icaaf87f4164c198b5b8ab6e900eaaaf21d229951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143534 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#758061}
-
Ian Struiksma authored
Unrelated to autofill blink change causing a failure as a checkbox click isn't being detected. Disabling the offending site test. If blink change will revert or change, can reenable. If it is the proper site behavior, can change action 20 in recipe to click the text of the element instead of the box and update the file in the cipd payload. Bug: 1069615 Change-Id: Idb3f10c5c3508b3cd75b665a3838098e46c16e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144826 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#758060}
-
