- 14 Oct, 2020 40 commits
-
-
Dale Curtis authored
An invalid RequestOverlayInfoCB was provided which triggered a nullptr crash when the callback was later executed. R=liberato Bug: 1135073 Change-Id: I62e4da8b5aec7ae32b8fb82ee6eea38346cd833b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469446 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#817042}
-
Jérôme Lebel authored
The following coordinators should only be used when the user is signed in: + AddAccountSigninCoordinator + AdvancedSettingsSigninCoordinator + TrustedVaultReauthenticationCoordinator ConsistencyPromoSigninCoordinator should only be signed in when the user is not signed in. This patch adds DCHECK to enforce that. Related to: crrev.com/c/2461345 Change-Id: I83282a15833f9450f0458793654d4a2da0ad0d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464274 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817041}
-
Xianzhu Wang authored
This reverts commit 9cdd5ba8. Reason for revert: Caused compilation failure. Original change's description: > Reland "Revert "[PM] Add FrameNode viewport intersection"" > > This is a reland of 53d410bb > > Original change's description: > > Revert "[PM] Add FrameNode viewport intersection" > > > > This reverts commit cf2a7489. > > > > Reason for revert: > > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > > > TBR=pmonette@chromium.org > > > > Original change's description: > > > [PM] Add FrameNode viewport intersection > > > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > > will allow the tracking of the visibility of each frame. > > > > > > Bug: 1077217 > > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > > Reviewed-by: François Doray <fdoray@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > > Reviewed-by: David Bokan <bokan@chromium.org> > > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#816728} > > > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1077217 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817024} > > Bug: 1077217 > Change-Id: If7f061e7722fdd6ae4a3ce37a1f51a337481dd58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471261 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817031} TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,pkotwicz@chromium.org,ftirelo@chromium.org Change-Id: I83951679f9ef83e80341da84769815277cc3bd66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471897Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817040}
-
Xianzhu Wang authored
This reverts commit eab74a79. Reason for revert: Caused compilation failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/18659? Original change's description: > Reland "[PM] Add FrameNode viewport intersection" > > This reverts commit 53d410bb. > > Reason for revert: There is a CL landed after this that changes a type somewhere, reverting is not that trivial > > Original change's description: > > Revert "[PM] Add FrameNode viewport intersection" > > > > This reverts commit cf2a7489. > > > > Reason for revert: > > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > > > TBR=pmonette@chromium.org > > > > Original change's description: > > > [PM] Add FrameNode viewport intersection > > > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > > will allow the tracking of the visibility of each frame. > > > > > > Bug: 1077217 > > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > > Reviewed-by: François Doray <fdoray@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > > Reviewed-by: David Bokan <bokan@chromium.org> > > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#816728} > > > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1077217 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817024} > > TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,ftirelo@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1077217 > Change-Id: I3c36272ac57b0857400331196a506069c596d36e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471259 > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817030} TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,ftirelo@chromium.org Change-Id: I0d0376a0aee042f1b4bfbd2807c66af2dc1bc5ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471898Reviewed-by:
-
kylechar authored
It's preferred to have the occasional OOM crash instead of truncating screenshot output at 8192 pixels. Also reenabled NoGPUCaptureScreenshotTest.LargeScreenshot since it's fixed. The test needs to be disabled on Android (in addition to CrOS) since they lack software compositing support. Bug: 1137291 Change-Id: I0889a842f17d9ddf7ab9980fd307d7c32285e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468738 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#817038}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bf2339dc0f8..1410c33130bc 2020-10-14 hjd@google.com Merge "ui: Fix SQL query escaping" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iba1e51abc3c705d2b4a38f67e33ee92adeb309d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817037}
-
Fabio Tirelo authored
This should reopen the tree: This reverts commit 53d410bb. This reverts commit eab74a79. This reverts commit 9cdd5ba8. Change-Id: Ifa97474155de2803dc95f5eb73573d7171ef6cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471677Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817036}
-
Tomasz Tylenda authored
Based on callback usage in AndroidManagementClient we conclude that StatusCallback should be migrated to base::OnceCallback. BUG=764795 TESTED=build Change-Id: I04b56e9abe8be42f678ba36c1be5f7c293608804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470580Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#817035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c5d2a2fe5321..9a6efa6be2ca 2020-10-14 mtklein@google.com move scalar functions out of SkVx.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ic33dfa6e73d20dab1877c3ea70cd5729f47b4738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470380Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010140700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/wN9syVuQA52Z_oVpW8HcXi5C0wcOpNkLkV_rn3ctZOEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/168070003 Tbr: media-app@grotations.appspotmail.com Change-Id: I032d1d2c22caa8ca14f6be352cb5678a20b10c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470379Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817033}
-
Adlai Holler authored
Just a name update to keep up with Skia. Change-Id: I61118e4cf4a18f5bdadbd7005dbf1f69be12e223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470464 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#817032}
-
Fabio Tirelo authored
This is a reland of 53d410bb Original change's description: > Revert "[PM] Add FrameNode viewport intersection" > > This reverts commit cf2a7489. > > Reason for revert: > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > TBR=pmonette@chromium.org > > Original change's description: > > [PM] Add FrameNode viewport intersection > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > will allow the tracking of the visibility of each frame. > > > > Bug: 1077217 > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816728} > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1077217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817024} Bug: 1077217 Change-Id: If7f061e7722fdd6ae4a3ce37a1f51a337481dd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471261Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817031}
-
Fabio Tirelo authored
This reverts commit 53d410bb. Reason for revert: There is a CL landed after this that changes a type somewhere, reverting is not that trivial Original change's description: > Revert "[PM] Add FrameNode viewport intersection" > > This reverts commit cf2a7489. > > Reason for revert: > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > TBR=pmonette@chromium.org > > Original change's description: > > [PM] Add FrameNode viewport intersection > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > will allow the tracking of the visibility of each frame. > > > > Bug: 1077217 > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816728} > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1077217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817024} TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1077217 Change-Id: I3c36272ac57b0857400331196a506069c596d36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471259Reviewed-by:
-
Elly Fong-Jones authored
These tests all use the PAGE_SIZE macro, which isn't correct under Rosetta until the 11.0 SDK; have them use base::SystemPageSize() instead. Bug: 1102194 Change-Id: I752462b38fc7cd33f45678e3708d6b16b23b7fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469224 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#817029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ee1c94588a..1bf2339dc0f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6a9c7d78f94d9a32ff27a351dac271d4eaf6f795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470338Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52c138e36e87..0c83e15c6b61 2020-10-14 alessiob@webrtc.org Move AGC2 config ToString to the right place and update Validate() 2020-10-14 ivoc@webrtc.org Add config options for python plots and text log to the NetEq simulator API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5afa041d94472442f78c7ae8249bbcb9c21bb0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470339Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I457a0bfebadb2b82d8f6ab7cc7ea809ec04dd0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469016 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817026}
-
Nicolas Ouellet-Payeur authored
Currently, (non-OffTheRecord) Profile objects are only destroyed when the entire browser exits. This patch adds an DestroyProfileOnBrowserClose flag, which causes the Profile object to be destroyed when the last window in that profile closes. It works, but it can cause crashes or instability in some cases, so it's off-by-default for now. This patch does not work well with ephemeral/guest profiles, or background mode. Bug: 88586, 566835 Change-Id: I73e78383cd57802deaee9ec23f6fa219881b1360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451696Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817025}
-
Fabio Tirelo authored
This reverts commit cf2a7489. Reason for revert: FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 TBR=pmonette@chromium.org Original change's description: > [PM] Add FrameNode viewport intersection > > This CLs plumbs the viewport intersection to the FrameNode, which > will allow the tracking of the visibility of each frame. > > Bug: 1077217 > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816728} TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
Sébastien Séguin-Gagnon authored
Bug: 1099268 Change-Id: I2a0de73ed846b100a549429888dabeb8ffe2db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461217 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#817023}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ee1c94588a..1bf2339dc0f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7afffe03f8b264b2ebaa830f3496511400f0649e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471217Reviewed-by:
-
Joon Ahn authored
Bug: 1136195 Change-Id: I23b30df8776b13558acf8ff9e9824b06d4c03cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463376 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817021}
-
Colin Blundell authored
WebLayer does not use //components/history and does not want to take a dep on the (large) component, as every dep that WebLayer adds has an impact on WebView. SubresourceFilterContentSettingsManager, however, currently depends on //components/history for its optional observance of the user's deletion of URLs from history. This CL abstracts that dependency via the following changes: - Adds the ability for SubresourceFilterProfileContext to store opaque embedder data (via a simple SubresourceFilterProfileContext::EmbedderData interface) - Moves the history observance to a new SubresourceFilterHistoryObserver class that is an EmbedderData and takes in a SubresourceFilterContentSettingsManager instance to call into - Has SubresourceFilterProfileContextFactory create SubresourceFilterHistoryObserver instances to be stored by SubresourceFilterProfileContext instances In this way, WebLayer will be able to use SubresourceFilterProfileContext, AdsInterventionManager, and SubresourceFilterContentSettingsManager without taking on the //components/history dep. Bug: 1116095 Change-Id: Ic81f63447f10afef1c4946ca7751d810d0a9cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466761Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#817020}
-
Alex Turner authored
Currently, FontMatchingMetrics uses the broader IdentifiabilityStudySettings::IsActive() call for its early returns. This ensures that unnecessary computation is not performed for users not participating in the study. We update these methods to use more specific checks that allow for server-side disabling of font metrics recording. Bug: 1136938 Change-Id: I12bdbd47e8bc0e6567f796fd3b058f02f4dd105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466143Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817019}
-
Tanmoy Mollik authored
This cl adds a render test to check that sync promo is shown when the user has signed in with without sync consent. Bug: 1105800 Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I8bc65fcbc91216668fd2f711cd17beb60f63cdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454170 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#817017}
-
Koji Ishii authored
To measure the usage to help discussions. Change-Id: Iaaada2de6899c38edd3f4be5624c832dfd119a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470896 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#817016}
-
Fergus Dall authored
Bug: None Change-Id: I7f27f2dbfb8b84458bd9df3aae7bb06ed8d9252a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467579 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#817015}
-
dpapad authored
Bug: 1132403 Change-Id: Ibe0f9bd3f481b716702caa92a325533372a0f3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469375 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817014}
-
sauski authored
Added UMA logging to record when the client has successfully contacted the HaTS Next service, but the service has declined to provide a survey for display. Bug: 1110888 Change-Id: I0d376c1612efc664ca52646b17ea4f68ae69d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463618 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#817013}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602654939-1f5462f983274209ab06546353a58e9ab57d2346.profdata to chrome-linux-master-1602676072-ebb21a5d77144e96fd6267407ee41b0443253d5d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I57601dadf1e85da773c32cec604c7e08067303d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471138Reviewed-by:
-
sandromaggi authored
The action previously had its call chain hidden in the |WebController|, this CL moves the chain to the util (as e.g. |ClickOrTapElement|). This will allow us to later on easier control what a |SetFieldValue| does. This CL adds utility functions to call existing chains while handling the lifetime of the |ElementFinder::Result| oneself (instead of letting the util handle it). This is required for actions that want to resolve the element and use it for multiple web-actions (e.g. |RequiredFields FallbackHandler|). This CL refactors the |SetFormFieldValueAction| to be easier understandable by moving from index to next-Callback and generally cleaning up the code. Bug: b/168107066 Change-Id: I504865ce9e70c5a5a14c30255feaf21fc5c916fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467857 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#817011}
-
Randy Rossi authored
Fixes msan issue warning of use of uninitialized variable. ==1066560==WARNING: MemorySanitizer: use-of-uninitialized-value Bug: None Test: ran unit tests with msan Change-Id: Ia8e57144e051f639d234d9117e05c6f08236cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468437 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#817010}
-
Fabio Tirelo authored
Most likely a linter rollout caused redundant tests to be identified in third_party/blink/web_tests/TestExpectations. Removing the unnecessary lines. Example run (search for 'webkit_lint'): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/108903 TBR=tkent@chromium.org Bug: 1068610 Change-Id: Ie818535d3e8bc86cf5576ccff61db73a6708984c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471236Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I1bfe954ba61dfc6608210bcea7a293c32b58075d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453290 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d314a40a3aa..e8c80d06a62a 2020-10-14 wolfi@chromium.org [TS] Port DOMStorageModel to TypeScript 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-14 alexrudenko@chromium.org Remove old entrypoints in inspector_overlay 2020-10-14 petermarshall@chromium.org [typescript] TypeScript-ify timeline_model/TimelineJSProfile.js 2020-10-14 tvanderlippe@chromium.org Build common-legacy.js with devtools_entrypoint 2020-10-14 jacktfranklin@chromium.org Migrate emulation/DeviceModeToolbar to TS 2020-10-14 sigurds@chromium.org [ts] Type-check resources/DatabaseQueryView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f6c50a86b3db8ca0a1ce653eabeb2a84b8b627d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471177Reviewed-by:
-
Matt Falkenhagen authored
This code is for creating a shared worker. Fixes a typo from r681479. Change-Id: I3a56d8bc84d575f385a840d1e0fca5b3c275ac16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470820 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#817006}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602654939-6aaab1e7299ba115ccc1d7beffbea8c42a27a599.profdata to chrome-mac-master-1602676072-1b8a347d7aacd68f729e2321f1fc4670c7061ae9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9ab4c6a2554eea1e183ed2c36fb320ee4e881f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470747Reviewed-by:
-
Sébastien Séguin-Gagnon authored
Bug: 1131107 Change-Id: Ib7b047409a42fe5a4ad5b33ecf10825214c9089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456126 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
-
Austin Sullivan authored
- Add DidFlush() method which checks for cancellation before flush completes. - This should fix the behavior of Cancel() Bug: N/A Change-Id: I763f5f87eaed80c7a8f1962d781a749d8a63b2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456866Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#817003}
-
