GitLab

Relanding this as this caused layout tests failures on Win7 due to the call to ShowScrollBars being incorrectly deleted
in the HWNDMessageHandler::OnSize for a regular WM_SIZE. Added that call back. The rest of the CL is exactly the same as
the previous one. TBR'ing sky.

Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows.

This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST
codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window
which is the only window which should be receive mousewheel messages.

I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that
would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the
scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message.
For normal sizing operations we continue to do this in WM_SIZE as before.

From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well

BUG=334454, 334541
TBR=sky

Review URL: https://codereview.chromium.org/133273020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332183

Review URL: https://codereview.chromium.org/140323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245288 0039d316-1c4b-4281-b951-d872f2087c98

There's already a robust check in page_runner. The extra check is messing up record_wpr.


BUG=333609
TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/top_10_000.wpr; tools/perf/record_wpr page_sets/top_10.json; mv ~/.boto.bak ~/.boto

Review URL: https://codereview.chromium.org/140293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245287 0039d316-1c4b-4281-b951-d872f2087c98

Implement a test fixture in DeviceMotionEventPumpTest to consistently
test DeviceMotionEventPump. The new implementation also avoids calls
to PlatformThread::Sleep() since it is generally undesirable in tests.

BUG=333928

Review URL: https://codereview.chromium.org/134073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245286 0039d316-1c4b-4281-b951-d872f2087c98

1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
   lib32/ and lib64/ from chrome.isolate to browser_tests.isolate.

2) On Windows, include <(version_full).manifest in chrome.isolate to be able
   to execute chrome.exe. Add needed chrome_child.dll and chrome_elf.dll.

3) Add libEGL.dll and libGLESv2.dll dependencies to gpu.gyp:gl_tests and a
   new angle.isolate; refer to it from gl_tests.isolate and
   gles2_conform_test.isolate.

4) Copy run_gpu_test to run_gpu_test.py, and invoke that instead in
   telemetry_gpu_test.isolate, to make this isolate work on Windows.

BUG=321878,334539

Review URL: https://codereview.chromium.org/140263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245283 0039d316-1c4b-4281-b951-d872f2087c98

FakeDB::EntryMap wasn't getting cleaned up in the test. Changed the API
to make it clearer that ownership isn't taken.
BUG=334682

Review URL: https://codereview.chromium.org/140113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245282 0039d316-1c4b-4281-b951-d872f2087c98

We need the file counts in order to send the completion event if we return a cached scan.  Also, in the scan result dialog we want to present the most interesting results first.

BUG=161119

Review URL: https://codereview.chromium.org/140033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245281 0039d316-1c4b-4281-b951-d872f2087c98

Transitions does not work if change is 'auto' -> '0'. As work around code sets
height to offsetHeight before changing height to '0'. However Blink still uses
computed style and does not starts transition. So we have to call el.offsetHeight
to force update computed style.

Removed unused argument from onFadeOutTransitionEnd.

BUG=330604

Review URL: https://codereview.chromium.org/139963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245280 0039d316-1c4b-4281-b951-d872f2087c98

Keeping the cache entry dirty to make sure that the edited file will eventually be uploaded.

BUG=326054
TEST=unit_tests

Review URL: https://codereview.chromium.org/139783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334711
TEST=Build on Chrome OS, check about:plugins, O3D is not there.

Review URL: https://codereview.chromium.org/139733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245276 0039d316-1c4b-4281-b951-d872f2087c98

This CL also does a bit of cleanup moving the WeakPtrFactory to the bottom of the member variables of a couple of BrowserPlugin/webview classes.

BUG=334606

Review URL: https://codereview.chromium.org/139603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245275 0039d316-1c4b-4281-b951-d872f2087c98

This message indicates to the recipient that the sender believes that it
is flow-control blocked but otherwise ready to send data. The BLOCKED frame
is purely advisory and optional.

This lands server change 56838900 by ygi.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/139573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245274 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Convert the re2 GYP targets to be generated by GN. (https://codereview.chromium.org/68853015/)

Reason for revert:
Broke Blink compile

Original issue's description:
> Convert the re2 GYP targets to be generated by GN.
> 
> BUG=288991
> R=bradnelson@google.com
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245254

TBR=bradnelson@chromium.org,bradnelson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=288991

Review URL: https://codereview.chromium.org/141063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245271 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
The indexeddb_perf tests on all Windows testers regressed in performance significantly. Don't yet know the exact cause, but because the performance drop is significant will revert this change first, and then proceed with the investigation.

Original issue's description:
> Created new Win32 LevelDB environment.
>     
> This change splits ChromiumEnv into two classes: ChromiumEnv/ChromiumEnvPosix.
> ChromiumEnvWin32 was also added which uses the Win32 API - except for logging.
> 
> The default is to create POSIX environments for all platforms for non-IDB
> LevelDB users. For IDB we create a Windows environment on Windows, else a
> POSIX environment like before.
> 
> BUG=222623
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245135

TBR=dgrogan@chromium.org,alecflett@chromium.org,jsbell@chromium.org,iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=222623

Review URL: https://codereview.chromium.org/140923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245270 0039d316-1c4b-4281-b951-d872f2087c98

Under non-impl-side painting, the thread proxy ends up releasing the
main thread then setting commit_waits_for_activation_ to false, which
is the wrong way around. This puts the order right.

R=enne
BUG=334611

Review URL: https://codereview.chromium.org/139553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245269 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szym@chromium.org
BUG=334837

Review URL: https://codereview.chromium.org/139543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/139923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245267 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/139903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/139883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245265 0039d316-1c4b-4281-b951-d872f2087c98

Simplify the code by using DOM Promises.

BUG=282464
TEST=browser_tests

Review URL: https://codereview.chromium.org/132013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245264 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the inbox_app in the Silk benchmark to use the newest
dynamics.js. The main difference is that we now do more work inside
requestAnimationFrame.

TBR=nduca

Review URL: https://codereview.chromium.org/140173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496,317432
R=wtc@chromium.org
CC=tzik@chromium.org

Review URL: https://codereview.chromium.org/138263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245262 0039d316-1c4b-4281-b951-d872f2087c98

Introduce content::TestLauncherDelegate.AdjustDefaultParallelJobs() to allow us to auto-disable parallelization for Ash browsertests.

BUG=286205

Review URL: https://codereview.chromium.org/132313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245261 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the LatecyInfo merging from the following path:

Compsitor to GPU:
CommandBufferProxyImpl::SetLatencyInfo()
-> (GpuCommandBufferMsg_SetLatencyInfo)
-> GpuCommandBufferStub::OnSetLatencyInfo()
-> ImageTransportHelper::SetLatencyInfo()
-> XXXImageTransportSurface:SetLatencyInfo()

After swap buffers:
XXXImageTransportSurface::SwapBuffers()
-> (GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params/
    GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params/
    GpuHostMsg_FrameDrawn)
-> RenderWidgetHostView

BUG=246034
TEST=unittests pass.
     Tested on Pixel. chrome://tracing shows correct InputLatency tracking for
     various inputs.

Review URL: https://codereview.chromium.org/123563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245260 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, we need to show a dialog to get permission to collect UMA data
and to change the default browser.

BUG=234637
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/137393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334679
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/139413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334253
R=ksakamoto@chromium.org

Review URL: https://codereview.chromium.org/139343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322820
TEST=manual tests on Daisy

Review URL: https://codereview.chromium.org/139323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245256 0039d316-1c4b-4281-b951-d872f2087c98

The real Drive server returns NOT_FOUND for deleted entries.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/139153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288991
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/68853015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245254 0039d316-1c4b-4281-b951-d872f2087c98

Someday we will rip out support for SYN_STREAM altogether,
but that will likely wait until we rip out SPDY <4.

This lands server change 56555536 by hkhalil.

Also updated SpdySession to work around removal of SYN_STREAM/SYN_REPLY:
 * OnSynReply() won't be called in SPDY4 contexts. OnHeaders() must
    handle initial response headers.
 * As OnPushPromise() isn't handled, associated stream checks aren't
   possible in SPDY4. Disable checks & related unit-tests.

Also updated compression test fixtures.

Review URL: https://codereview.chromium.org/138803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/138443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245252 0039d316-1c4b-4281-b951-d872f2087c98

That is, starting with an OS "channel" (e.g., socket), you can tell the
system to set up to send messages over it. It'll provide an initial
"bootstrap" message pipe, from which you'll eventually be able to bring
up more message pipes multiplexed on that channel (once you can pass
handles in messages over the channel).

Also:
- Make a base class for tests that need an IO thread.
- Add a way for test embedders to shut down the global instance.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/140403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245251 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to derive(create) a new font list in views::Tab.  Uses BaseFont and BoldFont.

TEST=none

Review URL: https://codereview.chromium.org/137533011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245250 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily move AshKeyboardControllerProxyTest from unit test to browser test.
There is a problem with calling ui::SetUpInputMethodFactoryForTesting() in unit
test right now. See comments in codereview.chromium.org/136033005 for detail.

BUG=NONE
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/139293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245249 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements nacl_irt_futex for non-sfi mode.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Review URL: https://codereview.chromium.org/139453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245248 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245247 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 244998 / a10bed42
Old Skia revision: 13077
New Skia revision: 13107
Control CL: https://codereview.chromium.org/140193002

This CL was created by Skia's roll_deps.py script.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/131123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245246 0039d316-1c4b-4281-b951-d872f2087c98

Using STYLE_OBSCURED in the ctor broke with r244436.
Remove 'styles', that ctor, and IsObscured/SetObscured.
Use TextInputType for password textfield configuration.
(rename textfield 'obscured' identifiers to 'password')

Inline STYLE_LOWERCASE to the EditSearchEngineDialog.
Remove GetTextForDisplay and its related handling.

Inline set_controller; remove GetController.
Cleanup users and unit tests.

BUG=131660,334252
TEST=Password textfields work (show '*'s, reveal last typed char, toggle in wifi/wimax dialogs, etc.) as expected. The EditSearchEngineDialog's keyword textfield holds lowercase text as expected.
R=sky@chromium.org
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/138363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245243 0039d316-1c4b-4281-b951-d872f2087c98

This is not something that would happen under normal circumstances, but it may happen if the preferences become corrupted or are modified.

BUG=321370

Review URL: https://codereview.chromium.org/138243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245242 0039d316-1c4b-4281-b951-d872f2087c98