- 16 Nov, 2019 40 commits
-
-
Max Li authored
Bug: 923594 Change-Id: I6c607c83aade019d2fae675d742c627b95f5e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915224Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Max Li <themaxli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0db19efecac9..b6ce42227610 Created with: gclient setdep -r src-internal@b6ce42227610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:b/143101359,chromium:b/143101359 Change-Id: I59fa5335935dd447d674774bb3bcc039cc3373f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715991}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19b88666bde0..14e51ec7bc7a git log 19b88666bde0..14e51ec7bc7a --date=short --no-merges --format='%ad %ae %s' 2019-11-16 treehugger-gerrit@google.com Merge "perfetto: remove IS_TRIVIALLY wrapper macros" Created with: gclient setdep -r src/third_party/perfetto@14e51ec7bc7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id94ca893dd1c259502d3095bf1b255d2e788dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715990}
-
Jérôme Lebel authored
Update the reauth infobar when #infobar-ui-reboot flag is on. Removing in re_signin_infobar_delegate.mm: + DCHECK(static_cast<InfoBarIOS*>(infobar())->View()); This DCHECK is not needed. View() method is not used. Removing in signin_interaction_coordinator.mm: + DCHECK(![self.topViewController presentedViewController]); The topViewController is already presenting the info bar and knows how to remove the info bar before presenting |viewController|. Related to: crrev.com/c/1372916 Bug: 1023328 Change-Id: I5af5236ad4e1ee6ec703c4d51d85f389d1577a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912911 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715989}
-
Martin Kreichgauer authored
Also change a typo in the aria-label attribute referencing the previously undefined string. Bug: 974046 Change-Id: I289a68928d0d1edc55d4c48b28d6e8556cc73e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919825 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715988}
-
rbpotter authored
After extensions was updated to Polymer 3, the JS files were updated to have the correct indentation using clang-format, but the HTML files still have extra spacing. Remove these extra indents. Also removing unused strings.html file. Bug: 1004967 Change-Id: I1b8199e233e9b25eb06a98c2cad75fe3e33b8521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919810 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL extend four flags which are related to the autofill flow, mainly on Android. They are loosely related and still very much in use. Bug: None Change-Id: Ibc9913dd6ede1c98dd78b026d5b9a1328474d997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920160 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#715986}
-
Tomasz Wiszkowski authored
- drop redundant properties, - specify minimum heights, preventing suggestions from shrinking Bug: 982818 Change-Id: I01d8bdd4e0ab08c0cccf61648e6dee3589aece14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919348 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715985}
-
Zhenyao Mo authored
Also, remove disable_dxva_zero_copy_video workaround for the latest drivers. BUG=1025427 TEST=manual with AMD GPU/driver R=magchen@chromium.org Change-Id: Iedce83eafcce5b1a3c138f72def93cdc2854e1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920022Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#715984}
-
Alex Newcomer authored
Avoid using the shelf size used for home launcher and overview when home launcher is showing. This should prevent the work area from needlessly changing (only system ui is shown when HomeLauncher is shown, so updating the work area only causes unnecessary calculations. Bug: 1019531 Change-Id: Ief65e7ccfddc5ad81cb0084a649e5e34c74848b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914838Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#715983}
-
Theodore Dubois authored
Bug: 696822 Change-Id: I5dff25148585cbe97a6dae5569f099679e52f618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919827Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Theodore Dubois <tbodt@google.com> Cr-Commit-Position: refs/heads/master@{#715982}
-
Friedrich Horschig authored
The fixed feature name (AutofillKeyboardAccessory{View,}) was wrong here and in the live config which meant the live config was effectively inactive. TBR=rouslan@chromium.org TBR Reason: Just explicitly disabled the feature in a test. Bug: None Change-Id: Ia5af6e3b295138fa6be5e85496bd13910aa10274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905552 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#715981}
-
Garrett Beaty authored
Bug: 922150 Change-Id: I366ee7d1eb9a4fd4e97b510e20573deee6ed2983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919604 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#715980}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I531cf25e318f9d1edf1c3ba076c84109716bf1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919911Reviewed-by:
-
Azeem Arshad authored
This CL fixes issue with Mobile Data subpage not triggering a tether scan. The issue was caused because we were sending only cellular type for scan requests. Fixed by sending mobile as type, this includes both cellular and tether in the scans. Fixed: 1023676 Change-Id: Icf8b0484cafec02e9a2e29247bf18aedb5d30ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919155Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715978}
-
Dale Curtis authored
Just showing users the raw enum values isn't useful. R=tmathmeyer Change-Id: I5097a865cc7e04f600c6a4361d308b2d50d062b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919496 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#715977}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bb45734988bb..1f392b83a83a git log bb45734988bb..1f392b83a83a --date=short --no-merges --format='%ad %ae %s' 2019-11-15 ehmaldonado@chromium.org gclient: Support setting local directories as dependency URLs. 2019-11-15 ehmaldonado@chromium.org presubmit: Print executed command along with test name. 2019-11-15 ehmaldonado@chromium.org depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt Created with: gclient setdep -r src/third_party/depot_tools@1f392b83a83a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1024683,chromium:1017812 Change-Id: I1aa471c40741a677876a8391e2e6aab4dd3e470d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919704Reviewed-by:
-
Tomasz Wiszkowski authored
The experiment was started late and we need to keep this flag around for a little longer. This is related to recently announced flag cleanup. Change-Id: I85c7f0f4ed4ffa668f9f94ac7679d07237409e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919901 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4aa7235b859..51b5a3222b60 git log e4aa7235b859..51b5a3222b60 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 tobine@google.com Update dEQP 3.1 expectations 2019-11-15 jonahr@google.com Expose EGL_CHROMIUM_sync_control via GLX_OML_sync_control Created with: gclient setdep -r src/third_party/angle@51b5a3222b60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:1020252 Change-Id: I983511f604ea965f9e79aed44f37030b238bb1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919703Reviewed-by:
-
Matt Wolenetz authored
virtual/not-site-per-process/http/tests/devtools/debugger/fetch-breakpoints.js is frequently timing out on some builders. BUG=1025437 TBR=lukasza@chromium.org Change-Id: I3f51730f636ec82d953516ec263db63464d45500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919824Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715973}
-
James Cook authored
It doesn't use the mojo pref service, so eliminate those deps. Bug: none Change-Id: I5272d6e6881efa44cd82ec6f4b7d4dc1d31c2594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919945 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#715972}
-
Yue Li authored
Bug: b/144383302 Test: Manual Test Change-Id: I50a2462e2094d08d52141a626c0dad89d55d27c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915322 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715971}
-
Kristi Park authored
Change-Id: I136a03e7b2174a3a4bc1ffccfb4c96a63e6e5fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919522Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#715970}
-
Caroline Rising authored
This is needed to have access to MenuButtonController::PressedLock and ToolbarActionView assumes that this will exist for a popup's reference button. Bug: 995448 Change-Id: I4855d4e30c38d530c6e8eadf7047ddc518258977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919660Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#715969}
-
Edward Jung authored
Bug: 978002 Change-Id: I309f3a1a4d49cbcc7369cdc86ad2c635c88a15d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919101Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#715968}
-
Garrett Beaty authored
Bug: 1024637 Change-Id: I504088dbf815b728092a02a97a916fed48a81e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920005 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Peter Kasting authored
This is a speculative fix for http://crbug.com/1025168 . If there's an open IME, we could skip adding child views, but the callback to get icons won't be canceled. In this case, the popup itself should be closed, so the code can check for that. (Clearly, if the popup is closed, it's pointless to update match icons anyway, so this seems reasonable.) Also makes tiny tweaks I noticed while thinking about this (int/size_t mismatch, impossible '<' case). Bug: 1025168 Change-Id: Ic84967f5376ad4dc19787b878cbe6f473b3b7d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920100Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#715966}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/96befae82483..d021c9f3296d git log 96befae82483..d021c9f3296d --date=short --no-merges --format='%ad %ae %s' 2019-11-15 thestig@chromium.org Make |CXFA_FFField::m_pNormalWidget| private. 2019-11-15 thestig@chromium.org Avoid more |CXFA_FFField::m_pNormalWidget| usage. 2019-11-15 thestig@chromium.org Use CXFA_FFField::GetNormalWidget() in more places. 2019-11-15 thestig@chromium.org Fix a crash in CXFA_FFComboBox::OpenDropDownList(). 2019-11-14 thestig@chromium.org Fix nits in FPDFEditPathEmbedderTest. Created with: gclient setdep -r src/third_party/pdfium@d021c9f3296d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:996123 Change-Id: I9373090e2e0d7c41dfb6863016191d5f61e48469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920019Reviewed-by:
-
Darin Fisher authored
Change-Id: I02bdd1240205bcf8b22563de74076b4859aced8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919561 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#715964}
-
Alex Ilin authored
This CL removes unused methods and cleans up some includes. Bug: 795291 Change-Id: I8d36adfb98387f22ef741479787d287aa7c977c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920039 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
Map EF_MOD3_DOWN to GDK_MOD_MASK when converting ui::KeyEvent into GdkEventKey before injecting key events into GtkIM. Mapping it to GDK_META_MASK is wrong and breaks Neo layout Layer 4 keys decoding. Bug: 1025376 Change-Id: I34afb73e006278e78f64b9b084732ee1176f70ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917052Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#715962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2835ec9385d..19b88666bde0 git log e2835ec9385d..19b88666bde0 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 fmayer@google.com Merge "Reland "Support packed fields for HeapGraph."" Created with: gclient setdep -r src/third_party/perfetto@19b88666bde0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4a11b015348ae356ec51cf4070424555eb58202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919818Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ced335afb0e..011e0230f209 git log 6ced335afb0e..011e0230f209 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 Rob.Paveza@microsoft.com DevTools: Fix non-dismiss of request inspector on reset Created with: gclient setdep -r src/third_party/devtools-frontend/src@011e0230f209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1025332 Change-Id: Ic54d93350ee9eaca0d4e6910005eacc55e28afb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919817Reviewed-by:
-
Sergey Ulanov authored
Extracted dummy external audio pipeline implementation out of libcast_external_audio_pipeline_1.0 target, so it can be used for other targets Bug: b/142420944 Change-Id: I727332c070c9ba8a3a850d1c0cb0800fe995a6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917601 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715959}
-
Hazem Ashmawy authored
Show a persistent error message at the top of the activities as well as a dialogue when the activity is launched, to warn the user that they are using a developer UI from a package that is different from the WebView package selected by the system. Bug: 981150 Test: Launch Dev UI from Trichrome, change webview implementation and switch back to the UI. Change-Id: If3ec3f09f4d8e1632583f3448d2d6e4bbf841607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912119 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715958}
-
Max Li authored
This changes GetEligibleActiveHostDevices to return a list of devices (the same one that GetEligibleHostDevices returns) if the flag is turned off. Bug: 923594 Change-Id: Ib2cae07aed18cacf2f8d663fce7a310b31eeae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915222Reviewed-by:
-
Kenichi Ishibashi authored
These are no longer used. Bug: N/A Change-Id: I94875f7a7145751b8934c36cce8460ed1f36302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919429 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715956}
-
Wei-Yin Chen (陳威尹) authored
Run StartSurfaceLayoutTest on more bots to see if the deflaking efforts work. TBR=meiliang@chromium.org Bug: 1023833 Change-Id: I554c82b0c02d90d6cf5770678e1eae47ee779ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917959Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#715955}
-
Koji Ishii authored
Because we're replacing |NGPaintFragment| by |NGFragmentItem|, this patch moves |is_layout_object_destroyed_| flag to |NGPhysicalFragment| by clearning its |layout_object_| to |nullptr|. Though |NGPhysicalFragment| is immutable, keeping a pointer to a destroyed object isn't good for anything. Note, this is done only for inline |LayoutObject| as it is called through |NGPaintFragment| today. We may revisit this in future. Bug: 982194 Change-Id: If89881cd9493526307106345db0549c0e9c8a6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914580 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715954}
-
chrome://downloadsDemetrios Papadopoulos authored
The test was loading chrome://downloads only so that loadTimeData is initialized, but that's unnecessary and causes this test to break when chrome://downloads is ported to Polymer3. Bug: 1022215 Change-Id: Icea9f16913b1e9f9d8154f5cc1242004218cfb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919569Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715953}
-
