- 31 May, 2019 40 commits
-
-
Fred Mello authored
In summary, the changes revolve around making proguarding rules to keep foreign symbols used by the module. The following are the highlights: - Investigate and add many missing "keep" rules to proguard file - Fix R(esource) files to point to the appropriate location (base vs. module) - Add build argument to build tab_ui as an async module - Create file to keep proguarding rules that must be added manually - Change proguard rule generation and add unit tests Bug: 958026 Change-Id: I10904776d54a21bb292e2ef176750fdd338bcf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627566 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665328}
-
Tommy C. Li authored
This CL is nearly a pure rename. It renames the ZeroSuggestRedirectToChrome flags and parameters to OnFocusSuggestionsCustomEndpoint. I think the new name is more descriptive, as the old name implied to me that the request was redirected locally to Chrome, when it was actually redirected to a Chrome-team maintained custom endpoint. Going forward, we may be using an endpoint that is NOT maintained by Chrome-team, so this will become particularly inaccurate if we don't do the rename. This feature that's being renamed is currently enabled via field trial for versions up to 76. This CL renames that feature, but the feature is still enabled by default in the binary, so it should continue with the server-side specified behavior. In other words, only 76 binaries without this feature enabled by default need the server-side config. That being said, for good measure it may be good to land this in 77. Bug: 966462 Change-Id: I4c9f1c1ae285f7d1be1a806b2f4c3b6bd8cd47ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633229 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#665327}
-
Harry Cutts authored
This will be used by a D-Bus service to allow developers to tweak gesture properties at run-time. See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Some of this code is based on Jacek Fedoryński's https://crrev.com/c/1350982. Bug: 952054 Test: As part of a series, tested that the D-Bus service can get and set properties. Alone, checked that Chromium and unit tests build. Change-Id: Icf0e82e02b5aa6dcdc4efc258292fc63d208e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589445 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665326}
-
Peter Kasting authored
These functions are unnecessary as callers can access the relelvant container directly. Bug: none Change-Id: I6b670e01ad1c05d3b6d06805ba7b62b33c0d7ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636646 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#665325}
-
Vladislav Kaznacheev authored
In the current implementation of SearchResultTileItemView the label is multiline only for kInstalledApp result type. This CL enables multiline for kArcAppShortcut type as well. Bug: 900278 Test: manual Change-Id: I19c96cccf7a09d1808f3b68e354403672274f304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639279 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665324}
-
Sophie Chang authored
This moves many of the previews-specific things from the top-level optimization and hints protos into a PreviewsMetadata object. Bug: 939857 Change-Id: I2ad3dc43ed3a43a207f73866371d86561b876801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637978Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665323}
-
Daniel Libby authored
See crrev.com/c/1629054 for initial changes under the feature flag. The previous bugs with the implementation have been verified fixed and I've ran bits for the past few days clicking on every scrollbar I could find, with no issues. Turn the feature on so that we can get more coverage. Bug: 954007 Change-Id: I49b20d9d68ee7f1262ab6dcc2e0652f4c1afff84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630813 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665322}
-
Collin Baker authored
NewTabButton sometimes paints an opaque background. With a recent change making ink drops paint below the View they're attached to (crrev.com/c/1603827), this means NewTabButton will occlude its ink drop in this case. As a fix, this CL makes NewTabButton override this behavior and stack its ink drop layer into a child view. This makes the ink drop layer paint above NewTabButton, matching the old behavior. Bug: 964466 Change-Id: Ieadceb541e8e94396180a01dd36ad835d7d0f004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636225 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#665321}
-
Toni Barzic authored
Change-Id: I54d96d45889729f1de91a8c16c176565acb7efc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637945Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#665320}
-
Nate Fischer authored
No change to logic, only docs. This clarifies in the quick-start that "setting up the build" really means configuring GN args. This should be obvious to most readers, but it's probably worth being explicit since this stuff could easily be misinterpreted as setting shell variables. It also clarifies that the doc expects folks to use `out/Default` as their out folder. Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I533eb37438135012229089ec53150b1b99619b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639038 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665319}
-
Joey Arhar authored
Bug: 968623 Change-Id: Ie0aaa7bc036ea5f170270f0f2e26ad158381b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639317Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665318}
-
Min Chen authored
For boards that don't support unibuild, the side volume button location info is written into the local file /usr/share/chromeos-assets/side-volume-button/location.json. For boards that support unibuild now, the side volume button location info is in the chrome flag "ash-side-volume-button-position". This cl goes to read the location info from the flag. After all the boards support unibuild in the future, the logic that read the location info from local file can be removed. Bug: 937907 Change-Id: I2138e3b0c32528767cec1efc746c8cdaa56775d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638741 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#665317}
-
Ned Williamson authored
Building this binary works fine but initializing GL fails when we run it. Since we are already fuzzing this successfully on Linux there's no need to replicate that effort on ChromeOS. Bug: 967220 Change-Id: Ie59988d860614d9d23e213ea52c52224660eac06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636855Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ned Williamson <nedwill@google.com> Cr-Commit-Position: refs/heads/master@{#665316}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5e3c9d53d8ef..95b1db9619fb git log 5e3c9d53d8ef..95b1db9619fb --date=short --no-merges --format='%ad %ae %s' 2019-05-31 sugoi@google.com BuiltInPointCoord implementation Created with: gclient setdep -r src/third_party/swiftshader@95b1db9619fb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ie228ddfa80e1d8d984c17a587630147e911a83fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665315}
-
John Emau authored
Marked 'Remove expression` console pin as a button with a tabindex, accessible name, Enter and Space keydown event activation, and focus indicator styling. Accessibility tree screenshot: https://i.imgur.com/6KCMN5b.png NVDA Speech Viewer screenshot: https://i.imgur.com/Dd5AyTW.png See: https://www.w3.org/WAI/WCAG21/quickref/#name-role-value Bug: 963183 Change-Id: I5dbd6b1d25bf52a3beacaf088bf7395e0f4ef083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629787Reviewed-by:
-
Jinsuk Kim authored
This CL fixes a bug that does not update the favicon when navigation takes places in the preview tab. Preview tab overrides OverlayContentDelegate to receive the event for navigation and updates URL accordingly. For this to work, Ephemeral Tab should observe FaviconDriverObserver to get notified of a new favicon in case the navigated page is new, with no corresponding favicon available in a local db. This also fixes another bug that doesn't display the right favicon for any new pages on it. Bug: 968364 Change-Id: I75ab428f9bcc42c7d28bc832a858d2707d1b1c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638305 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665313}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc9bc65588ee..f7106d16306a git log cc9bc65588ee..f7106d16306a --date=short --no-merges --format='%ad %ae %s' 2019-05-31 cnorthrop@google.com Revert "Revert "Vulkan: Use atomics in SerialFactory."" Created with: gclient setdep -r src/third_party/angle@f7106d16306a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I4f22d5748718981be9b0fc799185cb1f8563be01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639100Reviewed-by:
-
Jordan Bayles authored
Due to openscreen not having a 32-bit build, openscreen previously does not build in 32-bit, causing issues on 32-bit Chromium build bots. This patch rolls openscreen to include fixes for this issue. Change-Id: I11997fabf9822c124e260c228c63445781539b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637523 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#665311}
-
Aleks Totic authored
Nested LayoutInline outlines were not being painted. Bug: 967830 Change-Id: I97a8c11192509eb83bd7d0445ea63609a1dcaf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636647 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665310}
-
Jun Mukai authored
This test is flaky on debug builds; mostly fails with timeouts. For now, it's better to disable this test case on debug builds. This is somewhat a common pattern among webui tests -- and I think it's fine as long as it's tested on the release builds. Bug: 968608 Test: none Change-Id: I09b19f1e1854f9e5943b55b75e61abef777c493e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639143Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665309}
-
Ian Kilpatrick authored
As the LayoutTreeBuilder is only allowed to be stack-allocated, and doesn't take direct ownership of the ComputedStyle, we can just store a pointer to the ComputedStyle, instead of a scoped_refptr. There should be no behaviour change. Change-Id: Id70a0df625831aaf516b5b2c11537d9fd38498f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638617Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665308}
-
Henrique Nakashima authored
DownloadServiceFactory is now a SimpleKeyedServiceFactory, so its callers should provide a SimpleFactoryKey to access it. The helper method was added as a transitional state, but is not necessary in the long run. Bug: 943724 Change-Id: I74ea64e6f2bb2c7f15c0cc1ea5609340bed7925c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606247 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665307}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c8f285a7077e..6a07591a5577 git log c8f285a7077e..6a07591a5577 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 herb@google.com Simplify calculation of the path gap. 2019-05-31 rmistry@google.com [G3 compile bot] Remove cl link 2019-05-31 michaelludwig@google.com Move GrQuad to src/gpu/geometry folder 2019-05-31 herb@google.com max glyph dimension == 0 means don't fallback 2019-05-31 fmalita@chromium.org [skottie] Add support for opacity text animators 2019-05-31 fmalita@chromium.org [skottie] Initial animated text properties support 2019-05-31 herb@google.com Remove unused enum 2019-05-31 robertphillips@google.com Implement color-based backend texture creation for Vulkan Created with: gclient setdep -r src/third_party/skia@6a07591a5577 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I25e45735fe9e00673d0f168a88c0e13d318a0d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639101Reviewed-by:
-
Tommy C. Li authored
Currently, Android Chrome has its own page classification logic within autocomplete_controller_android.cc. This duplicates logic that now lives within LocationBarModel. This CL makes the Android Autocomplete system re-use the LocationBarModel version, which handles Query in Omnibox correctly. Bug: 963680, 912722 Change-Id: I0dd14b6d6f4ab34a52c9629d3511baef111c73cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627896 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665305}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bd419fd9eb93..8fa6a209221b git log bd419fd9eb93..8fa6a209221b --date=short --no-merges --format='%ad %ae %s' 2019-05-31 thestig@chromium.org Sanity check |fill_mode| in CFX_AggDeviceDriver. Created with: gclient setdep -r src/third_party/pdfium@8fa6a209221b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I09981ecabd10152c8f32ef37963f97cac52f9126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639128Reviewed-by:
-
David Benjamin authored
The hostname is just a host, not a URI. IPs are also fine. Bug: none Change-Id: I6e51f3a1086d10b68b2c5d34ca675f1e48a2aa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639147 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665303}
-
Bruno Santos authored
Bug: 968778 Change-Id: I333a7385e13f95ae420a7daf22fbe862e4bc235c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637819 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665302}
-
Yue Li authored
InterfacePtrSet should be passed by reference, otherwise its contents will lost. Not using const ref here since ForAllPtrs method is not marked const. Bug: None Test: Manual Test Change-Id: I24c631caafbd959b08212152163301e701dd2460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639377Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#665301}
-
Sajjad Mirza authored
The LLVM coverage runtime uses this system call. Bug: 842424 Change-Id: I68160535194fe2fbfc58c712a8b19daebc22de89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637855Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665300}
-
Karan Bhatia authored
Enforce CSP checks for javascript urls in isolated worlds when they are navigated through changing the frame location. Also add tests for the same. Since the IsolatedWorldCSP feature is disabled by default, this CL will cause the CSP check to use an empty CSP instead of just bypassing the CSP checks for isolated worlds. In practice, this should cause no behavior change. BUG=896041 Change-Id: I18b8031b554cebd1165d3b8f71abe9a25370bd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636644 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#665299}
-
Vladislav Kaznacheev authored
Delay fetching the notifiers until the profile is fully loaded. Bug: 957121 Test: manual Change-Id: Ib62c9b144a49ea18bf508cbb0e26df47b0a03e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636284 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665298}
-
Rohan Pavone authored
Follows the W3C for ExecuteScript endpoint by implementing promise-handling steps, causing ALL JavaScript executions to return promises, unless an exception occurs before the script completes. This is facilitated by Runtime.evaluate's awaitPromise argument, which will wait for a promise if it is returned, and the return value directly if there is no promise (if an error is uncaught, it returns unknown error). Bug: chromedriver:2925 Change-Id: I72c3a15d70842165bdce4019c6886e54f6c057e5 Tested: run_py_tests, call_function_test, execute_script_test, WPTs (except json_windowproxy_serialize.py) for execute_script. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628267 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665297}
-
manuk authored
Before the classification deduping changes, some providers limited the texts to 200 characters when classifying. When either the suggestion or input texts were longer, truncated versions would be used instead. With the classification deduping changes, all providers follow this behavior. This can look slightly awkward; e.g. for an input of 220 characters, the search-what-you-typed suggestion will be un-bolded for the first 200 characters, but bolded for the last 20. This CL increases the truncation length from 200 to 2000. This should be large enough to cover most use cases; on a 3840 resolution screen, with default English fonts, approximately 1100 '|'s fit in the omnibox. Bug: 366623, 968911 Change-Id: Ic4648c3fa000c09563fe0afae0d4883cefe3d156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639105Reviewed-by:
-
Michael Spang authored
No functional change. Change-Id: I98bb99a0df8e7eecec323252c17cfbfd46861bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637228 Auto-Submit: Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#665295}
-
John Emau authored
Marked the console settings checkboxes container as a group so screen readers will announce entering and exiting the collection of settings. Screenshot: https://i.imgur.com/4Vp5Ypn.png Bug: 963183 Change-Id: I017121ecd0826dcd9bd067b30d749ba41b0a1858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628223Reviewed-by:
-
Yuchen Liu authored
Due to the recent change of https://chromium-review.googlesource.com/c/chromium/src/+/1612248 Android specific logic inside of ContentMain is removed. Instead, MainDelegate::RunProcess should return non negative number to avoid BrowserMain to be called for Android. Bug: None Test: internal CQ Change-Id: Iedb9f6940cc2f6b7e4cba563c52a6eb6e39e741d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637739Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665293}
-
Daniel Murphy authored
This change removes all of the non-onion-soup code in the renderer, but leaves the feature flag still intact, as the browser-side code still uses it. R=mek@chromium.org Bug: 918910 Change-Id: I490cb42497757c318067b1125765fe9c4b94ecc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629707Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#665292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c92b6ad29083..261cefc6693a Created with: gclient setdep -r src-internal@261cefc6693a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I692ebb389f24855162edaa6195457b1b17fc1b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665291}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7919b877c3c1..699e167d78ee git log 7919b877c3c1..699e167d78ee --date=short --no-merges --format='%ad %ae %s' 2019-05-31 zoddicus@users.noreply.github.com Remove asserts from GetUnderlyingType (#2646) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@699e167d78ee The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If764ba8e2b138c087032f8e1ead38d208f3ae7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638562Reviewed-by:
-
Peter Kotwicz authored
BUG=817263 Change-Id: Ief0b71fa401066bb7d95d2a8f02596cf60068367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637695 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
