- 11 Apr, 2019 40 commits
-
-
manuk authored
Currently, search suggestions' descriptions (e.g. the 'Google Search' suffix) are classified DIM. However, document suggestions' descriptions (e.g. the 'Apr 3 - Google Docs' suffix) are classified NONE. Bug: 366623 Change-Id: I14ea6d9e9342e5793cfa73762e0efc233fe3df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555353Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649894}
-
Nazerke authored
Adds new flag. Bug: 951422 Change-Id: If04dc0f33071474359b8ee8b95d5ffb59eb70afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564117 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#649893}
-
sczs authored
- Creates an UpdatePasswordFormUsernameAndPassword util function which updates the FormManager Username and password. - It should be used when editing these values on the Bubble in desktop and on the Modal Infobar on Mobile. Bug: 945478 Change-Id: I990c5983a34e33a67c75a1db662226a2a7e3b10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560448Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#649892}
-
sczs authored
Bug: 911864 Change-Id: Icdc85ddf13f82992b4b20a1b9f17b7aaff501a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559354Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#649891}
-
Yue Zhang authored
Initialize TabGrid LayoutManager with proper span count based on initial orientation. Bug: 945740 Change-Id: Ifd50eee201f9087e376f3a3237fe727ed3658d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561951Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#649890}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e6b23e45b380..d581f918e90d git log e6b23e45b380..d581f918e90d --date=short --no-merges --format='%ad %ae %s' 2019-04-11 syoussefi@chromium.org Vulkan: few more EGL dEQP suppressions on Android Created with: gclient setdep -r src/third_party/angle@d581f918e90d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ifb7e47810bc391ea27f5c49b9142f1442a742446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649889}
-
Batalov Vladislav authored
According docs the LOAD_ONLY_FROM_CACHE flag guarantees that any navigation with it will fail if it cannot serve the resource from the cache (or some equivalent local store). However, this flag is used only by http_cache_transaction which isn't created if we are using network context without http cache at all. Without cache there is only a http_network_transaction which completely ignore LOAD_ONLY_FROM_CACHE flag and doesn't fail requests with it. Also, this CL fixes `setBlockNetworkLoads` for android webview without cache. https://cs.chromium.org/chromium/src/third_party/android_tools/sdk/sources/android-25/android/webkit/WebSettings.java?type=cs&q=setBlockNetworkLoads&g=0&l=887 Change-Id: I04c027fe671f83020cba580fa5c763b09fb00886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556775 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#649888}
-
Elly Fong-Jones authored
Bug: 951774 Change-Id: I7988f56b462c3138037a165e920a8f462d469e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564652 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649887}
-
Jérôme Lebel authored
This patch makes sure the FirstSetupComplete flag is only set when the user turn Sync on for the first time (either during sign-in or later using Google services settings). FSC flag on & Sync on => Sync is on and working FSC flag on & Sync off => Sync is off, the user turned Sync on at least once FSC flag off & Sync on => Sign-in is still in progress FSC flag off & Sync off => The user doesn't want Sync Changes in this patch: * FSC flag should not be set when opening the advanced sign-in settings. * The advanced sign-in settings set FSC flag on, only when the user taps on "Confirm" with Sync on. * Sync toggle is off, when FSC flag is off, and Sync on * In Google services settings (in settings mode) FSC flag is turned on as soon as the user turns Sync on. * When closing the Google services settings (in settings mode), if FSC flag is still off, Sync is turned off since the user doesn't want Sync (otherwise FSC flag would have been on, by turning Sync on). Bug: 948681 Change-Id: I86e7b74374e20e71fd069421733a300a187c777a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556790 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#649886}
-
Maxim Kolosovskiy authored
Bug: 951390 Change-Id: I049b51ba7c0b6021d2f293bb4ce91bae27745415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564114Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#649885}
-
Marc Treib authored
They're never read. Bug: 948148 Change-Id: I4a11ed4508c28b3b81342e256f62432173d0ce64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564116 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#649884}
-
Manu Cornet authored
I've double checked with UX/PM that this is okay to remove. Bug: 924761 Change-Id: I9aa33479c8c738f40c61e6b9a31b236a8c31d739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563598Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#649883}
-
Oskar Sundbom authored
According to the kill manpage: If sig is 0, then no signal is sent, but existence and permission checks are still performed; this can be used to check for the existence of a process ID or process group ID that the caller is permitted to signal. This seems to be tripping up at least ESET anti-virus, causing an unnecessary crash in the audio process. Bug: 904787 Change-Id: Ibdfe5db69fa494e4a0438ae0244f20820a0220af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559088 Auto-Submit: Oskar Sundbom <ossu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#649882}
-
Jan Krcal authored
Lack of data_model for AutofillDataModelChanges of type REMOVE caused hacky code for the sync bridges for AUTOFILL_PROFILE and for WALLET_METADATA. They could not distinguish deletions of local profiles from deletions of server profiles. This CL fixes it by adding data_model also for removals. It has minimal overhead in the database and simplifies (sync) code. Bug: 950419 Change-Id: If4f9462efa73ad2b5d89df4051104b19fff306c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559326 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#649881}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de4e8874ae82..6a80f56a7690 git log de4e8874ae82..6a80f56a7690 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 lalitm@google.com Merge "perfetto: add dump_ftrace_stats tool" Created with: gclient setdep -r src/third_party/perfetto@6a80f56a7690 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib8c7665b62b746226e6d2ba007261667f265040e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649880}
-
Lutz Justen authored
TBR=pmarko@chromium.org BUG=None Change-Id: I76636c02a65c06286ddbadbc2c7ff292ded8e674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563999Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#649879}
-
Toni Barzic authored
BUG=496832 Change-Id: Id6c4ca6629a88334cc9c5e4eb5d761663148106a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562758Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649878}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ddef1af8859..deb0854e685d git log 7ddef1af8859..deb0854e685d --date=short --no-merges --format='%ad %ae %s' 2019-04-11 yinwa@webrtc.org Minor fix, rename method name to setNetworkStatePredictorFactoryFactory(). 2019-04-11 nisse@webrtc.org Delete unused class RTCMediaConstraints (JSON) 2019-04-11 nisse@webrtc.org Delete unused class MockVCMFrameTypeCallback 2019-04-11 ilnik@webrtc.org Disable padding for paused encoders even on reconfiguration 2019-04-11 jonasolsson@webrtc.org Add support for lists to the FieldTrialParser. Created with: gclient setdep -r src/third_party/webrtc@deb0854e685d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5bb6751454142afc9329b2e05ed46002d753c84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649877}
-
arthursonzogni authored
Move initialization from the constructor initializer list to the class declaration. Keep only the ones depending on the constructor's input arguments. Bug: 950969 Change-Id: Ia8872089b0a0c323e49219ac05e433edff83d181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564078Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649876}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ec1a396fb79..389fd9db15e8 Created with: gclient setdep -r src-internal@389fd9db15e8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I38c806e23e2706de336dde60175d2ac622e595dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564632Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649875}
-
Ramin Halavati authored
FileSystem Browser test is updated to run tests in both regular and incognito modes. Bug: 93417 Change-Id: Iacc830111416f73899b0be82c4b64344452cd115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554347 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#649874}
-
Kaan Alsan authored
When too many LatencyInfo objects accumulate in a vector they are manually purged without being terminated. This prevents the running traces from ending. Change-Id: I66f61bec39da1f63fb9341852e1f9dc7d55d7ccf Bug: 950677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557869Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#649873}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d60534e95d8..76e626d9bb55 git log 6d60534e95d8..76e626d9bb55 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 halcanary@google.com SkQP: remove bad tests from future branches. Created with: gclient setdep -r src/third_party/skia@76e626d9bb55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129265491,chromium:b/127371533 TBR=egdaniel@chromium.org Change-Id: Ica24533a89ccca92fd23d618db2077749590a3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649872}
-
Lambros Lambrou authored
It appears this code is no longer used anywhere. It contained a misleading method: GetOauthScope() which was described as getting the scopes for the host's refresh token. It simply returned a hard-coded list (which included the 'googletalk' scope), rather than actually querying the token's scopes. Now that we are migrating away from Talk/XMPP, it doesn't make sense to keep this code around. Change-Id: Ia9041f45f0cfffd56ccfa9af0cab11e72e69dc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560468 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649871}
-
Daniel Vogelheim authored
Bug: 938929, 739170 Change-Id: I2abc44e570076be7c0d817e9bf41352c3e89f2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549121Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#649870}
-
Elly Fong-Jones authored
This reverts commit 2657e7df. Reason for revert: broke linux-rel: FAILED: gen/services/metrics/public/cpp/ukm_builders.cc gen/services/metrics/public/cpp/ukm_builders.h gen/services/metrics/public/cpp/ukm_decode.cc gen/services/metrics/public/cpp/ukm_decode.h python ../../tools/metrics/ukm/gen_builders.py --input ../../tools/metrics/ukm/ukm.xml --output gen/services/metrics/public/cpp Traceback (most recent call last): File "../../tools/metrics/ukm/gen_builders.py", line 35, in <module> sys.exit(main(sys.argv)) File "../../tools/metrics/ukm/gen_builders.py", line 29, in main builders_template.WriteFiles(args.output, relpath, data) File "/b/swarming/w/ir/cache/builder/src/tools/metrics/ukm/builders_template.py", line 93, in WriteFiles HEADER.WriteFile(outdir, relpath, data) File "/b/swarming/w/ir/cache/builder/src/tools/metrics/ukm/codegen.py", line 84, in WriteFile output.write(self._StampFileCode(relpath, data)) File "/b/swarming/w/ir/cache/builder/src/tools/metrics/ukm/codegen.py", line 70, in _StampFileCode for event in data['events']) KeyError: 'events' [24366/72009] ACTION //services/metric https://ci.chromium.org/p/chromium/builders/ci/linux-rel/23405 Original change's description: > Specify relative order of nodes in ukm.xml > > For each ObjectNodeType, specify alphabetization rules for all its child nodes types, which enforce their order relative to other types when pretty printed (sorting key is checked here: https://cs.chromium.org/chromium/src/tools/metrics/common/pretty_print_xml.py?q=_TransformByAlphabetizing&g=0&l=143). This patch fixes the issue where the pretty print script needs to be run more than once before the XML is sufficiently pretty for presubmit check. > > > Bug: 801614 > Change-Id: I7e9076c8e55d300f346bde07db0b12d4c7533661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561610 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Yue Ru Sun <yrsun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649863} TBR=rkaplow@chromium.org,yrsun@chromium.org Change-Id: I0a26eea9b2cbc8e25bb8200ef76d3a4ab4e77587 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564653Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649869}
-
Giovanni Ortuño Urquidi authored
The strings will be used in a dialog that prompts users to restart the app so that we can finish installing it. Bug: 844278 Change-Id: I9628d8e9c68df809f8c8fd45027d640f52b11095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557867 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#649868}
-
Yi Gu authored
The test has been flaky since the migrating animator patch landed. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycwsSBUZsYWtlImhjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBleHRlcm5hbC93cHQvYW5pbWF0aW9uLXdvcmtsZXQvd29ya2xldC1hbmltYXRpb24tZHVyYXRpb24uaHR0cHMuaHRtbAw TBR=xidachen@chromium.org Bug: 951753 Change-Id: I951e614240dff7f6772a3d04caa6bcd68f369839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564216 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649867}
-
Gauthier Ambard authored
Revert of https://crrev.com/c/1514060. In some cases, push state in JavaScript doesn't update the URL. This CL fixes it by re-introducing some code that was removed because it seemed not used. Bug: 949305 Change-Id: I668600e732ff53846369a334351ecd8a41124cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553558Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#649866}
-
Yuly Novikov authored
Was switched to Linux VM by mistake in https://chromium-review.googlesource.com/c/chromium/src/+/1562617 Bug: 951750, 950021 TBR=smut Change-Id: I71aa3bb9dbfa8e4d26cd557f5b0401b0309dc341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564610Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649865}
-
Jérôme Lebel authored
Before: https://drive.google.com/open?id=1H5lpt8w3n_KBH7ipBavOBqpueG3r8Uhu After: https://drive.google.com/open?id=12StJJdlb_-eMjih8XcEhdZPkB-3qiZ4x Bug: 951749 Change-Id: I19426605110ff223e7244e208f1df99dc14952c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564000Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649864}
-
Yue Ru Sun authored
For each ObjectNodeType, specify alphabetization rules for all its child nodes types, which enforce their order relative to other types when pretty printed (sorting key is checked here: https://cs.chromium.org/chromium/src/tools/metrics/common/pretty_print_xml.py?q=_TransformByAlphabetizing&g=0&l=143). This patch fixes the issue where the pretty print script needs to be run more than once before the XML is sufficiently pretty for presubmit check. Bug: 801614 Change-Id: I7e9076c8e55d300f346bde07db0b12d4c7533661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561610Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#649863}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/911b1a37708e..de4e8874ae82 git log 911b1a37708e..de4e8874ae82 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 lalitm@google.com trace_processor: remove proto API 2019-04-11 lalitm@google.com ui: make UI use the iterator API of trace processor Created with: gclient setdep -r src/third_party/perfetto@de4e8874ae82 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:118867986,chromium:118867986 TBR=perfetto-bugs@google.com Change-Id: I651d27f335ccb1f34eb0dd0d092d0bfdfdd87355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564433Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649862}
-
Dan Elphick authored
Uses Context version of Object::Set and calls Check on the result in cases where it cannot fail and CreateDataProperty for setting values in Arrays to avoid potential modifications by user-scripts to the Array prototype. Bug: v8:7283, v8:8834 Change-Id: If8dd9793d815ca3d75f4a206e4f3257d307a2e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552877 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649861}
-
Yashar Dabiran authored
This CL is part of the efforts to replace OriginTrialEnabled with RuntimeEnabled. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q Bug: 934451 Change-Id: I14688df0fdf4895b8ed61a5a45142bcdeabf5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558707 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#649860}
-
Lucas Tenório authored
Bug: 927809 Change-Id: I5ec26029f1ece2c102e4a9b792112100413033b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558795 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649859}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21a8eca7b39f..3ec1a396fb79 Created with: gclient setdep -r src-internal@3ec1a396fb79 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I6714655081f99c965e22e65eb86213a9391989d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649858}
-
Vadym Doroshenko authored
With CL https://chromium-review.googlesource.com/c/chromium/src/+/1530980 NewPasswordFormManager::PasswordNoLongerGenerated might be called when NewPasswordFormManager is not in generating state. Bug: 886583, 866444 Change-Id: If69df52c77c10d195fad8b992462595942d45c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561125Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#649857}
-
Lucas Tenório authored
The original intent for the GetApps method for the bridge was to only return installed apps. This change actually enforces that. Note that apps with Readiness == kUninstalledByUser are still represented in AppControllerClient notifications. After all, we still want the bridge to be notified when an app is uninstalled. Bug: 927809 Change-Id: Ibed29f80aefb02b6e66c1db6feb58f1a4da656d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562190 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649856}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7061e51b48ee..7ddef1af8859 git log 7061e51b48ee..7ddef1af8859 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 minyue@webrtc.org Revert "Replace usage of old SetRates/SetRateAllocation methods" Created with: gclient setdep -r src/third_party/webrtc@7ddef1af8859 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I65c9353539e69f49f495d398ead575b1dac2bcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649855}
-