- 30 Jul, 2020 40 commits
-
-
Maggie Cai authored
This CL adds a sharesheet button in files app and handles it's visibility. In addition, the original share button will be hidden if the sharesheet button is available. This is implemented behind a flag Sharesheet. BUG=1097623 Change-Id: Iee1dcf5363cd22a53f7bd2ec30de51d052457cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322268Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#793438}
-
Yuwei Huang authored
This CL removes the gRPC support library from remoting/. Bug: 1103416 Change-Id: I1f0a3855414c651bd843270d3f96690d288b219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330440 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#793437}
-
John Z Wu authored
CWVPasswordController contained a bunch of duplicated code that is no longer needed. Bug: 1097353 Change-Id: I62f57d8dff5291d7aebaa24713ff1d8da82c1e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315252 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#793436}
-
Yulun Wu authored
All back gestures are recorded as dismissed by timeout because the nudge is logged as timed out as soon as nudge animations are finished. Additionally, kBackGestureStarted should not be used as a dismiss reason because it would override the intended metric, kPerformedGesture. Bug: 1101105 Change-Id: I667d02610bde3f7c159f4f63d9732e7bd6f855ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295928 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793435}
-
Dominic Schulz authored
We have some data stored in prefs keyed off the install_url. Until we can migrate that to BMO stuff, we shouldn't change the install_url. Bug: 1111171 Change-Id: I2af4191a6f2049f661870378df5d4d82beb63edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330656 Auto-Submit: Dominic Schulz <dominicschulz@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#793434}
-
Daniel Rubery authored
This allows Safe Browsing to continue reporting only the potentially dangerous files by filtering within the FileAnalyzer, but WebProtect can make decisions based on all files contained within the archive. Safe Browsing will filter the downloads in the browser process by only considering downloads with is_executable or is_archive set. WebProtect will not filter the archived binaries, so it will begin identifying encrypted downloads of a safe file type. Fixed: 1058210 Change-Id: I46274954f49f964fd350f3900dfc646c9670611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305209 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#793433}
-
Dan Harrington authored
Bug: 1044139 Change-Id: Iaec80af41c2c4ed300ab92db4fb23f0f52d96f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330439 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#793432}
-
David Van Cleve authored
We're shipping the pertinent change^ in M85 so this will allow a lifetime of three milestones. ^ https://www.chromestatus.com/feature/6251880185331712 Bug: 1014207 Change-Id: I01d2b0961aebdfda44fbed621d99b39428aec121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326091 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#793431}
-
Henrique Nakashima authored
Not a clean revert as other dependent CLs over this. The code is a clean revert, but the build target that was split out in https://chromium-review.googlesource.com/c/chromium/src/+/2246983 is merged back into //chrome/browser. Also leave Profile#setLastUsedProfileForTesting() which has been used by many tests since then. Reason for revert: crbug.com/1108345 Original change's description: > Remove Profile reference from web_contents_state.cc > > Bug: 1090048 > Change-Id: I156fa5e8b6258d453c5809247e809a4ec7957125 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281307 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787271} Bug: 1090048 Change-Id: Iab4e650ed3fe9a559e58ea7462fad5199999ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324105Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793430}
-
Kevin Marshall authored
Defines a class "ScopedApi" provides RAII-based management of injected Chromecast bindings and their MessageChannels. Move BindingsManager to a component, rename it as cast_api_bindings::Manager. An alias subclass is added at its old location to allow the new name to be transitioned in a followup CL. Bug: 1104369 Change-Id: I1ecaff11dae85a3f62f75056a5c1d6005c3652c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303563Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793429}
-
Mohammad Refaat authored
This is done by introducing a new property in previousSessionInfo, which will hold information about if the last session was a multiwindow session or not, using that we can determine the path that is used to load the session from. Bug: 1084484 Change-Id: I5cb0d5c34a66e6b31a585fdae0039a8339b0311f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320141 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#793428}
-
Mei Liang authored
crrev.com/c/2240422 adds a custom zoom in then fade out removal animation for the TabListRecyclerView. This animation has a compatibility issue with StartSurface and GTS when there is at least one Incognito tab. There is an unexpected scaling animation on Tab cards when switching between the normal and incognito TabModel. This CL reverts the scaling animation part of crrev.com/c/2240422. Bug: 1095948 Change-Id: Ic709bf2dcf644f32268fcb5231ce574afc23f9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329873 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793427}
-
Ravjit Singh Uppal authored
Bug: 984199 Change-Id: I4aa48e62ef9624a2261261d4359840bddeb23659 TBR: jyasskin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282759Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793426}
-
Hodol Han authored
Currently there is only ui::DataObjectImpl::SetData which sets |owns_medium|, but it should always be true because of DataObjectimpl duplicates the medium if |should_release| is false. Bug: 11078061 Test: Run ui_base_unittests.exe --gtest_filter="OSExchangeDataWinTest.SetData*" Change-Id: I62125ef6d0c4d5d364deb2deefd8272a973507e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308637 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793425}
-
Teresa Kang authored
We want to know how many canvases are being affected by the disableAcceleration call in getImageData and fillRect with CPU patterns. The former tells us how many users might experience regressions from the willReadFrequently feature. Additionally, we want to record the number of canvases that will have willReadFrequently set to true. Bug: 1090180 Change-Id: I7f4f7e076fa36a55ad72bd22be3dfc6473228f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321000 Commit-Queue: Teresa Kang <teresakang@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793424}
-
Evan Stade authored
This target contains the minimal amount of code and dependencies needed for smart URL processing in WebLayer. Besides the justifications given in the bug, carving this out reduces the size of SystemWebView.apk by a small amount (4kb). Bug: 1106138 Change-Id: I1bb97103a4f33884793ebf6bd688b5206d2f4ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327083Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#793423}
-
Josh Nohle authored
Register with GCM and fetch ClientAppMetadata as part of the DeviceSync service initialization flow. Previously, GCM registration was performed by the enrollment manager, and ClientAppMetadata was fetched on demand by any class that needed it. Note: Currently, the GCM registration ID is persisted across restarts, and the ClientAppMetadata is lazily created and stored in memory by its provider class; so there is already an assumption that the GCM registration ID will never change and that the ClientAppMetadata will not change during the user's session. By fetching the ClientAppMetadata every time the service starts, we will be able to detect if it has changes since the last successful enrollment. For instance, a feature bit in the ClientAppMetadata might be newly marked as "supported" behind a feature flag. In a follow-up CL [3/4], we will directly pass the ClientAppMetadata to other classes instead of passing the ClientAppMetadata provider. This will remove a lot of technical complexity in place because of the ClientAppMetadata provider's asynchronous API. --- This is ClientAppMetadata change-detection CL [2/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: Id629244053b7cf557d01502d1a2ea32aa8029e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319328Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793422}
-
Dave Tapuska authored
This moves the override of the device scale factor to the spot to which the IPC first hits the location so it is correct through the pipeline. BUG=1097816 Change-Id: I691a9bf127ceb1f72a1616a09a3ae90ec5d5ca07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316402 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Daniel Rubery authored
Since the ChromePasswordProtectionService is already per-profile, this is straightforward. We simply pass the profile to SafeBrowsingService::GetURLLoaderFactory, which will select the right profile depending on the Finch flag and profile. Bug: 1049833 Change-Id: Ie4013f1bc400d15590adfd44a083feaec0d627a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327856Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#793420}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/23b75a4d658c..5a58acd2d744 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2cda056ccd26abe1b57d7f29ac86e6198f14ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793419}
-
Lukasz Anforowicz authored
Bug: 1073933 Change-Id: Iae62a5b7b22d753d218d8a2e86e273bdb38abd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303301 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Scott Violet authored
This adds a function to ErrorPageDelegate to get the html to show. GetErrorPageContent() returns a struct, which at this time contains a single string with the content. I'm going with a struct to make it easier to add support for message ports, should we need it at a later date. This isn't that important for the c++ side, but on the java side where we have to worry about compat it's easier to design with future extensibility in mind. GetErrorPageContent() is only called for non-ssl errors. In other words, the embedder can not override ssl error pages at this time. BUG=1031060 TEST=covered by tests. Change-Id: Ib4ab17285900a2545ee4f9a9e35c042abcaa287c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326672Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#793417}
-
Klaus Weidner authored
The blink-side drawing buffer operations were missing a WaitSyncToken call to ensure proper sequencing. Also, the browser-side code needs to be careful about creating sync tokens. The shared image interface internally uses its own GPU command buffer stream with a separate namespace, and we must either reuse its created sync token, or wait for it before creating our own. Bug: 1100997 Change-Id: Ica4e9953e8851bb8cc25ca480803b77252daebb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324892 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793416}
-
Yusuf Sengul authored
Add hooks into gcpw setup library to install/uninstall gcpw extension. Also, refactors the installable gcpw files out of setup library to have the ability to override them in the tests. Bug: 1101590 Change-Id: I16996adcee6b20502fea9b9fc68fe60b9ff1a969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288495Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#793415}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f05e507a003..5a58acd2d744 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieb2890a6219b72182a45c5e4e82c96652fdb41b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330630Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/958a3bb6708c..f02c0489c9c8 2020-07-30 jvanverth@google.com Update command buffer and finishProc processing in Metal 2020-07-30 ethannicholas@google.com Fixed build error blocking Android roll 2020-07-30 shawn.guo@linaro.org Check vendor and render string for Freedreno driver 2020-07-30 scroggo@google.com Rename "master context" to "primary context" 2020-07-30 elliotevans@google.com Remove remaining usages of skvx::mad 2020-07-30 scroggo@google.com Remove unused SkCoverageModePriv code 2020-07-30 johnstiles@google.com Update doc comments. 2020-07-30 johnstiles@google.com Add LLDB visualization support for sk_sp<>. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491 Tbr: borenet@google.com Change-Id: Ic164086f4ce1ce442711dfe99c61e0a5f1d36061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330437Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596121186-b7801e315884d1e13178a2cadb53255b7accfd25.profdata to chrome-win32-master-1596131728-ae408445987ddd6aa50e0d258bdde96ebf55cf02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1429d32a0e80f7719051eec08975ade15207ae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330085Reviewed-by:
-
Miriam Zimmerman authored
This enum will track the reasons crash_sender deletes a crash. It is implemented in https://crrev.com/c/2324768. BUG=chromium:1110120 TEST=deploy to DUT with crash_sender changes, run crash_sender,\ check chrome://histograms for CrosCrashSenderRemoveReason Change-Id: I56b1afa833de04b076eb55e3a63468b30f5eaf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321775Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#793411}
-
Yuwei Huang authored
* Rename FtlGrpcContext to FtlServicesContext and remove unused methods * Remove unused reference or dependencies to gRPC * Remove service protobufs Bug: 1103416 Change-Id: Id65fbb965519640cb695f1a68e523c88f5582dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330580 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dcc562158c8e..d7d79de3af6e 2020-07-30 jmadill@chromium.org Update inaccurate error string. 2020-07-30 cnorthrop@google.com Tests: Add NBA2K20 trace 2020-07-30 cnorthrop@google.com Capture/Replay: Limit string lengths in capture 2020-07-30 tobine@google.com Vulkan: ATrace marker fix-ups If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Test: Test: Compile NBA2K20 MEC with MSVCTest: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Ia63c336253bb56be9d484ee1197dfe6b4624b08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329928Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: Iff4c2e72ba388e342ba007245a002e61e7ae551c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330313Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#793408}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6c0b15e0dc40..13d4daad7486 2020-07-30 jalyn@microsoft.com Fix Network Datagrid row focus bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110854 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd16fda7b418e6146d5f3400ff9997a212d45299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330089Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9a3a085f8f6..aa5bd7657e6c 2020-07-30 swiftshader.regress@gmail.com Regres: Update test lists @ 08a3cc4c 2020-07-30 capn@google.com Use more inclusive terms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1097202 Tbr: swiftshader-team+autoroll@google.com Change-Id: I2e2fd8d4825f2e475a83e9253b3a8f2f7102c638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330082Reviewed-by:
-
Kristian H. Kristensen authored
This will forward the modifier all the way to the eventual EGLImage or gbm bo import such that GLES or KMS will properly understand the buffer layout. BUG=b:145579089, b:79682290 TEST=wayland_rects_client --use-drm=msm and verify modifiers get passed Change-Id: Ia422c3713f1a9384aa737c3d1cccb1dd76709e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314984 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#793405}
-
Ken Rockot authored
These tests were written prior to the recent auto-reload refactoring. Their expectations are no long quite correct, and they're flaky as a result. This CL updates the tests to rely on more appropriate expectations given the new auto-reload implementation. Fixed: 1111238 Change-Id: I81661230bd8f58f6ab6f72b57f7360e251778860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330333Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#793404}
-
Olivia Flynn authored
This CL adds: - A member to the InspectorSourceOrderHighlight class to store the node's position in the source order, which is used to populate the label - DrawNode() has a new parameter for the source order position Screenshot: https://imgur.com/a/IVtbWdm This CL is part of creating a Source Order Viewer, which was identified as a customer ask on The Web We Want The Web We Want submission: https://webwewant.fyi/wants/64 Explainer: https://docs.google.com/document/d/1t33UTIpW46MGor70W8mdBJVRio8eo3p76w3FH8MjV7A/edit?usp=sharing Back-end CL that this builds on: https://chromium-review.googlesource.com/c/chromium/src/+/2250504 Front-end CLs: Drawing labels: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2250404 UI: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2251080/9 Bug: 1094406 Change-Id: I818deb88dde14e7b1c40632ca59b03a6fe0ec545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250883 Commit-Queue: Olivia Flynn <t-olfly@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793403}
-
Junbo Ke authored
parameters. Bug: b/149872771 Merge-With: eureka-internal/390186 Test: On device Change-Id: I5e3f4b5fdea52a7f28467527a0762ed7708b7a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240230Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#793402}
-
Natalie Chouinard authored
These lint suppressions are no longer necessary following: https://crrev.com/c/2318549 Bug: 1099842 Change-Id: I01c33c1142b7ea1cb3f06b627cdfbb3ebbfbdb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330293 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#793401}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d8eae98f..edf39aef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f56c351a7674e3a6a4295dfb8978ed6d0cfbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330490Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793400}
-
Pete Williamson authored
Bug: 1111533 Change-Id: If82663c0a22eba1d9d5a35ad44a7ac70339d5e1b TBR: dmurph@chromium.org Change-Id: If82663c0a22eba1d9d5a35ad44a7ac70339d5e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330341 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793399}
-
