GitLab

The CL includes:
- Prevent Chrome for prompting user to save passwords when not possible
- Do not show manual fallback while entering password if the password
    store cannot save passwords
- Add a metric for attempts to prompt to save passwords when it's not
    possible
- Add a metric for PasswordStore::Init() success rate

This is a continuation of https://chromium-review.googlesource.com/c/chromium/src/+/1251452

Bug: 479725
Change-Id: Ia9b3a4e5f42a1446e41676ca69b576e4fe819a61
Reviewed-on: https://chromium-review.googlesource.com/1256969Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595939}

Move ExecuteGetCurrentWindowHandle() from session_commands.cc
to window_commands.cc, to make use of automatic window state
validation done for window commands.

Bug: chromedriver:1404
Change-Id: Id5ac4c7cea5323f12612b2dfb4dff2b819ce22ff
Reviewed-on: https://chromium-review.googlesource.com/1257362Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595938}

This is a thorough update of the presentation of offline content on the
dino page to match the currently proposed design.

Bug: 852872
Change-Id: I93ead161e14da48742a2791927ed813e9d431c74
Reviewed-on: https://chromium-review.googlesource.com/1232398
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595937}

The test has fixed dimensions of 100x100 pixels - the reference does
not. Add same fixed dimensions to the reference to get the same clipping
behavior.

Bug: 890755
Change-Id: Ib3d12ad1f7ace05027b81b9c683158490ae116ab
Reviewed-on: https://chromium-review.googlesource.com/1256568Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#595936}

Also make matching API changes.

https://android.googlesource.com/platform/external/perfetto.git/+log/1cae4d538d01..a80f9bc11bcb

git log 1cae4d538d01..a80f9bc11bcb --date=short --no-merges --format='%ad %ae %s'
2018-10-02 primiano@google.com Merge "Fix -Wdefaulted-function-deleted warning in Patch"
2018-10-02 fmayer@google.com Fix fuzzer build.
2018-10-02 fmayer@google.com Merge "Correctly handle case where sendmsg returns less than requested bytes."
2018-10-02 fmayer@google.com Merge "profiling: Add sampler."
2018-10-02 primiano@google.com Merge "Introduce support for deferred start (fast triggering)"

Change-Id: If74cfdca66a9400eee48be67a8ca5e1b430ee8a2
Reviewed-on: https://chromium-review.googlesource.com/1256846
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595935}

Bug: 806868
Change-Id: I055e151ab2b4f1df0c1a374d946ffbf1572f4165
Reviewed-on: https://chromium-review.googlesource.com/c/1256248
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595934}

Adds a BackgroundFetchError which is propagated to the developer.

Bug: 889401
Change-Id: Ie4505cd0f50ab263cce5d66c854094133bc3539c
Reviewed-on: https://chromium-review.googlesource.com/1246102
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595933}

This is a partial revert of the click target calculation
CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1161164

which puts https://crbug.com/869919 back on the table.

It still keeps the wpt test though to make sure the test is
there for the final desired behavior.

Bug: 890711, 869919
Change-Id: I3ea000a8f62b08b7222f91d27a6957d5a94e8388
Reviewed-on: https://chromium-review.googlesource.com/1256377
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595932}

This wraps the existing CountWebAuthnCredentials and
DeleteWebAuthnCredentials functions in a new interface called
PlatformCredentialStore. The Touch ID implementation of the interface
encapsulates the |metadata_secret| and |keychain_access_group|
parameters that currently have to be fetched from the Profile and passed
explicitly. This will allow us to not leak this implementation detail
into the browsing data deletion code.

This also moves the existing TouchIdAuthenticatorConfig struct from
//content into //device/fido/mac, so that it can be passed as the ctor
argument to the credential store.

This is only a structural change. No functional changes intended.

Change-Id: I4eda36d82c80fa13a91f5ce5e508f4a23803574f
Reviewed-on: https://chromium-review.googlesource.com/1242400Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#595931}

If an authentication challenge is received by NetworkServiceClient --
implying that there were no cached credentials or ambient identity
around to respond to the challenge -- the authentication request should
be canceled. A typo resulted in this pending challenge being supplied an
empty username and password instead.

This condition applies to requests that are made in the absence of a
WebContents, and those made with an associated WebContents that went
away prior to the network service notified the client of the
authentication challenge.

Bug: 874790
Change-Id: Ib3c866d1074b2a431a5196614ac3397bf97ea132
Reviewed-on: https://chromium-review.googlesource.com/1252868Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595930}

Removes exit-time destructors in
gpu::webgpu::WebGPUImplementation and gpu::BufferBacking.

Bug: 101600
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I611dd3dfd3d8acdd5b051743884fa1d060fdb220
Reviewed-on: https://chromium-review.googlesource.com/c/1246418
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595929}

Change-Id: I730fa92718409b518c9d9ada04e7378f203c40bd
Reviewed-on: https://chromium-review.googlesource.com/c/1257145Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595928}

Bug: 867518
Change-Id: Ic6f4f6db89960c3ccdeeb3d8590ace98a8545ed7
Reviewed-on: https://chromium-review.googlesource.com/c/1253061Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595927}

TBR=dgozman@chromium.org

Bug: chromium:854474
Change-Id: Iae615d06e1c6fe207a889f989df5a396aed72073
Reviewed-on: https://chromium-review.googlesource.com/c/1255574Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595926}

This test is flaky on the msan bot, and I suspect it could flake on the
non-msan bot as well.

BUG=891383
TEST=test only change

Change-Id: Ib8bdc7248faab8058fb8c37a02529214cb580f91
Reviewed-on: https://chromium-review.googlesource.com/c/1256987Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595925}

Set the network quality in the client hints to the holdback
value if network quality web holdback experiment is enabled.

Change-Id: Ifc6bcef11c9f980c340d4286e4472572e871f6f7
Bug: 880545
Reviewed-on: https://chromium-review.googlesource.com/c/1227684Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595924}

Copy over the files
components/ntp_snippets/content_suggestions_metrics.cc
components/ntp_snippets/content_suggestions_metrics.h
to
components/feed/core/feed_logging_metrics.cc
components/feed/core/feed_logging_metrics.h



Bug: 888047

Change-Id: I7f8baff84c6d23c80f1d079b6f0e33aa69c9a2c4
Reviewed-on: https://chromium-review.googlesource.com/c/1235314Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595923}

No behaviour change intended. Using JavaRef instead of bare jobject
pointers is preferred. These changes are to prepare for an upcoming
refactoring.

Bug: 519562
Change-Id: Iff019df737a9d3f4edae0f5ede8c068cee3443d0
Reviewed-on: https://chromium-review.googlesource.com/c/1255662
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595922}

This change disables caching queries to the Chrome autofill server. This
will induce Chrome to always use a POST request when querying the
Autofill server, instead of switching between GET and POST requests
depending on the request length. An unfortunate side effect of this change is that I had to recapture nearly
all the sites.

Also adding a number of tests.

Bug: 847905
Change-Id: Id052cb4945abd177624465e9793f55c8f034c742
Reviewed-on: https://chromium-review.googlesource.com/c/1250058Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#595921}

Add timeout before and after setting the focus. Otherwise it's quite likely
that we drop one or two characters when using InputWithSelector.

Bug: 878390
Change-Id: Ib703447425160eb87683143a61e03461af1795b7
Reviewed-on: https://chromium-review.googlesource.com/c/1256984Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595920}

The addresses stored on stack are used while unwinding, which could
refer back to the main thread's stack. To avoid this, replace all
address on the stack to point to the copied segment. Also remove
SA_ONSTACK flag since it causes unnecessary stack copies while
unwinding.

BUG=888434

Change-Id: I063216673529893a9458ba36d120268145224521
Reviewed-on: https://chromium-review.googlesource.com/c/1256563
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595919}

Change-Id: I5a4afc31244d701466af8ba673ceb79f1e2a9d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1168502
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595918}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95d4c855637a..0daedf7758e1


git log 95d4c855637a..0daedf7758e1 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 dpranke@chromium.org Remove agable, bradleynelson from //OWNERS.


Created with:
  gclient setdep -r src/third_party/depot_tools@0daedf7758e1

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Id5db1ab19d2828ea448b6251ff8b442980e50cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1257382Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595917}

Automates the two manual tests for ensuring that attempting to use
keyboard input while in the VR browser without the keyboard APK
installed triggers a DOFF prompt to install or updated the APK.

As a side effect, also adds the ability to wait for an element
in the native UI to change visibility.

Bug: 887588
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie4e08317c82fc2f4cc5379a5d18a82994f34a804
Reviewed-on: https://chromium-review.googlesource.com/c/1246279
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595916}

Without the minium version flag the Chrome Cleanup Tool will try to use this method even when it's not available on older versions of Chrome.

R=joenotcharles@google.com

Change-Id: I67846a30dca37f66f87a0ac04f1c687c739c4723
Reviewed-on: https://chromium-review.googlesource.com/c/1255571
Commit-Queue: Preston Carpenter <timidger@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595915}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa7c7ba5051f..1ed6f3571d8a


Created with:
  gclient setdep -r src-internal@1ed6f3571d8a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib9ca57e8a7644767d19da9a2fd94e5d6471152f0
Reviewed-on: https://chromium-review.googlesource.com/c/1257343Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595914}

Fields ssrc, rtx and fec are not part of the standard anymore.

Bug: 777617
Change-Id: If937b085ec9fe58f6f763e5bf79fdf95d6635a30
Reviewed-on: https://chromium-review.googlesource.com/c/1255625Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595913}

This CL adds the boilerplate code to convert Cast.MediaStatus into
media::MediaStatus, and propagates it to FlingingRenderer.

The CL also adds an "UNKNOWN" and a "STOPPED" state to MediaStatus, to
better represent the statuses that can be received.

Bug: 790766
Change-Id: Ic14d85e1e2aa93f45ce1ca3cd4dbee4eccb2fd27
Reviewed-on: https://chromium-review.googlesource.com/c/1241695Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595912}

https://webrtc.googlesource.com/src.git/+log/1ac95546dd12..bfff4bac826c


git log 1ac95546dd12..bfff4bac826c --date=short --no-merges --format='%ad %ae %s'
2018-10-02 buildbot@webrtc.org Roll chromium_revision 81efb6d0..24d8c445 (595716:595822)
2018-10-02 kthelgason@webrtc.org Fix RTCAudioDeviceModule tests.
2018-10-02 philipel@webrtc.org Make RtpGenericFrameDescriptor available for E2EE.
2018-10-02 aleloi@webrtc.org Add support for many channels in push_resampler.


Created with:
  gclient setdep -r src/third_party/webrtc@bfff4bac826c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ibecc3708f3e90bdcb9e4a3b317d45daa8a3038a6
Reviewed-on: https://chromium-review.googlesource.com/c/1257182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595911}

Currently the AsyncImageView starts to retrieve thumbnails when the
view holders are binded before the actual layout happens, which results
in the width and height in thumbnail requests to be 0.

This CL delays the thumbnail request after the actual layout happens.

Also uses centerCrop for image and video view holders.

Bug: 890377
Change-Id: I98f3864027553614a40d8211ac72743e66929db5
Reviewed-on: https://chromium-review.googlesource.com/c/1255586
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595910}

Currently the timestamps are displayed with only 2 digits for the
millisecond field if it is less than 100 ms, resulting in misleading
numbers (e.g. 00:00:09 62). Updating the display to always show 3
digits for the milliseconds, and adding a period before
(e.g. 00:00:09.062).

BUG=
TEST=tested locally

Change-Id: I37e2cf375ce4311623e6a30271f495ebd0fc4d74
Reviewed-on: https://chromium-review.googlesource.com/c/1256205Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595909}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a77bb2e54b35..2a88bcbaff3e


git log a77bb2e54b35..2a88bcbaff3e --date=short --no-merges --format='%ad %ae %s'
2018-10-02 stevenperron@google.com Update CHANGES


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2a88bcbaff3e

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iecf84ca4c56ae262cf396355d36c9a2616d7d89d
Reviewed-on: https://chromium-review.googlesource.com/c/1257187Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595908}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/84f3a15fd9db..20afd180cccb


git log 84f3a15fd9db..20afd180cccb --date=short --no-merges --format='%ad %ae %s'
2018-10-02 dgarrett@google.com som-dispatcher: Remove the som-dispatcher builder.
2018-10-02 nya@chromium.org cidb: Include branch info on inserting builds.
2018-10-02 yamaguchi@chromium.org Avoid CommitQueueCompletion failure by ProgrammingError.
2018-10-02 akeshet@chromium.org gerrit: add a key existence check for gerrit search queries
2018-10-02 saklein@chromium.org portage_util: expand CPV handling.
2018-10-02 saklein@chromium.org run_chroot_version_hooks: port to python/chromite


Created with:
  gclient setdep -r src/third_party/chromite@20afd180cccb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If2ae3e83e125ffd62999f88e89cde752c4b26432
Reviewed-on: https://chromium-review.googlesource.com/c/1257185Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595907}

This is to sync the client/server R.txt files

Change-Id: Iaed949845032ec14c951b3d5d45c62839f282826
Reviewed-on: https://chromium-review.googlesource.com/c/1246953
Commit-Queue: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595906}

And add a new test "chrome_all_tast_tests" that uses a conditional. And
add that test to the FYI bot.

Bug: 876587
Change-Id: I9518389338b99207ba045bfc62d87dda02c4e3e9
Reviewed-on: https://chromium-review.googlesource.com/c/1256209Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595905}

This change clang formats a subset of network related source files.

BUG=891143
TEST=Compile.

Change-Id: I131d132dbcd36200310a8c785eab067795e20576
Reviewed-on: https://chromium-review.googlesource.com/c/1252334
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595904}

Change-Id: I46e26e968f8ef512f890faa2d7c88abcfb17f0f6
Reviewed-on: https://chromium-review.googlesource.com/c/1256367Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595903}

The offline indicator will show up when the network is disconnected,
i.e., the bot is put in airplane mode or does not connect to WIFI.
This can cause problems to some tests that need to grab UI elements
from the page. To avoid this, we disable offline indicator feature
in ChromeActivityTestRule.

Bug: none
Change-Id: I8828ac7ac340acff3cef129f37e4052f7d6c2ba6
Reviewed-on: https://chromium-review.googlesource.com/c/1252362Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595902}

Bug: 888716, 851163
Change-Id: I0fce8657b8ab41c0ac57bff548a029bab302c8b3
Reviewed-on: https://chromium-review.googlesource.com/c/1256106Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595901}

Bug: 882927
Change-Id: I7217526edbe448fd9588ef0b8a2554e1e969651e
Reviewed-on: https://chromium-review.googlesource.com/c/1255725
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595900}