- 19 Jun, 2014 40 commits
-
-
viettrungluu@chromium.org authored
Also: * Move SetMinimumLogLevel() into MojoLogger itself. (This is somewhat unfortunate, since may not be thread-safe -- in particular, when sharing a copy of base's logging as in a component=shared_library build, it becomes blatantly unsafe. Thus it's of slightly dubious value. But it's where it belongs logically. Of course, sharing a log level across applications that are cohabiting a process is dubious. Avoiding this would mean at least layering a log level on top of Chromium's.) * Allow the (standalone) Environment's choices for default AsyncWaiter and/or Logger to be overridden. R=darin@chromium.org Review URL: https://codereview.chromium.org/339403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278401 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This adds a few helper functions to WidgetTest for getting information from a native widget and makes widget_test.h responsible for defining typedefs for PlatformNativeWidget and (when not ChromeOS) PlatformDesktopNativeWidget. 4 aura-specific tests (that are #ifdefd out on ChromeOS) that use DesktopAuraTopLevelWindowTest are moved from widget/widget_unittest.cc to widget/desktop_aura/desktop_native_widget_aura_unittest.cc widget_unittests.cc doesn't yet compile on Mac with this alone due to the event generator (addressed in CL/322893005). BUG=378134 TEST=views_unittests Review URL: https://codereview.chromium.org/334573008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278400 0039d316-1c4b-4281-b951-d872f2087c98
-
bshe@chromium.org authored
If current wallpaper is set by third party app/extension, show its name in wallpaper picker. BUG=360695 Review URL: https://codereview.chromium.org/338883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278399 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
R=ajwong TBR=ajwong Review URL: https://codereview.chromium.org/346743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278398 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
This also increments the app list shortcut version. This will trigger a rebuild of all app shims. This also disables updating all shortcuts in tests. BUG=353047 Review URL: https://codereview.chromium.org/346753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278397 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
Also switch bionic_canary over to being updated automatically. pepper_canary used to update based on the Chrome canary version, but that often prevents pepper_canary from updating as quickly. It also is unlikely that a newer pepper_canary than Chrome canary will cause any issues. This change makes pepper_canary (and bionic_canary) update based solely on which bundles are available in the cloud storage bucket. BUG=none R=sbc@chromium.org TEST=update_nacl_manifest_test.py Review URL: https://codereview.chromium.org/340243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278396 0039d316-1c4b-4281-b951-d872f2087c98
-
sashab@chromium.org authored
Update the list of file permissions in the App Info dialog to elide in the middle, to better match the UI mocks of the dialog. Screenshots on bug. BUG=385978 Review URL: https://codereview.chromium.org/341703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278395 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
No intended behavior change. BUG=none Review URL: https://codereview.chromium.org/348493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278394 0039d316-1c4b-4281-b951-d872f2087c98
-
csharp@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/343613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278393 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Previously, OpaqueBrowserFrameView was being used for popups and hosted apps. So popups and hosted apps would only use the native frame when the "Use system titlebars and borders" option was selected. BUG=376137 TEST=Manual, see bug (Must use i3 window manager) Review URL: https://codereview.chromium.org/327083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278392 0039d316-1c4b-4281-b951-d872f2087c98
-
noyau@chromium.org authored
Same owners as the one in enhanced_bookmarks/OWNERS. BUG=None R=blundell@chromium.org Review URL: https://codereview.chromium.org/346843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278390 0039d316-1c4b-4281-b951-d872f2087c98
-
n.bansal@samsung.com authored
Show error when an http:// URL is passed as parameter to chrome.app.window.create(). BUG=241487 Review URL: https://codereview.chromium.org/343433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278389 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
TBR=dnicoara NOTRY=true BUG= Review URL: https://codereview.chromium.org/347803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278386 0039d316-1c4b-4281-b951-d872f2087c98
-
malcolm.2.wang@gmail.com authored
Listen to the full screen event, then if so, close the bubble. BUG=326081 Review URL: https://codereview.chromium.org/320393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278385 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This is not necessary, and causes the entire ash mode to get WS_CAPTION as ash mode shares a single HWND. BUG=385557 Review URL: https://codereview.chromium.org/346713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278384 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
to ensure that we don't typically send out incomplete packets. Review URL: https://codereview.chromium.org/343753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278382 0039d316-1c4b-4281-b951-d872f2087c98
-
hanxi@chromium.org authored
This CL aims to fix the bug that when webview guest create a SharedWorker, the sctipt file of SharedWorker can not be loaded. The SharedWorker lives in a separate render process as the webview who creates it. Because url_request_util::AllowCrossRendererResourceLoad(...) doesn't consider that the render process of the SharedWorker is a guest, so it denies the load of SharedWorker's script. So we introduce webview partition id map in ExtensitonRenderState. When loading a SharedWorker script, we will check whether the script file is in the accessible resource of given "Partition ID", and decide whether it can be loaded or not. BUG= Review URL: https://codereview.chromium.org/333313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278377 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://devicesmichaelpg@chromium.org authored
When settings in a window is enabled, add a back button to the devices page. This helps because the window has no address bar. See bug for screenshot. Longer-term, the devices page should show as an overlay in Settings rather than load as a new page. RTL is not enabled for this page; see issue 386020. BUG=384333 R=noamsml@chromium.org,oshima@chromium.org +oshima@ for icon. Oshima, is theme_resources the right place for this? +stevenjb@ for browser shenanigans in local_discovery_ui.cc. Review URL: https://codereview.chromium.org/338423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278376 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278370 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
This resulted in incorrect processing and things like entering not working. BUG=386256 TEST=none R=ben@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/344763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278369 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=bruening@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/341083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278367 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
BUG=364365 Review URL: https://codereview.chromium.org/344603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278366 0039d316-1c4b-4281-b951-d872f2087c98
-
jl@opera.com authored
Mostly renumbered and restructured grammar productions. Notable changes: - add support for static attributes via StaticMember - add support for built-in types ByteString and RegExp - allow trailing comma in enum declarations Depends on: IDL parser: drop AttributeOrOperation and StaticAttribute overrides https://codereview.chromium.org/336733002/ ...or else breaks Blink compile. Review URL: https://codereview.chromium.org/329853005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278365 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
* If NSS version doesn't support AES-GCM * If NSS version doesn't support RSA-OAEP BUG=384485 Review URL: https://codereview.chromium.org/343473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278364 0039d316-1c4b-4281-b951-d872f2087c98
-
fmalita@chromium.org authored
Skia's save() SaveFlags bits are deprecated. At this point all callers have been updated to always pass kMatrixClip, but SkCanvas subclasses also need to use the new willSave() API. (depends on https://codereview.chromium.org/338833003/ rolling) BUG=skia:2297 R=piman@chromium.org, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/337163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278363 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
SyncTaskRunner's task invocation tend to grow call stack deeper. This CL clears the call stack per task to avoid stack overflow. BUG=344769 Review URL: https://codereview.chromium.org/334053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278362 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
Should not affect behaviour of the normal app list. The experimental app list now transitions pages in from the correct side of the screen, instead of simply sliding pages out to the left. BUG=377381 Review URL: https://codereview.chromium.org/316393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278361 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*" Review URL: https://codereview.chromium.org/340243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278359 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
Honour the safe browsing opt out and report on incidents that arrive before profile initialization is complete. BUG=383039,383365 R=mattm@chromium.org, noms@chromium.org TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/341563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278358 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
mojo_common can not depends on embedder, as standalone application must depends on it. channel_init is in fact a part of the embedder. R=viettrungluu@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/346633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278357 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
Currently, we use wrong storage type for nested arrays. For example, the storage type of the outer array of int8[][] is StructPointer<Array_Data<int8_t>>. After this CL it will be ArrayPointer<int8_t>. The current code works because StructPointer happens to be of the same size as ArrayPointer. (The newly-added tests pass with/without this CL. But I think it is good to have them.) BUG=None TEST=None Review URL: https://codereview.chromium.org/340223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278356 0039d316-1c4b-4281-b951-d872f2087c98
-
cmasone@chromium.org authored
It's a goodness to sequester build configuration in the build/ directory. The gn secondary_source stuff was under tools/gn for historical reasons, so move it to a more appropriate place. BUG=None TEST=do a gn build of base_unittests, run said unittests. Review URL: https://codereview.chromium.org/340153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278355 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
All benchmarks that uses the old format have been converted. https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20'%22%20 https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20%5C%22%22 BUG=362293 Review URL: https://codereview.chromium.org/331213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278353 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/346663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278352 0039d316-1c4b-4281-b951-d872f2087c98
-
sashab@chromium.org authored
Since the "Create Shortcuts" button is disabled on ChromeOS, add a pin/unpin button that allows pinning and unpinning the app from the shelf. This is the functional equivalent of creating shortcuts on ChromeOS. Based off https://codereview.chromium.org/335523002/. BUG=385526 Review URL: https://codereview.chromium.org/340453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278351 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
BUG=344769 Review URL: https://codereview.chromium.org/337803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278350 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278349 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/b59161f0000eb4aca3dcef29f27ffd0fb5a568e5..30e6e2af14e84216b1c113fd7500d0822bc81daa CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=reed@google.com BUG= win_chromium_rel seems unrelated to this cl NOTRY=True Review URL: https://codereview.chromium.org/343593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278348 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
A ui::Combobox (|denial_combobox_|) doesn't take an owner of a ui::ComboboxModel, so we should have clarify who is the owner of the combobox model. This CL fixed the leak to make TranslateBubbleView owner of the ui::ComboboxModel (|denial_combobox_model_|). BUG=309468 R=sky@chromium.org Review URL: https://codereview.chromium.org/330443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278347 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
Add a regression test, confirming that sessions which race host resolutions don't fail network transactions. BUG=334413 Review URL: https://codereview.chromium.org/346713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278346 0039d316-1c4b-4281-b951-d872f2087c98
-