- 11 Jan, 2021 40 commits
-
-
Bartek Nowierski authored
If GigaCage isn't enabled, this DCHECK will get triggered: AllocFlagsNoHooks->PartitionRefCountPointer->DCheckGetSlotOffsetIsZero-> ->PartitionAllocGetSlotOffset-> ->DCheckIfManagedByPartitionAllocNormalBuckets GigaCage isn't needed to set up PartitionRefCount. It's only needed to easily detect from BackupRefPtr code if PartitionRefCount is available, but this won't be an issue because BackupRefPtr is disabled when GigaCage isn't needed. Bug: 1073933 Change-Id: Iaea2781d207e9534293a1b3dd57dd6c42a422ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620922Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842036}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1da2af9a674..ccdfc9bed156 2021-01-11 szuend@chromium.org Roll deps from Chromium into DevTools 2021-01-11 pfaffe@chromium.org Update DevTools Chromium DEPS. 2021-01-11 tvanderlippe@chromium.org Fix changes computation for inspector-stylesheet 2021-01-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-11 jacktfranklin@chromium.org Remove old TODO from linear_memory_inspector example If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I261dfb0e7d7107a883fcc9d5664513a807145c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842035}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a 2021-01-11 skyostil@chromium.org tracing: Support enum class annotations 2021-01-11 treehugger-gerrit@google.com Merge "tracing: Disable Clang thread safety analysis for trace lambdas" 2021-01-11 skyostil@google.com Merge "tracing: Minor compatibility changes to legacy trace macros" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:1006541 Tbr: perfetto-bugs@google.com Change-Id: Ie381bd5d7bebc344292353ca38950804888d5f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621587Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8cf47fb7ac36..cffaf0aea477 2021-01-11 hta@webrtc.org Inclusive language: Remove a couple of occurences of "whitelist" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7badb0ff4a0547cf9f9c67432182b53724c2e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621049Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/34315538364b..03ceda9701cd 2021-01-10 wl@gnu.org * builds/*: s/BUILD_DIR/PLATFORM_DIR/. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I31b4ce1e2440add008c8a410200cd56f29b93e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619977Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#842032}
-
Frédéric Wang authored
This CL adds tests for SecurityOrigin::IsPotentiallyTrustworthy, similar to the one added for SecurityOriginIsSecure and network::Is*PotentiallyTrustworthy added in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2593629 Bug: 1153336 Change-Id: I15edacefc65294aae2472b82d30b19d93e37b11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610100Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#842031}
-
Rainhard Findling authored
* Make the button next to weak passwords white (instead of blue for compromised passwords). * Adapt the color of the "external" icon in the button to the button's strong or weak CTA, including for dark mode. * Screenshots: screen/3QHcFDpoZTpovNP, screen/6oPv3M82uqZAxk3 Bug: 1128904 Change-Id: Ibea49560a033d51b143b6eacdf08a205a8801d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599859Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842030}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e979dadb25d94f1385b114c888753248ac29f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621595Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609934346-5c74c9288bb90a2547279b7951f6e0eb771b0f27.profdata to chrome-mac-master-1610365490-cff9cfe8ee50bd1daf2a4d54676a0415ea568ae4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iadd5c50c27f98b7d588a68772c9b49ae1f7678eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620484Reviewed-by:
-
Boris Sazonov authored
Bug: None Change-Id: I64f193a4b0ba424e3989ccedfb66e921478483f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611099Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842027}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia4601097cb083fc222d18fda8445302dffc59651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621594Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd58c190..cfaba518 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie82f5be361059afaa0a4fffaaf27dfece6c5f3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621593Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842025}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610338418-506ef60e799a83be30c02d3485d0519970a70817.profdata to chrome-linux-master-1610365490-2d34930da692ba60039f1162f9ee976fe2d1462a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I396c1a95ae8ceccf5e847bf17981692104e0b4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620486Reviewed-by:
-
Adithya Srinivasan authored
Tests that console messages are preserved across a x-process navigation. Bug: 1158210 Change-Id: I7273ad218f2cf96e797679cf9552d5279f3dfe08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616830Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#842023}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5338df44. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I2afae2a4fde9c35838b8a5883d0b27637c35b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619686Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842022}
-
Rohit Agarwal authored
This CL removes the parameterized test to detect history based leaks from Incognito to regular and instead adds two single non-parameterized tests to check a) History leak from Incognito tabbed Activity and b) History leak from Incognito CustomTabActivity. Since, for all different kind of profiles the history service (via which one can query history) remains the same. It just suffices to check that for "Incognito cases" we don't write an entry. If we don't write an entry then one can't read it via the history service. Bug: 1140751 Change-Id: Icb038bfd034f509fd2a806a5dea82065987b0f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621061Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842021}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared are deprecated. This CL changes these calls to OnPrimaryAccountChanged(). As on iOS, the user cannot be signed with a primary account at ConsentLevel::kNotRequired (on iOS, setting a primary account requires the user to go through the sync consent), the migration is defensive and DCHECKs that the OnPrimaryAccountChanged() are always fired for primary account changes at sync level. Bug: 1158855 Change-Id: I071545f01f2a984a365d563997997873d75fd86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617881 Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842020}
-
Daniel Cheng authored
Bug: 1013149 Change-Id: Ifea542795b864dcd01a2f2e72f112748e3ec35e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619420 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL changes the original fix [1] that relaxed the condition to call PlatformWindowDelegate::OnWindowStateChanged() from WaylandToplevelWindow::HandleSurfaceConfigure(). [1] https://crrev.com/c/2601219 Most of the original change in [1] is recovered, and an extra call to PlatformWindowDelegate::OnWindowStateChanged() was added to WaylandToplevelWindow::TriggerStateChanges(). This keeps the synchronous nature expected for the calls coming from the browser that change window show states. BUG=1113900 R=msisov@igalia.com Change-Id: If61d71c3ae885b6ea0e9c1ab8e091694f48db771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614433Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#842018}
-
Anastasiia N authored
Add enableGaiaActionButtons_ parameter to shouldShowGaiaButtons_ call, to update "hidden" property of the buttons when the flag is updated. Bug: b/177064517 Change-Id: I46999193c2d7f42485b15053f9eff22964becb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620799 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e543a256b4d..6d48354d5a1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com Change-Id: I6b35aa19e3dc0fbe17b299c4bda0f45258c80ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842016}
-
Hans Wennborg authored
Bug: 765692 Change-Id: I76787e44706a2f09fbe69d574917d9453fb505c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620264 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842015}
-
Gauthier Ambard authored
This CL prevents the default preview when the user is long pressing on the WebView and the system ContextMenu UI is used (instead of the action sheet). Bug: 1140387 Change-Id: Ie3449e3d4f185f9bf4506601882e0a7204c3cdc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584962 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842014}
-
Rouslan Solomakhin authored
This patch adds a use counter for the number of times that a user invokes a payment handler with a standardized payment method identifier, such as "basic-card" or "tokenized-card", as distinct from URL-based payment method identifiers, such as "https://bobpay.xyz". Chrome status: https://chromestatus.com/feature/5717324021628928 Blink intent to deprecate and remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/ZS0JxjApEhI/m/GP1_t04gBAAJ Bug: 1159510 Change-Id: I4082ddfee7dcf293d57cb1847a526192419ff0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595617 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842013}
-
Alessio Bazzica authored
AGC2 includes SIMD optimizations for different platforms. Recently, SSE2 and NEON code has been added (see [1]) and kill switches have been added to the GainController2 configuration in APM. When `(sse2|neon)_allowed` is set to false, the corresponding SIMD code path won't be used even if available. Tested: appr.tc call made [1] third_party/webrtc/modules/audio_processing/agc2/rnn_vad/vector_math.h Bug: webrtc:7494 Change-Id: I2c10b09210914dfe8362c8d8b7fd434c6e4043fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620801Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#842012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e3706155af8..a1da2af9a674 2021-01-11 patrick.brosset@microsoft.com Grid/Flex: Improve drawing performance of the grid and flex overlays If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159870 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idbbd7f0c2667e69cee4fd8262ab46ec83763fd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621572Reviewed-by:
-
Michael Lippautz authored
Drive-by: IWYU for HeapDeque. Bug: 1056170 Change-Id: I0be011fd4701533e24ca9dfbbbc2c046059a4f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620563Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842010}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7fb7ffccc870a2717217fa856d9db4e24d88b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620874Reviewed-by:
-
Aya ElAttar authored
This is a reland of 57cebabc Original change's description: > DLP: Change DragDropDelegate::OnDragUpdated return type > > - Changed the return type of DragDropDelegate::OnDragUpdated > to return a struct of DragOperation and DataTransferEndpoint. > - The returned DataTransferEndpoint should be used in > DragDropController for allowing/disallowing dropping the > data according to the policy rules, See crrev.com/c/2595382. > > Bug: 1139886 > Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841675} TBR=sky@chromium.org,oshima@chromium.org Bug: 1139886 Change-Id: I547af7ff0dbd1dba47596e1cc47e743d8631c86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621300Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842008}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I3313c7091e8c775af08c8b997d36073a9631c30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621063Reviewed-by:
-
Benjamin Beaudry authored
Once again, there was a nit we didn't detect in the first out-of-flow-multicol test we ever created and we duplicated it to all tests we created using the original one as a template. This CL fixes it. Change-Id: I7ad19fa9b3eda9205c1ad007b0bfbbe47d31d83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616972 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#842006}
-
Ramin Halavati authored
|Browser* GetOrCreateBrowser()| is renamed to |GetOrCreate|. |Browser::BrowserCreationStatus| is renamed to |Browser::CreationStatus| |Browser::GetBrowserCreationStatus()| is renamed to |Browser::GetCreationStatus()|. This CL does not change any behavior. Bug: 1162794 Change-Id: I14ce77c85153f746e1d1e70fcb66f5e83beb62ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617779Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#842005}
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged() are deprecated. So this cl changes these calls to OnPrimaryAccountChanged(). There is a behavior change introduced with this cl for AboutSigninInternals. Observers are now notified when the unconsented primary account changes as well as when sync account changes. Bug: 1158855 Change-Id: I2c7f2f70dd1b6e79f4b12033306fecc160329edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611276 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842004}
-
Elizabeth Popova authored
Add regexes for found on Russian websites names/labels. Bug: 1154727 Change-Id: I3eba2c09559ee8bb0ec42af488cd4c210fb0e155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599806Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#842003}
-
Benoit Lize authored
Some call sites in Chromium use (for instance) base::AlignedAlloc() with a small-enough alignment to be fulfilled by the normal allocator. For instance, with alignment = sizeof(void*), or 16 on 64 bit architectures. In these cases, we can use the regular allocator directly, which is faster, and can reduce memory fragmentation. Bug: 998048 Change-Id: Idca581c5db744f15fbb34cf3a80caf1f6d941546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615058 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842002}
-
Anatoliy Potapchuk authored
After crrev.com/c/2395298, the settings window opening would cause cause kiosk to crash. Previuosly, one of the lines was always returning false when checking SystemWebAppManager::IsEnabled, thus never exectuted. After the change, it was only executed in kiosk mode, which caused crashes. Bug: 1157279,1159274 Change-Id: I1456230547bb7d6e05a1c1515c3980000d88fa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593381Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#842001}
-
Alice Wang authored
This CL removes the unused method ProfileDataSource#getProfileDataMap in the ProfileDataSource interface and updates the interface comment as there is no requirement to invoke the interface on UI thread now. Bug: 1136452 Change-Id: Iadbc7021d3acc6b3405cc996428c73ddf6774787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620619Reviewed-by:
-
Mihai Sardarescu authored
This CL fixes the order in which the notifications to update the primary account are being fired. The scenario that failed before this CL was the following (covered in test SigninManagerTest.UnconsentedPrimaryAccountUpdatedOnSyncConsentRevoked): 1. Account A and B are signed in with this order in the cookie jar. 2. Unconsented primary account: A 3. User enables sync with account B. B becomes the primary account 4. User revokes sync consent. 5. Unconsented primary account is reverted to B Before this CL, 2 notifications were sent with primary account changed in the wrong order: 1. { previous_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:NotRequired } current_state: { primary_account: gaia_id_for_me_gmail.com, consent_level:NotRequired } } 2. { previous_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:Sync }, current_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:NotRequired } } This CL fixes this order, and ensures that notification 2 above is correctly sent before notification 1. The change in the CL is fairly complex as it also updates the SigninManager to observe OnPrimaryAccountChanged notifications which is required as OnUnconsentedPrimaryAccountSet is deprecated. Bug: 1163126 Change-Id: I047014ce9bc569040d44121d90670d375f8fba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613971 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Monica Basta <msalama@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53f842487859..7e543a256b4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com Change-Id: Ice64dc5ab4775adf58b4d648ec1b46d7917d936e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620481Reviewed-by:
-
Rohit Agarwal authored
ToolbarDataProviderTest is a batch tests which keeps the ChromeTabbedActivity alive in between the tests. These tests also included CCT tests which launched CustomTabActivity on top of the existing ChromeTabbedActivity. In test environment, launching multiple Activities often results in Android killing the background process and all the Activities encapsulating it. This CL, therefore decouples the CCT tests from ToolbarDataProviderTest and move it to CustomTabActivityIncognitoTest. Bug: 1154445 Change-Id: If7a69773fb441d17439401fe2881a11d7a1c5eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621058Reviewed-by:
-
