- 27 Feb, 2020 40 commits
-
-
Elly Fong-Jones authored
Removes the remaining overrides (which are just tests inside Views) and marks the method not virtual. It should probably be renamed to something like just 'buttons()' at some point. Bug: 1011446 Change-Id: I8affaf1e80d7f0c2c8245edcd419f3dab14d9472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075078 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#745081}
-
Peter Kotwicz authored
This CL re-enables StatusBarColorControllerTest on phones only. The test does not apply to tablets where the status bar is always black BUG=1056196 Change-Id: Ie8a06eeb272ab17a36eeb28668320ffdd1592425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075976Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745080}
-
Dave Tapuska authored
Remove definition from WebWidgetClient because it is used in various classes that have no concept of the WebWidgetClient. Stop including web_widget_client.h inside chrome_client.h Change-Id: I14f6fa28c87054cd1004e078c828a24b817c50f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078592 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#745079}
-
Dominique Fauteux-Chapleau authored
Makes the drag/drop input events ignore the "ignore events" flag on WebContents. Bug: 1045015 Change-Id: Ia0ba24dac83f0e83a78b8ba000fcc9806090c77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078654 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745078}
-
Nohemi Fernandez authored
This patch adds the authentication flow required to sign-in or sign-out a user account following a click on one of the "Turn on Sync?" buttons. This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: Id9e38721b4343929d23f7861b5b5199a5dfb6a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059414 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745077}
-
Gang Wu authored
The bug was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2032427 and code was moved to here by https://chromium-review.googlesource.com/c/chromium/src/+/2063037 Bug: 1053790 Change-Id: I683351902f635ba329c14ccaec87540c36758cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075418Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745076}
-
Patrick Noland authored
This moves logic from ToolbarManager into a Coordinator, Mediator, and ViewBinder that are hooked up to the existing progress view, and adds unit tests for the new mediator. This change shouldn't affect visible behavior. Bug: 865801 Change-Id: I24e121aec7be79535b67d8c5b647327c0e8ba99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001264Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#745075}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/201bb086c442..f0d32401cf06 git log 201bb086c442..f0d32401cf06 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 cclao@google.com Vulkan: Optimize element buffer conversion Created with: gclient setdep -r src/third_party/angle@f0d32401cf06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ib2ee8280ff6a99ac2e62abb99d14bebf0620617e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745074}
-
Nico Weber authored
Normally we don't whitelist files for determinism, but nacl's on the way out. Bug: 1040247 Change-Id: I27fb62f05903532c128e8feeca252eb5e9e887e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078773 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/66adad7d3726..289ecf8b9b71 git log 66adad7d3726..289ecf8b9b71 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 westont@google.com Update Go Deps 2020-02-27 bsalomon@google.com Remove cheap/any texture distinction from SkImageGenerator. Created with: gclient setdep -r src/third_party/skia@289ecf8b9b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I6d02fcfac33da8a5f56ca7df3e4f5746129356c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078296Reviewed-by:
-
Rouslan Solomakhin authored
Patch #3: Unify flag control for the minimal UI feature. Before this patch, chrome://flags/#enable-web-payments-minimal-ui controlled whether the minimal UI could be displayed, while chrome://flags/#enable-experimental-web-platform-features controlled whether the respondWithMinimalUI() API was available in Blink. After this patch, both UI display and availability of the feature in Blink is controlled by the single flag chrome://flags/#enable-web-payments-minimal-ui. Bug: 1005076 Change-Id: I43c449b0ca14c97ccadcd25da8261119d261d80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075479 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/235fe2c3aa10..6165cdcbe8fa git log 235fe2c3aa10..6165cdcbe8fa --date=short --first-parent --format='%ad %ae %s' 2020-02-27 vapier@chromium.org scripts: convert random standalone programs to python3 only 2020-02-27 jiyounha@google.com arc: Increase timeout even more for master-pi-android-pfq. 2020-02-27 vapier@chromium.org image_test: fix bytes processing 2020-02-27 saklein@chromium.org flash-ap: initial `cros flash-ap` support. 2020-02-27 vapier@chromium.org cros_test/cros_vm: convert to python3 only 2020-02-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-26 mmortensen@google.com Support multiple -s arguments in contrib/query_build_logs. 2020-02-26 vapier@chromium.org cbuildbot_launch: switch to python3 only [reland] 2020-02-26 saklein@chromium.org cli/command: Make device argument named by default. Created with: gclient setdep -r src/third_party/chromite@6165cdcbe8fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I7121d005ee41afbc032a1217ee4f185317645ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078299Reviewed-by:
-
Tom Anderson authored
Fixes this error: ld.lld: error: undefined symbol: __cxa_thread_atexit BUG=1047860 R=thakis Change-Id: I0fc3ddd44b68fcdcc594a3bdc398a6b2924ac15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075840 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745069}
-
Vasiliy Telezhnikov authored
This CL adds checkbox to animation tests inside WebView system shell that enables external stencil by adding rounded corners clip path to WebView. Bug: 956709 Change-Id: Ia918bf2fa6af522bdda90d559eddf24c48172dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075970 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745068}
-
Colin Blundell authored
This CL starts the componentization of URLUtilities.java and its native counterpart in order for sharing with WebLayer (specifically, this code is used by //chrome's launching of external intents). As this class is used internally we structure the componentization as a 3-sided patch: this patch just copies the existing //chrome code and deprecates the //chrome code, while a followup will remove the //chrome code once the internal code has been ported. An immediate followup CL will componentize ShadowUrlUtilities.java. TBR=mmenke@chromium.org Bug: 1031465 Change-Id: I73d29744808a33e86b277f2d88c19e76f18ff10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077681 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/36f7f246a827..572d6abf7f22 $ git log 36f7f246a..572d6abf7 --date=short --no-merges --format='%ad %ae %s' 2020-02-26 junyer Don't break the RE2 object when compiling the reverse Prog fails. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I582e0c47696cf5d156cc93a5b2e6b43c83a0c3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077588Reviewed-by:
-
ckitagawa authored
Follow up change to make PaintPreviewBaseService use DirectoryKey for accessing protos. Also move the access methods to FileManager. Bug: 1055505 Change-Id: I322998cbd5d7d6d78d9aa541ac81a8f292059235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075043 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745065}
-
Hailey Wang authored
A trace is uploaded via "slow reports" when a long input delay is detected (for opted-in clients). This trace event will make it easier to identify the location of the long input delay when analyzing the trace. Bug: 1055890 Change-Id: Iba0e818b9c1a245da0099f44cc1224c437c8df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072665 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#745064}
-
Jonah Ryan-Davis authored
When the passthrough command decoder is destroyed, the callback needs to be un-registered from ANGLE. That way if the ANGLE context is used elsewhere, it won't dereferences an invalid pointer. Bug: chromium:1048205 Change-Id: Icf1b9969fa2bbc53d449e1b73ef66853303e94c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055423Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#745063}
-
Omer Katz authored
TraceAfterDispatch is used avoid adding vtables to types. Instead a flag in the object is used to choose the right Trace method. This CL changes all the non-const flags used for dispatching to const. Change-Id: I29b1817b56808360c27b31dd41b98c5ae5ece1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078533Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Chris Lu authored
If the webstate is nil or if it's not the active webstate, then it is likely that the BadgeTabHelper is not valid, so return early. This change also ensures that all InfobarCoordinator blocks use weakSelf in calls of InfobarContainerMediator Fixed: 1055908 Change-Id: Ic68ee9950ce928f1143981425cbac934057bbe64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075300 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#745061}
-
Paul Lewis authored
Bug: 1032561 Change-Id: I77d1aeba69c58c88d19fb9a239f2ec4b912539ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077739Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#745060}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc110cba..f4467316 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a83693816b373441924e03290f5fa694c4741d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078551Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745059}
-
Thomas Lukaszewicz authored
Removed remaining use of global NativeTheme accessor from profile menu and added color update capability on theme change. Fixed spacing on HoverButtons taking image views for consistency with other constructors. Bug: None Change-Id: I717a45fb068a3bd35b992797e38e729da1cd3521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072998 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745058}
-
Jeff Yoon authored
Missed removing arguments from iOS' WPR test runner constructor Bug: 1055330 Change-Id: I21faef3071ce28a0d3c7e4f3e51c20d987b3af4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076764Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745057}
-
Anatoliy Potapchuk authored
This reverts commit 0e5a5146. Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this. Original change's description: > Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably" > > This reverts commit cdce07c9. > > Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653 > > Original change's description: > > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably > > > > This handler was little bit overcomplicated. This led to a bug in web > > kiosk mode when we update network state, but do not update the handler. > > > > Because of this convolution, in web kiosks, the network configure > > screen did not update itself when connected to network(which is what > > client will expect from the handler which observes network state). > > Now it behaves more logically and predictably. > > > > Bug: 1015383 > > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406 > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739128} > > TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1015383 > Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739735} TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015383 Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#745056}
-
sandromaggi authored
While checking an unrelated piece, I found the element_finder to still be very confusing. This should CL should clean it up and make it a bit more understandable. It also fixes a minor bug, where the container_frame_selector_index was not correctly set for OOPIF. Bug: none Change-Id: I49965dcbc5378a0f73812489b68790b5db9f888f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072386Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#745055}
-
Katie Dektar authored
This reverts commit 77288e6f. Reason for revert: All/DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc/0 is consistently failing, and this change touches that test and is in the blamelist, so I expect reverting it will be the fix. First failing build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44692 Original change's description: > DNR: Speculatively fix flaky DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc. > > Wait for the fetch to complete before checking whether xhr request was > seen by the browser. This should hopefully fix the flakiness since page > load won't necessarily wait for the fetch to complete. > > BUG=1050536, 1056031 > > Change-Id: I9c043d69c4d619e00737303d2aaa3c15dc587ae2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076658 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744926} TBR=lazyboy@chromium.org,karandeepb@chromium.org Change-Id: I032be2858ed91613891949a5540a8875b56d5d04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050536, 1056031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078595Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745054}
-
Katie Dektar authored
This reverts commit a9df7cc8. Reason for revert: Seems to be causing compile failures on multiple builders: [2431/2474] CXX obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o FAILED: obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o ../../build/cros_cache/chrome-sdk/symlinks/eve+12933.0.0+target_toolchain/bin/x86_64-cros-linux-gnu-...(too long) In file included from ../../chromeos/services/assistant/audio_decoder/ipc_data_source.cc:5: ../../chromeos/services/assistant/audio_decoder/ipc_data_source.h:37:37: error: non-virtual member function marked 'override' hides virtual member function const ReadCB& callback) override; ^ Original change's description: > media: Migrate DataSource::ReadCB to once callback. > > This callback is used to signal completion of the read operation, > therefore, it's a once callback: > * https://cs.chromium.org/chromium/src/media/base/data_source.h?rcl=6e8610f8f31aa3bb8266660380a66c6c25b2e64a&l=27 > > This is part of the base::Callback migration. > > Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 > > Bug: 714018 > Change-Id: Ie43febda1247be065f9f22cc4aec0d8412873491 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056729 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Jose Lopes <jabolopes@google.com> > Cr-Commit-Position: refs/heads/master@{#745018} TBR=danakj@chromium.org,xhwang@chromium.org,treib@chromium.org,jabolopes@google.com Change-Id: I29a9ef7f049320a36dcd52212b7f5ac80e6fc02b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714018,1056660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078593Reviewed-by:
-
Sean Gilhuly authored
Update SkiaOutputDeviceDawn to match the change from Capabilities::flipped_output_surface to output_surface_origin. Change-Id: Ifce77d6ed142edbd5e1bcfe80154ddf8de0c328e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076378 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#745052}
-
Donn Denman authored
Adds another experiment arm for preserving the Tap gesture, in case users get confused during the transition to long-press. This will let us evaluate the difference between preserving and just switching. This changes the default to ONLY recognize longpress rather than both. Note that Privacy wants only one gesture to fully launch, so we are doing this as a fallback in case both need to be supported during a user-education timeframe. BUG=956277 Change-Id: I1b42d86bbd9cdc7e0a58bafb8a796601ae0cb353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076338 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
ckitagawa authored
Refactor FileManager to accept a DirectoryKey rather than a GURL. This makes it more ammenable to possibly supporting other keys for creating directories such as tab id, UnguessableTokens, etc. Bug: 1055505 Change-Id: Id93cc1bcbfdfdd69baf0f57764636dcbcd62c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070737Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
James Cook authored
The mojo identity service (//services/identity) is not used in production. However, a variety of chrome code uses the typedef identity::ScopeSet when talking to the C++ IdentityManager and related auth-token code. Introduce signin::ScopeSet for these use cases. It's just a copy of identity::ScopeSet, which is a std::set<std::string>. I didn't eliminate identity::ScopeSet in this CL due to existing usage in //services/identity as well as typemapping code. I'll delete the identity::ScopeSet version when I delete the rest of the identity service. TBR=rockot@chromium.org TBR=droger@chromium.org Bug: none Change-Id: Ib938f08763eda81de22a1a79b460011e012a81ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076426Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745049}
-
Thomas Lukaszewicz authored
Removed the need to use the global GetInstanceForNativeUi() call to get required colors when constructing avatars and sync icons for profile menu views. Also updated the profile menus such that their sync and avatar icons are updated appropriately on theme changes. Performed some basic cleanup, moved some functions into the base class. Bug: None Change-Id: Ia3566c77653c3209265d077e64b524b7bde9c8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070377 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This knocks ~5% off the total runtime of unit_tests on my workstation, since most tests in this suite otherwise take multiple seconds to run. Bug: 1055824 Change-Id: Id911e97ce55efed11f6ee5fb34eaf5409426f19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072660Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#745047}
-
Antonio Gomes authored
The former wraps the later with two additional bits: - request_id - is_processing_user_gesture This CL adds accessor methods to both bits in UserMediaRequest, and uses it directly instead of the UserMediaRequestInfo. BUG=704136 R=guidou@chromium.org Change-Id: Iee9cef6b20293a71fb8b35ba655642355b1841fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075639Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#745046}
-
Jérôme Lebel authored
The sign-in interaction coordinator is active when it is used with the sign-in coordinator. Bug: 971989 Change-Id: Ic199eb9e7628d6f4195f7bbc5637827eccc38cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077933 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#745045}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1468dd8d57f8..091710f87c8c git log 1468dd8d57f8..091710f87c8c --date=short --first-parent --format='%ad %ae %s' 2020-02-27 almuthanna@chromium.org Refactor Console E2E test to use helpers 2020-02-27 jacktfranklin@chromium.org Typecheck Common/JavaScriptMetaData.js 2020-02-27 changhaohan@chromium.org migrate debugger/script-formatter-breakpoints-4.js to e2e test 2020-02-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-27 jacktfranklin@chromium.org Reland "Extract `toBase64` into `StringUtilities`" 2020-02-27 tvanderlippe@chromium.org Typecheck common/Worker.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@091710f87c8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1044632,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1be8db4bad2275ba8486db55ae41601bac4c993c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078291Reviewed-by:
-
Rune Lillesveen authored
We used to skip the whole base computed style optimization and just compare the new style with the old stored base, but used the newly computed style always when DCHECK was enabled. This CL always computes the computed style without the base, but then, after verifying it matches the base, use the base computed style. Bug: 669790 Change-Id: Ifc82de4644fae104d69d8abf91261ba1cfe52f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074399Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#745043}
-
Bang-Cheng Wang authored
It was removed in: https://webrtc-review.googlesource.com/c/src/+/154344 Bug: internal b/144781004 Test: CQ Change-Id: I5b4ab99107f1fc3db72fb0ec279f3e9bb3c92445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076742 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Bang-Cheng Wang <bcwang@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#745042}
-
