- 10 Sep, 2020 40 commits
-
-
K. Moon authored
This reverts commit 3e085ec3. Reason for revert: Test is crashing with a segmentation fault Original change's description: > Add a pop-up for Chrome OS secondary login screen > > Bug: 1066489 > Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 > Commit-Queue: Thomas Tellier <tellier@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#805844} TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com Change-Id: I35550da66bba011cb35b9e50d38b4b02b572ce29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404061Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805939}
-
Noah Rose Ledesma authored
This change adds MediaNotificationViewModernImpl which will be used in place of MediaNotificationViewImpl when the off-by-default "Global Media Controls Modern UI" flag is enabled. This change also adds the logic to switch impls based on this flag. Bug: 1124401 Change-Id: I85893609cc8e6c072d37cd1df878498441a0044a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398950 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805938}
-
Toby Huang authored
This CL extends the expiry for the AddSupervisionDialog* UMA histograms to September 8, 2021. Bug: 1125645 Change-Id: I06478fca1b7448cd2ac46ba6722901f7ba8f6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401266 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#805937}
-
Akihiro Ota authored
This change merges the implementation for the hint and nudge systems in the interactive tutorial. Now, nudges and hints are both mangaged by the tutorial component, instead of being split between the tutorial and lesson components. Bug: N/A Change-Id: I68f237690f336ec22f2af97bf978e76340d6ecb5 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401945 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805936}
-
Rouslan Solomakhin authored
Bug: None Change-Id: I6df78c2937779d00733d213d9607768095926de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403388Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805935}
-
Michael Bai authored
Currently to get the visual rect from layout tree requires document being paint clean, it became not a good way for ContentCapture task to get the visual rect now. This patch get the visual rect from cc while capturing the content. It should have better performance than from layout tree. Bug: 1126615,1122472 Change-Id: Id10fa1ad84f64058f30c3523b78d2aff822e62a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388344Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#805934}
-
David Black authored
This UserAction is recorded from a user click on the body of a screenshot notification. Bug: 1126573 Change-Id: Ifcb2a3910e55b5019e641b24b4b4a64288361a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401267Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#805933}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599738815-ff1bf13166c585a2e1282bb43357481f321e4e87.profdata to chrome-mac-master-1599760756-5eeaad3a0935fac8a24777486ae90bd2f43c056f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I52a51996f7a1b9bf3a5b6486429441a873db68f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805932}
-
Rakina Zata Amni authored
If a page is not stored in the bfcache, the unload event will be dispatched and might trigger actions that are currently tracked in ActionAfterPagehide. This case is not interesting to track (as it is expected for these actions to happen after pagehide), so we should only track when the unload event is not in progress. This also obsoletes the version 1 of the histogram and adds a new version (recording ActionAfterPagehide2 instead of ActionAfterPagehide now). This CL also adds tracing and fixes a bug in DOMWindow::DoPostMessage where we check the target frame instead of the source frame for pagehide status. TBR=alexmos@chromium.org Bug: 977562, 1110744 Change-Id: I5d8036c5a7037a2266cef821c44c98ee55bdfd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402849 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805931}
-
kylechar authored
Fuchsia doesn't support the GL renderer backend and always uses Vulkan. This mainly stops running parameterized pixel tests with GLRenderer or SkiaRenderer+GL on Fuchsia, except LayerTreeHostCopyRequestTest* will start running on SkiaRenderer+Vulkan when Vulkan is enabled. Bug: 1117587 Change-Id: I47a9e1286a9278c4aa901359bcb1a020b3b63ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401322Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805930}
-
John Lee authored
https://imgur.com/a/lmrQgaq Change-Id: I5d7621d209b0f081fc562250a82cef839760fc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399443Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805929}
-
Robert Sesek authored
These denials were observed in local testing. Change-Id: Iccfdbdbe4d755ac954bf6757505ee583dd89fa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404411Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805928}
-
Liquan (Max) Gu authored
Change: * Move the interface NormalizedAddressRequestDelegate from PaymentRequestImpl to PaymentUIsManager. Address normalization is treated as UI logic because it's part of Autofill which is regarded as UI logic for its tight coupling with the PaymentRequestUI. This moving includes these methods: - onAddressNormalized - onCouldNotNormalize * Because the delegate is assigned in PRImpl.startShippingAddressChangeNormalization(), the method is moved into PaymentUIsManager as well. PersonalDataManager's delegate is assigned with a different "this" (from PRImpl to PaymentUIsManager). * Refactor onAddressNormalized(): - Since redactShippingAddress() is mainly used for business logic, it's taken out from onAddressNormalized(), and turned into a static method of CPRImpl. - onAddressNormalized()'s business logic is generalized into onUiServiceError() and onShippingAddressChange(). Bug: 1102522 Change-Id: I61daf4240ca64be354cc537280948ce55481155d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401515 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805927}
-
Yuheng Huang authored
Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3259362 Bug: 1099917 Change-Id: I45be750e33c43852314516e638ef348f1efabc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399499Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805926}
-
Ryan Hansberry authored
As per post-submission convo in crrev.com/c/2370094. Change-Id: I1a8ab0fd4ff9bf1b27cbfe05c36408fce9bf2438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402399 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805925}
-
Olivier Yiptong authored
This change removes a bug on Mac: a redundant ScriptPromiseResolver creation. Bug: 1043306 Change-Id: I302255dad325c2cbca96bde07f414da689f635d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404260 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805924}
-
Evan Stade authored
//chrome/android/features/media_router is moved wholesale, with the following exceptions: * integration tests move to //chrome/android/javatests as they depend on Chrome. * ChromeMediaRouterClient is moved to //chrome/android/java as it's specific to Chrome. The unit tests are now part of components_junit_tests instead of the standalone media_router_junit_tests. Bug: 1057100 Skip-Translation-Screenshots-Check: True Change-Id: I4ee0ee59ec1622fc12983f2c5d6964ec52d4ab04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389021 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805923}
-
Tamir Duberstein authored
The referenced bug is long closed. Bug: fuchsia:20851 Change-Id: I29b79d15545b5231f09da91a0afc81451608328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404623 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#805922}
-
Kevin McNee authored
InnerWebContentsCreated was only being called for GuestViews. We now call it for portal inner contents creation. This allows for test code, namely Safe Browsing tests, to be notified of the creation of the inner contents, so that test classes are created in time to observe the necessary events in the newly created contents. Bug: 1096115 Change-Id: I6cc7e3cabb72523a8c116988194db2cbd42036cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385775Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805921}
-
Ana SollanoKim authored
The test fieldset-multicol.html is passing with the feature flag, but we were expecting it to fail. In this change, the correct expectation is added and TestExpectations is updated to reflect it. Bug: 829028 Change-Id: Ie6cabfbb85cbb20ca6fd35a34d3d5f46bdba601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402178 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805920}
-
Steven Bingler authored
Add a config for SameSiteCookieMessages to turn on CookieDeprecationMessages for M85+. Removing SameSite entries as both "CookiesWithoutSameSiteMustBeSecure" and "SameSiteByDefaultCookies" are default enabled. Bug: 1054036 Change-Id: I4957bb68c315b89e5a7cf1c3b00bb0593b5262ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399580Reviewed-by:
-
Nathan Zabriskie authored
In Canvas OOPR mode we want all contexts in the renderer process to use RasterInterface/OOP resources (minus WebGL contexts). This CL uses the kCanvasOopRasterization feature flag when creating worker thread contexts to match the context settings for the shared main thread context. Bug: 1018894 Change-Id: I7ba0b565c7901e42b5545aff80ded0a395e203ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399573Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Android 11 package visibility rules mean that HTMLViewer cannot access LicenseContentProvider by default, even though the content provider does not require a permission, because that would reveal the existence of the package to it. To fix this, explicitly grant URI access permission in the intent used to invoke HTMLViewer - while actual permission is not necessary, this also implicitly grants HTMLViewer the right to "see" the WebView package. Note that in most circumstances this was already working without this change: when an app uses WebView, the platform grants the app visibility of the current WebView implementation package as a side effect (so that it can load the code), so as long as the LicenseActivity belonged to the current WebView there wasn't an issue. This change is only required for the case where you launch the LicenseActivity for a *different* WebView implementation. Change-Id: I7bab033c05d386039c55799328fe0163bc4906ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404364 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805917}
-
Zentaro Kavanagh authored
- Just import the default cros styles - No other styling yet Bug: 1125150 Test: None Change-Id: I7185db001995045d48e45d4479faa23ce6ed9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401781Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#805916}
-
Joe Mason authored
gmock's Pointee matcher dereferences raw or smart pointers. It depends on smart pointers defining element_type to recognize what type they hold. This patch adds element_type to StructPtr and InlineStructPtr so gmock will recognize them as smart pointers. R=rockot Change-Id: I06333a31c0a958fd24784e1ee2244d0232267bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403583Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#805915}
-
adamta authored
Corrects the location for the Discover feed header menu IPH bubble by using the view instead of the button's frame. Adds an event for when the Discover feed is loaded in order to add a server-side config for the IPH. Bug: 1124448, 1085419 Change-Id: I4df2919e428a5cdc429b6b157a34b82f80e3421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401971Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#805914}
-
Olivier Yiptong authored
It is unnecessary to check for Transient User Activation if the permission status has been previously granted or denied. This change ensures that the UA check is skipped in those cases on Mac, in alignment with the ChromeOS, Linux and Windows implementations. Bug: 1043306 Change-Id: I69016cdd696a7003b691d91eae1386ebf7e0f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404060 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Robert Sesek authored
Also removes a long-dead unittests_manifest.json. Change-Id: Iaded46b3c193b77acae7103bdfa363469531d3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404526Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Egor Pasko authored
When running on buildbot, we always use the internal version. The git stash/unstash/commit/push should be avoided when running locally (options.buildbot=False). In the public repository, the OrderfileUpdater should be able to upload files, it was useful just once. With this, the OrderfileNoopUpdater looks unnecessary, since we replace OrderfileUpdater in the internal repo anyway, so remove it. Otherwise the split of functionality between the public and the internal OrderfileUpdater is accidental. Not revisiting it here. Bug: None Change-Id: Icd0fc9ed69d0def8e1fa9cfd1be05083f7c9cbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403469Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805911}
-
Jonah Ryan-Davis authored
Recent patches to fix the 2D texture path on Mac have fixed a number of tests on ANGLE's Metal/Swiftshader backends. Bug: angleproject:4846 Bug: chromium:1099978 Bug: chromium:1099979 Change-Id: I1f33074d61176d6ae72e2ee57fe0b847fc4b1471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380732 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805910}
-
Michael Checo authored
Screenshot: http://shortn/_9HmkoESwea Bug: 1122235 Test: manual inspection Change-Id: I2c02dedb2b6f2201ae147349f60f872b247055bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386488 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
Kevin Schoedel authored
Web page-level focus was absent, which in turn meant that blink-level focus was suppressed. The aura::Window on which focus was attempted did not have an OnWindowFocused observer; this change focuses the Window that does. This is a reland of one piece of the reverted http://crrev.com/c/2274201 Bug: b/156123509 Test: manual on device Change-Id: I0a9ec66de97f346512f9ade01f7ad4821159c527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348420Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805908}
-
Trevor Perrier authored
This is the last of four CLs for the Clank language decouple. It adds UI to the Language settings that allows users to set an application specific language. The UI is behind the flag DETAILED_LANGUAGE_SETTINGS. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1068667#c6 Bug: 1068667 Change-Id: Ie32a7efe66091a5072499bd886e1f9c8728e75e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355494 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805907}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e8358a4dead..feb1579dfb25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a99b96f9a4fda85232926df5d55fd3e75788475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/65dcbe124508..1bd71b48fb5c 2020-09-10 syoussefi@chromium.org Make gl::DrawBufferMask a BitSet8 2020-09-10 emaxx@chromium.org Fix useless move() in SizedMRUCache_unittest.cpp 2020-09-10 timvp@google.com Vulkan: Avoid linking to SPIR-V validation if possible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122844 Tbr: ianelliott@google.com Test: Test: CQ Change-Id: I58d5f34c0bc0fb77b2b49fc6756eca63b5eb56d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404083Reviewed-by:
-
Matt Jones authored
This patch throws exceptions for cases that shouldn't be happening when using the bottom sheet. These will hopefully help track down an issue where the sheet is visible with null content. Bug: 1126872 Change-Id: I65789df1a569674d19610f41e50b45e21edb1136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403902Reviewed-by:
-
Sharon Yang authored
Remove the Native / Android comment on the StringAttribute kClassName since that value is no longer populated by Android and is used on all platforms. Change-Id: I361912e66c8c2c0b4cd136a02412d135ac0180bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404408Reviewed-by:
-
Junbo Ke authored
|is_for_auth| is unnecessary since we only need to know which headers are signature. Bug: b/162380916 Merge-With: eureka-internal/444720 Test: On device Change-Id: Icd46e0b88d55de83cbfc1d43fb7584c25999d421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382714Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb8d5f7d60cb..0c37bf0f193b 2020-09-10 jegarc@microsoft.com [Issues] UMA tracking for the issues panel 2020-09-10 patrick.brosset@microsoft.com Grid: Display a "no grids" message in the layout pane when there are no grids 2020-09-10 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewProcessingView.js with TypeScript 2020-09-10 jacktfranklin@chromium.org Reland "Expose the live directive from LitHtml" 2020-09-10 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewStartView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1100658,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I939df8e1d59948d15b19a791c74d84ba77ed08c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404204Reviewed-by:
-
Kevin McNee authored
This test navigates a new tab via its opener to demonstrate that the source information in the referrer chain reflects the previously committed URL in the navigating frame, rather than the initiator of the navigation. This scenario is worth considering for any future attempt to capture information about the initiator in the referrer chain. Bug: 1096115 Change-Id: If997a84b46ea45640266cfb2e954ee291f06201f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386755Reviewed-by:
-
