GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/07475fa782de..31899ec2ac04

git log 07475fa782de..31899ec2ac04 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 tbarzic@google.com Increase parallel emerge job output interval

Created with:
  gclient setdep -r src/third_party/chromite@31899ec2ac04

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I1312b9695e1581219457227beebb76c7a4600177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683526}

Using wpt-import in Chromium fd0bec2f.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
6790530d "[WPT/common/security-features] Make subresourceContext unmodified"
219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I90ea852ac71df99f922fcad1a309f17453ab3f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731512Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683525}

https://chromium.googlesource.com/angle/angle.git/+log/369f9e5df60b..5e6468ba6b6f

git log 369f9e5df60b..5e6468ba6b6f --date=short --no-merges --format='%ad %ae %s'
2019-08-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src eea340047eca..a0eb5efd2bad (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@5e6468ba6b6f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: chromium:None
Change-Id: I65962fb26216f3c9e1cbd042a8c4bf48ece1caa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732685Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683524}

https://android.googlesource.com/platform/external/perfetto.git/+log/f50c2ff2f70c..432573ac119d

git log f50c2ff2f70c..432573ac119d --date=short --no-merges --format='%ad %ae %s'
2019-08-02 fmayer@google.com Merge "Parse line numbers for llvm-symbolizer."

Created with:
  gclient setdep -r src/third_party/perfetto@432573ac119d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I589e96bc4ac9e1b93eef2715b4e136c2570eba30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733010Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683523}

Following https://dawn-review.googlesource.com/c/dawn/+/9641, a
GPURenderPipeline fragmentStage is not required anymore.
Note that it will still raise a validation error as vertex-only render
pipelines are not supported yet in Dawn.

Bug: 877147
Change-Id: I2ccf88974fa011a6ba3a45d229e36e40e23c5dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730057Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#683522}

It seems like, in rare cases, the local changes sync up to the server
before the test has the chance to assert that local changes are pending.
Since the condition is not crucial for the test, let's just skip it.

Bug: 956043
Change-Id: Ia515d174aeae3f8ccf5648e46ed79e685d9e29e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731934
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683521}

When WebUsage is disabled, the touch recognizer is disconnected from the
WebController. The WebController is no longer notified of the touch
events.
The touch recognizer was never reconnected, even when WebUsage was
enabled back.
This CL completely removes the touch recognizer from the Container view
when the WebUsage is disabled, but add a new one when it is re-enabled.

Bug: 987613
Change-Id: I696955bf0d28ee08658f5e788afcb1ffc07cdc12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724672
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683520}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b0db4f56..97bc222c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic12beacf693c76ec193e40f3be4333c6c8cce301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731340Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683519}

PerNavigationMojoInterface is turned on by default. Beta/Stable rollout
gets controlled by a finch config.

Bug: 784904, 988368
Change-Id: I3e0fd0af1b47582764fb076a5be244a700b9bfc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710320Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683518}

The 'options' argument has been replaced with a new 'run_options',
where callers are expected to pass a fully formed options object with
all settings required to run benchmark stories.

This also requires clients to provide an output_dir suitably wired
to a temp_dir for tests.

Bug: 985712
Change-Id: If26078caa61f7b0a006906420899109d1f4e9a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720839
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683517}

Latency is a priority for our team in the next year so we're extending
the expiration for the relevant metrics.

Bug: 988629
Change-Id: I2b26a29d3722d6dfa0907eb626eddf07c8d1ead8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731830
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683516}

SpeechGrammar's addFromUri method was already measured because the
capitalization doesn't match the spec, but also measure the other parts
of the grammar API surface to learn how widely used it is.

Prompted by spec issue: https://github.com/w3c/speech-api/issues/57

Change-Id: Ib9289f911ad4966d5e0c836924444cd1d3b4be60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732790
Auto-Submit: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683515}

Theoretically, if the scheduler for some reason doesn't destroy the
callback right after its execution,
CancelableTaskScheduler::CancelAndWait may stall. I'm not sure if this
is the reason why performance tests fail with timeouts on win-perf, but
it may be related to Windows scheduler specifics.

Bug: 987574
Change-Id: Id3bf951c78bf37aae66ce0657e113ddefe9918b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731930
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683514}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=grunell@chromium.org, jbroman@chromium.org

Bug: 968047
Change-Id: Id8a11433f2c3e2d37c5452bab643ed098441b435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728886
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683513}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/eea340047eca..a0eb5efd2bad

git log eea340047eca..a0eb5efd2bad --date=short --no-merges --format='%ad %ae %s'
2019-08-02 johnkslang@users.noreply.github.com Merge pull request #1860 from zoddicus/fixShaderCRoll

Created with:
  gclient setdep -r src/third_party/glslang/src@a0eb5efd2bad

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com,geofflang@google.com

Bug: None
Change-Id: Id612423397a0b4bb1edb2ab7dacee09136fa0118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732792Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683512}

This reverts commit addae291.

Reason for revert: Still flaking (see https://crbug.com/990229).

Original change's description:
> Re-enable ChromeVox panel tests
> 
> TBR=sky@chromium.org
> 
> Bug: 795840
> Change-Id: Idc11aa884c29cd73960355e660ce2219aa674621
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534283
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#644494}

TBR=dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,anastasi@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 795840, 990229
Change-Id: I2de806da00fb806e042d2a89b71026738105348a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732889
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683511}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/87ba747e956d..07475fa782de

git log 87ba747e956d..07475fa782de --date=short --no-merges --format='%ad %ae %s'
2019-08-02 vapier@chromium.org lint: catch excess quotes at the start of docstrings
2019-08-02 vapier@chromium.org third_party: import pylint_quotes module for linting
2019-08-02 mmortensen@google.com Refactor artifacts.BundleEbuildLogs to use service/lib structure.

Created with:
  gclient setdep -r src/third_party/chromite@07475fa782de

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ieedfec86be40b306f33291980fd2d4853dfc2a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732517Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683510}

Also make punctuation consistent across descriptions of the Renderer Panel.

Bug: 989861
Change-Id: I4f1026d1899fb5965f791d1ae6891073a6e4e637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730412
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#683509}

This CL renames *_struct_traits.* to *_mojom_traits.* in
//services and fixes the wrong header guard name.

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: I4e45625070fa592af6c05a734a15f46e08378ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730411Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#683508}

Now that pending NavigationItem are stored in NavigationContext, it
will never be null. Remove the legacy code that checks if pending
NavigationItem exists in CRWWKNavigationHandler.

Bug: 925304
Change-Id: I5eb541f068b4a6db1f5322fed2e7318d686a845a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730424
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683507}

r683358 introduced a bug where in a SpellCheckHost.CallSpellingService
message response callback may be dropped without being called whenever
the source render process has been terminated. That can result in a
DCHECK being hit in testing environments but is otherwise harmless.

This CL fixes the issue by ensuring that the response callback gets
called in the case where the process has been terminated.

Bug: 977637
Change-Id: I6d815be3cad8199c7f8bef27ac10f322b217f881
Tbr: thestig@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732678Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#683506}

The presubmit told me so.

TBR=rsorokin@chromium.org
BUG=b/138287069
TEST=None

Change-Id: I6e32ff7e4cc74e044e949e09a75d8fffbd271c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731835Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683505}

Change-Id: Ie171df6c108992ecaf417f95de24bb43e1d79967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732076
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683504}

PendingAppManagerImplBrowserTest.BypassServiceWorkerCheck tests whether
the pending app installation installs the app as a PWA rather than a
shortcut app. This can be determined by the presence of a scope.
The function FindAppWithUrlInScope() uses a default scope if there isn't
one present so its return value can't be used as an indication of the app
having/not having a scope.

This CL improves the check by explicitly checking GetAppScope().

Change-Id: Ieeb0c9dfb911cf3af5657e53ed86f65b60a8f07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732516
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683503}

This reverts commit f37f7fde.

Reason for revert: Let me revert this so that crrev.com/c/1728889 can create
throttles on the IO thread.

Original change's description:
> Remove unused members of ProfileIOData
>
> These are no longer used after http://crrev.com/c/1731919
>
> Bug: 824840
> Change-Id: I7163336861c227fb7fa7aab9fe297898d92067c7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731180
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683474}

Change-Id: I2b5c64dd5d5548dfe472352a6a1313bee7fa8770
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732519
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683502}

Incognito window counter has been enabled by default since M66. Removing
the kEnableIncognitoWindowCounter flag.

Bug: 896235
Change-Id: Ib52d17f652f8c77e42496732e74efefc3edab79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729224
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683501}

This is a preparation CL for removing WorkerShadowPage. Before this CL, shared
worker's user agent is supplied by WorkerShadowPage's Document. After this CL,
it's supplied from SharedWorkerHost in the browser process. This is aligned with
service workers.

Bug: 538751
Change-Id: I16a4c51077ed04563c9bba4609f821b704d59ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730490
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683500}

In processing interface inheritance, we make a copy of unforgeable
member defined in recursively inherited interfaces.


Bug: 839389
Change-Id: I7ad45a90c0540f75aed39982f0831424a3459181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728511
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683499}

[PasswordManager] Fixed linter issues / style guide violations in |FormStructure| caused by using non-const references instead of pointers.

Change-Id: I44623a3c24d353a82c9745d0c1ed222afd242876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731114Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#683498}

Change-Id: I7e4b2b61214ccb74a14a7bffb4a4b64eb9d80f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724525
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683497}

R=dvadym@chromium.org

Change-Id: I9cdd44e714d07344743f8886bc22d801ceb119bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732071
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683496}

Change-Id: I3b6c93cc61d66922b92ac12cfcc31e4e528000c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731637
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683495}

https://dawn.googlesource.com/dawn.git/+log/574b951188bb..c1583a558c58

git log 574b951188bb..c1583a558c58 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 idanr@google.com Create CommandRecordingContext

Created with:
  gclient setdep -r src/third_party/dawn@c1583a558c58

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: chromium:976495
Change-Id: Ic3bc1f5dfed56b289efba9c5ed0a045a8d1a1d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683494}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9532972a16bb..87ba747e956d

git log 9532972a16bb..87ba747e956d --date=short --no-merges --format='%ad %ae %s'
2019-08-02 yyanagisawa@chromium.org Allow to set Goma client used for build package.

Created with:
  gclient setdep -r src/third_party/chromite@87ba747e956d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I79a05fdadc1ddc3a0d5d622fcb3074d9a32c175f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683493}

BUG=988321

Change-Id: I71583875adc8297fa632eb1caedc08e925d50235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731639Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683492}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0390f88f270..e1cff9e2ff2c


Created with:
  gclient setdep -r src-internal@e1cff9e2ff2c

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: I40100397071ec8b43b943b5a8d6f5415560dd19a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732715Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683491}

Using wpt-import in Chromium 1d7d96a9.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
6790530d "[WPT/common/security-features] Make subresourceContext unmodified"
219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mstensho@chromium.org:
  external/wpt/css/css-multicol

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I54029a61a648c79becb0cdd82a816dab20cac127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731452Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683490}

This CL replaces the gray outline of the navigation bubble with a
shadow. Also fixes a bug on Kitkat where the bubble appears in dark
gray which was a side effect from RippleBackgroundHelper.

Bug: 979499, 988341
Change-Id: Ibea69d60834d916f99ec7add54e1d4ae7484c5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722581Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683489}

This reverts commit 536bae08.

Reason for revert: unit_tests failure fixed by crrev.com/c/1732110

Original change's description:
> Revert "Flip the AppServiceAsh feature default to enabled"
> 
> This reverts commit 1b08fa8e.
> 
> Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg.
> https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673
> deterministic failures:
> ArcAppLauncherForDefaultAppTest.AppIconUpdated/0
> ArcAppLauncherForDefaultAppTest.AppIconUpdated/1
> ...
> E.g.
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0
> [ RUN      ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0
> Received signal 11 <unknown> 000000000000
> #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread()
> #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver()
> #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver()
> #12 0x5611ff697745 apps::ArcApps::~ArcApps()
> #13 0x5611ff69786c apps::ArcApps::~ArcApps()
> ...
> #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate()
> #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed()
> #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed()
> #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed()
> #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder()
> #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown()
> #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile()
> #29 0x5611fe3b43cc TestingProfile::~TestingProfile()
> ...
> 
> Original change's description:
> > Flip the AppServiceAsh feature default to enabled
> > 
> > BUG=826982
> > BUG=989789
> > 
> > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Commit-Queue: Nigel Tao <nigeltao@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#683064}
> 
> TBR=dominickn@chromium.org,nigeltao@chromium.org
> 
> Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 826982, 989789
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/heads/master@{#683108}

TBR=tasak@google.com,dominickn@chromium.org,nigeltao@chromium.org

Change-Id: I0f8e2a335011012df144a02cf75fe943f6196171
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826982, 989789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731373Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683488}

This (PS1) passes all existing tests as-is but
ParkableStringTest.ReportTotalUnparkingTime.

This failure happens because samples of Now() within the same task
no longer have any delta under MOCK_TIME regardless of how CPU expensive
the operation actually is.

That test was using a state of the art approach, base::ElapsedTimer,
MOCK_TIME, base::HistogramTester, etc.

But base::ElaspedTimer is neutered by the change to MOCK_TIME in this CL.

There are two potential solutions:
  1) Have ElapsedTimer play a role in auto-advancing mock-time.
  2) Mock timings returned by ElpasedTimer.

(1) is undesirable because it would make it possible for delayed tasks
to run as part of a basic RunUntilIdle() which takes control of delayed
tasks away from the ScopedTaskEnvironment owner and is highly undesired.

(2) is more explicit but also easier to control. This CL does that by
adding base::ScopedMockElapsedTimersForTest.

This actually makes ParkableStringTest.ReportTotalUnparkingTime cleaner
because it can now test for a specific timing instead of just
"has a non-zero timing".

Bug: 905412
Change-Id: I91fab300b4005fd7802ce837733665e77766d4b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707870
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683487}