- 03 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cba9bbbed68f..fc059c13722f 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c278dada96d9 to 2c60d16a646b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4158c41ad3ac2e882c735964a9ded3b60ba80f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804186}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. Note: This patch also changes number of bits of |SharepResult::num_glyphs_| from 30 to 29 to hold bit flags in |unsigned| (32-bit) for re-landing[1]. [1] http://crrev.com/c/2390615 Revert "Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing" Bug: 1124446 Change-Id: I120cc379a191e1499ac1548a569474ed03d0f6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391890 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804185}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca13f09d7848..e3c171740b34 2020-09-03 wolfi@chromium.org Fix context menu for issues banner 2020-09-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11e584bc177516d5cd648b29c620598bc1cf056a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392270Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96dcbc6eb372..1d46a533aa37 2020-09-03 primiano@google.com Merge "UI: Fix GA CSP and improve logging for 127.0.0.1:9001" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If0e4d5314dc758f2eee7dbe8ae4e299940832c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392557Reviewed-by:
-
Eric Willigers authored
On Desktop, we support sharing the same set of MIME types and file extensions as are already supported for sharing on Android - see ShareServiceImpl.java Bug: 1035527 Change-Id: I4f61ea13443fa0b89df8952fadf4fdd57f6a4faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387040 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804182}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009020800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/1qbXo8ERLriX3qTO61nU_5jcnLyTY24RI8vMnsekD9AC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165389574,b/166688012 Tbr: media-app@grotations.appspotmail.com Change-Id: Id306159286afd57d63cf52c88aab3a34d4a1b2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390981Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804181}
-
Hajime Hoshi authored
Change-Id: I151463a89d83de0f9745a268a85923e3ca20e8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390614Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804180}
-
Rob Buis authored
Unskip some OOF tests since these pass since some time. Bug: 6606 Change-Id: Ie48a103933b502ed910a05ada2e6276d31788fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390743 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804179}
-
Kent Tamura authored
shadow_element_names.* contains element ID names and pseudo names. Since this CL, C++ symbols for the former are prefixed by "kId", and symbols for the latter are prefixed by "kPseudo". This CL has no behavior changes. Bug: 1124623 Change-Id: I7bf23f93b5365351b71568aa48ef3bc855c7560a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390613 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804178}
-
Yoshisato Yanagisawa authored
Bug: 1124200 Change-Id: Ib629c0146d29bfb2a8a0cedaf88b80d4a1efb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392416 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#804177}
-
Niels Möller authored
And delete corresponding chrome flag and experiment wiring. Bug: webrtc:8504,842613 Change-Id: I06b1d02943a50784680f688ba0968d7304529276 Tbr: beccahughes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351774 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804176}
-
Jimmy Gong authored
FeatureStatusProvider will now also be notified if there is a change with the local and remote host connection. Bug: 1106937 Test: unit_tests Change-Id: I8d2cc98beb5453e71e084935b88f6ab51a308b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389105 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804175}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1c3e060. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I8e1d557e130cb8cd5a229fad656be7cb4b7c5e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390722Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804174}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46877765c47c..96dcbc6eb372 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib3170ce732260c78a4b35c8cfc8859a3da082b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390836Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL hides the "Move to your Google Account" option in the overflow menu for the entry in chrome://settings/passwords/device corresponding to the first signed-in GA. The reason is it makes no sense to move a password for an account into that same account. Screenshots are attached in the linked bug. Fixed: 1113739 Change-Id: I6a5cfed2a67ed9f0b6ede373f552a77029b291b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385336 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804172}
-
Paula Vidas authored
Bug: 1102312 Change-Id: Ia1c4e4582bb6d4a36f7e21aa1300952b6d3361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390200 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804171}
-
Ulan Degenbaev authored
With concurrent allocation GetHeapStatistics and GetHeapSpaceStatistics may return different results. This CL makes GetHeapSpaceStatistics the source of truth and relaxes some DCHECKs. Bug: v8:10315 Change-Id: I6e774ed3974b4dbe00d7fbb913c8ff77e3649e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388391Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804170}
-
Justin Cohen authored
This is a reland of 2f675c0b Original change's description: > Reland "ios: Disable RemoveCookie test on iOS14." > > This reverts commit c88fabeb. > > Reason for revert: Still failing in beta 6 on the bots: > https://chromium-swarm.appspot.com/task?id=4e4543820c675010 > > Original change's description: > > Revert "ios: Disable RemoveCookie test on iOS14." > > > > This reverts commit 163b6034. > > > > Reason for revert: Speculative revert for beta 6 > > > > Original change's description: > > > ios: Disable RemoveCookie test on iOS14. > > > > > > TBR=mrefaat > > > > > > Bug: 1121425 > > > Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705 > > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#801345} > > > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > > > Change-Id: Ideb21ea26cee61249444139f7a0c59735f1e5754 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1121425 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376314 > > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801908} > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > No-Try: true > Bug: 1121425 > Change-Id: I07719c7d73c83b5d288136ae4df9d57845b162d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378534 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801933} TBR=justincohen@chromium.org,mrefaat@chromium.org No-Try: true Bug: 1121425 Change-Id: I7cadaf0831995ff830ec38539c9651db814e4a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392281Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804169}
-
Dominik Röttsches authored
Instead of individual tests for tag sequences, use newer ICU methods to detect xpicto_sequences as in Unicode TR#29, compare https://www.unicode.org/reports/tr29/#Regex_Definitions by using ICU's UCHAR_EMOJI_COMPONENT and UCHAR_EMOJI_COMPONENT checks. Bug: 1121420 Change-Id: I37c9cab51ea88c6be85c2df637af03dcf68c568f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390341Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4cac73d9..0463f138 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id030c6f1ac89d49e6f32cbd078e239f796366656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804167}
-
Alex Chau authored
Bug: 1109827 Change-Id: I39f378208da3d24b1c49738c8e30b111d3a3dd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390661Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#804166}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599025789-3a109ab6fe2db36da4d9ead01eda119b5774b91d.profdata to chrome-win64-master-1599089820-30c557886a4f99c250ad2970e2bac8f9c1182d9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0203da053eb6a18d6a34008b98c1baa0b540e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392043Reviewed-by:
-
Makoto Shimazu authored
Disabled two tests: - WebContentsImplBrowserTest.DownloadImage_Deny_FileImage - WebContentsImplBrowserTest.DownloadImage_Allow_FileImage TBR=falken@chromium.org No-Try: true Bug: 1124349 Change-Id: I5412e0a932b22952e4243c7f075260bf2b434405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391889Reviewed-by:
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_PreviewIds to print.mojom to pass it to Mojo interfaces. This is a precursor CL to move PrintPreviewUI implementations to PrintPreviewMessageHandler and use WebContentsFrameReceiverSet instead of having its own pipe. Bug: 1122515, 1008939 Change-Id: I034e05f64f2de565dcf6a7d9724b78e822bf2114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379455 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804163}
-
Palak Agarwal authored
stage of media::VideoCaptureBufferPoolImpl Change-Id: I993f1527729b11a12909bf07a3a1d929289fbf3a Bug: 781987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384035Reviewed-by:
-
Joel Hockey authored
This is a refactor only change to move functions from plugin_vm namespace to PluginVmFeatures object. TBR'ing owners as per https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=stevenjb@chromium.org TBR=khorimoto@chroimum.org TBR=nancylingwang@chromium.org Change-Id: I3e0fe49adb32eb2f9cd830efec26b8adecfaff73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391031 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804161}
-
Alice Wang authored
This CL adds a field for spinner view in the AccountPickerBottomSheetView and rearranges some view setup methods. There is no behavior change in the CL. Bug: 1122942 Change-Id: I42bc643684be24f27e7234eea807672cde3fa14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385115Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804160}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6cebd4f5bf5..ca13f09d7848 2020-09-03 changhaohan@chromium.org Add UMA to track computed style grouping usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096230 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d5c7e68619fa995a2ab82001efe73dd33f76b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391866Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7571f9e49024..a66a9c31a318 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e1051cbaad46 to 75690ce7ef4a (4 revisions) 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 33b01ad5 to 210fb6b5 (274 revisions) 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6eeb3d8bf667 to 0c25fbe3e3ed (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1034840,chromium:1123524,chromium:1124379 Tbr: michaelludwig@google.com Change-Id: I0a395f20daaae9bab4aa28237b6215c3f527f6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391867Reviewed-by:
-
Hiroki Nakagawa authored
This is just a cleanup, and doesn't change functional behavior. Bug: n/a Change-Id: I42b6c5ca089302a9dcdffb85c01e3fc24e090d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391185Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#804157}
-
Michele Mancina authored
Bug: b/157457785 Change-Id: I405f33df3d48af3a83edfd58ebf6bb8fe29c08fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390644Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#804156}
-
Koji Ishii authored
This reverts commit 8ecd46b9. Reason for revert: Increases memory usage on 32 bits Original change's description: > Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing > > This patch changes |NGInlineNode::ShapeText()| not to reuse > |ShapeResult| for text with CSS property "letter-spacing" because we > modify |ShapeResult| directly to apply letter spacing. Thus, letter- > spacing is applied more than once on reused portion of |ShapeResult|. > > Bug: 1124446 > Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804147} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: I2fbb377d000fa3944b5902043ae8796dedd9119c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390615Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f76c76d25df8..3649c2a8b0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1116650,chromium:897470 Tbr: shimazu@google.com Change-Id: If890693c473d4bb641d6b96a59dd53af8491c72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391863Reviewed-by:
-
Benoit Lize authored
glibc used to allocate memory using __libc_memalign(), and free it with free(). This imbalance means that our allocators are asked to free() data they didn't allocate. To make sure this doesn't happen, intercept the internal libc symbols. This was already done for tcmalloc, but not for PartitionAlloc. Extend it to PartitionAlloc, and add a test. Also document the issue more clearly in the files. This is required for PartitionAlloc Everywhere. Bug: 998048 Change-Id: I0852fc87f92f97de93aba130b2416926aa71d873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386717Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804153}
-
Camillo Bruni authored
Move the erroneously placed Microtask checkpoint from V8ScriptRunner::EvaluateModule to ModulatorImplBase::ExecuteModule. This CL affects the ordering around module script evaluation, especially between microtasks and Window/WorkerGlobalScope error events. This CL is a preparation to make the top-level await implementation simpler and more spec-conformant: https://crrev.com/c/2228881 Additionally we fix the evaluation-order-2-import-worker.mjs test expectations to be spec compliant. Bug: 1022182, 1096455c, 1114034, v8:9344 Change-Id: I0f6d510b62310d9342fea30ff8ed6cbe37349cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339658 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#804152}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599089820-64812fa7a88dc8607ac3baec5789a7fcb10cfda3.profdata to chrome-mac-master-1599112620-f359a51daebae2f754df062494b1fdebe13ff3bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I83e8fb9c57a0e3cb6054e08ffe8b66c74f1816b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391871Reviewed-by:
-
Alice Wang authored
This CL refactors AccountPickerBottomSheetTest by extracting the method clickContinueButtonAndWaitForErrorSheet() and add two more checks in checkCollapsedAccountList() method. Bug: 1121536 Change-Id: Id7a890ad66b244ea171c7a24d583c402600fca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383029Reviewed-by:
-
Irina Fedorova authored
This CL renames CompromisedCredentialsManager class to InsecureCredentialsManager and renames its methods. We need these changes as we want to repurpose this credentials manager to work with both weak and compromised credentials. Bug: 1119752 Change-Id: I533561b1212d8e55022e324dffa5c916b7e73d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387098 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
James Vecore authored
This change makes the Nearby Share keyed service only start for 'PrimaryProfiles' on chromeos and adds some additional profile oriented logging for debugging process manager profile issues. Change-Id: If239b038627c343bbf5848e9a4ab1f5aed498f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391905Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804148}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. Bug: 1124446 Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804147}
-
