- 03 Feb, 2010 20 commits
-
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=31704 Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02 Reviewed by David Levin. This is so it can be called from the newly exposed Chromium API setter method. * rendering/RenderThemeChromiumLinux.cpp: * rendering/RenderThemeChromiumLinux.h: WebKit/chromium: [Chromium] Add API method for setting caret blink frequency. https://bugs.webkit.org/show_bug.cgi?id=31704 Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02 Reviewed by David Levin. This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method to be called Chromium's API. The API is linux-only as it is currently the only port to implement RenderTheme::setCaretBlinkInterval. * WebKit.gyp: Add WebRenderTheme.{h,cpp} * public/linux/WebRenderTheme.h: Added. * src/linux/WebRenderTheme.cpp: Added. (WebKit::setCaretBlinkInterval): Exposed API git-svn-id: svn://svn.chromium.org/blink/trunk@54280 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yael.aharon@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=34425 Reviewed by Kenneth Rohde Christiansen. Buffer the sent data in SocketStreamHandlePrivate instead of relying on the network layer to do it. This is more robust and more consistent with how Qt's HTTP stack works. Close the socket in SocketStreamHandlePrivate::close() regardless of its state. No new tests, since no new functionality is introduced. * platform/network/qt/SocketStreamHandlePrivate.h: * platform/network/qt/SocketStreamHandleQt.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@54279 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hamaji@chromium.org authored
Unreviewed revert of r54259 as it seems to break chromium's unit tests. The tests pass with r54257 but fail with r54260. As r54258 and r54260 don't touch code, I'm reverting this change. [V8] Generate toV8 conversion helpers, a la JSC bindings. https://bugs.webkit.org/show_bug.cgi?id=32563 * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement): * bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): * bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): * bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter): * bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): * bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object): * bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): * bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback): * bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent): * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent): * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent): * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent): * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter): * bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): * bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter): * bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter): * bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter): * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback): * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback): * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback): * bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback): * bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter): * bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter): * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter): * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback): * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter): * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback): * bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback): * bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter): * bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback): * bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback): * bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback): * bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object): * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): * bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback): git-svn-id: svn://svn.chromium.org/blink/trunk@54278 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Start unforking debugger and profiler code. Remove custom implementation of Console. Add 'ScriptProfiler' and 'ScriptProfile' types. Start migration to engine-neutral types in InspectorController. https://bugs.webkit.org/show_bug.cgi?id=34481 * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSConsoleCustom.cpp: * bindings/js/ScriptProfile.h: Added. * bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop): * bindings/js/ScriptProfiler.h: Added. * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile): * bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop): * bindings/v8/ScriptProfiler.h: Added. * bindings/v8/custom/V8ConsoleCustom.cpp: Removed. * inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName): * inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage): * page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd): * page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles): * page/Console.idl: git-svn-id: svn://svn.chromium.org/blink/trunk@54277 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mnaganov@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54276 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot https://bugs.webkit.org/show_bug.cgi?id=33349 * platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped. git-svn-id: svn://svn.chromium.org/blink/trunk@54275 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. Fix a bug that changes for some constraint attributes doesn't update validation CSS selectors. https://bugs.webkit.org/show_bug.cgi?id=31716 Add tests for maxLength changes and step changes. * fast/forms/input-live-pseudo-selectors-expected.txt: * fast/forms/resources/input-live-pseudo-selectors.js: * fast/forms/resources/textarea-live-pseudo-selectors.js: * fast/forms/textarea-live-pseudo-selectors-expected.txt: 2010-02-02 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. Fix a bug that changes for some constraint attributes doesn't update validation CSS selectors. https://bugs.webkit.org/show_bug.cgi?id=31716 - Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck() - Introduce HTMLFormControlElement::setNeedsWillValidate() - Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute(). - We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck): * html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue): * rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged): git-svn-id: svn://svn.chromium.org/blink/trunk@54274 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rolandsteiner@chromium.org authored
(https://bugs.webkit.org/show_bug.cgi?id=34198) Reviewed by Adele Peterson. Resetting line-height to 'normal' in the default UA style sheet. Adding layout-test to check for this. WebCore: Test: fast/ruby/ruby-line-height.html * css/html.css: LayoutTests: * fast/ruby/script-tests: Added. * fast/ruby/script-tests/ruby-line-height.js: Added. * fast/ruby/ruby-line-height-expected.txt: Added. * fast/ruby/ruby-line-height.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54273 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=datetime, datetime-local, month, time and week https://bugs.webkit.org/show_bug.cgi?id=34483 Add tests for datetime, datetime-local, month, time and week, and merge existing tests into one test file. * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-date.html: Removed. * fast/forms/ValidityState-rangeOverflow-expected.txt: Added. * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-number.html: Removed. * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-range.html: Removed. * fast/forms/ValidityState-rangeOverflow.html: Added. * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-date.html: Removed. * fast/forms/ValidityState-rangeUnderflow-expected.txt: Added. * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-number.html: Removed. * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-range.html: Removed. * fast/forms/ValidityState-rangeUnderflow.html: Added. * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow.js: Added. * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added. 2010-02-02 James Robinson <jamesr@chromium.org> Reviewed by Dmitry Titov. Add a null check for image, which might be NULL if tileSize is empty https://bugs.webkit.org/show_bug.cgi?id=34510 Test: fast/gradients/crash-on-1px-border.html * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): git-svn-id: svn://svn.chromium.org/blink/trunk@54272 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=datetime, datetime-local, month, time and week https://bugs.webkit.org/show_bug.cgi?id=34483 Add tests for datetime, datetime-local, month, time and week, and merge existing tests into one test file. * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-date.html: Removed. * fast/forms/ValidityState-rangeOverflow-expected.txt: Added. * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-number.html: Removed. * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed. * fast/forms/ValidityState-rangeOverflow-range.html: Removed. * fast/forms/ValidityState-rangeOverflow.html: Added. * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-date.html: Removed. * fast/forms/ValidityState-rangeUnderflow-expected.txt: Added. * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-number.html: Removed. * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed. * fast/forms/ValidityState-rangeUnderflow-range.html: Removed. * fast/forms/ValidityState-rangeUnderflow.html: Added. * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed. * fast/forms/script-tests/ValidityState-rangeOverflow.js: Added. * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed. * fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added. 2010-02-02 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=datetime, datetime-local, month, time and week https://bugs.webkit.org/show_bug.cgi?id=34483 Tests: fast/forms/ValidityState-rangeOverflow.html fast/forms/ValidityState-rangeUnderflow.html * html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types. git-svn-id: svn://svn.chromium.org/blink/trunk@54271 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hamaji@chromium.org authored
Reviewed by Dimitri Glazkov. [Chromium] Implement WebFrameImpl::pageNumberForElementById https://bugs.webkit.org/show_bug.cgi?id=34471 * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageNumberForElementById): * src/WebFrameImpl.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54270 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54269 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn. git-svn-id: svn://svn.chromium.org/blink/trunk@54268 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ukai@chromium.org authored
Reviewed by Alexey Proskuryakov. WebSocket wrapper can be collected even if events are pending https://bugs.webkit.org/show_bug.cgi?id=34014 * websocket/tests/websocket-pending-activity-expected.txt: Added. * websocket/tests/websocket-pending-activity.html: Added. 2010-02-02 Fumitoshi Ukai <ukai@chromium.org> Reviewed by Alexey Proskuryakov. WebSocket set pending activity to avoid unexpected GC. https://bugs.webkit.org/show_bug.cgi?id=34014 Test: websocket/tests/websocket-pending-activity.html * websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity. * websockets/WebSocket.h: * websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data. git-svn-id: svn://svn.chromium.org/blink/trunk@54267 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kov@webkit.org authored
No review, rolling out r54261. http://trac.webkit.org/changeset/54261 https://bugs.webkit.org/show_bug.cgi?id=34435 Causes crashes on release builds * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): * platform/gtk/GOwnPtrGtk.cpp: Removed. * platform/gtk/GOwnPtrGtk.h: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@54266 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Geoffrey Garen. Crash in CollectorBitmap::get at nbcolympics.com https://bugs.webkit.org/show_bug.cgi?id=34504 This was caused by the use of m_offset to determine the offset of a new property into the property storage. This patch corrects the effected cases by incorporating the anonymous slot count. It also removes the duplicate copy of anonymous slot count from the property table as keeping this up to date merely increased the chance of a mismatch. Finally I've added a large number of assertions in an attempt to prevent such a bug from happening again. With the new assertions in place the existing anonymous slot tests all fail without the m_offset fixes. * runtime/PropertyMapHashTable.h: * runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::checkConsistency): git-svn-id: svn://svn.chromium.org/blink/trunk@54265 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
No review, rolling out r54245. http://trac.webkit.org/changeset/54245 https://bugs.webkit.org/show_bug.cgi?id=34492 This patch seems to have broken thousands of chromium tests on Windows (and since it was for chromium, I'm rolling it out). * dom/Element.cpp: (WebCore::Element::baseURI): git-svn-id: svn://svn.chromium.org/blink/trunk@54264 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sfalken@apple.com authored
Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: 2010-02-02 Steve Falkenburg <sfalken@apple.com> Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * win/tools/scripts/auto-version.sh: 2010-02-02 Steve Falkenburg <sfalken@apple.com> Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * WebKit.vcproj/WebKit.rc: 2010-02-02 Steve Falkenburg <sfalken@apple.com> Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * WebCore.vcproj/QTMovieWin.rc: git-svn-id: svn://svn.chromium.org/blink/trunk@54263 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
No review, rolling out r54257. http://trac.webkit.org/changeset/54257 https://bugs.webkit.org/show_bug.cgi?id=34491 [Chromium] broke thousands of Win tests and a few of Linux tests. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths): * platform/graphics/skia/PlatformContextSkia.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54262 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Gustavo Noronha Silva. [Gtk] libsoup critical warning in media player http cookies injection code https://bugs.webkit.org/show_bug.cgi?id=34435 Fixed the critical warning and refactored the User-Agent/Referer/cookies injection code, in that order. Previous order (cookies first) was wrong because if cookies injection could not be done neither the User-Agent not Referer were injected. Also started a non-JSC-specific, gtk-specific GOwnPtr module. * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): * platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement): * platform/gtk/GOwnPtrGtk.h: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54261 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 02 Feb, 2010 20 commits
-
-
kov@webkit.org authored
Reviewed by Xan Lopez. Bump version, and adjust library versioning for 1.1.20. * configure.ac: WebKit/gtk 2010-02-02 Gustavo Noronha Silva <gns@gnome.org> Reviewed by Xan Lopez. Changes in 1.1.20, and documentation control files update. * NEWS: * docs/webkitgtk-docs.sgml: git-svn-id: svn://svn.chromium.org/blink/trunk@54260 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
Reviewed by Dimitri Glazkov. [V8] Use toV8() to wrap in the custom bindings, and remove the old wrapping code from V8DOMWrapper. https://bugs.webkit.org/show_bug.cgi?id=32563 * bindings/v8/ScriptController.cpp: * bindings/v8/ScriptObject.cpp: * bindings/v8/V8AbstractEventListener.cpp: * bindings/v8/V8Collection.h: * bindings/v8/V8DOMWindowShell.cpp: * bindings/v8/V8DOMWrapper.cpp: * bindings/v8/V8DOMWrapper.h: * bindings/v8/V8NodeFilterCondition.cpp: * bindings/v8/V8Proxy.cpp: * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: * bindings/v8/custom/V8CustomPositionCallback.cpp: * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * bindings/v8/custom/V8DataGridColumnListCustom.cpp: * bindings/v8/custom/V8DocumentCustom.cpp: * bindings/v8/custom/V8DocumentLocationCustom.cpp: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8EventCustom.cpp: * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: * bindings/v8/custom/V8HTMLCollectionCustom.cpp: * bindings/v8/custom/V8HTMLDocumentCustom.cpp: * bindings/v8/custom/V8HTMLFormElementCustom.cpp: * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: * bindings/v8/custom/V8MessageChannelConstructor.cpp: * bindings/v8/custom/V8MessageEventCustom.cpp: * bindings/v8/custom/V8NamedNodeMapCustom.cpp: * bindings/v8/custom/V8NodeIteratorCustom.cpp: * bindings/v8/custom/V8NodeListCustom.cpp: * bindings/v8/custom/V8NotificationCenterCustom.cpp: * bindings/v8/custom/V8SVGMatrixCustom.cpp: * bindings/v8/custom/V8StyleSheetListCustom.cpp: * bindings/v8/custom/V8TreeWalkerCustom.cpp: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: * bindings/v8/custom/V8XSLTProcessorCustom.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@54259 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
snej@chromium.org authored
Reviewed by David Levin. https://bugs.webkit.org/show_bug.cgi?id=32137 git-svn-id: svn://svn.chromium.org/blink/trunk@54258 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by David Levin. When using the Skia graphics context, the beginTransparencyLayer call currently creates a new layer, but does not keep the current compositing mode for use when merging the created layer back onto the rest of the context. This patch fixes that. https://bugs.webkit.org/show_bug.cgi?id=34491 fast/backgrounds/svg-as-mask.html is affected by this change in Chromium, but not fixed. This is the first of a series of patches to fix it. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54257 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Seidel. Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument https://bugs.webkit.org/show_bug.cgi?id=34409 Platform guards for localtime_r are not needed because we already have WTF::getLocalTime which does the same thing. * loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString): * loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt): git-svn-id: svn://svn.chromium.org/blink/trunk@54256 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Seidel. [BREWMP] Add dummy main thread functions https://bugs.webkit.org/show_bug.cgi?id=33569 Add dummy initializeMainThreadPlatform and scheduleDispatchFunctionsOnMainThread. * wtf/brew/MainThreadBrew.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread): git-svn-id: svn://svn.chromium.org/blink/trunk@54255 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Gustavo Noronha Silva. http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot https://bugs.webkit.org/show_bug.cgi?id=33445 * platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out. git-svn-id: svn://svn.chromium.org/blink/trunk@54254 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Move misplaced JS files to the proper location. https://bugs.webkit.org/show_bug.cgi?id=34256 * fast/events/script-tests/basic-touch-events.js: Removed. * fast/events/script-tests/create-touch-event.js: Removed. * fast/events/script-tests/send-oncancel-event.js: Removed. * fast/events/touch/basic-touch-events.html: * fast/events/touch/create-touch-event.html: * fast/events/touch/script-tests: Added. * fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html. * fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js. * fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js. * fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js. * fast/events/touch/send-oncancel-event.html: git-svn-id: svn://svn.chromium.org/blink/trunk@54253 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34502 Unused method pluginLayer in Netscape plug-in views * Plugins/Hosted/WebHostedNetscapePluginView.h: * Plugins/Hosted/WebHostedNetscapePluginView.mm: * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: Removed the method. git-svn-id: svn://svn.chromium.org/blink/trunk@54252 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
This will allow other projects to use these scripts. Fixes <http://webkit.org/b/34498>. Reviewed by Mark Rowe. * WebCore.xcodeproj/project.pbxproj: Added the bindings generation scripst to the Copy Headers phase, and marked them as Private. git-svn-id: svn://svn.chromium.org/blink/trunk@54250 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Part of Bug 34496: Clean up WebCore's IDL/script copying <https://bugs.webkit.org/show_bug.cgi?id=34496> Reviewed by Steve Falkenburg. * WebCore.vcproj/WebCore.make: * WebCore.vcproj/WebCoreGenerated.vcproj: Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts. git-svn-id: svn://svn.chromium.org/blink/trunk@54249 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Part of Bug 34496: Clean up WebCore's IDL/script copying <https://bugs.webkit.org/show_bug.cgi?id=34496> Reviewed by Steve Falkenburg. * WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts. * WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh. * WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames. git-svn-id: svn://svn.chromium.org/blink/trunk@54248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
No one uses these anymore (as of r52921). Part of Bug 34496: Clean up WebCore's IDL/script copying <https://bugs.webkit.org/show_bug.cgi?id=34496> Reviewed by Steve Falkenburg. * WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files anymore. Keep copying the scripts, though, since other projects (outside of the WebKit repository) do use those. git-svn-id: svn://svn.chromium.org/blink/trunk@54247 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
WebKit doesn't use these anymore (as of r52921). Part of Bug 34496: Clean up WebCore's IDL/script copying <https://bugs.webkit.org/show_bug.cgi?id=34496> Reviewed by Steve Falkenburg. * WebKit.vcproj/WebKit.make: git-svn-id: svn://svn.chromium.org/blink/trunk@54246 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Avoid using an invalidated KURL object in baseURI. https://bugs.webkit.org/show_bug.cgi?id=34492 This change fixes baseURI for Chromium (where the KURL implementation does not allow invalid KURLs to carry relative paths). This is regression tested by LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg * dom/Element.cpp: (WebCore::Element::baseURI): git-svn-id: svn://svn.chromium.org/blink/trunk@54245 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Add using WTF::getLocalTime to CurrentTime.h https://bugs.webkit.org/show_bug.cgi?id=34493 * wtf/CurrentTime.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54244 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chang.shu@nokia.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54243 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34076 <rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute Test: fast/forms/misplaced-img-form-registration.html * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away. git-svn-id: svn://svn.chromium.org/blink/trunk@54242 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kenneth@webkit.org authored
is not working properly and it is not needed at all, as the comboboxes comes up in their full width on the screen and do not depend on view. Reviewed by Ariya Hidayat. * WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): git-svn-id: svn://svn.chromium.org/blink/trunk@54241 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors Extract OS version into WebInspector.platformFlavor https://bugs.webkit.org/show_bug.cgi?id=34469 * inspector/front-end/InspectorBackendStub.js: * inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform): * inspector/front-end/inspector.css: * inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac): git-svn-id: svn://svn.chromium.org/blink/trunk@54240 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-