- 05 Feb, 2020 40 commits
-
-
Haiyang Pan authored
Bug: 1047762 Change-Id: I33e3ecc44228a50df727f57433e0138c5ad9d479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036547Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#738637}
-
Natalie Chouinard authored
Move Theme settings alongside other night_mode code. Bug: 1047357 Change-Id: I1e32fe0f49d002f6c29852d9cbe9180a44fbc7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036432 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#738636}
-
Jacques Newman authored
A call to DynamicTo<Text> where "from" is a HTMLBRElement will return null. We need to be able to handle this condition, so a null check was added before "text_node" is dereferenced. Bug: 928948 Change-Id: I5d27b63e905035c8d12d41bf3d2a86adc5a82bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031937Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738635}
-
Daniel Cheng authored
Split out webgl as an initial test module. Bug: 1048907 Change-Id: Iadad65e4a0480196670e697767850fdd99f4a35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038278Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738634}
-
Sorin Jianu authored
This implements the section related to 'manifest objects' in the Omaha protocol: https://cs.chromium.org/chromium/src/docs/updater/protocol_3_1.md ``` A manifest object contains details about how to fetch and apply an update. *`arguments`: A string, indicating command-line arguments that should be passed to the binary specified in `run`. Default: "". *`run`: A path within the CRX archive to an executable to run as part of the update. The executable is typically an application installer. If unsent or the empty string, no particular update-delivered installer needs to be run. Default: "" (empty string). ``` Such values are being parsed and passed over as an optional parameter to the CrxInstaller::Install call. An std::unique_ptr is used to avoid forcing all callers of CrxInstaller::Install to use the base::Optional type. The //chrome/updater code picks up this parameter and, on Windows, it runs the program specified by the update response. The other platforms don't implement this call yet but code will land soon for macOS. This change is transparent for the component and extensions updaters since their installers ignore these optional parameters. A compliant server would not respond with {run, arguments} for these update_client requests. Bug: 1042218 Change-Id: I00368182d0aa1189893808c1b6972284c5b3407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036287Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738633}
-
Yue Zhang authored
Bug: 983170, 1035995 Change-Id: Iecc3809a4578bee16f80f93f00fc68047db61422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976300 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738632}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/30fcb3eb..4dc7c627 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1b354018cddc6d772d057ec5f76c80d7a13e315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039092Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738631}
-
Brett Wilson authored
This information is supplied by a straightforward system call. Change-Id: Ic035732ecee94d1ca04d384dc223d6d3987bb91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037821 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738630}
-
Luis Sanchez Padilla authored
These tests might produce gestures due to the pointer moves that are being fired, but they are not trying to exercise such behavior. They currently assume a slop region of 15 pixels as a requirement for gestures to get fired, but if that region shrinks, these tests will fail. Adding touch-action:none in the target element's style ensures that no gesture gets produced. Bug: 1048893 Change-Id: Iabe6c1dbc9a710a5417aa38290ccf37fd958f198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037960Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Luis Sanchez Padilla <lusanpad@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738629}
-
Caleb Rouleau authored
This benchmark does not need to be run on other platforms. Also fix a minor bug in generate_perf_sharding that caused problems for shards that don't have any telemetry benchmarks on them. Bug: 1047129 Change-Id: I72f58194ef35a8482fe358dcd99b307c4cdf5c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039170 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738628}
-
Jan Wilken Dörrie authored
This change adds copy and move constructors from the underlying_storage to base::flat_tree, replacing the previous by value constructor. This results in a small win for perf and binary size, as the number of temporaries is reduced. Bug: 682254 Change-Id: I0c3c8fd6e785556ada363cf406d7f58f22a60284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037674Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#738627}
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Bug: 1038710 Change-Id: I9ab7345b24a24abfe1640712e9b57af0bbd4245e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037995Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738626}
-
Koji Ishii authored
This patch fixes computing scrollable overflow for a line box not to skip children of culled inline boxes. Bug: 982194 Change-Id: Ia4f2fbe1dbf008a56c3ff99cb1684483b3869943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038914Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738625}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/712ebbb5b73b..02b17a5507ae git log 712ebbb5b73b..02b17a5507ae --date=short --first-parent --format='%ad %ae %s' 2020-02-05 danilchap@webrtc.org Add helper to calculate frame dependencies based on encoder buffer usage Created with: gclient setdep -r src/third_party/webrtc@02b17a5507ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4d85f0f8d9735bf8c0e33204915fd9a955b55b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738624}
-
Natalie Chouinard authored
Move Android resources from: //chrome/android/java/res_download to: //chrome/browser/download/android/java/res. Clean up the new android_resource target's deps to remove dependence on all of chrome_app_java_resources. Bug: 1047896 Change-Id: I0b6377840b2716c05832842dd938e93c513a7fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033939Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738623}
-
Rohit Rao authored
Creates a PolicyConversionsClient abstract class with a concrete ChromePolicyConversionsClient subclass. The code remaining in PolicyConversions and PolicyConversionsClient does not have any dependencies on //content or //chrome and can be moved to //components/policy in a future CL. Does not yet create an iOS implementation of PolicyConversionsClient, but that will also come in a future CL. PolicyConversionsClient is an abstract class which contains methods that individual embedders need to implement. For example, //content-specific dependencies are hidden behind these methods. PolicyConversionsClient also contains some helper methods that need to be shared by all embedders. ChromePolicyConversionsClient is the //content-specific implementation of PolicyConversionsClient. Its code is largely moved from PolicyConversions, with some small refactorings to call methods on the superclass instead of directly accessing private ivars. BUG=1027249 Change-Id: I64e01ff487df9f96ebb657e4cde6651490833f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025927 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#738622}
-
Tommy Steimel authored
Bug: 1048902 Change-Id: I5c7d4d94fed28d7943fd7bdf96be31856580e44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038073Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738621}
-
Michael van Ouwerkerk authored
Bug: 1049127 Change-Id: I89324004b8e243870a443d842fba49f97b8519c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038704Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738620}
-
Chong Gu authored
These tests show some pixels difference on Fuchsia on ARM64. The differences are similar to those on Windows on ARM64. Bug: 1048249 Change-Id: I2a1742b0412ffe7d1f8613ba49604515d949dec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036284Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#738619}
-
Jan Wilken Dörrie authored
Similarly to r714618 this change renames PasswordLeakHistoryConsumer to CompromisedCredentialsConsumer to better reflect the actual usage of the class. Bug: 1047726 Change-Id: I7f2691e0eb2a4dc6dc5e16ca11cdc1e2baea6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039250 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738618}
-
Luca Hunkeler authored
Adds a new type of additional section which prompts a list of items for the user to chose from. If it's a required field and no item is selected an error message is displayed and the Continue button is disabled. We technically support multiple selection if specified (although not needed yet it was not much more complicated to support it rather than not). However at the moment we only display the first of the selected items in the ui when the section is collapsed. Moreover, the results of TextInputSection can also be sent to the backend now, if specified in the proto. Screenshots Collapsed: https://screenshot.googleplex.com/C9B0DLtT8nU.png Popup: https://screenshot.googleplex.com/3OzWxsbDrgY.png Bug: b/147653652 Change-Id: I6bad58d1a6b5b79b2c2ca0bab5a396dca7b8f313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014915 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#738617}
-
Ken Rockot authored
content_browser_client.h exposes a public dependency on generated outputs from the //media/mojo/mojom target. This CL properly expresses that dependency in GN. Fixed: 1049140 Change-Id: Icabe78cf9bc4e784444495d72da1bfbe9b90df01 Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039172 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#738616}
-
Tomasz Wiszkowski authored
This change adds metrics to measure: - Time spent creating individual suggestions - Time spent measuring and positioning suggestions - Efficiency of suggestions re-use mechanism. To enable the code to perform view re-use and create time the CL extracts two methods from the ModelListAdapter#getView(): - tryConvertView() - attempts to re-use supplied view for a new suggestion, and - createView() that constructs a new view of a specified type. We do not yet know what range of values to expect, so we assume 10ms to be the upper limit. This will be revisited. We do not yet know how well the Debug.threadCpuTimeNanos will work as it *might* return -1. this will also be a benchmark for us regarding reliability of this method. The alternative SystemClock.currentThreadTimeMillis() has much worse resolution. We hope to narrow this time down to - say - 5ms with 50us resolution if that proves to be reasonable. See https://crrev.com/c/2007943 for more context. Bug: 982818 Change-Id: I1cc83b8f5d45ae06e5ee6aa58d2cffa78d5b7ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023195Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#738615}
-
Sadrul Habib Chowdhury authored
Context: https://docs.google.com/document/d/1fQM5XxoPxGGQfjpQhKe6No9eVoQic2-1MGzgSgKhOOM/edit?hl=en# Summary of pinpoint runs: https://docs.google.com/spreadsheets/d/1DXm_xeZu8xEP5dZEszqAcIyjPJsd7p3crb-cS9Z7tYU/edit#gid=0 Interesting observation: the UMA metric for FirstContentfulPaint match very closely with the tracing-based metric for _cold loads. However, for _warm/_hot loads, the UMA metric is higher than the tracing-based metrics in a majority of the stories (although there are a couple of exceptions). Another observation: it looks like the LargestContentfulPaint UMA metric is not reported at all for _cold loads. It is unclear whether this is a bug in reporting, or whether the test ends too quickly for the _cold loads. BUG=1049117 Change-Id: Ic213eacc537a6430b8cbe3f6d6ef8491370c69d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037962 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738614}
-
Manas Verma authored
Adding metrics to log the duration of the perceived latency when the GetDetailsForGetRealPan response is received after a card is chosen by an opted-in user. Also adding metrics for when this latency times out and falls back to CVC. Bug: 949269 Change-Id: I95330aaa25f2da2f95284788c4ba5a267c9ab590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993871 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#738613}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c61d7e3d6e12..d2ccbb522eb0 git log c61d7e3d6e12..d2ccbb522eb0 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 egdaniel@google.com Have GrTextureEffect factories take a view as input. 2020-02-05 brianosman@google.com In GrSkSLFP, store inputs as SkData. Tighten size checks. 2020-02-05 kylixrd@chromium.org SkColorSetA now warns if the result is unused. 2020-02-05 egdaniel@google.com Rename view getters in various image subclasses. 2020-02-05 jlavrova@google.com RTL fixes + few small bugs Created with: gclient setdep -r src/third_party/skia@d2ccbb522eb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I02680a8f62e22abebc1fcf2b6d3e40741493daa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037982Reviewed-by:
-
Theresa Wellington authored
Remove FeatureHighlightProvider's dependency on AppHooks in preparation for moving to //components/browser_ui/widgets/. BUG=1010176 Change-Id: Idea815e073fd757140b9ed2b60434dc561b60ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016325 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738611}
-
Liquan (Max) Gu authored
Before change: 1. In Android PaymentHandlers, Payment App could circumvent the security check by delaying onload. 2. toolbar url get updated on navigation end. After change: 1. Payment Apps are no longer able to circumvent the check this way. 2. toolbar url get updated on navigation start. Change: 1. * Add ssl check on security state changed * Move ssl check from page load end to navigation end 2. Move updating url from navigation end to navigation start. 3. Prevent PaymentHandlerCoordinator from calling hider in hider. 4. Prevent WebContents from being used in PaymentHandlerView after WebContents is destroyed. Bug: 1035903 Change-Id: I57821d7e6fbbdc10da2387aff7f8962ae4338716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037017 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738610}
-
Wez authored
Rather than prefixing the name with Fuchsia, prefix with Frame, to reflect the scope to which it applies. Change-Id: I8d946ea9076f3fc04193cfc3ea8a44d830109ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038775 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738609}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9c62f66c7235..a44d96dcd676 git log 9c62f66c7235..a44d96dcd676 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 lexa.knyazev@gmail.com Apply compressed format workarounds to texStorage entrypoints 2020-02-05 jmadill@chromium.org Add environment overrides for ANGLE features. Created with: gclient setdep -r src/third_party/angle@a44d96dcd676 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I64507f29a506a9cb947a147b89a80d72b90239c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039034Reviewed-by:
-
Adrienne Walker authored
This test has been disabled due to 747589, and so it was using deprecated RunLoop constructs that DCHECK when running. For now, this test is still deprecated because it might be flaky. I will followup and turn it back on separately in case it gets reverted again. I am trying to get this test running again to test changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2020533 Most of the changes are fairly straightforward to use RunLoop Quit() as callbacks to quit running instead of RunUntilIdle. The tricky part here is that this test now crashes because QuotaManager kicks off a task in NotifyStorageModified that runs after the test has been torn down: [204729:204736:0204/170817.027368:1900997872433:ERROR:database.cc(1584)] Quota sqlite error 1032, errno 0: attempt to write a readonly database, sql: INSERT INTO OriginInfoTable (used_count, last_access_time, origin, type, last_modified_time) VALUES (?, ?, ?, ?, ?) [204729:204736:0204/170817.027526:1900997872589:FATAL:database.cc(1597)] attempt to write a readonly database To avoid this, a new function to turn off the QuotaManager database is added for testing. Bug: 747589, 1015214 Change-Id: I98d07ffc62e0ff8047da3e994fbf40728f0972bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038133Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738607}
-
Alex Khouderchah authored
This CL clarifies that {Included,Excluded}Routes can be used for any network Type and describes the default routing behavior for each Type. Bug: 1038601 Change-Id: Ibb1cf5fba164f416b31f3b22d81c4105639839da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037318 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738606}
-
Wenyu Fu authored
Update the HomepageSettings UI to the radio group style when homepage conversion flag is enabled. Change-Id: Ic5d707de0a32bb0715518953bbc6286c0ec0a2da Bug: 1036470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015552Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738605}
-
Alfonso Garza authored
params. crbug/1046559 Submitting without tests as emergency fix and bc the bridge does not have existing tests will take a little longer to get together. Bug: 1046559 Change-Id: I3a71ce1c772102940596643d657e9532a62423d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038170Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ib43108417a9889af53b0550bc6c8d0dd5648dba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039091Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738603}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51b5640863e8..a0eb8359beb5 Created with: gclient setdep -r src-internal@a0eb8359beb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049070 Tbr: jbudorick@google.com Change-Id: I217d90ed748acdea9279cd4f38809ddbd1fc13e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039002Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738602}
-
Mitsuru Oshima authored
* Fix EventGenerator so that GestureTapDownAndUp and Scroll methods works on external display. * Changed the test harness to use the EventGenerator which is much closer to how home button works. * Updated AppListTest to use MoveMouseTo and the global event generator. Bug: 1042754 Change-Id: I33e9696960cd990512847a54a7e487098d73d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008130Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738601}
-
Adam Langley authored
M81 has now branched off, so this change is targeted for M82. There are known incompatibilities (see bug) and several sites have been contacted. Having the breakage be clearly obvious on dev and beta will help to demonstrate the issue. This change also adds a control in about:flags to make testing easier. Bug: 1028602 Change-Id: I306e28350e9dfaa0235c8f10e9b06e0cd9db93d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035861 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#738600}
-
Annie Sullivan authored
Change-Id: Ieb31ef6a9a4409f51547ba635244b4f8e2ecc787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036554Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738599}
-
Lei Zhang authored
Filter out potentially more potentially problematic characters and replace them with underscores. Bug: 1041897 Change-Id: Ib3286474f41212c9a4cf7607ca9485324fff3742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038254Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738598}
-
