- 03 Dec, 2018 40 commits
-
-
Katie D authored
This fixes a regression where the platform impl was created even when it wasn't yet needed. Bug: 911184 Change-Id: I6555a81ff86327fd12994bf4de5e44074dfeee15 Reviewed-on: https://chromium-review.googlesource.com/c/1358919Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#613207}
-
Henrique Santos authored
This reverts commit 71f820a1 ("Disable assistant for child account"). Bug: b:120075638 Test: built and tested locally Change-Id: I59d3d4869ba596fa462a904b8a64a88230c28325 Reviewed-on: https://chromium-review.googlesource.com/c/1351155 Commit-Queue: Henrique Nazaré Santos <nazare@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613206}
-
Mike Klein authored
Change-Id: Id5440ef6f3cd24040a57bd7e74873df899b59266 Reviewed-on: https://chromium-review.googlesource.com/c/1346729 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613205}
-
Harley Li authored
With this patch users are able to search for cache entries which contain a given URL path in Application panel's cache storage table. Only entries that have the matching URL paths will be displayed in the table, which supports pagination if there are too many entries returned. Bug: 884194 Change-Id: If285cc43859e82f5e59b80b1b761e9836aa5f510 Reviewed-on: https://chromium-review.googlesource.com/c/1345421Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#613204}
-
Tommy C. Li authored
Whenever the user unelides the URL, the omnibox also enters user_input_in_progress_ mode. This is was harmless before, but since then we have started displaying suggestion favicons in the omnibox, the current page's security indicator is being clobbered by the page's favicon during unelision. This is not correct, since unelision is supposed to be as unobtrusive as possible. This is going to become more noticable now that Ctrl+L triggers unelision, as well as our future planned work for One-Click-Unelide. This CL replaces the old logic, and keeps showing the current page's security indicator until the user actually modifies the user text. Bug: 874592, 906223, 910145 Change-Id: I8a5619d4408b09d2e9f98fd5ce011ecbd2cab085 Reviewed-on: https://chromium-review.googlesource.com/c/1351564 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#613203}
-
Sean Gilhuly authored
FrameSinkElement creation is moved into a function that creates the unique_ptr and adds it to the map of elements. Removing elements from this map now deletes them. The FrameSinkElements need to be owned by DOMAgentViz because it receives all of the FrameSinkObserver events. Whereas for Views, each ViewElement, WidgetElement, and WindowElement is its own Observer, so centralized ownership in DOMAgentAura doesn't make as much sense. Elements are no longer inserted into |frame_sink_elements_| by BuildTreeForFrameSink(), so we don't need to static_cast pointers any more. Also make variable names in BuildTreeForFrameSink() clearer. Bug: 816802 Change-Id: Ieec4db482ffb3ff8a740eb559c1c3d9ee9a80705 Reviewed-on: https://chromium-review.googlesource.com/c/1346910 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#613202}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/58dc4bf4fc2b..f1684ef61ea6 git log 58dc4bf4fc2b..f1684ef61ea6 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 stevenjb@chromium.org cros_chrome_sdk: Elim _StripGnArgs Created with: gclient setdep -r src/third_party/chromite@f1684ef61ea6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie0821ee52d1b39b60a83b4f4261b897def21b39f Reviewed-on: https://chromium-review.googlesource.com/c/1358802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613201}
-
Nico Weber authored
There's no downside of doing this on Windows and it makes the build deterministic, so always enable it. Bug: 330260 Change-Id: I0e86a2ae5864af2fb4e1716cff1718c9606ab42f Reviewed-on: https://chromium-review.googlesource.com/c/1358700Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613200}
-
Peter Boström authored
Makes the loading-progress animation smoother for pages that have not finished loading pretty-much instantly. A follow-up might consider removing actual loading progress completely and just animate to 70% slowly until loading finishes. Bug: chromium:908920 Change-Id: I207d602c1552591396840c346e88b0962af07be2 Reviewed-on: https://chromium-review.googlesource.com/c/1358923Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613199}
-
George Burgess IV authored
This CL turns on ThinLTO optimizations for Android by default for all official builds. This CL is expected to increase link times of official builds by something around 2.5x CPU/2x wall time. More build capacity was requested in http://crbug.com/883563. This is also a pretty wide-reaching CL. A size decrease of a hundred KB is expected, and we expect that the CPU-bound parts of Chrome will generally be faster. If there are slowdowns, they should be very few in number, and very small. ThinLTO is a type of link-time optimization, which defers actual code-generation and some optimization until link-time. This is very beneficial to the optimizer, since it now has visibility into functions/constants that, at a per-TU level, would be opaque. ThinLTO is already deployed on Linux and Android, but our default Linux configuration does *not* use optimizations. This CL specifically enables these optimizations for Android. size/build time measurements. Bug: 807147 Test: Perf testing on nexus-5 (crbug.com/836550); manual binary Change-Id: I7e07d9d9cb1dadd077adf44ca6217c40e13b00a8 Reviewed-on: https://chromium-review.googlesource.com/c/1149061Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#613198}
-
Bailey Berro authored
This change adds an InSettings attribute that is used to determine whether the File Manager should be automatically opened on a successful mount call. When mounting from the free-form dialog, the File Manager will not be automatically opened. Bug: chromium:887135 Test: browser_tests --gtest_filter=CrSettingsSmb* Change-Id: I4e681c1ffe104f234784c2f958d24b2d257bc33c Reviewed-on: https://chromium-review.googlesource.com/c/1336911Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#613197}
-
Jered Gray authored
Previously, the HintCache's initialization, which involved adding all hints contained within a hint vector to the cache, was being handled on the UI thread. This initialization could take a significant amount of time and triggered the creation of a jank startup performance bug. The logic has been modified so that the HintCache is no longer initialized on the UI thread. It is instead initialized within its constructor during PreviewsHints::CreateFromHintsComponent() on a background thread. This is accomplished via a HintCache::Data object. Once the hints are fully added to Data, it is moved into the HintCache's constructor. The HintCache is immutable after construction. Not only does this remove all of the costly UI thread processing, but it also eliminates the expensive intermediate hint vector. Bug: 910251 Change-Id: I04a28248ad1ce790f999da06f48e3c5aabfcb812 Reviewed-on: https://chromium-review.googlesource.com/c/1356226 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#613196}
-
Jonathan Backer authored
Change-Id: I06a35cb28512af457eb7e77fe44eedfef7fab9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1359055Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#613195}
-
Kristi Park authored
Place the colored monogram inside a gray circle. This matches the fallback style on mobile. Screenshots: https://screenshot.googleplex.com/SjGT71VeutN.png https://screenshot.googleplex.com/6eXirCU0knX.png https://screenshot.googleplex.com/8xcd9KZvvgp.png Bug: 905437 Change-Id: Ib26c04fc22e4eb50685c5de04300dd543a625cee Reviewed-on: https://chromium-review.googlesource.com/c/1354318 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#613194}
-
Chase Phillips authored
Bug: 717812 Change-Id: I6d53865348171ba2fe777a8730b08248d05e7f26 Reviewed-on: https://chromium-review.googlesource.com/c/1344222 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#613193}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4fbd264904eb..a44efb76a8a4 git log 4fbd264904eb..a44efb76a8a4 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tsepez@chromium.org Add ability to append narrow strings to CFX_WideTextBuf. Created with: gclient setdep -r src/third_party/pdfium@a44efb76a8a4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b730f25264f5f5ffe3ad56db523e2c79d8d8907 Reviewed-on: https://chromium-review.googlesource.com/c/1358803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613192}
-
Kevin Ellis authored
The decomposition of a transformation matrix into translations, rotation, scale and skew transforms is not unique. In some cases, the generalized 3-D decomposition does not align with the working draft for CSS transforms (https://drafts.csswg.org/css-transforms/). In the special case where the transforms being interpolated are both 2-D, a simplified model provides more restricted set of decomposition transforms with less computational overhead. Bug: 797472 Change-Id: I2b8ba99fe02c2eef878d94f5dfaea55c39652759 Reviewed-on: https://chromium-review.googlesource.com/c/1332253 Commit-Queue: Kevin Ellis <kevers@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#613191}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b13658891bbd..45723ac93149 git log b13658891bbd..45723ac93149 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 egdaniel@google.com Take into accout the GrBackendFormat when deciding if we can chain textures together. 2018-12-03 reed@google.com update docs for MakeFromString and SkTextEncoding 2018-12-03 brianosman@google.com Fix two GPU image filters handling of subset inputs 2018-12-03 egdaniel@google.com Reland "Add support for Ycbcr Conversion Samplers in vulkan." 2018-12-03 reed@google.com flag to convert to SkTextEncoding Created with: gclient setdep -r src/third_party/skia@45723ac93149 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905548 TBR=jcgregorio@chromium.org Change-Id: Ib31eec67290dbff8f2a826b06a7d825bf21a68d0 Reviewed-on: https://chromium-review.googlesource.com/c/1358757Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613190}
-
Peter Boström authored
Prevents showing cached favicons for the previous page during a timing bug while it's connecting to the new page. Bug: chromium:907642 Change-Id: Ifb1cfa75ed8fbc6842ec9811b2b92bd10d2442b5 Reviewed-on: https://chromium-review.googlesource.com/c/1358921Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613189}
-
Hiroshige Hayashizaki authored
Source: go/fieldtrial-testing-config#introduction (Google internal) Bug: 910586 Change-Id: I9bdd750a5712437b952a1220ce5b175dfe4bb21c Reviewed-on: https://chromium-review.googlesource.com/c/1357541Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#613188}
-
James Hawkins authored
This change also factors out TestTimerFactory to reuse code. R=khorimoto@chromium.org Bug: none Test: DisconnectTetheringOperationTest.* Change-Id: I5988d6bfdbf145511d9ea5c7451c31b9d929b753 Reviewed-on: https://chromium-review.googlesource.com/c/1357614 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613187}
-
Regan Hsu authored
Remove unhelpful UI modal that is displayed that just says "Configure phone" which offers to connect to the phone again. It doesn't seem to be helpful. Bug: 862794 Change-Id: I6637d9b9931f0ca1b38b6d57b9326a806dee923e Reviewed-on: https://chromium-review.googlesource.com/c/1357529 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613186}
-
John Chen authored
Add Release Actions endpoint as required by W3C spec, and connects the endpoint to a partial implementation, which doesn't yet include the processing of input cancel list. Bug: chromedriver:1897 Change-Id: I8c00c6b76233ef325d562c3a5c123f5e94276064 Reviewed-on: https://chromium-review.googlesource.com/c/1357840Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#613185}
-
Nate Chapin authored
This removes the need for dumpFrameLoadCallbacks(), which is difficult to make consistent with and without site isolation Bug: 619662 Change-Id: I94a553707c306eae4a755a2b2d3ddf45fa145bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1354574Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#613184}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=cmumford@chromium.org Bug: 903957 Change-Id: I0e677a2f89f333b999d71fa83f15646a97c53fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1338415 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#613183}
-
Stephen Barber authored
BUG=chromium:910802 TEST=none Change-Id: I489c8a24e30aece1706af1b2e4e858187d8992fa Reviewed-on: https://chromium-review.googlesource.com/c/1356965Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> Cr-Commit-Position: refs/heads/master@{#613182}
-
Theresa authored
Remove unused ChromeMemex flag and associated code in preparation for more Toolbar* refactoring. BUG= Change-Id: I3f4d2aaf0fba3ecea7806d3d36670cd815a94b21 Reviewed-on: https://chromium-review.googlesource.com/c/1358908Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#613181}
-
Becky Zhou authored
Bug: 899318 Change-Id: Idffc1e1577058fcf273dcf4ad082a05814833d0c Reviewed-on: https://chromium-review.googlesource.com/c/1351540 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#613180}
-
Peter K. Lee authored
mailto: URL scheme handling using Google UI launched in M67. Now is the time to remove the legacy implementation. Bug: 909726 Change-Id: I0ee2fa6ab0f34e51554898be8441d46b913c67a6 Reviewed-on: https://chromium-review.googlesource.com/c/1353895 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613179}
-
Etienne Pierre-Doray authored
Instantiate TracingSamplerProfiler in RendererMain. Change-Id: I527be13dcff3a58a4e60c8fe8ca21474515b91b0 Reviewed-on: https://chromium-review.googlesource.com/c/1336075Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#613178}
-
Ben Pastene authored
R=jbudorick, martiniss Bug: 790372 Change-Id: I56f5374182eaa3779459c05203ebb5cb1d94802f Reviewed-on: https://chromium-review.googlesource.com/c/1359030Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#613177}
-
Eugene But authored
NavigationItemCommitted is deprecated in favour of DidFinishNavigation. This change will simplify transition from NavigationItemCommitted to DidFinishNavigation, because DidFinishNavigation does not pass NavigationItem as argument. Bug: 720786 Change-Id: Ic71f49c687aa73957afc0033910dd028a2f942e9 Reviewed-on: https://chromium-review.googlesource.com/c/1356772 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#613176}
-
Tony de Luna authored
Only do periodic WiFi scanning when WiFi is enabled. Hide scanning progress bar as soon as user disables WiFi, even if a scan is still in progress. BUG=891947 Change-Id: Ica6cc4116f88743b24fb081b89886501ecd1d2d3 Reviewed-on: https://chromium-review.googlesource.com/c/1356027Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#613175}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aa3d8ad71b9d..056f9738bf7a git log aa3d8ad71b9d..056f9738bf7a --date=short --no-merges --format='%ad %ae %s' 2018-12-03 solenberg@webrtc.org Remove CodecInst pt.1 2018-12-03 orphis@webrtc.org Encode frames at the largest layer resolution instead of last layer 2018-12-03 eladalon@webrtc.org RtcEventLogImpl nits Created with: gclient setdep -r src/third_party/webrtc@056f9738bf7a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I09b50b7a8c0b254791d5b97067a84505c4bae463 Reviewed-on: https://chromium-review.googlesource.com/c/1358755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613174}
-
Jonathan Backer authored
This CL is kept minimal to facilitate merge to M72 (and potentially M71). Details on comments 14 and 15 on https://crbug.com/910274 A more complete solution addressing SkiaRenderer,SkDDL will come when issue 902904 is resolved. Bug: 910274 Change-Id: Ie0f44443fa30a5ec87045bd138a3a8a08e17e35c Reviewed-on: https://chromium-review.googlesource.com/c/1358799Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#613173}
-
Wenzhao Zang authored
In addition to fixing the DCHECK, this CL contains a speculative fix for flaky test (crbug.com/907379). The guess for the flakiness is (not able to repro the failure locally though): |RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock| when recording the CAI event, because the lock is being taken by |UpdateExistingAccessPointRlz|. In tests, the delay for |ScheduleDelayedInit| is set to zero, so it's possible for this race condition to happen. But in production, the delay is non-zero. I don't think we're losing test coverage by disabling |UpdateExistingAccessPointRlz| here because the call is a no-op in tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is testing its implementation. Bug: 906293, 907379 Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730 Reviewed-on: https://chromium-review.googlesource.com/c/1353990Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613172}
-
Eugene But authored
Tests that new page load calls NavigationItemsPruned callback if there were forward navigation items. Bug: 910894 Change-Id: I98bfd1a9960b99d0d7d8511b2b4068f56344b8d1 Reviewed-on: https://chromium-review.googlesource.com/c/1357841Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#613171}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/317a9ebdb019..c10a023a66f2 git log 317a9ebdb019..c10a023a66f2 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 jmadill@chromium.org Fix fuchsia build of libfeature_support. 2018-12-03 thakis@chromium.org List vulkan_core.h as input of generate_vulkan_layers_json.py. 2018-12-03 Tom.Tan@microsoft.com Don't copy d3dcompiler_47.dll when build target is Windows ARM64 2018-12-03 jmadill@chromium.org Refactor test shader style. 2018-11-30 syoussefi@chromium.org Vulkan: Add dynamic index buffers to graph 2018-11-30 ianelliott@google.com Version-2 API of the A4A opt-in/out (a.k.a. feature-support utilities) Created with: gclient setdep -r src/third_party/angle@c10a023a66f2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:910699,chromium:869348,chromium:893460,chromium:b/113346561 TBR=ynovikov@chromium.org Change-Id: I29ee936a536269990c413cdd50ad7d46601914a6 Reviewed-on: https://chromium-review.googlesource.com/c/1358758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613170}
-
Javier Ernesto Flores Robles authored
Similar to pull to refresh, pulling the suggestions to the right will reset the keyboard and the manual fallback view. Video: https://drive.google.com/file/d/1QpoiU3YPXdFhLQ_ubzZcyJ7VxVo86Zpv/view?usp=sharing Bug: 845472, 911142 Change-Id: Ie13322d168dac81288d95a8e10a0bcb5bab59339 Reviewed-on: https://chromium-review.googlesource.com/c/1355188 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#613169}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a21a7c53d9b2..7808a519be73 git log a21a7c53d9b2..7808a519be73 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 clemensh@chromium.org Fix typo in man page for git new-branch Created with: gclient setdep -r src/third_party/depot_tools@7808a519be73 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie82b94a503eda12fc79c6fc1d5d16e5d7c0cbf8b Reviewed-on: https://chromium-review.googlesource.com/c/1358756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613168}
-