- 27 Jul, 2018 40 commits
-
-
Rohit Rao authored
BUG=835860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide83ee27d1a888a08787b8726c0e5cc80fe80f03 Reviewed-on: https://chromium-review.googlesource.com/1148018Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578614}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8d361113. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 408f60ca "Remove Shared Worker WPT for WebUSB" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21781 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=robertma No-Export: true Change-Id: I52462748674d7db6eefa708e280ccf67bc5d99eb Reviewed-on: https://chromium-review.googlesource.com/1152706 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578613}
-
Lutz Justen authored
Adds channel information ("stable", "beta", "dev", 'cannary") next to the browser version. BUG=chromium:849803 TEST=browser_tests --gtest_filter=*DeviceStatusCollector* Change-Id: I30c4b78950ad1540169835bc4e295bc9ba0ea483 Reviewed-on: https://chromium-review.googlesource.com/1124162Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#578612}
-
Philipp Hancke authored
BUG=836871 Change-Id: I278b34cb305a13a029e84eaaeec57144e2858678 Reviewed-on: https://chromium-review.googlesource.com/1149364Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#578611}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aa418e541589..b3bab6ce43ca git log aa418e541589..b3bab6ce43ca --date=short --no-merges --format='%ad %ae %s' 2018-07-27 art-snake@yandex-team.ru Parse obj nums range within Hint tables for shared groups. Created with: gclient setdep -r src/third_party/pdfium@b3bab6ce43ca The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7ceedf4be65097d8869c4dac59137cbffb9fccf8 Reviewed-on: https://chromium-review.googlesource.com/1152615Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578610}
-
Oscar Johansson authored
Building //media takes around 23 CPU minutes. A experimental branch showed that this could be reduced, by using jumbo, to around 9 CPU minutes. media/cast is the fourth largest part of media and takes around 2 CPU minutes to compile without jumbo. This commit enables jumbo for media/cast. Bug: 867350 Change-Id: Iaefb6e7ac95c1c7fab78478f879a8ba542f329d9 Reviewed-on: https://chromium-review.googlesource.com/1152807Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#578609}
-
Oscar Johansson authored
Building //media takes around 23 CPU minutes. A experimental branch showed that this could be reduced, by using jumbo, to around 9 CPU minutes. media/filters is the third largest part of media and takes around 2 CPU minutes to compile without jumbo. This commit enables jumbo for media/filters. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I01fe34fb39b35bf1a95e893916c2fc49e59a6d9e Reviewed-on: https://chromium-review.googlesource.com/1152808Reviewed-by:
-
Maksim Ivanov authored
Make sure that GetPacMandatoryFromExtensionPref() sets |*out| whenever it returns true. Without this fix, ProxyPrefTransformer::ExtensionToBrowserPref() would proceed with reading an uninitialized variable. Change-Id: I62bd8dcf7e173171dadd824787ea725c93a73eb1 Reviewed-on: https://chromium-review.googlesource.com/1151668 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#578607}
-
jonross authored
While work on Android is on going, the remaining Viz failures on other platforms have been resolved. The filter file is no longer needed. This change removes it. TEST=viz_content_browsertests Bug: 794961 Change-Id: I46f8a7094aa10f72cf383607a8b7a68a19141fc8 Reviewed-on: https://chromium-review.googlesource.com/1150684Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#578606}
-
Colin Blundell authored
When clearing the primary account, three behaviors are possible: 1. Explicitly remove all accounts. 2. Explicitly keep all accounts. 3. Let the signin code internally decide between 1 and 2 based on its own default policy. The IdentityManager test APIS (IdentityTestEnvironment and identity_test_utils.h) currently support only 3. However, an upcoming conversion will require 1 and 2. This CL adds that support in to the APIS for clearing the primary account. Bug: 798699, 809923 Change-Id: Idb717836c843a14a5f6d33aab5d60d7e14ff4d1c Reviewed-on: https://chromium-review.googlesource.com/1149861 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578605}
-
Keishi Hattori authored
Change-Id: I63eae05326391dcb2c62f571ac13650a6e2967b0 Reviewed-on: https://chromium-review.googlesource.com/1148210Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578604}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If9283073cb46cbdb2b123b13695c1b7dc5b2c4a0 Reviewed-on: https://chromium-review.googlesource.com/1152887Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578603}
-
Denis Kuznetsov authored
Bug: 864455 Change-Id: Ia71d2bc2360b3db4100643e62210401c9b6c7a2b Reviewed-on: https://chromium-review.googlesource.com/1148451 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Mythri Alle authored
We want to decouple the code cache from the HttpCache and recently added a separate code cache [1]. This cl adds required support to fetch the generated code from the code cache. There will be a followup cl that uses this API and fetches from the code cache. [1] chromium-review.googlesource.com/c/chromium/src/+/1120179 Bug: chromium:812168 Change-Id: I4972def83f05d2c6d5810f489704ffd9f1d1d536 Reviewed-on: https://chromium-review.googlesource.com/1150239 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#578601}
-
Tim Volodine authored
Rebaseline some interfaces/properties that have been exposed in Chrome and should also be exposed in Android WebView. In particular: - attribute @@toStringTag - method @@iterator - attribute @@unscopables - CSS* related interfaces/attributes BUG=867450 Change-Id: Iee23c9f75fb3031826dfe388920a1ae6b3a9722e Reviewed-on: https://chromium-review.googlesource.com/1150177Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#578600}
-
Tatsuhisa Yamaguchi authored
Resolve errors on Chrome OS with opening Drive files whose file name contains a valid URL-encoding like "%41.pdf". Test: unit_tests --gtest_filter=ExternalFileURLUtilTest.*:FileManagerPathUtilConvertUrlTest.* Bug: 850035 Change-Id: If4768ae07f82d722065601192d557eaea53b3f12 Reviewed-on: https://chromium-review.googlesource.com/1151172 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#578599}
-
Mihai Sardarescu authored
This reverts commit bfc33b7c. Reason for revert: The work for UKM is done in a separate CL, so this is no longer needed. Original change's description: > [unified-consent] Add shutdown information for the UrlKeyedDataCollectionConsentHelper. > > This CL adds methods that handle the shutdown state for the > UrlKeyedDataCollectionConsentHelper. This is set when the dependent sync > service is shut down. > > Bug: 867388 > > Change-Id: Id6f948bc0aa1a55ec2943590a5f77cd179b65e3f > Reviewed-on: https://chromium-review.googlesource.com/1148564 > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578242} TBR=msarda@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867388 Change-Id: If3978f977afcb9ea1997bdde1b7220f56a271bbb Reviewed-on: https://chromium-review.googlesource.com/1152847Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#578598}
-
Helen Li authored
Rearrange ReceiveMore and SendMore, so that we check MOJO_RESULT_SHOULD_WAIT before !MOJO_RESULT_OK. This CL adds three unit tests that pass with or without the change. Bug: 721401 Change-Id: I6b132b2399f9091374d037d890d7ca98ba358445 Reviewed-on: https://chromium-review.googlesource.com/1150428Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#578597}
-
Oscar Johansson authored
When building using jumbo, files get merged and functions and variables with the same name may end up in the same namespace and conflict. This happens in: media/cast/net/cast_transport_impl.cc media/cast/net/udp_transport_impl.cc Since the functions and variables are identical they are moved to a common util file. Bug: 867350 Change-Id: I08747781d56b78e9a8783bfec870c7084183062a Reviewed-on: https://chromium-review.googlesource.com/1152738 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Pin-chih Lin authored
Currently VideoEncodeAccelerator::Initialize() does not take level into account which is a factor of AVC encoding. Instead, it always set the fixed level in VEA implementation. For upstream Android CTS, it requires AVC level setting and checks the level of output encoded stream is within configured one. To satisfy this we need to pass level on initialization. Since there is a bunch of parameters we decide to refactor VEA::Initialize() to use Config struct bundling all parameters as VideoDecodeAccelerator did. This CL only modifies VEA::Initialize() API to use Config struct as input to cover original parameters and output_level. Once this is approved to change, we will implement the utilization of output_level inside VEA. BUG=b:110811755 BUG=863321 TEST=build and deplot chrome on eve TEST=build and run video_encoder_accelerator_unittest on eve TEST=build media_unittests TEST=build content_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I002169634a2b2d23a00178eb5015a14f4ddcf5dc Reviewed-on: https://chromium-review.googlesource.com/1130570 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#578595}
-
Oscar Johansson authored
When building using jumbo, files get merged and functions with the same name may end up in the same namespace. This happens with the functions InProgressFrameEncode defined in: media/cast/sender/external_video_encoder.cc media/cast/sender/h264_vt_encoder.cc This commit solves the issue by renaming the functions to something more file specific. Bug: 86750 Change-Id: I8f6fb84783539dcec4aae824bb971e982b4db5c2 Reviewed-on: https://chromium-review.googlesource.com/1152745 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files gets merged. Files and variables with the same name may merge into the same namespace or scope and conflict. This happens in the files: media/filters/aom_video_decoder.cc media/filters/ffmpeg_video_decoder.cc media/filters/vpx_video_decoder.cc This commit solves the issue by renaming the function GetThreadCount to something more file specific. It also moves some constants to that function. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id57aa6cc6ac10acd0073eee032d0d04592ba87e4 Reviewed-on: https://chromium-review.googlesource.com/1151311 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files merged and functions with the same name may end up in the same namespace/scope. This happens for the function OnError() that gets called by Bind(). OnError() is defined in: media/filters/audio_video_metadata_extractor.cc media/filters/media_file_checker.cc This commit solves the issue by renaming one of the functions to something more file specific. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b762e4f1c4b11751df2302874af53106889d085 Reviewed-on: https://chromium-review.googlesource.com/1151316 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
In jumbo builds the compiler complain about not knowing about the template specialization of the function OnStartOfCodedFrameGroup, that is defined in source_buffer_stream.cc. To solve this issue a fordward declaration is done before usage. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If090b848bc2ae78121620aba2349eac4c63d8a65 Reviewed-on: https://chromium-review.googlesource.com/1151313 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4db8708c903..55b1e6168454 git log c4db8708c903..55b1e6168454 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 dbd1612782f5..18f7e5033040 (1 commits) 2018-07-27 herb@google.com const all the things 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-26 ziadb@google.com SkAR Java: refactored project structure 2018-07-26 ziadb@google.com SkAR Java: changes to DrawManager/FingerPainting 2018-07-26 halcanary@google.com site: Documentation & Fiddle links on front page Created with: gclient setdep -r src/third_party/skia@55b1e6168454 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ib2b45c09f9e0f4cdfa425c6591808cbcea5f1115 Reviewed-on: https://chromium-review.googlesource.com/1152613Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578590}
-
Anita Woodruff authored
This prevents developers updating the channel id of a notification and forgetting to update the channel id that is logged. Bug: 772027 Change-Id: Ic32cead46f91a24d3164592c196b527fc21edcdd Reviewed-on: https://chromium-review.googlesource.com/1148321 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578589}
-
Daniel Bratell authored
Some osmesa code uses the "real" OSMesa API headers and those are not 100% compatible with the wrapper API headers normally used. That incompatibility means that they cannot compile in the same translation unit (jumbo builds). This splits the osmesa files into their own build target to avoid potential conflicts. Also changes the code to be consistent with how osmesa.h is included. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifc96cf25f7b69f23f293e297ab59ce5192f1cd20 Reviewed-on: https://chromium-review.googlesource.com/1149874Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#578588}
-
Daniel Bratell authored
In jumbo compilation many cc files compile in the same translation unit and if they use the same local variable names, there will be compilation clashes. That happened in the automatically generated code with info about various problems in gpu drivers or the like. This patch makes sure necessary variables have unique names by adding a unique keyword for each set of data. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ief86248f2d17f123602c7e641c286d0550a85d89 Reviewed-on: https://chromium-review.googlesource.com/1151314 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578587}
-
Jose Dapena Paz authored
IWYU: it fixes the build with libstdc++ after dc24395b "Retry initializing download db on failure" Bug: 819294 Change-Id: Id8a9bdf56f74d979d4e48747a3a6fbd9c51f59c6 Reviewed-on: https://chromium-review.googlesource.com/1150530 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578586}
-
Colin Blundell authored
Currently, AccountTracker::GoogleSigninSucceeded() calls AccountTracker::OnRefreshTokenAvailable() for each account that the token service knows about. However, this is conceptually somewhat confusing, as it's not the case that the refresh tokens for those accounts have suddenly become available. Moreover, an upcoming conversion of this class to use IdentityManager will make it even less suitable, as the corresponding observer callback passes information that AccountTracker won't have (and doesn't need) when invoking it manually. This CL changes AccountTracker::GoogleSigninSucceeded() to directly call through to AccountTracker::UpdateSigninState(), better reflecting the actual flow. Bug: 809923 Change-Id: Ic7673659cb9383d55eb8eda5cfb84a22f3a72214 Reviewed-on: https://chromium-review.googlesource.com/1150223 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578585}
-
Takuto Ikuta authored
Currently MSVC builder cannot build v8 and pdfium with cl.exe. TBR=dpranke@chromium.org, thakis@chromium.org Change-Id: Ic7fc3bd57583f33f56a795e1534e5c04774c6612 Reviewed-on: https://chromium-review.googlesource.com/1152645Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578584}
-
Vasilii Sukhanov authored
The spec specifies max width for labels in the password dropdown. Bug: 868020 Change-Id: I112c0866e7f0f0165b82f72bdc55c21a25c6c09f Reviewed-on: https://chromium-review.googlesource.com/1151637 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#578583}
-
Vadym Doroshenko authored
This Cl copies and adapts creating pending credentials from PasswordFormManager to NewPasswordFormManager. No changes in logic. Creating of pending credentials is the step in implementing of saving in NewPasswordFormManager. Next steps will be to implement Save() and Update() methods. Bug: 831123 Change-Id: I2a7f24c85e46ecd1474f99cf26c9b5136fe2ae9d Reviewed-on: https://chromium-review.googlesource.com/1148393 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578582}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dbd1612782f5..604d873e1df5 git log dbd1612782f5..604d873e1df5 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 oetuaho@nvidia.com Fix multiview combined with flat interpolation 2018-07-27 fjhenigman@chromium.org Vulkan: make DynamicBuffer reusable, always valid. Created with: gclient setdep -r src/third_party/angle@604d873e1df5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I12373ce7d2a0d223b8dbea76ee55f4ceb65bc32c Reviewed-on: https://chromium-review.googlesource.com/1152614Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578581}
-
Dan Elphick authored
Gets the Isolate via ToIsolate(LocalFrame*). Change-Id: I8e6fcb1043d5774483cd9533d848ae5d0fcf6179 Reviewed-on: https://chromium-review.googlesource.com/1151195Reviewed-by:
-
Dan Elphick authored
since they infer the Isolate from the address of the String they're called on. This will cease to work reliably in future V8 releases, so this change replaces all uses in chromium with ones that pass in the Isolate explicitly. v8: :Write, v8::WriteUtf8 and v8::Utf8Length are marked V8_DEPRECATE_SOON Change-Id: I13780586c91de98375adec0ad414d65476ed5170 Reviewed-on: https://chromium-review.googlesource.com/1149879Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578579}
-
Boris Sazonov authored
This CL modifies the intent used by SyncPromoView and Sync customization pages when master sync toggle in Android is turned off. New intent opens main Sync settings page instead of the specific page for the signed in account. This is necessary because master sync toggle is not accessible from the account sync page. Bug: 863370 Change-Id: I5b2b410084bc0945b6190aec6a0c9cbf1277fefd Reviewed-on: https://chromium-review.googlesource.com/1151988Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578578}
-
Henrik Boström authored
It was added in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1145872 I wasn't sure whether to revert that CL or disable the test. Disabling. It's flakily not terminated: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939871163610794448/+/steps/webkit_unit_tests_on_Windows-10-15063/0/logs/WorkerThreadTest.TerminateWorkerWhileChildIsLoading/0 TBR=japhet@chromium.org, nhiroki@chromium.org NOTRY=True Bug: 868253 Change-Id: I286472514666b2d11627a515fdab92e0d73cd155 Reviewed-on: https://chromium-review.googlesource.com/1152743 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Henrik Boström authored
TBR=fdoray@chromium.org, reillyg@chromium.org NOTRY=True Bug: 868254 Change-Id: I5e80699e1d04e51be31a097b2b4deb0ec5e3a7ce Reviewed-on: https://chromium-review.googlesource.com/1152737 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib683d4e2468e6454d9ac3ee53ec56218f024071e Reviewed-on: https://chromium-review.googlesource.com/1152700Reviewed-by:
-
