- 04 Oct, 2017 40 commits
-
-
Eric Willigers authored
animations/unanimated-style.html was using setTimout(0) to wait for the initial style calculations before starting the animation. This isn't a reliable method. We now force style recalc explicitly by reading an element's offsetTop. BUG=770362 Change-Id: Icf518b3a43b51d854de81cc2fab371922e271e16 Reviewed-on: https://chromium-review.googlesource.com/699974Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506497}
-
Eric Willigers authored
The test would previously fail if a rAF callback occurred 0.3s later than anticipated. We increase the animation duration, so that the animation will still be in progress if the callback occurs later that anticipated. The entry in TestExpectations is no longer needed. BUG=248938 Change-Id: Ida03745d18bd5a8ac4d454fc0e3fbdae5254d20a Reviewed-on: https://chromium-review.googlesource.com/699954Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506496}
-
Daniel Murphy authored
This reduces the size of the extra large backing store class, and leads towards a smaller class in the future as other classes can now call the appropriate leveldb operations. R: cmumford@chromium.org, pwnall@chromium.org Bug: 725565 Change-Id: I29e7c72970b47801a51db4548f9e0a1b3ae26d4b Reviewed-on: https://chromium-review.googlesource.com/693382Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#506495}
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Change-Id: I14ff5597d1482fe56836ba49dcee6f6755c303c5 Reviewed-on: https://chromium-review.googlesource.com/673127Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#506494}
-
Mike Wasserman authored
Bug: 771381 Change-Id: I42a1b5c2d691e9973f21ac0de8fc441aa9fe3e21 Reviewed-on: https://chromium-review.googlesource.com/699940Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506493}
-
dpapad authored
This is a necessary preparatory step for optimizing the MD Extensions page with polymer-bundler. Side benefits of this change: - No need for the repeated "resources/md_extensions" prefix on every file's path declaration in the grd file. - Faster build times when a file is touched (no longer need to rebuild the gigantic browser_resources.pak) - No longer need to call source->AddResourcePath() repeatedly in extensions_ui.cc. Also moved two HTML files that were misplaced in the old Extensions folder even though they are only used in the new MD version. Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9b13ed4f46fa14f27d9280eca40c9cd79a6d4b4 Reviewed-on: https://chromium-review.googlesource.com/696670 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506492}
-
Ke He authored
Define the mojom::InputDeviceInfo. Simply replace the old native InputDeviceInfo. Make sure all the existed test cases pass. In next CL we'll do the mojofication. The InputServiceProxy will be removed then. BUG=767309 Change-Id: Ic307a794592e74d73fb016c56ec24c027441c41b Reviewed-on: https://chromium-review.googlesource.com/676944Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#506491}
-
Lucas Garron authored
content::SSLManager previously contained some logic for computing whether/how an interstitial should be bypassable, which it then passed into ContentBrowserClient::AllowCertificateError(), though only ChromeContentBrowserClient's implementation was using it. This presents a problem for the interstitial refactor because this logic is needed for interstitial display, but SSLManager/ChromeContentBrowserClient::AllowCertificateError() is no longer going to be the point that triggers interstitial display. We're moving this logic into //chrome's SSLErrorHandler, which is a more convenient place for the logic to live because both the old and new interstitial display codepaths pass through that point. This change moves the calculation of the following into ssl_error_handler.cc: 1. The mapping of cert_error -> fatal (opposite of "soft overridable"). - Moves from SSLManager::OnCertError() and into an anonymous namespace in `ssl_error_handler.cc`. 2. The calculation of an SSLErrorUI::SSLErrorOptionsMask mask for SSLBlockingPage::Create(). - Moves from ChromeContentBrowserClient::AllowCertificateError(). In addition, this change removes the SSLManager::OnCertErrorInternalOptionsMask enum, since its use would be reduced to a passing a single bool from SSLManager::OnCertError() to SSLManager::OnCertErrorInternal(). (Also, it was confusingly similar to SSLErrorUI::SSLErrorOptionsMask.) This change leaves the `overridable` parameter in ContentBrowserClient::AllowCertificateError() unused. The followup CL at crrev.com/c/680114 will remove it. Bug: 768105 Change-Id: Iffbd56d944fc96427cb41a691aecd04236bb4cb6 Reviewed-on: https://chromium-review.googlesource.com/679937 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#506490}
-
Vladimir Levin authored
This patch changes the approximate scale math to use rect bounds instead of a vector, which yields more accurate results. This means that if a layer is effectively shrunk after the transformation we won't use a larger scale which could have been the case with the scale math. R=chrishtr@chromium.org Bug: 766021 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I42aea3e7b9900b2a1e5499c8c24d7264b7bd6d3f Reviewed-on: https://chromium-review.googlesource.com/693303 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506489}
-
Andrew Grieve authored
And add tests :) Change-Id: Ic26d1c3d27c0af101d9c2ea94284f85dc21b2027 Reviewed-on: https://chromium-review.googlesource.com/700656 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506488}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 570b9f37. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2551 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Ia2f1f2872d20cfb83f655db2b3716a9f5a8d9f8f Reviewed-on: https://chromium-review.googlesource.com/700716 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506487}
-
Dave Schuyler authored
This CL adds a listener to the settings subpage that will allow setting the filter value. The filter may be cleared by setting the value to ''. Bug: 770423 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If4ac8e4bb1f1b38224b52e970f549293ff9b5e9d Reviewed-on: https://chromium-review.googlesource.com/693390 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506486}
-
Tibor Goldschwendt authored
Bug: Change-Id: Ib0c511a7e032b05d9b3644966419520aa18160c3 Reviewed-on: https://chromium-review.googlesource.com/699702Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506485}
-
Tom Sepez authored
This is another step towards normalizing (somewhat) the InitializeSandbox() API across the various platforms. Change-Id: I86279c2f5c26c9c1bd0b7586b7ac882c3667f6e5 Reviewed-on: https://chromium-review.googlesource.com/699154 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506484}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/aafdc153a2b7..3e3a78b68c31 $ git log aafdc153a..3e3a78b68 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 art-snake Improve readability for CPDF_LinearizedHeader. 2017-10-04 hnakashima Fix UAF in SetVisible(). 2017-10-02 art-snake Unify parsing of cross ref table v4. 2017-10-02 art-snake Simplify CPDF_DataAvail::ParseIndirectObjectAt Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I581e223cbaa4d2fc0e2410fd567fdad0d91ff96a Reviewed-on: https://chromium-review.googlesource.com/699644 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506483}
-
Scott Little authored
Bug: Change-Id: I9f792d5b74dd28ee9442725a182a69de62c4f66e Reviewed-on: https://chromium-review.googlesource.com/700794Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#506482}
-
rbpotter authored
Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc4fc5ac44534f51305f6573ba1a1f00c55d5672 Reviewed-on: https://chromium-review.googlesource.com/699638Reviewed-by:
-
Alan Bram authored
Change-Id: Iaf4d6035552698559e56b1459d5b3e4c4e47ac38 Reviewed-on: https://chromium-review.googlesource.com/699934 Commit-Queue: Alan Bram <flyboy@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#506480}
-
Devlin Cronin authored
It looks like many of the strings from the old delete browsing data interface are unused, but still included (the rest of the old browsing data settings UI was removed in crrev.com/1f2b58d7). Remove them. Bug: None Change-Id: Idb3c724430c626d5ae262f55e147107f6de34f60 Reviewed-on: https://chromium-review.googlesource.com/699804 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/672cabd12c68..d0b91b8f3a17 $ git log 672cabd12..d0b91b8f3 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 nednguyen Add snap-it tests to Catapult CQ Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I55dd57a09a38178eb2437fd9298ac940df0b92ae Reviewed-on: https://chromium-review.googlesource.com/700795 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506478}
-
Tom Anderson authored
This CL: * Fixes some manpage syntax. * Compresses the manpages. * Adds manpage entries for google-chrome-stable and google-chrome for the stable channel. * Fixes a reference to google-chrome in the RPM spec. * Handles rpmlint suppressions using a conf file instead of just filtering out what we don't want. This fixes the following lint errors: * lintian: * E: chromium-browser-stable: manpage-not-compressed usr/share/man/man1/chromium-browser.1 * W: chromium-browser-stable: manpage-has-errors-from-man usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * rpmlint: * chromium-browser-stable.x86_64: W: manpage-not-compressed bz2 /usr/share/man/man1/chromium-browser.1 * chromium-browser-stable.x86_64: W: manual-page-warning /usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * chromium-browser-stable.x86_64: W: no-manual-page-for-binary google-chrome * chromium-browser-stable.x86_64: W: no-manual-page-for-binary chromium-browser-stable BUG=771373 R=thestig@chromium.org Change-Id: I5d1921150945123b72b5f2a50714c3094a526648 Reviewed-on: https://chromium-review.googlesource.com/699855Reviewed-by: -
Scott Violet authored
For OOPIF we want the parent renderer to embed the child. This is mediated by the browser. That is, we want something like the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser passes cWTC to parent renderer. 3. Parent renderer creates Window in mus and calls Embed() with cWTC. Unfortunately in step 2 if the parent renderer were compromised then it could directly call functions on cWTC, such as spoofing events. This is a security problem. To avoid this scenario I'm adding the option of a two phase embed. This results in the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser calls ScheduleEmbed() on it's WindowTree connection. ScheduleEmbed is a new function that takes a WindowTreeClient and returns a token. 3. Browser waits for token. 4. Browser passes token to parent renderer. 5. Parent renderer creates Window in mus and calls Embed() passing token. With this flow renderers don't end up with a WindowTreeClient from a different client. BUG=758387 TEST=covered by tests Change-Id: I819a57cd811d4939cbeecec8aeb8273eefca64f5 Reviewed-on: https://chromium-review.googlesource.com/699519Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506476}
-
Andrew Grieve authored
This reverts commit 1dd22ad0. Reason for revert: Breaks when lint_suppressions_file is assigned within //build_overrides/build.gni Original change's description: > Android: Allow per-target lint suppression configuration > > This change allows for Android lint suppression configurations > to be defined on a per-target basis (assuming said target is > "Android lint capable") rather than having one global config. > This will allow embedders to keep upstream's lint config for > Chromium targets (w/o patching), while using a separate config > for the embedding application. > > Bug: 737897 > Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc > Reviewed-on: https://chromium-review.googlesource.com/698297 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506393} TBR=agrieve@chromium.org,justmoto@amazon.com Change-Id: Ib15a61731179cc9ffc8d415844cfe8fbbc8e68eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737897 Reviewed-on: https://chromium-review.googlesource.com/701014Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#506475}
-
Justin DeWitt authored
This enables the Downloads Home integration as well as the notification background task. The UI can still be disabled manually in chrome://flags. Bug: 701939 Change-Id: Ifd38830b4442465287bb47f6440afeb499e3e234 Reviewed-on: https://chromium-review.googlesource.com/699578Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506474}
-
Justin DeWitt authored
This will cause downloads to error out of the download system once their freshness time has passed in prefetching's db. Bug: 701939 Change-Id: I78a2e026349405db643fd960a7b41aaf8f370b44 Reviewed-on: https://chromium-review.googlesource.com/699151 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506473}
-
Andrew Grieve authored
Change-Id: I0c2898761911c0e517c8e0fa84ad3855959e38fb Reviewed-on: https://chromium-review.googlesource.com/700038Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506472}
-
Tim Volodine authored
org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Full org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Two org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Two org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Full see crbug.com/771648. BUG=771648 TBR=bauerb@chromium.org,dgn@chromium.org NOTRY=true Change-Id: I80223ea645ae25bf27e4152ca872b685ea80b816 Reviewed-on: https://chromium-review.googlesource.com/700894Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#506471}
-
Rob Percival authored
Use net::DnsQuery to encode the DNS request. Bug: 667805 Change-Id: I89e03912522466dfb17bae4d3b6def448af80667 Reviewed-on: https://chromium-review.googlesource.com/671015Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#506470}
-
Samuel Huang authored
This reverts commit f9cc9601. Reason for revert: Speculative revert, for failing net_unittests on Android Tests (dbg). Original change's description: > SimpleCache: Port (unsequenced) use of SequencedWorkerPool over to TaskScheduler > > This is what it does behind scenes in Chrome anyway, but always using the scheduler > in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call > rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting() > as separate calls, which causes trouble when control jumps back and forth between the two. > > Bug: 766221 > Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53 > Reviewed-on: https://chromium-review.googlesource.com/697925 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506395} TBR=scottmg@chromium.org,asanka@chromium.org,morlovich@chromium.org Change-Id: Ie79bee31116c2fea12122a0c4cf8339af7a6b8a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766221 Reviewed-on: https://chromium-review.googlesource.com/700934Reviewed-by:
-
Nate Chapin authored
Also, the timer in RawResource::MatchPreloads Expose the WebTaskRunner for loading on FrameFetchContext and wire it up for WorkerFetchContext, which enables us to get the ResourceFetcher constructor back down to one parameter and removes the need for thread and null checks when handling task runners in platform/loader/fetch/ Bug: Change-Id: I36a0bd8f1a9758b51a33badf8e93a84880618600 Reviewed-on: https://chromium-review.googlesource.com/671624 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506468}
-
James Zern authored
demux,StoreFrame: restore hdr size check to min req avoids over reading if the reported ANMF payload is < 8 bytes. likely broken since: 81b8a741 Design change in ANMF and FRGM chunks: BUG=b/67381469 Change-Id: If2d82a063ef0d2d33385d6b816d7cea8a3455163 Reviewed-on: https://chromium-review.googlesource.com/699757 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506467}
-
Bo Liu authored
Convert to Log.d to Log.i so that they work on release builds as well. Add trace logs to TestAwContentsClient since WebViewContentsClientAdapter isn't built into tests. Change-Id: I03652c5b25e6263bce7875242d612225b0451f80 Reviewed-on: https://chromium-review.googlesource.com/700816 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506466}
-
Guido Urdaneta authored
Elements with srcObject contain MediaStreams and they cannot be cross origin since capture from cross-origin elements (with src) is disabled. The cross-origin check fails for mediaStreams since it uses the src, which is empty when the stream has been assigned to the element as an srcObject. Bug: 771388 Change-Id: I060ce54e37ba34814ac6186b0e098edfcc3d752e Reviewed-on: https://chromium-review.googlesource.com/699434Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#506465}
-
chrome://policy-toolAnton Urusov authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f15ec24fe6fa4a7c96dbdabfc7517fd01a7191e Reviewed-on: https://chromium-review.googlesource.com/690574 Commit-Queue: Anton Urusov <urusant@google.com> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506464}
-
liberato@chromium.org authored
AVDACodecAllocator previously was designed to work with AVDA on the GPU main thread. This CL makes it work properly even if clients call it from other threads, such as MCVD will do. It does three main things: - Create/ReleaseCodec calls post to the thread on which the allocator was constructed. This keeps everything ordered. Otherwise, it's very difficult to ensure that one client stopping threads won't happen concurrently with another posting tasks. Locks worked, but this prevents blocking the caller, and makes it easier to deal with the weakptr used to cancel StopThreadTask. - Responses to the client are on whatever thread it called on. This lets us continue to use client-provided WeakPtrs. - StartThread now sends its results asynchronously, since it posts to another thread sometimes. Bug: 760822 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib1bca55602a2f43ea9e2ecfd55fa98c877fb6217 Reviewed-on: https://chromium-review.googlesource.com/669799 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506463}
-
Mustafa Acer authored
Bug: 396462 Change-Id: I7f23f1da022b700a15f6edd43781e20219999cac Reviewed-on: https://chromium-review.googlesource.com/666321Reviewed-by:
-
Becky Zhou authored
Bug: 507469 Change-Id: I023ba00b05b21bfd57ed9dc2a6f2ca0d7cd51c28 Reviewed-on: https://chromium-review.googlesource.com/699745Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#506461}
-
Uttam Thakore authored
This CL fixes the bit arithmetic in the constants used to generate UMA histograms for local network request metrics. The problems with the arithmetic are detailed in the associated bug. BUG=764852 Change-Id: Ifd06282b05b1893cae7756840893053fc1daa057 Reviewed-on: https://chromium-review.googlesource.com/699703Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: U Thakore <uthakore@chromium.org> Cr-Commit-Position: refs/heads/master@{#506460}
-
Daniel Murphy authored
Bug: 771630 Change-Id: I424e87f5873bd627b2756f9b54ee55e75c9b6ef0 Reviewed-on: https://chromium-review.googlesource.com/699766Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#506459}
-
Simon Que authored
This feature is too specific. It should not be hard-coded into the log source system. Instead, it should be implemented by the caller of the API that uses these log sources. BUG=767742 Change-Id: I43da7adfb36c3ab899099fc174ce07a327673c00 Reviewed-on: https://chromium-review.googlesource.com/687810 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#506458}
-
