GitLab

BUG=None
TEST=blink_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/454353002

git-svn-id: svn://svn.chromium.org/blink/trunk@179981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And call the new functions: SetUpBlinkTestEnvironment() and
TearDownBlinkTestEnvironment().

BUG=None
TEST=webkit_unit_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/461443002

git-svn-id: svn://svn.chromium.org/blink/trunk@179977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We had an explicit list of these folks for modules,
but given that these individuals are charged with
Blink's long-term stewardship, it makes sense that
they should be able to review all changes across
Blink's source.

This also makes this list publicly documented
which we had failed to do so in the past.

R=abarth@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/441083002

git-svn-id: svn://svn.chromium.org/blink/trunk@179975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Skia's SkMatrixConvolutionImageFilter expects its "bias" parameter
to be in pixel component scale (ie., 0 = none, 255 = full), whereas
FEConvolveMatrix uses normalized scale. Scale by 255 to please Skia.

BUG=402493

Review URL: https://codereview.chromium.org/465503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow-up to
  https://codereview.chromium.org/425953002/
addressing some late comments.

BUG=397909

Review URL: https://codereview.chromium.org/462613004

git-svn-id: svn://svn.chromium.org/blink/trunk@179971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/451993003

git-svn-id: svn://svn.chromium.org/blink/trunk@179970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Calling writePixels on a canvas using DisplayList2DCanvas was ignoring the call (canvas.pixels == null)
To make this work, we need to fallback to a raster canvas to be able to directly access the canvas' pixels.

To be more consistent, the method willReadback has be renamed to willAccessPixels.

Fixes the following layout-tests with --enable-display-list-2d-canvas:
  fast/canvas/canvas-imageSmoothingEnabled.html [ Failure ]
  fast/canvas/canvas-putImageData.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html [ Failure ]
  fast/canvas/canvas-imageSmoothingEnabled-patterns.html [ ImageOnlyFailure ]

BUG=401624

Review URL: https://codereview.chromium.org/455863002

git-svn-id: svn://svn.chromium.org/blink/trunk@179969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding a inline helper function in SkiaUtils.h to hide the cast of WebCore Windrule to SkPath::FillType

Review URL: https://codereview.chromium.org/453233002

git-svn-id: svn://svn.chromium.org/blink/trunk@179968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jbroman

Review URL: https://codereview.chromium.org/459843002

git-svn-id: svn://svn.chromium.org/blink/trunk@179966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of DevTools: Introduce module initializers (https://codereview.chromium.org/458753003/)

Reason for revert:
Un-reverting at request of patch author.

Original issue's description:
> Revert of DevTools: Introduce module initializers (https://codereview.chromium.org/451713002/)
> 
> Reason for revert:
> Breaks android_aosp bot and prevents Blink roll.
> 
> http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4536/steps/compile/logs/stdio
> 
> make: *** No rule to make target `out/target/product/generic/obj/GYP/shared_intermediates/resources/inspector/documentation/DocumentationView.js', needed by `out/target/product/generic/obj/GYP/shared_intermediates/devtools/devtools_resources.grd'.  Stop.
> 
> 
> Original issue's description:
> > DevTools: Introduce module initializers
> > 
> > For all lazy-loaded modules and workers, _module.js files are introduced, which
> > importScript() all scripts for a particular module.
> > 
> > This allows to:
> > - get rid of importScript() calls intertwined with meaningful code,
> > - simplify module loading, since Runtime does not need to read the
> >   module descriptor to determine the resource names.
> > 
> > This approach is similar to how we implement
> > the CSS loading in inspector.css.
> > 
> > R=pfeldman, vsevik
> > BUG=391566
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948
> 
> TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=391566
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179963

TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391566

Review URL: https://codereview.chromium.org/459833002

git-svn-id: svn://svn.chromium.org/blink/trunk@179965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=398787

Review URL: https://codereview.chromium.org/462603002

git-svn-id: svn://svn.chromium.org/blink/trunk@179964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Breaks android_aosp bot and prevents Blink roll.

http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4536/steps/compile/logs/stdio

make: *** No rule to make target `out/target/product/generic/obj/GYP/shared_intermediates/resources/inspector/documentation/DocumentationView.js', needed by `out/target/product/generic/obj/GYP/shared_intermediates/devtools/devtools_resources.grd'.  Stop.


Original issue's description:
> DevTools: Introduce module initializers
> 
> For all lazy-loaded modules and workers, _module.js files are introduced, which
> importScript() all scripts for a particular module.
> 
> This allows to:
> - get rid of importScript() calls intertwined with meaningful code,
> - simplify module loading, since Runtime does not need to read the
>   module descriptor to determine the resource names.
> 
> This approach is similar to how we implement
> the CSS loading in inspector.css.
> 
> R=pfeldman, vsevik
> BUG=391566
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948

TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391566

Review URL: https://codereview.chromium.org/458753003

git-svn-id: svn://svn.chromium.org/blink/trunk@179963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402431

Review URL: https://codereview.chromium.org/458963002

git-svn-id: svn://svn.chromium.org/blink/trunk@179962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: fix highlighting in CPU profiles.

BUG=

Review URL: https://codereview.chromium.org/460543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is a split from https://codereview.chromium.org/457483002/.
This CL supports private scripts in partial interfaces.

Assume that XPartial-1 and XPartial-2 are partial interfaces of X.
Then we have XPartial-1.js, XPartial-2.js and X.js.
When a DOM attribute/method in any of the JS files is requested
at the first time, all of the JS files are compiled at the same time.

This is redundant because when a DOM attribute/method in XPartial-1.js
is requested, we just need to compile XPartial-1.js and X.js.
I'll address the issue in a follow-up CL.

BUG=341031
TEST=fast/dom/private-script-unittest.html

Review URL: https://codereview.chromium.org/454773002

git-svn-id: svn://svn.chromium.org/blink/trunk@179960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes unnecessary blink:: prefixes.
Also it merges *namspace blink{}* blocks.

BUG=

Review URL: https://codereview.chromium.org/462613002

git-svn-id: svn://svn.chromium.org/blink/trunk@179959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=235436

Review URL: https://codereview.chromium.org/460673002

git-svn-id: svn://svn.chromium.org/blink/trunk@179958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=396086

Review URL: https://codereview.chromium.org/456363002

git-svn-id: svn://svn.chromium.org/blink/trunk@179957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363976

Review URL: https://codereview.chromium.org/431273005

git-svn-id: svn://svn.chromium.org/blink/trunk@179956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a private script throws an exception, what the private script binding does is:

- if the exception is the one supported in private scripts,
the private script binding clones the exception in the user's script and throws it.

- if the exception is the one not (yet) supported in private scripts,
the private script binding dies.

Since these operations are done explicitly, we should use ReThrow()
instead of relying on V8TryCatchRethrowScope. (V8TryCatchRethrowScope is not
a proper mechanism for doing this because V8TryCatchRethrowScope is intended
to be used to rethrow an exception the way it is without doing any conversion.)

BUG=341031

Review URL: https://codereview.chromium.org/461593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/462653002

git-svn-id: svn://svn.chromium.org/blink/trunk@179954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This uses the "date" given in the http://auto-sheriff.appspot.com/data page to
show how recent the failure information is.

I intend to add some styling when the data is more than 5 minutes old, but I'm
pretty new to Polymer and want to make sure this is on track first.

BUG=399712
NOTRY=true

Review URL: https://codereview.chromium.org/453543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DOMPresentationUtils.simpleSelector behavior used to be fixated in a
couple of tests that dumped default selector in a new style rule section.
This patch adds a separate test for simpleSelector method and removes
the calls to default selector in the affected tests.

This makes it possible to use InspectorTets.addNewRule in these tests

Review URL: https://codereview.chromium.org/458213002

git-svn-id: svn://svn.chromium.org/blink/trunk@179952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092

Review URL: https://codereview.chromium.org/438273002

git-svn-id: svn://svn.chromium.org/blink/trunk@179951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Give more descriptive names to MIME type related methods
- Split responseMIMEType() into one without fallback to text/xml and one
  with it as this fallback is requird only a few places
- Add some FIXMEs to address issues found during this refactoring later

BUG=none

Review URL: https://codereview.chromium.org/450103003

git-svn-id: svn://svn.chromium.org/blink/trunk@179950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Keep track of collection rate. If we collect less than 50% of objects,
use a factor of 4 instead of 2 allocation to force conservative GCs.

This will only have an effect when you do not get back to the event
loop in a timely manner. That happens a lot in benchmarks and almost
never in reality.

R=erik.corry@gmail.com, zerny@chromium.org

Review URL: https://codereview.chromium.org/460593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For all lazy-loaded modules and workers, _module.js files are introduced, which
importScript() all scripts for a particular module.

This allows to:
- get rid of importScript() calls intertwined with meaningful code,
- simplify module loading, since Runtime does not need to read the
  module descriptor to determine the resource names.

This approach is similar to how we implement
the CSS loading in inspector.css.

R=pfeldman, vsevik
BUG=391566

Review URL: https://codereview.chromium.org/451713002

git-svn-id: svn://svn.chromium.org/blink/trunk@179948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink only supports [Exposed] as an interface-level annotation right now,
but it also makes sense as a member-level annotation in case certain members
should only be available in a subset of the interface's exposure set.

The first user for this will be the Web Notifications API, which now
defines requestPermission() to only be exposed on Document, whereas the rest
of the API will be available in both windows and workers.

BUG=398446

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179418

Review URL: https://codereview.chromium.org/424163002

git-svn-id: svn://svn.chromium.org/blink/trunk@179947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The string version of Add() was unfortunately omitted in an earlier CL.

R=falken@chromium.org,jkarlin@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/458853002

git-svn-id: svn://svn.chromium.org/blink/trunk@179946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/458903003

git-svn-id: svn://svn.chromium.org/blink/trunk@179945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No particular need for these to be custom, so turned into File accessors
instead.

Also drop a runtime feature check for FileConstructor; it is now stable.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/458953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

method.cpp misses a check for a returned value of a method implemented in a private script.
This CL adds the check. Other places already have the check.

(This call path is not yet used in production.)

BUG=341031

Review URL: https://codereview.chromium.org/462623002

git-svn-id: svn://svn.chromium.org/blink/trunk@179943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=

Review URL: https://codereview.chromium.org/457353002

git-svn-id: svn://svn.chromium.org/blink/trunk@179942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AudioNode::dispose() must be called before the AudioNode is destructed.
This is currently guaranteed in both oilpan builds and non-oilpan builds.
However the logic is not trivial, so this CL adds the ASSERT about it.

BUG=340522

Review URL: https://codereview.chromium.org/455353002

git-svn-id: svn://svn.chromium.org/blink/trunk@179941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Auto-rebaseline r179870 for r179857 appears to have failed with respect to Mac10.8.

TBR=wangxianzhu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/461583002

git-svn-id: svn://svn.chromium.org/blink/trunk@179940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaElementAudioSourceNode::dispose() should call HTMLMediaElement::setAudioSourceNode(0) in oilpan builds

Currently HTMLMediaElement::setAudioSourceNode(0) is called only in non-oilpan builds.
However, there is no reason why oilpan builds cannot call HTMLMediaElement::setAudioSourceNode(0).
It's better to call it both in oilpan builds and non-oilpan builds and reduce #if branches.

BUG=340522

Review URL: https://codereview.chromium.org/456273002

git-svn-id: svn://svn.chromium.org/blink/trunk@179939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. For case TraceIfNeeded, modify TraceIfNeededTester to inherit from GarbageCollectedFinalized and at the end of test case TraceIfNeeded trigger a GC.
   After GC, the destructor of TraceIfNeededTester will dereference the RefPtr<OffHeapInt> instance, stop the leak.
2. For case MapWithCustomWeaknessHandling and MapWithCustomWeaknessHandling2, need clear the Persistent handle and trigger a GC at the end of test case.

R=ager@chromium.org, oilpan-reviews@chromium.org
BUG=401018

Review URL: https://codereview.chromium.org/452723002

git-svn-id: svn://svn.chromium.org/blink/trunk@179938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402263,402218

Review URL: https://codereview.chromium.org/455333002

git-svn-id: svn://svn.chromium.org/blink/trunk@179937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=iliia, semeny, yurys

Review URL: https://codereview.chromium.org/454873006

git-svn-id: svn://svn.chromium.org/blink/trunk@179936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/463433002

git-svn-id: svn://svn.chromium.org/blink/trunk@179935 bbb929c8-8fbe-4397-9dbb-9b2b20218538