GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/073720e..52f401e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/884253002

Cr-Commit-Position: refs/heads/master@{#313590}

BUG=369661
TEST=tests stay green

Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699
Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c

Review URL: https://codereview.chromium.org/839413004

Cr-Commit-Position: refs/heads/master@{#313589}

With throttled, async touch dispatch, an uncancelable touchmove is sent
as soon as the touch sequence exceeds an arbitrarily defined
application slop region, separate from the platform slop region. The
intent in doing so was to allow web apps to clear any tap/press-related
state after a scroll has begun. However, the sending of this touchmove
at the start of a scroll sequence can be problematic; the early part of
a scroll sequence is often sensitive to minor bottlenecks, and the
dispatch of an additional touchmove can conceivably push the app into
high latency mode by delaying frame production.

Stop sending this slop-exceeding touchmove, instead relying on the
existing timer-based async touchmove dispatch.

Note that while this may regress touch behavior on certain sites (e.g.,
causing faulty tap interpretation), it's likely that behavior on such
sites was already racy and fragile, subject to the arbitrary value of
the fixed "application" slop region.

BUG=449275

Review URL: https://codereview.chromium.org/872633005

Cr-Commit-Position: refs/heads/master@{#313588}

This pulls in the following Native Client changes:

58c9abe: (dschuff@chromium.org) Update revision for PNaCl
fd92de8: (teravest@chromium.org) Revert "Output depfile from build_nexe."
fb70836: (dschuff@chromium.org) PNaCl: Update libc++abi revision in pnacl/COMPONENT_REVISIONS
939a13a: (teravest@chromium.org) Provide an irt_core_lib GN target.
dbf2af4: (sbc@chromium.org) Remove include of build_config.h from nacl_exception.h
e205317: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b: (jfb@chromium.org) Update revision for PNaCl
3d00a54: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8: (mseaborn@chromium.org) Update codereview.settings following the switch from SVN to Git
7a6cf46: (jfb@chromium.org) Update revision for PNaCl
bc28c0b: (jvoung@chromium.org) Fix the native_client URL in the PNaCl REV file.
f8aa9dc: (bradnelson@google.com) Adding le32-nacl build of pnacl tools.
cfda521: (teravest@chromium.org) Explicitly include build_config.h.
61b7ba9: (teravest@chromium.org) Output depfile from build_nexe.
2d65c23: (jfb@chromium.org) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88: (sbc@chromium.org) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204: (jvoung@chromium.org) Remove some more dead code and variables from pnacl/build.sh.
f116471: (dschuff@chromium.org) Update revision for PNaCl
01f3d97: (teravest@chromium.org) Always define product_dir in build_nexe.
8a5a846: (mseaborn@chromium.org) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a: (mseaborn@chromium.org) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394: (bradnelson@google.com) Change driver bash scripts to work in devenv.
490e554: (dschuff@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a: (sbc@chromium.org) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c: (dschuff@chromium.org) Support filenames with spaces in the PNaCl driver scripts.
4f726e8: (sbc@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341: (dschuff@chromium.org) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773: (sbc@chromium.org) Update GCC revision in tools/REVISIONS
29ae54a: (jfb@chromium.org) Update revision for PNaCl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk

Review URL: https://codereview.chromium.org/883073002

Cr-Commit-Position: refs/heads/master@{#313587}

This will make it have the same behaviour as the User Manager, vs. navigating to
chrome://settings/createProfile.

BUG=452125
TEST=Choose Add Person from the OS menu bar. This should create a profile and
switch to it immediately.

Review URL: https://codereview.chromium.org/870203003

Cr-Commit-Position: refs/heads/master@{#313586}

net: fix typo and add ustr.gov to HSTS preloaded list.
Cr-Commit-Position: refs/heads/master@{#313585}

screen readers know which human language to read a page in.

R=dmazzoni@chromium.org
TBR=sky@chromium.org,asanka@chromium.org
BUG=438704

Review URL: https://codereview.chromium.org/880313002

Cr-Commit-Position: refs/heads/master@{#313584}

On Mac, the --show-app-list flag causes the AppLauncher to start loading before the Profile is loaded. For this, the profile_path is sent to AppListService::InitAll(), so that this load can be aborted if it would point to a Locked Profile.

The AppListService will no longer permit loading a locked profile, and will direct to the UserManager instead. StartupBrowserCreator has a similar flow.

BUG=421308
TEST=Try to load the App Launcher for a locked profile in any possible way the Launcher can be launched ;) It should always direct to the UserManager, upon Profile Selection which then directs to the AppLauncher. Opening the AppLauncher for a non-locked profile should always work smoothly.

Review URL: https://codereview.chromium.org/856733004

Cr-Commit-Position: refs/heads/master@{#313583}

This makes the naming consistent with other use cases, e.g. CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, ProtectedMediaIdentifierPermissionContext etc.

BUG=446263
TEST=Renaming only.

Review URL: https://codereview.chromium.org/881023002

Cr-Commit-Position: refs/heads/master@{#313582}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/884823002

Cr-Commit-Position: refs/heads/master@{#313581}

Review URL: https://codereview.chromium.org/868473002

Cr-Commit-Position: refs/heads/master@{#313580}

For MediaSourcePlayer, we can use this flag to reduce the browser seek when codec is recreated.
Will implement the logic to reduce browser seek in a follow up CL.

BUG=304234

Review URL: https://codereview.chromium.org/872253008

Cr-Commit-Position: refs/heads/master@{#313579}

This actually represents a pretty huge milestone - no more usage of
{Unmanaged} NetworkConnectionHandler from InternetOptionsHandler!
Everything is now using setProperties which uses MNCH.

BUG=430113

Review URL: https://codereview.chromium.org/700383008

Cr-Commit-Position: refs/heads/master@{#313578}

This patch changes where we do the ready to draw or ready to activate
check. Previously, this was done in the layers. Tile manager got all
of the picture layers, and asked them if they were ready. How, it
just builds a queue of an appropriate type to get this information.

R=reveman, danakj

Review URL: https://codereview.chromium.org/868803002

Cr-Commit-Position: refs/heads/master@{#313577}

When an app/extension places a ZoomController in manual mode, it is
reasonable to expect that navigating the main frame should reset that
mode, since the app/extension will be reloaded in the process.

The root cause of this bug was the sending of a ZoomChangeEvent that
contained stale information (the old, manually managed, zoom level),
which in turn caused the zoom bubble to be displayed.

BUG=450909

Review URL: https://codereview.chromium.org/884063004

Cr-Commit-Position: refs/heads/master@{#313576}

And don't break presubmit!
Basically, the change I put in previously that kind of fixed extensions redirects
actually meant presubmit would fail.
So I've gone and put in a real fix.

I also updated the redirects.json files in these GitHub repos for this to work: devtools, multi-device, and store.

Thanks, Ben, for your help.

Review URL: https://codereview.chromium.org/883963002

Cr-Commit-Position: refs/heads/master@{#313575}

This code significantly simplies the logic for matching.

Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches).  Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken.  See the second test case I added.  Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory.  Luckily this was rare; there are few reports on
crbug.

It's possible this new code is slower or faster than before (when the
old code behaved correctly).  I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.

TBR=sky for owners stamp; review it if you feel like

BUG=450850,434604

Review URL: https://codereview.chromium.org/882823004

Cr-Commit-Position: refs/heads/master@{#313574}

PrefsTabHelper was watching > 1K prefs so that it could update the renderer side data structures when they change. When session restore was used and it had 50 tabs, this would take almost a second on a Z620. Switch this to watching these prefs once per profile instead.

BUG=452693

Review URL: https://codereview.chromium.org/878363002

Cr-Commit-Position: refs/heads/master@{#313573}

Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.

BUG=453020
R=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884813002

Cr-Commit-Position: refs/heads/master@{#313572}

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/876203003

Cr-Commit-Position: refs/heads/master@{#313571}

BUG=368321

Review URL: https://codereview.chromium.org/867463006

Cr-Commit-Position: refs/heads/master@{#313570}

Specifically, remove triggered builders from the list of "launched"
builders.  The new CQ verifier will pick up triggered builders from
the "triggered" section. This eliminates the duplicate specs.

This CL depends on the deployment of the (Google-only) CL:
https://chromereviews.googleplex.com/145077013/

R=phajdan.jr@chromium.org
BUG=436774

Review URL: https://codereview.chromium.org/866293003

Cr-Commit-Position: refs/heads/master@{#313569}

BUG=452249

Review URL: https://codereview.chromium.org/881203002

Cr-Commit-Position: refs/heads/master@{#313568}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db3c2b2..c6b67b8

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/884803002

Cr-Commit-Position: refs/heads/master@{#313567}

BUG=452514

Review URL: https://codereview.chromium.org/879863004

Cr-Commit-Position: refs/heads/master@{#313566}

After crrev.com/310952 linux_me2me_host.py fails to start if it's called
using relative path. This CL fixes it. The problem was that it was trying
to run itself using sys.argv[0] after changing current directory, and
this works only if argv[0] is an absolute path.

Review URL: https://codereview.chromium.org/883063002

Cr-Commit-Position: refs/heads/master@{#313565}

At present, if a user changes zoom on OSX while the zoom bubble is
already being shown, the new zoom bubble (with the most up to date
information) is not shown. This CL changes this behaviour by allowing
a new zoom bubble to be created, and replace the existing one.

Example: load a PDF and repeatedly click the zoom +/- controls in the
lower-right corner of the viewer.

BUG=444995

Review URL: https://codereview.chromium.org/849693006

Cr-Commit-Position: refs/heads/master@{#313564}

The pieces added are as follows:

1. PresentationServiceDelegate: An interface to be implemented by an
embedder to handle Presentation API requests. Includes an Observer
interface to observe the lifetime of the delegate object.
2. PresentationScreenAvailabilityListener: An interface to be
implemented by content/ code to receive screen availability results
from the embedder.
3. Added method to ContentBrowserClient: GetPresentationServiceDelegate.
Returns nullptr by default. Embedder may override it with an
implementation that can handle Presentation API requests. Added to
allow content/ code to obtain a reference to a
PresentationServiceDelegate to forward presentation API requests to.

Presentation Mojo service patch: crrev.com/839773002/
Blink plumbing: crrev.com/832263007

The Chrome implementation of PresentationServiceDelegate is currently
in a private repo.

BUG=412331

Review URL: https://codereview.chromium.org/883953002

Cr-Commit-Position: refs/heads/master@{#313563}

The DeviceCloudPolicyInvalidator used to ensure that a suitable
InvalidationService is available on its own. This CL makes it a consumer
of AffiliatedInvalidationServiceProvider, which manages an
InvalidationService that can be shared by DeviceCloudPolicyInvalidator
and other consumers.

BUG=442800
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/846453006

Cr-Commit-Position: refs/heads/master@{#313562}

BUG=417463
TEST=build with clang plugin

Review URL: https://codereview.chromium.org/885703002

Cr-Commit-Position: refs/heads/master@{#313561}

It's not used anymore, last usage was removed
in https://codereview.chromium.org/583883003

R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/877183003

Cr-Commit-Position: refs/heads/master@{#313560}

The flake should hopefully be fixed by https://codereview.chromium.org/877213002/

R=earthdok
BUG=451988

Review URL: https://codereview.chromium.org/879053004

Cr-Commit-Position: refs/heads/master@{#313559}

There is a check in build-webapp.py (line 197) that ensures that
non-dev builds have this set to 'prod'. Up 'til now, we've been
setting this manually (hence the check in build-webapp), but it
is better to set it correctly in the gyp file.

This also allows the bots to build Official builds without
triggering the build-webapp check.

BUG=

Review URL: https://codereview.chromium.org/886543002

Cr-Commit-Position: refs/heads/master@{#313558}

Right now --disable-sync disables a lot of signin; any signin errors aren't surfaced, because nothing attempts to ping GAIA. This will help address that.

BUG=NONE
TEST=Run Chrome with the --disable-sync flag. Sign into a Profile and
the name (from G+) should appear in the Avatar Menu.

Review URL: https://codereview.chromium.org/870803003

Cr-Commit-Position: refs/heads/master@{#313557}

This fixes a problem where event listeners could stick around for a
short time period after an extension is unloaded, causing problems
with the onInstalled event for a new version of an extension.

BUG=449654

Review URL: https://codereview.chromium.org/877233002

Cr-Commit-Position: refs/heads/master@{#313556}

The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
Cr-Commit-Position: refs/heads/master@{#313446}

Review URL: https://codereview.chromium.org/864253002

Cr-Commit-Position: refs/heads/master@{#313555}

r227327 Fix indents on argument parsing code. No behavior change.
r227326 Make asan_symbolize.py not crash on Windows.

BUG=451741
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/884043004

Cr-Commit-Position: refs/heads/master@{#313554}

r313118 removed unused Cloud Devices code.
Cloud Print code must be untouched.

BUG=452871

Review URL: https://codereview.chromium.org/885683002

Cr-Commit-Position: refs/heads/master@{#313553}

R=lcwu@chromium.org,erickung@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/886583002

Cr-Commit-Position: refs/heads/master@{#313552}

BUG=447332

Review URL: https://codereview.chromium.org/853523004

Cr-Commit-Position: refs/heads/master@{#313551}