- 30 Aug, 2016 40 commits
-
-
rjkroege authored
To permit reusing portions of ash/display in both mus and ash, we need to move some code to ui. Start this process by relocating ash/common/display/display_info.* as it is the root of the inclusion dependency tree. BUG=581462 Review-Url: https://codereview.chromium.org/2270553002 Cr-Commit-Position: refs/heads/master@{#415395}
-
tommycli authored
Also updates a bunch of strings. BUG=622922 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2280233002 Cr-Commit-Position: refs/heads/master@{#415394}
-
fs authored
SVGSMILElement adds a reference to its target, and any instances of the target should never be mutated, so the registration of reference to the extended target element set in SVGAnimateElement::resetAnimatedType does not add any value. BUG=640676 Review-Url: https://codereview.chromium.org/2292983002 Cr-Commit-Position: refs/heads/master@{#415393}
-
dpranke authored
This picks up a change that will help address flaky telemetry failures. This includes the following changes (v0.9.5..v0.9.7): 79fe79db Change typ's interpretation of a test that first fails and is then skipped. 101acd31 Bump version to 0.9.6, clean up Python 3 failures 2f8787b8 rework run script to remove python3 log d5023636 rework sharding tests TBR=rnephew@chromium.org, nednguyen@google.com BUG=618330 Review-Url: https://codereview.chromium.org/2289303002 Cr-Commit-Position: refs/heads/master@{#415392}
-
sdy authored
Instead of guessing what *would* have been the OS X version constant for a version our SDK doesn't even support and then asserting when we're wrong, just skip the check when it doesn't matter. BUG=636093 Review-Url: https://codereview.chromium.org/2289173002 Cr-Commit-Position: refs/heads/master@{#415391}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bf2b35a6b699..578e20909005 $ git log bf2b35a6b..578e20909 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 jbudorick [devil] Disable USB reset in device_recovery. BUG=642194 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2295933002 Cr-Commit-Position: refs/heads/master@{#415390}
-
thestig authored
Review-Url: https://codereview.chromium.org/2293823002 Cr-Commit-Position: refs/heads/master@{#415389}
-
alexmos authored
BUG=636513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2281103002 Cr-Commit-Position: refs/heads/master@{#415388}
-
tomhudson authored
skia::GetTopDevice() gets removed from our public API. SK_API also removed from a couple of classes we don't want used. R=fmalita@chromium.org BUG=543755 Review-Url: https://codereview.chromium.org/2294813002 Cr-Commit-Position: refs/heads/master@{#415387}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26642c66..3d96d7ee Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2289243002 Cr-Commit-Position: refs/heads/master@{#415386}
-
rch authored
BUG=641791 Review-Url: https://codereview.chromium.org/2283393002 Cr-Commit-Position: refs/heads/master@{#415385}
-
geofflang authored
TBR=zmo@chromium.org BUG=483282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2296853002 Cr-Commit-Position: refs/heads/master@{#415384}
-
estark authored
The browser process used to record subresources that were loaded with certificate errors as mixed content. This meant that DevTools wasn't able to distinguish mixed content (subresources loaded over HTTP) from subresources loaded with certificate errors. On a page that loaded subresources with certificate errors, DevTools would show the mixed content explanation, which was confusing/inaccurate because it described "HTTP resources". The commits in https://crbug.com/634171 created separate plumbing in the browser process for subresources with certificate errors. This CL uses that plumbing to distinguish these two cases for DevTools, and adds separate bullets to the security panel when there are subresources with cert errors on the page. I have also renamed various instances of "insecure content" to "mixed content" to be more precise: trying to use "insecure content" to mean any type of insecure content, and "mixed content" to mean specifically content loaded over HTTP on an HTTPS page. (There are still some more places throughout Chrome that need to be cleaned up with this terminology.) (For subresources with cert errors, there is no link to the Network panel with a filter like there is for mixed content; we can perhaps add that later.) BUG=587172 Review-Url: https://codereview.chromium.org/2286553002 Cr-Commit-Position: refs/heads/master@{#415383}
-
vollick authored
We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None Review-Url: https://codereview.chromium.org/2289593006 Cr-Commit-Position: refs/heads/master@{#415382}
-
flackr authored
BUG=642023 Review-Url: https://codereview.chromium.org/2294453002 Cr-Commit-Position: refs/heads/master@{#415381}
-
senorblanco authored
BUG=642376 Review-Url: https://codereview.chromium.org/2289193002 Cr-Commit-Position: refs/heads/master@{#415380}
-
thestig authored
BUG=401588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2290753004 Cr-Commit-Position: refs/heads/master@{#415379}
-
msw authored
Migrate ash/sysui/shelf_delegate_mus.* to ash/mus. Move mash/shelf/public/interfaces to ash/public/interfaces. Merge shelf_constants.mojom and shelf.mojom. Add ShelfController/ShelfObserver multi-display support. Add ShelfObserver::OnShelfCreated mojo interface. Add EnumTraits for alignment and auto-hide behavior. Remove redundant ash/shelf_layout_manager* Inline RootWindowController::OnShelfWindowAvailable. BUG=557406,614182,615155,616857 TEST=Mash shelf shows chrome icon; no cros changes. R=jamescook@chromium.org,sky@chromium.org TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2259153002 Cr-Commit-Position: refs/heads/master@{#415378}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/f5bd76f5c1b5..e66cd132f09e $ git log f5bd76f5c..e66cd132f --date=short --no-merges --format='%ad %ae %s' 2016-08-27 jzern vpx_mem,align_addr: use ~ to create mask 2016-08-27 jzern vp9_alt_ref_aq_set_nsegments: harmonize fn signature 2016-08-25 yuryg Move vp9_alt_ref_aq_private.h to vp9_alt_ref_aq.c 2016-08-26 jingning Fix VS build warnings in vp9_alt_ref_aq files 2016-08-26 paulwilkins Add ALLOW_RECODE_FIRST speed mode. 2016-08-25 marpan vp8: Move loopfilter synchronization to end of encode_frame call. 2016-07-18 yuryg Create interface for the ALT_REF_AQ class 2016-08-25 jimbankoski libyuv: update to c244a3e9 2016-08-24 jzern add_noise,vpx_setup_noise: correct 'char_dist' type 2016-08-23 jzern vpx_mem: add basic size check 2016-08-24 jzern vpx_mem: normalize function names 2016-07-26 urvang vpx_realloc correction. 2016-07-25 urvang vpx_mem: Refactor code 2016-08-24 marpan Add datarate tests for encoder multi-threads (vp8 and vp9). 2016-07-18 yuryg Add --alt-ref-aq=<int> option 2016-08-23 jzern vp8_decoder_create_threads: check sem/pthread returns 2016-08-23 jzern vp8_create_decoder_instances: add missing setjmp 2016-08-23 johannkoenig Remove halfpix specialization 2016-08-23 jzern vp8: fix decoder crash with invalid leading keyframes 2016-08-22 yuryg Correct CHECK_MEM_ERROR macro (release builds) (...) R=johannkoenig@google.com Review-Url: https://codereview.chromium.org/2295893002 Cr-Commit-Position: refs/heads/master@{#415377}
-
emircan authored
This CL addresses the bug where we see iOS HW decoder dropping most of the frames in a H264 connection with OSX HW encoder. There is a mismatch between the header bytes of these two implementations. iOS expect a 4 bytes header whereas currently 3 bytes are written by OSX encoder. Making them both based on 4 bytes fixes the dropped frames issue. [0] https://cs.chromium.org/chromium/src/third_party/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc?rcl=0&l=345 BUG=webrtc:5931 TEST= Tested H264 connection between Macbook Air and iOS. Review-Url: https://codereview.chromium.org/2292683002 Cr-Commit-Position: refs/heads/master@{#415376}
-
chrisha authored
BUG=617176,619923 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2037883004 Cr-Commit-Position: refs/heads/master@{#415375}
-
sky authored
I move creation to RootWindowControllerCommon, but I think RootWindowControllerCommon should go away. I'm going to do that next, which will result in some additional cleanup. BUG=624173 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2292183003 Cr-Commit-Position: refs/heads/master@{#415374}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/14882d030b9fc5b4dbd97030681b80f46bb96f4e Add configs to set up WebView 32bit perf bots. (mikecase@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2292223002 Cr-Commit-Position: refs/heads/master@{#415373}
-
braveyao authored
Currently when screen is off (or Chrome goes to background) for more than 1 min, peerconnection will be stoppted by PowerMonitor to save battery power. This is not necesary now since we'll suspend video call when the tab is background. And users prefer that audio call can continue while they are doing something else. BUG=513633 Review-Url: https://codereview.chromium.org/2263373003 Cr-Commit-Position: refs/heads/master@{#415372}
-
scottmg authored
ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 Review-Url: https://codereview.chromium.org/2287813002 Cr-Commit-Position: refs/heads/master@{#415371}
-
asvitkine authored
Also, rename use of internal codename in the file. BUG=none Review-Url: https://codereview.chromium.org/2292203002 Cr-Commit-Position: refs/heads/master@{#415370}
-
yoav authored
When the sizes attribute changes, that has the potential of modifying the image's intrinsic dimensions. However, the LayoutImage object was not notified of that explicitly. While the intrinsic dimensions were changed when a new resource was downloaded as a result of the sizes attribute change, that wasn't the case when such the resource was not changed. This CL fixes that, by explicitly notifying the LayoutImage of the change. BUG=639845 Review-Url: https://codereview.chromium.org/2292013002 Cr-Commit-Position: refs/heads/master@{#415369}
-
bgoldman authored
The Blimp browser tests now cover every action of NavigationFeature. GoForward is an additional step in the existing GoBack test, rather than a new test, because you can't test GoForward without GoBack. Also adds no-op behavior on the engine for when the client requests GoBack or GoForward but those operations aren't valid, and tests for those cases. Tested log output for the invalid GoBack and GoForward cases with the following: blimp_browsertests --single_process --gtest_filter=EngineBrowserTest.InvalidGoBack | grep Ignoring blimp_browsertests --single_process --gtest_filter=EngineBrowserTest.InvalidGoForward | grep Ignoring BUG= Review-Url: https://codereview.chromium.org/2295543002 Cr-Commit-Position: refs/heads/master@{#415368}
-
eugenebut authored
Use methods which returns id instead of deprecated methods which return NSString. JS execution API returned NSString because that was the only supported option from UIWebView. Now WKWebView returns id which should be used everywhere. BUG=None Review-Url: https://codereview.chromium.org/2286773002 Cr-Commit-Position: refs/heads/master@{#415367}
-
xingliu authored
The goal is to let Blimp reuse this logic on browser process, since Blimp client doesn't have renderer process. BUG=577985 Review-Url: https://codereview.chromium.org/2285083004 Cr-Commit-Position: refs/heads/master@{#415366}
-
hanxi authored
On UI, the text for installing a WebAPK in the App Banner is: 1) "Add to Homescreen" -> "Adding" -> "Open" for a sucessful installation 2) "Add to Homescreen" -> "Adding" -> "Unable to save" toast for an unsucessful installation. WebAPK-specific logic is added to AppBannerInfobarDelegateAndroid to show the above text. Besides, checking whether a site is WebAPK Compattive is based on 1) installable check + 2) url is over "https" + 3) WebAPK is enabled on command line. Currently, WebAPK is installed as an untrusted source with Android installation dialog pops up. User could choose cancel the installation even after the WebAPK has been downloaded locally. To detect the cancel behavior, AppBannerInfobarDelegateAndroid checks whether the WebAPK has been installed or not after Chrome is resumed. This isn't an ideal way, but it seems we can't find a better way to detect the cancel event. This logic will be removed when WebAPK is installed by Play soon. This CL disables creating WebAPKs by selecting add-to-homescreen from the app menu. Instead, in a follow up CL, selecting from the app menu will make the app banner info bar shown to install WebAPKs. BUG=627250 Review-Url: https://codereview.chromium.org/2259553002 Cr-Commit-Position: refs/heads/master@{#415365}
-
jbudorick authored
BUG=641597 Review-Url: https://codereview.chromium.org/2294843002 Cr-Commit-Position: refs/heads/master@{#415364}
-
pdr authored
This patch adds a new (currently failing) filter repaint test to show how we improperly repaint turbulence filters. In addition, the existing test for 640264 has been unskipped and rebaselined with a failing result. These two changes should help catch progressions in the future. BUG=598051,640264 Review-Url: https://codereview.chromium.org/2294633002 Cr-Commit-Position: refs/heads/master@{#415363}
-
alokp authored
BUG=641559 Review-Url: https://codereview.chromium.org/2283163002 Cr-Commit-Position: refs/heads/master@{#415362}
-
mmenke authored
This reverts commit 64fea5e2. The CL broke the Windows build for some users. NOPRESUBMIT=true NOTRY=true TBR=dpranke@chromium.org BUG=634184 Review-Url: https://codereview.chromium.org/2294903002 Cr-Commit-Position: refs/heads/master@{#415361}
-
eakuefner authored
This directory has not been touched since 2008, appears to be from the very early history of tracing, and contains only some very primitive trace examples. The frontend tracing code lives in Catapult, so let's remove this dir. Review-Url: https://codereview.chromium.org/2290393002 Cr-Commit-Position: refs/heads/master@{#415360}
-
sdy authored
BUG=636093 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2271653006 Cr-Commit-Position: refs/heads/master@{#415359}
-
sfiera authored
A partial list of things done here: * Move tests that verified NTPSnippet::best_source() behavior into ntp_snippet_test.cc; they don't belong here. * Switch it to use the chromecontentsuggestions-pa. Testing new features like server-provided categories is not possible without this. * Replace MockContentSuggestionsProviderObserver with a fake. It shouldn't have been a mock, since we weren't using it to test behavior, only state. * In one case, test using what the observer sees, instead of peeking in through debugging hooks. * Get rid of special test base class and Mock::VerifyAndClear calls; I consider these anti-patterns. * Initialize the service better; give it an empty list of snippets for its first fetch, and wait for it to complete the fetch before returning (I think this is what was most strongly implicated by the failures with the other CL). * Create the service and expect the scheduling directly from each case, so they are more readable individually. Review-Url: https://codereview.chromium.org/2285133004 Cr-Commit-Position: refs/heads/master@{#415358}
-
malaykeshav authored
BUG=642078 COMPONENT=HaTS, Chrome OS Review-Url: https://codereview.chromium.org/2294473003 Cr-Commit-Position: refs/heads/master@{#415357}
-
brettw authored
Inline sources into GN files. Review-Url: https://codereview.chromium.org/2291223002 Cr-Commit-Position: refs/heads/master@{#415356}
-